| *** brinzhang0 has joined #openstack-release | 00:09 | |
| *** tosky has quit IRC | 00:12 | |
| *** brinzhang_ has quit IRC | 00:13 | |
| *** armax has quit IRC | 00:24 | |
| *** armax has joined #openstack-release | 00:32 | |
| *** armax has quit IRC | 00:33 | |
| *** armax has joined #openstack-release | 00:44 | |
| *** armax has quit IRC | 01:27 | |
| *** brinzhang_ has joined #openstack-release | 01:42 | |
| *** brinzhang0 has quit IRC | 01:45 | |
| *** armax has joined #openstack-release | 01:47 | |
| *** armax has quit IRC | 01:51 | |
| *** ricolin_ has joined #openstack-release | 02:27 | |
| *** ricolin_ has quit IRC | 02:34 | |
| *** ricolin_ has joined #openstack-release | 02:34 | |
| *** ricolin_ has quit IRC | 03:04 | |
| *** ricolin_ has joined #openstack-release | 04:01 | |
| *** ricolin_ has quit IRC | 04:07 | |
| *** ricolin_ has joined #openstack-release | 04:08 | |
| *** ykarel has joined #openstack-release | 05:13 | |
| *** ykarel_ has joined #openstack-release | 05:32 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-release | 05:33 | |
| *** ykarel has quit IRC | 05:34 | |
| *** ykarel_ is now known as ykarel | 05:35 | |
| *** fnordahl has joined #openstack-release | 06:01 | |
| *** vishalmanchanda has joined #openstack-release | 06:14 | |
| *** whoami-rajat__ has joined #openstack-release | 06:39 | |
| *** cgoncalves has joined #openstack-release | 07:27 | |
| *** ricolin_ has quit IRC | 07:27 | |
| *** ricolin has joined #openstack-release | 07:27 | |
| *** gibi_pto is now known as gibi | 07:58 | |
| *** e0ne has joined #openstack-release | 07:58 | |
| *** slaweq has joined #openstack-release | 08:09 | |
| *** e0ne has quit IRC | 08:15 | |
| *** sboyron has joined #openstack-release | 08:27 | |
| *** vishalmanchanda has quit IRC | 08:34 | |
| *** tosky has joined #openstack-release | 08:35 | |
| *** rpittau|afk is now known as rpittau | 08:51 | |
| *** brinzhang0 has joined #openstack-release | 08:56 | |
| *** brinzhang_ has quit IRC | 08:59 | |
| *** icey has quit IRC | 09:19 | |
| *** icey has joined #openstack-release | 09:25 | |
| *** slaweq has quit IRC | 09:31 | |
| *** slaweq has joined #openstack-release | 09:33 | |
| *** e0ne has joined #openstack-release | 10:04 | |
| *** e0ne has quit IRC | 10:05 | |
| openstackgerrit | Merged openstack/releases master: Release os-win 5.4.0 (Wallaby) https://review.opendev.org/c/openstack/releases/+/767674 | 10:10 |
|---|---|---|
| *** dirk1 is now known as dirk | 10:18 | |
| openstackgerrit | Merged openstack/releases master: TripleO repos feature release for stable/victoria https://review.opendev.org/c/openstack/releases/+/768237 | 10:24 |
| ttx | I've been holding on the tempest EM patches so that we discuss it first | 10:30 |
| hberaud | HNY to everyone! | 10:30 |
| hberaud | ttx: yes I seen thanks | 10:30 |
| ttx | Happy new year to you too! | 10:30 |
| hberaud | ttx: I already added this one to our next meeting agenda | 10:31 |
| ttx | On Dec 18 there was a release job failure around https://review.opendev.org/c/openstack/releases/+/767686 | 10:31 |
| ttx | Logs at https://zuul.opendev.org/t/openstack/build/cc76b45601184d6484c5783b550a0951/console | 10:31 |
| ttx | Was it investigated already? | 10:31 |
| hberaud | yes we already discussed about this with fungi the OSA team | 10:32 |
| ttx | what was the issue? /home/zuul/scripts/release-tools/add_release_note_page.sh: line 51: python: command not found ? | 10:32 |
| hberaud | We think that a project-config script doesn't behave as expected | 10:32 |
| hberaud | lemme find the link | 10:33 |
| ttx | It seems to have mostly branched as requested, so probably not critical | 10:33 |
| ttx | Maybe we can track progress in the meeting, just don;t want it to fall in post-holidays cracks | 10:33 |
| ttx | https://zuul.opendev.org/t/openstack/build/9927456740bf4287ad980af9482b2111/console looks like a similar issue | 10:35 |
| hberaud | yes we investigated and everything seems to have been created as expected, unfortunately the script doesn't behave as expected especially this part https://opendev.org/openstack/project-config/src/branch/master/roles/copy-release-tools-scripts/files/release-tools/process_release_requests.py#L110-L116 and so we didn't caught the error properly | 10:41 |
| hberaud | Concerning the last release job failure I suppose this one is due to the fact that we branched in the same time that we created a new tag, please can you double check? => http://lists.openstack.org/pipermail/release-job-failures/2020-December/001499.html | 10:41 |
| hberaud | it was related to these changes => https://review.opendev.org/c/openstack/releases/+/768008 | 10:41 |
| hberaud | the following command "git checkout stable/victoria" returned "error: pathspec 'stable/victoria' did not match any file(s) known to git" | 10:42 |
| hberaud | but everything was created as expected (tag, branch) too, only the release note is wrong and I think it's due to the fact that we skipped the doc job due to the rc code | 10:42 |
| hberaud | so the 22.0.0rc1 appear under the unreleased section instead of the victoria section of reno (c.f https://docs.openstack.org/releasenotes/openstack-ansible/unreleased.html) | 10:42 |
| hberaud | I already added this topic to our next meeting | 10:43 |
| ttx | yeah, that seems like a fair analysis | 10:43 |
| hberaud | however I suppose we need to reenque the doc part | 10:44 |
| hberaud | to move 22.0.0rc under victoria | 10:44 |
| ttx | branching and tagging at the same time should work | 10:44 |
| ttx | that pathspec error is, I think, expected | 10:45 |
| hberaud | but we got a rc>0 | 10:46 |
| ttx | /home/zuul/scripts/release-tools/add_release_note_page.sh: line 51: python: command not found | 10:47 |
| ttx | is more likely to blame | 10:47 |
| hberaud | ah I missed this one | 10:49 |
| hberaud | exact | 10:49 |
| ttx | we should get rid of that other message, it's been misleading me regularly too | 10:50 |
| hberaud | yes | 10:53 |
| ttx | looking at where it originates since I have the tabs open now :) | 10:53 |
| hberaud | I can't find this script | 10:53 |
| hberaud | Where I can find it? | 10:54 |
| ttx | still digging | 10:54 |
| hberaud | I suppose we just need "python3" rather than "python" somewhere | 10:54 |
| ttx | it starts from release.sh https://opendev.org/openstack/project-config/src/branch/master/roles/copy-release-tools-scripts/files/release-tools | 10:54 |
| hberaud | https://opendev.org/openstack/project-config/src/branch/master/roles/copy-release-tools-scripts/files/release-tools/add_release_note_page.sh#L51 | 10:55 |
| ttx | oh sure, I'm trying to find where the spurious error comes from | 10:55 |
| ttx | (pathspec 'stable/victoria' did not match any file(s) known to git) | 10:55 |
| hberaud | ah | 10:56 |
| hberaud | sorry :) | 10:56 |
| * hberaud school run | 10:56 | |
| ttx | ok got it | 10:58 |
| ttx | https://opendev.org/openstack/project-config/src/branch/master/roles/copy-release-tools-scripts/files/release-tools/clone_repo.sh#L197 | 10:58 |
| ttx | (git checkout $BRANCH || git checkout master) && retry git pull --ff-only) | 10:58 |
| ttx | git checkout $BRANCH is expected to fail in some cases, thus activating the "|| git checkout master" | 10:59 |
| ttx | But in that case it logs a spurious error | 11:00 |
| ttx | We probably should (git checkout $BRANCH 2>/dev/null || ... or even better expand that code and properly log in that case | 11:03 |
| hberaud | +1 to expand | 11:03 |
| ttx | I'll try to find time to do it... but not today :) | 11:04 |
| hberaud | ack np | 11:04 |
| hberaud | on my side I'll propose "python3" rather "python" | 11:04 |
| hberaud | *than | 11:04 |
| hberaud | it seems that this one was forgotten, I can see that other scripts of "roles" already use python3 => https://opendev.org/openstack/project-config/src/branch/master/roles/copy-release-tools-scripts/files/release-tools/release.sh#L97 | 11:10 |
| hberaud | done by https://review.opendev.org/c/openstack/project-config/+/769128 | 11:17 |
| *** slaweq has quit IRC | 12:18 | |
| *** slaweq has joined #openstack-release | 12:20 | |
| *** ykarel has quit IRC | 12:33 | |
| hberaud | well... a freshly release job failure related to https://review.opendev.org/c/openstack/releases/+/768237 just poped up, it seems related to the new pip's resolver | 12:33 |
| *** ykarel has joined #openstack-release | 12:33 | |
| hberaud | http://paste.openstack.org/show/801385/ | 12:34 |
| hberaud | the first of 2021... http://lists.openstack.org/pipermail/release-job-failures/2021-January/001500.html | 12:35 |
| *** ykarel_ has joined #openstack-release | 12:37 | |
| *** ykarel has quit IRC | 12:37 | |
| hberaud | I suppose we didn't see this error previously as the previous jobs all failed for various reasons and the publish reno/doc's job wasn't triggered due to these fails | 12:38 |
| fungi | if it ran in a python3-based virtualenv/venv it would have been unnoticed | 13:04 |
| *** ricolin has quit IRC | 13:06 | |
| *** haleyb has quit IRC | 13:24 | |
| *** haleyb has joined #openstack-release | 13:27 | |
| *** tosky has quit IRC | 13:30 | |
| *** tosky has joined #openstack-release | 13:30 | |
| *** dave-mccowan has quit IRC | 13:52 | |
| *** CrayZee has quit IRC | 13:53 | |
| *** snapiri has joined #openstack-release | 13:53 | |
| *** dave-mccowan has joined #openstack-release | 13:54 | |
| fungi | the script call i mean | 13:58 |
| fungi | hberaud: that resolver conflict looks pretty typical, we've been hitting it in places where we install things not covered by the global upper-constraints.txt in openstack/requirements, so lower-constraints jobs as well as linters and static analysis tools which we don't cover globally | 13:59 |
| hberaud | fungi: you speak about http://lists.openstack.org/pipermail/release-job-failures/2021-January/001500.html , right? | 14:00 |
| fungi | hberaud: | 14:01 |
| fungi | er, hberaud yes | 14:01 |
| hberaud | ack | 14:01 |
| fungi | probably just need to tweak the test-requirements.txt entries a bit | 14:02 |
| hberaud | from openstack/release? | 14:02 |
| hberaud | I guess yes | 14:03 |
| fungi | hberaud: i think it's trying to install https://opendev.org/openstack/tripleo-image-elements/src/branch/master/test-requirements.txt | 14:04 |
| fungi | probably the version of flake8 hacking wants is incompatible with the pyflakes pin in there | 14:04 |
| hberaud | IIUC, that mean that potentially we could face similar issue with all the repos | 14:06 |
| fungi | i'm not entirely sure why the job installs the project's test-requirements.txt instead of, say, doc/requirements.txt | 14:06 |
| fungi | (clearly things like hacking and pyflakes aren't needed to generate release notes) | 14:07 |
| hberaud | it would be terrible if it is the case | 14:07 |
| hberaud | maybe it's because this project haven't doc/requirements.txt | 14:08 |
| hberaud | maybe it's a default rule... I don't know | 14:09 |
| fungi | yeah, this is where it decides to use test-requirements.txt: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-sphinx/tasks/main.yaml#L36 | 14:10 |
| fungi | i'll bring it up in #zuul, seems like a questionable choice, or at least something we'd like to be able to override | 14:10 |
| hberaud | thanks | 14:10 |
| fungi | oh! | 14:10 |
| fungi | i misread that. so it _will_ use doc/requirements.txt if it exists, and only fall back to test-requirements.txt if not | 14:11 |
| hberaud | yes a break will be triggered if the file exist | 14:12 |
| fungi | if tripleo-image-elements adds a more focused doc/requirements.txt file with just their docs (and release notes) deps then this would work much more reliably and faster | 14:12 |
| hberaud | but in all the case that mean that all repos should be fixed/standardized first to avoid similar issue | 14:13 |
| fungi | sure. that's basically what we're finding with the new dep solver in pip, it's pointing out actual errors in our projects and highlighting places where we've been inconsistent/sloppy up to now | 14:13 |
| hberaud | ack | 14:14 |
| fungi | so in the case of tripleo-image-elements, 1. they have an incompatibility between entries in their test-requirements.txt, and 2. they're missing a doc/requirements.txt file | 14:15 |
| fungi | both things worth fixing | 14:15 |
| fungi | anyway, i need to go run some errands, but will be back in an hour | 14:15 |
| hberaud | I'll try to get a list of identified repos that need to be fixed by using beagle | 14:16 |
| hberaud | beagle search --ignore-comments -f link --file '(^test-requirements.txt)' --repo-pattern "openstack/*" 'sphinx' | 14:17 |
| hberaud | something like this should works ^ | 14:17 |
| hberaud | if we consider that sphinx should be present in doc/requirements.txt | 14:18 |
| hberaud | by example with PyCADF it seems to works as expected https://opendev.org/openstack/pycadf | 14:19 |
| hberaud | https://opendev.org/openstack/pycadf/src/branch/master/test-requirements.txt#L16 | 14:19 |
| hberaud | and the doc/requirements.txt doesn't exist | 14:19 |
| hberaud | all these repos seems fit our search => http://paste.openstack.org/show/801396/ | 14:24 |
| hberaud | now I need to check if a doc/requirements.txt file exist or not in thel | 14:24 |
| hberaud | them | 14:25 |
| hberaud | ttx, smcginnis: Please hold all the validations for now | 14:47 |
| ttx | ack | 14:47 |
| *** ykarel_ has quit IRC | 15:26 | |
| *** ykarel_ has joined #openstack-release | 15:55 | |
| iurygregory | hberaud, I will push some patches to ironic projects (sushy, sushy-tools, virtualbmc, ironic-python-agent-builder) | 15:56 |
| hberaud | iurygregory: related to the doc issue? | 15:56 |
| iurygregory | yeah | 15:57 |
| hberaud | iurygregory: awesome thanks | 15:57 |
| iurygregory | np =) | 15:57 |
| *** ykarel_ has quit IRC | 16:03 | |
| *** slaweq has quit IRC | 16:19 | |
| *** slaweq has joined #openstack-release | 16:20 | |
| iurygregory | hberaud, https://review.opendev.org/c/openstack/virtualbmc/+/769160 would be something like this right? | 16:23 |
| *** armax has joined #openstack-release | 16:36 | |
| hberaud | iurygregory: I replied directly on https://review.opendev.org/c/openstack/virtualbmc/+/769160 | 16:52 |
| hberaud | iurygregory: but yes it would be something like this | 16:53 |
| iurygregory | hberaud, I did the clean-up locally (just trying to get pdf-build working because I'm using a new notebook hehe) | 16:53 |
| hberaud | :) | 16:55 |
| *** slaweq has quit IRC | 17:13 | |
| *** rpittau is now known as rpittau|afk | 17:14 | |
| *** slaweq has joined #openstack-release | 17:15 | |
| openstackgerrit | Hervé Beraud proposed openstack/releases master: Add doc related to validation status (red, orange, green) https://review.opendev.org/c/openstack/releases/+/769171 | 17:28 |
| *** diablo_rojo has joined #openstack-release | 17:47 | |
| *** e0ne has joined #openstack-release | 18:40 | |
| *** e0ne has quit IRC | 18:55 | |
| *** e0ne has joined #openstack-release | 18:57 | |
| *** e0ne has quit IRC | 18:57 | |
| nicolasbock | hberaud: I am trying to get `designate-tempest-plugin` up to speed in terms of pip resolver issue and submitted https://review.opendev.org/c/openstack/designate-tempest-plugin/+/769170 | 18:59 |
| *** e0ne has joined #openstack-release | 18:59 | |
| nicolasbock | Is that sufficient? Or do we also need to add the `release-notes-jobs-python3` template job? | 19:00 |
| *** e0ne has quit IRC | 19:06 | |
| iurygregory | hberaud, hey molteniron is a bit of problems (we neve did release on ironic side, it is just some tools 3rd party CI use to checkin/out baremetal resources for CI | 19:12 |
| iurygregory | is there a way to "remove" from the publish job? | 19:12 |
| hberaud | iurygregory: these projects are published? Please, can you give me an example | 19:45 |
| iurygregory | hberaud, https://opendev.org/openstack/releases/src/branch/master/deliverables/_independent/molteniron.yaml | 19:47 |
| iurygregory | molteniron doesn't have any release | 19:47 |
| iurygregory | also by anychance do you have an idea about the need to test docs build with usedevelop=False? dtantsur raised two comments in the changes for ironic projects but zuul seems happy with the changes https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/769196/1/tox.ini https://review.opendev.org/c/openstack/sushy/+/769174/1/tox.ini | 19:49 |
| hberaud | nicolasbock: I see that you already use `publish-openstack-docs-pti` so I think you're potentially impacted by this bug, but I don't think you need to add this job template except if you want to release your release notes, but I didn't see lot of them in your repo | 19:51 |
| nicolasbock | Thanks hberaud . So you think the current change is sufficient then? | 19:58 |
| hberaud | iurygregory: even if motleniron doesn't yet have been released it should be fixed, concerning `usedevelop` I think it can't hurt but I'm not an expert on this point | 19:58 |
| nicolasbock | Ah just noticed that you left me a comment on the change :) | 19:59 |
| hberaud | nicolasbock: at first glance yes, but some clean up could be done | 19:59 |
| hberaud | yes :) | 19:59 |
| hberaud | np | 19:59 |
| nicolasbock | I updated the change hberaud | 20:02 |
| hberaud | thanks | 20:04 |
| *** sboyron has quit IRC | 20:35 | |
| *** dave-mccowan has quit IRC | 20:40 | |
| *** dave-mccowan has joined #openstack-release | 20:41 | |
| *** whoami-rajat__ has quit IRC | 21:01 | |
| *** e0ne has joined #openstack-release | 21:05 | |
| *** slaweq has quit IRC | 21:24 | |
| *** e0ne has quit IRC | 21:31 | |
| *** tkajinam has joined #openstack-release | 23:00 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!