*** tosky has quit IRC | 00:09 | |
*** johnthetubaguy has quit IRC | 00:16 | |
*** HongKong has joined #openstack-release | 00:17 | |
*** johnthetubaguy has joined #openstack-release | 00:22 | |
openstackgerrit | zhongshengping proposed openstack/releases master: Puppet OpenStack wallaby Milestone 3 https://review.opendev.org/c/openstack/releases/+/781601 | 02:18 |
---|---|---|
*** evrardjp has quit IRC | 03:33 | |
*** evrardjp has joined #openstack-release | 03:33 | |
*** HongKong has quit IRC | 03:44 | |
*** bdodd has quit IRC | 03:57 | |
*** diablo_rojo has quit IRC | 04:02 | |
*** armstrong has joined #openstack-release | 04:09 | |
*** vishalmanchanda has joined #openstack-release | 04:09 | |
*** ykarel has joined #openstack-release | 04:28 | |
*** whoami-rajat_ has joined #openstack-release | 04:57 | |
*** EmilienM has quit IRC | 05:13 | |
*** ykarel has quit IRC | 05:23 | |
*** ykarel has joined #openstack-release | 05:25 | |
*** ricolin_ has joined #openstack-release | 06:17 | |
*** armstrong has quit IRC | 06:19 | |
*** ricolin_ has quit IRC | 06:23 | |
*** xarlos has quit IRC | 07:15 | |
*** slaweq_ has joined #openstack-release | 07:15 | |
*** eolivare has joined #openstack-release | 07:37 | |
*** slaweq_ is now known as slaweq | 07:53 | |
*** e0ne has joined #openstack-release | 07:57 | |
*** whoami-rajat_ is now known as whoami-rajat | 08:03 | |
*** sboyron has joined #openstack-release | 08:04 | |
*** rpittau|afk is now known as rpittau | 08:13 | |
*** e0ne has quit IRC | 08:15 | |
openstackgerrit | Hervé Beraud proposed openstack/releases master: Proposing Wallaby RC1 for magnum https://review.opendev.org/c/openstack/releases/+/781670 | 08:54 |
*** ykarel is now known as ykarel|lunch | 08:57 | |
brinzhang | hberaud: hi, I found the some patches reported by OpenStack Release Bot, but the pep8 failed, it's said "rsync: change_dir "/home/zuul//src/opendev.org/openstack/cyborg/.tox/pep8/log" failed: No such file or directory (2)" | 09:02 |
brinzhang | hberaud: do you know what happened? such as https://review.opendev.org/c/openstack/cyborg/+/781645 | 09:02 |
* hberaud look | 09:04 | |
*** tosky has joined #openstack-release | 09:04 | |
hberaud | brinzhang: I think that the rsync error is a side effect triggered by an other issue with tools/check-cherry-picks.sh during the pep8 job execution (`Stable branch requires either cherry-pick -x headers or [stable-only] tag!`) | 09:10 |
hberaud | I can reproduce the issue locally | 09:10 |
hberaud | however I've no idea of what is the goal of `check-cherry-picks` | 09:11 |
brinzhang | hberaud: me too, but I dont find howto resolve it now :( | 09:11 |
hberaud | this is one of your tools and I don't know what is expected here | 09:11 |
hberaud | I think that you should debug is execution step by step to see what's the culprit | 09:12 |
brinzhang | yeah, doing now | 09:12 |
hberaud | this is a shell script so maybe by using `set -x` you'll have a better understanding of what's went wrong | 09:13 |
hberaud | but I think that's the problem is somewhere here | 09:14 |
brinzhang | you mean, using "tox -e pep8 set -x"? | 09:14 |
hberaud | no | 09:14 |
hberaud | let me show you | 09:14 |
hberaud | brinzhang: http://paste.openstack.org/show/803814/ | 09:16 |
brinzhang | ack, thanks, will try | 09:16 |
elod | brinzhang hberaud : i am surprised that cherry-pick-check is in the cyborg repository :) | 09:17 |
elod | actually it is a tool added to nova repo, | 09:17 |
elod | to force stable-policy way of working: | 09:17 |
hberaud | as the goal of https://review.opendev.org/c/openstack/cyborg/+/781645 is to create the right git config for wallaby is stable branch I suppose that your shell script dedicated to stable branch isn't compatible | 09:17 |
elod | * use cherry-pick -x | 09:18 |
elod | * always backport to N-1 branch from branch N | 09:18 |
hberaud | I think that they have copied this script | 09:18 |
hberaud | however some pieces are surely missing | 09:18 |
brinzhang | elod: yes, I think using this shell in order to using "tox -e fast8", and the raise out of control | 09:19 |
brinzhang | but I am not sure, need to be debug | 09:19 |
elod | brinzhang: I know the issue | 09:19 |
brinzhang | ? | 09:20 |
elod | brinzhang: you need [stable-only] tag | 09:20 |
hberaud | it have been added 6 months ago https://opendev.org/openstack/cyborg/commit/bb4fd104a3cc21ae93d67f1b64910c77bd79c664 | 09:20 |
elod | as that kind of patch is not cherry-picked from master, so it needs a [stable-only] tag | 09:20 |
elod | in the commit message | 09:20 |
hberaud | I see | 09:21 |
hberaud | brinzhang: so I think you just need to update the commit message of this patch | 09:21 |
elod | exactly | 09:21 |
hberaud | accordingly to elod's explanation ^ | 09:22 |
hberaud | good to know | 09:22 |
hberaud | thanks elod for these details :) | 09:22 |
brinzhang | you mean just need to update this patch's commit message? such as "Update .gitreview for [stable/wallaby]' | 09:23 |
hberaud | yes | 09:23 |
hberaud | "[stable-only] Update .gitreview for stable wallaby" | 09:23 |
brinzhang | ok, let me try | 09:23 |
hberaud | elod.the.master.of.stable.branches++ | 09:24 |
elod | brinzhang: yes, e.g.: https://review.opendev.org/c/openstack/nova/+/754319 | 09:24 |
elod | hberaud: :) | 09:24 |
brinzhang | elod, hberaud: ack, I think yes | 09:25 |
brinzhang | I will test in my local | 09:25 |
elod | well, this script was added by the nova stable cores, so as being a nova stable core I'm familiar with it :) | 09:25 |
brinzhang | elod, hberaud: yes, it's ok now, may I need to update the shell and add some comments inline. | 09:26 |
hberaud | brinzhang: can't hurt | 09:27 |
brinzhang | elod: thanks, as I said, we think it's useful to us, so I introduced it | 09:27 |
brinzhang | hberaud: ^^ | 09:28 |
hberaud | however https://opendev.org/openstack/cyborg/commit/bb4fd104a3cc21ae93d67f1b64910c77bd79c664 isn't in victoria this is why we didn't see the same error with victoria | 09:28 |
elod | brinzhang: no problem :) and yes, it could help to better track backports :) | 09:28 |
*** vishalmanchanda has quit IRC | 09:28 | |
brinzhang | hberaud: yes, we introduced it in wallaby release | 09:30 |
brinzhang | elod: agree. thank you very much elod, hberaud, I will update the commit message and allow the Bot commit to go | 09:30 |
elod | brinzhang: although I suggest to compare the script with nova, as there were some fixes (nova (master)$ git log --oneline -- tools/check-cherry-picks.sh) | 09:33 |
elod | brinzhang: might worth to cherry-pick to cyborg those fixes | 09:33 |
brinzhang | elod: ack, will diff later, and adding the update info | 09:33 |
elod | brinzhang: and also, this is really for stable branches, so needs to be backported all the way to stable branches | 09:34 |
brinzhang | elod: there are also some json and arqs.inc changed, I am not sure it's easy to backport, but I will try ^^ | 09:36 |
elod | brinzhang: I recommend then to backport only the script (with a [stable-only] tag :)) | 09:41 |
brinzhang | ack | 09:41 |
elod | brinzhang: and feel free to ping me if you need help with this check script (or other stable reviews) | 09:43 |
brinzhang | elod: ok, after I backport that commit, I will add you to review and ping you here :) | 09:44 |
elod | good-good :) | 09:53 |
brinzhang | hberaud: did you remember the python-cyborgclient 1.3.1.dev1 required error? it has happened again in https://review.opendev.org/c/openstack/python-cyborgclient/+/781789, the Bot patch, it seems https://review.opendev.org/c/openstack/python-cyborgclient/+/781603 didnt fix that unknown issue | 09:54 |
hberaud | You didn't backport https://review.opendev.org/c/openstack/python-cyborgclient/+/781603 on stable/wallaby | 09:55 |
hberaud | https://review.opendev.org/c/openstack/python-cyborgclient/+/781603 is only on master | 09:55 |
brinzhang | wow, yes | 09:56 |
brinzhang | I ignored it, her fix was after wallaby was released. | 09:58 |
*** ykarel|lunch is now known as ykarel | 10:01 | |
hberaud | p | 10:07 |
hberaud | np | 10:07 |
openstackgerrit | Merged openstack/releases master: Proposing Wallaby RC1 for tacker-horizon https://review.opendev.org/c/openstack/releases/+/781760 | 10:12 |
*** tosky has quit IRC | 10:13 | |
*** tosky has joined #openstack-release | 10:14 | |
*** e0ne has joined #openstack-release | 10:16 | |
brinzhang | elod: I was backport that patch to victoria, and diff the updated info from nova/tools, and added you as the reviewer, if you are free pls review it | 10:35 |
brinzhang | elod: I was cherry-picked until stable/ussuri, others branch need to be check the conflicts after we merged the ussuri backport | 10:36 |
elod | brinzhang: ack, I will review them | 10:44 |
brinzhang | elod: thanks | 10:44 |
*** yoctozepto has quit IRC | 11:02 | |
*** yoctozepto has joined #openstack-release | 11:03 | |
*** vishalmanchanda has joined #openstack-release | 11:11 | |
*** elod has quit IRC | 11:13 | |
*** elod has joined #openstack-release | 11:21 | |
*** brinzhang has quit IRC | 11:56 | |
*** brinzhang has joined #openstack-release | 11:57 | |
*** EmilienM has joined #openstack-release | 12:05 | |
*** e0ne has quit IRC | 12:36 | |
*** ykarel has quit IRC | 12:38 | |
*** ykarel has joined #openstack-release | 12:38 | |
*** nweinber has joined #openstack-release | 12:39 | |
*** ykarel_ has joined #openstack-release | 12:44 | |
*** ykarel has quit IRC | 12:47 | |
*** mgoddard has quit IRC | 12:53 | |
*** ykarel_ is now known as ykarel | 13:17 | |
*** ykarel_ has joined #openstack-release | 13:22 | |
*** ykarel has quit IRC | 13:24 | |
*** ykarel_ has quit IRC | 13:26 | |
openstackgerrit | Hervé Beraud proposed openstack/releases master: Proposing Wallaby RC1 for monasca-transform https://review.opendev.org/c/openstack/releases/+/781696 | 13:32 |
*** e0ne has joined #openstack-release | 13:44 | |
*** bdodd has joined #openstack-release | 13:45 | |
*** mgoddard has joined #openstack-release | 13:57 | |
*** e0ne has quit IRC | 14:00 | |
*** whoami-rajat has quit IRC | 15:03 | |
*** frickler has quit IRC | 15:37 | |
*** irclogbot_2 has quit IRC | 15:37 | |
*** irclogbot_3 has quit IRC | 15:37 | |
*** frickler has joined #openstack-release | 15:37 | |
*** dirk has quit IRC | 15:38 | |
*** dirk has joined #openstack-release | 15:39 | |
*** irclogbot_1 has joined #openstack-release | 15:39 | |
*** irclogbot_2 has joined #openstack-release | 15:39 | |
*** adriant7 has joined #openstack-release | 15:44 | |
*** adriant has quit IRC | 15:46 | |
*** adriant7 is now known as adriant | 15:46 | |
*** irclogbot_1 has quit IRC | 15:49 | |
*** irclogbot_2 has quit IRC | 15:51 | |
*** irclogbot_1 has joined #openstack-release | 15:53 | |
*** irclogbot_2 has joined #openstack-release | 15:53 | |
openstackgerrit | Merged openstack/releases master: Proposing Wallaby RC1 for kuryr-libnetwork https://review.opendev.org/c/openstack/releases/+/781664 | 16:53 |
openstackgerrit | Merged openstack/releases master: Proposing Wallaby RC1 for glance https://review.opendev.org/c/openstack/releases/+/781653 | 17:00 |
*** iurygregory has quit IRC | 17:02 | |
*** rpittau is now known as rpittau|afk | 17:26 | |
openstackgerrit | Merged openstack/releases master: trivial - fix week number https://review.opendev.org/c/openstack/releases/+/781071 | 17:26 |
*** armstrong has joined #openstack-release | 17:28 | |
*** iurygregory has joined #openstack-release | 17:29 | |
*** vishalmanchanda has quit IRC | 18:17 | |
*** eolivare has quit IRC | 18:24 | |
*** dtantsur is now known as dtantsur|afk | 18:55 | |
*** dtantsur|afk is now known as dtantsur|afk|afk | 18:55 | |
*** dtantsur|afk|afk is now known as dtantsur|afk | 18:55 | |
*** sboyron has quit IRC | 19:22 | |
*** armstrong has quit IRC | 19:38 | |
*** e0ne has joined #openstack-release | 20:36 | |
*** nweinber has quit IRC | 21:05 | |
*** e0ne has quit IRC | 21:31 | |
*** e0ne has joined #openstack-release | 21:32 | |
*** e0ne has quit IRC | 21:35 | |
*** fnordahl has quit IRC | 21:37 | |
*** jbadiapa has quit IRC | 21:45 | |
*** slaweq has quit IRC | 21:52 | |
*** slaweq has joined #openstack-release | 21:54 | |
*** diablo_rojo has joined #openstack-release | 21:56 | |
*** slaweq has quit IRC | 23:05 | |
*** slaweq has joined #openstack-release | 23:06 | |
*** johnthetubaguy has quit IRC | 23:36 | |
*** johnthetubaguy has joined #openstack-release | 23:38 | |
*** johnthetubaguy has quit IRC | 23:49 | |
*** johnthetubaguy has joined #openstack-release | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!