| *** dviroel|ruck is now known as dviroel|out | 00:04 | |
| opendevreview | Eyal proposed openstack/releases master: release new version 8.0.1 https://review.opendev.org/c/openstack/releases/+/833722 | 07:34 |
|---|---|---|
| opendevreview | Eyal proposed openstack/releases master: release new version 8.0.1 https://review.opendev.org/c/openstack/releases/+/833722 | 07:37 |
| *** amoralej|off is now known as amoralej | 07:54 | |
| opendevreview | Eyal proposed openstack/releases master: release new version 8.0.1 https://review.opendev.org/c/openstack/releases/+/833722 | 08:05 |
| opendevreview | Eyal proposed openstack/releases master: release new version 8.0.1 https://review.opendev.org/c/openstack/releases/+/833722 | 08:27 |
| *** dviroel|out is now known as dviroel|ruck | 11:09 | |
| *** marios is now known as marios|biab | 11:23 | |
| *** marios|biab is now known as marios | 12:12 | |
| *** amoralej is now known as amoralej|lunch | 13:14 | |
| *** amoralej|lunch is now known as amoralej | 14:13 | |
| *** dviroel|ruck is now known as dviroel|ruck|mtg | 14:16 | |
| opendevreview | Merged openstack/releases master: Add question before pushing a patch with bulk_review.sh https://review.opendev.org/c/openstack/releases/+/831313 | 14:20 |
| opendevreview | Merged openstack/releases master: Do not add reviewers when bulk pushing changes https://review.opendev.org/c/openstack/releases/+/831314 | 14:24 |
| opendevreview | Merged openstack/releases master: Release designate-tempest-plugin for Yoga https://review.opendev.org/c/openstack/releases/+/833571 | 15:00 |
| *** dviroel|ruck|mtg is now known as dviroel|ruck | 15:01 | |
| opendevreview | Stephen Finucane proposed openstack/reno master: Update CI to use unversioned jobs template https://review.opendev.org/c/openstack/reno/+/833828 | 15:09 |
| *** dviroel|ruck is now known as dviroel|ruck|lunch | 15:35 | |
| *** dviroel|ruck|lunch is now known as dviroel|ruck | 16:03 | |
| *** diablo_rojo is now known as Guest2228 | 16:11 | |
| *** Guest2228 is now known as diablo_rojo | 16:17 | |
| *** marios is now known as marios|out | 16:57 | |
| *** amoralej is now known as amoralej|off | 18:03 | |
| *** dviroel|ruck is now known as dviroel|ruck|brb | 20:19 | |
| *** dviroel|ruck|brb is now known as dviroel|ruck | 20:57 | |
| smcginnis | Did something change with git review setup? I'm really struggling figuring out how to get it to add the change ID for some reason. | 21:07 |
| clarkb | smcginnis: no, it shouldn't have. Are you reverting something? reverts don't run the commit message hook. You can revert then git commit --amend after to fix that | 21:13 |
| smcginnis | clarkb: No, this is a new change. I'm sure I had run `git review -s` some time in the past, but I did it again and tried amending. No luck. | 21:14 |
| clarkb | smcginnis: check .git/hooks/commit-msg in the repo | 21:16 |
| clarkb | the file needs to exist and be executable and if you open it should have a gerrit comment header | 21:16 |
| smcginnis | clarkb: Bingo! Looks like it got clobbered with a git-good-commit hook that another project wanted installed. | 21:17 |
| smcginnis | clarkb: Do you know if I can delete that file and run setup again? | 21:17 |
| clarkb | smcginnis: yes that should be safe | 21:17 |
| clarkb | the fiel is hosted by the gerrit server so it should redownload it | 21:17 |
| smcginnis | clarkb: Looks better! "# From Gerrit Code Review 3.4.3-46-g21b75586a3-dirty" | 21:17 |
| clarkb | yup | 21:18 |
| opendevreview | Sean McGinnis proposed openstack/releases master: Fix Yoga R-13 duration https://review.opendev.org/c/openstack/releases/+/833922 | 21:18 |
| smcginnis | Thanks clarkb ! | 21:18 |
| clarkb | you're welcome | 21:18 |
| *** dviroel|ruck is now known as dviroel|ruck|afk | 21:51 | |
| *** dviroel|ruck|afk is now known as dviroel|ruck | 23:55 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!