| bauzas | folks, I know we're super late for Nova RC1, but that's coming hopefully today | 07:55 |
|---|---|---|
| bauzas | we eventually merged all the needed reverts, but we still have the reno prelude patch on fly | 07:55 |
| opendevreview | Stephen Finucane proposed openstack/releases master: oslo.db 14.0.1 https://review.opendev.org/c/openstack/releases/+/895776 | 09:13 |
| frickler | stephenfin: hmm, weird validate error on that one. I would also argue that the version should be 15.0.0, because adding autocommit is a major change, but I'm open to discussion | 09:53 |
| frickler | I guess we need to override this somehow "deliverables/bobcat/oslo.db.yaml: validate_version_numbers: New dependency sqlalchemy-migrate" | 09:54 |
| frickler | in theory the check is correct, new dependencies must not be added in stable branches, but this is a special situation here I guess | 09:55 |
| frickler | hberaud: ttx: elodilles_pto: ^^ | 09:55 |
| stephenfin | Yeah, the sqlalchemy-migrate dependency is not _really_ required since most affected projects should be including it themselves, but without it docs don't build | 09:56 |
| stephenfin | I could try to fix up the docs build and remove it again, but if we can sidestep that I'd be happy invest my time elsewhere | 09:56 |
| frickler | stephenfin: oh, if it is for docs build only, moving it to doc/requirements.txt would be rather simple? but agreed to wait for release team feedback first | 09:59 |
| stephenfin | won't the req-check job look at that also? | 10:00 |
| frickler | I must admit I'm not sure about that, would have to need to look into the testing code | 10:01 |
| frickler | if I read this correctly, only the requirements in the sdist are checked https://opendev.org/openstack/releases/src/branch/master/openstack_releases/requirements.py#L93-L101 | 10:07 |
| stephenfin | Okay. Just in case it's easier https://review.opendev.org/c/openstack/oslo.db/+/895780 | 10:16 |
| zigo | stephenfin: frickler: Once we have oslo.db in order, and tagged, for all of this, let me know, and I can easily reschedule builds for all OpenStack projects (meaning, running unit tests at build time) with the new oslo.db, and report the failures. Even just a commit hash, I can test... | 10:17 |
| zigo | (even an unmerged patch...) | 10:17 |
| stephenfin | you can use the HEAD of stable/2023.2 now | 10:17 |
| zigo | Of oslo.db ? | 10:17 |
| zigo | Ok. | 10:17 |
| stephenfin | yup | 10:18 |
| zigo | stephenfin: There's no reversion or autocommit support in master yet ... | 10:19 |
| zigo | Oh, not master, sorry... | 10:19 |
| stephenfin | Yeah, we won't be (re-)adding it to master. We *have* to address SQLAlchemy 2.x support in C | 10:20 |
| stephenfin | stable-only | 10:20 |
| zigo | Agreed ! | 10:21 |
| zigo | FYI, I'm packaging this as 14.0.0+git.2023.09.18.4ee79141e6 | 10:21 |
| zigo | (probably just temporary...) | 10:22 |
| zigo | Is there a list of affected projects? Or shall I just attempt rebuilding them all? | 10:23 |
| zigo | I know we have aodh, cinder, cloudkitty, heat, at least... | 10:24 |
| stephenfin | https://meetings.opendev.org/irclogs/%23openstack-release/%23openstack-release.2023-09-18.log.html#t2023-09-18T08:49:36 | 10:25 |
| stephenfin | Careful not to confuse projects that have issues with sqlalchemy >= 2.0 and projects that have issues with oslo.db >= 13.0 | 10:25 |
| stephenfin | These oslo.db changes won't address the former, only the latter (by re-adding support for autocommit, which doesn't exist in sqlalchemy 2.x) | 10:26 |
| stephenfin | Cinder was working fine with oslo.db 13.0.0 iirc since it doesn't use autocommit | 10:26 |
| zigo | Sure ! :) | 10:26 |
| zigo | Well, somehow, it failed, so I'm attempting another rebuild... | 10:27 |
| zigo | Heat for bobcat hasn't been released yet, has it? | 10:29 |
| zigo | So I can't test it ... | 10:30 |
| zigo | (unless I tag and package head ...) | 10:30 |
| stephenfin | I've no idea, I'm afraid | 10:30 |
| zigo | Masakari fails for me: https://paste.opendev.org/show/btm0NRnJMsPDS68NcPgI/ | 10:31 |
| zigo | but that's maybe not related. | 10:31 |
| stephenfin | that's not oslo.db, that's oslo.context | 10:32 |
| zigo | Surprisingly, no issue when building it in Experimental, just in bookworm backport it fails to build ... | 10:32 |
| stephenfin | because of the sanitization thing that JayF added recently. I don't have the full context but he had to fix some projects. I guess masakari was missed? | 10:33 |
| stephenfin | I think Masakari needs a fix like this? https://review.opendev.org/c/openstack/cinder/+/893382/ | 10:33 |
| stephenfin | JayF will know more when he's online | 10:33 |
| zigo | Oh ok, so it probably doesn't fail with oslo.context 5.1.1, right? | 10:35 |
| zigo | That's yet another thing to track then ... | 10:36 |
| zigo | stephenfin: All fine to me. Should I expect the new oslo.db to be released today? | 10:40 |
| stephenfin | I think so, yes. We're just ironing a requirements-based kink (see above) | 10:41 |
| zigo | castellan needs fixing too ... Not sure who's working on it. | 10:41 |
| *** ralonsoh_ is now known as ralonsoh | 11:07 | |
| frickler | zigo: for castellan I proposed a series of reverts https://review.opendev.org/q/topic:revert-castellan-bobcat | 11:18 |
| frickler | maybe some day some oslo core will look at them | 11:18 |
| JayF | stephenfin: per masakari ptl they need no fix, I proposed one and they rejected it as unnecessary. I think they have same defaults in their context constructor | 13:28 |
| JayF | stephenfin: | 13:28 |
| JayF | As far as 4/2023.2, we should be good to go. I think there might be a couple of straggler backboards | 13:28 |
| JayF | **for 2023.2 | 13:28 |
| * JayF will be at a full size computer in an hour if you need more | 13:31 | |
| JayF | Looking at zigo's log, the PTL was wrong and they need that patch. I'm just not sure how to get someone to land a fix that they don't believe they need LOL | 13:36 |
| JayF | I'll paste that log into and bump the patch when I'm at a computer | 13:37 |
| opendevreview | Sylvain Bauza proposed openstack/releases master: Release nova RC1 for 2023.2 Bobcat https://review.opendev.org/c/openstack/releases/+/894693 | 13:56 |
| bauzas | huzaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaah | 13:57 |
| JayF | zigo: stephenfin: frickler: https://review.opendev.org/c/openstack/masakari/+/894393 | 14:05 |
| frickler | JayF: maybe they need a noop patch to demonstrate the gate failure? sorry I'm lacking a bit of context | 14:07 |
| JayF | frickler: Notifications have to be enabled to expose the failure | 14:07 |
| JayF | frickler: which they don't appear to have in their gate | 14:07 |
| JayF | hopefully the logs from zigo are sufficient, if it doesn't move in a day or two I'll email that PTL | 14:07 |
| JayF | they are in asia so I believe/hopefully sleeping right now :) | 14:08 |
| frickler | ah, so you'd have to add additional testing otherwise | 14:08 |
| JayF | on a project that I'm mostly unfamiliar with, exactly | 14:08 |
| hberaud | stephenfin: I don't think we have to remove this requirements, I think this message only ask us to move to a minor version | 14:13 |
| hberaud | stephenfin: I don't think we have to remove this requirements, I think this message only ask us to move to a minor version | 14:13 |
| frickler | hberaud: can you check the code link I pasted earlier? I don't think the message is about any version thing, it is about adding a requirement on a stable branch, which is not allowed | 14:23 |
| hberaud | AFAIK even if adding a new requirements to a stable branch is not allowed by our policy, this is not forbidden by the release tooling, its just that the version number proposed here do not respect the semver https://github.com/openstack/releases/blob/74ea15922cdc35619e313470e728e947d3023fc8/openstack_releases/cmds/validate.py#L1097 so normally moving to a minor release | 14:34 |
| hberaud | should fix that in all the cases | 14:34 |
| opendevreview | Dr. Jens Harbott proposed openstack/releases master: oslo.db 14.1.0 https://review.opendev.org/c/openstack/releases/+/895776 | 14:36 |
| frickler | so let's test this ^^. fwiw I also did a small amend for the commit message | 14:36 |
| zigo | JayF: Thanks, let me try that patch... :) | 14:37 |
| JayF | zigo: if it works, please post a comment on that change (well, either case really :D) | 14:37 |
| hberaud | frickler: the validation job just passed successfully | 14:42 |
| zigo | JayF: \o/ Your patch fixed it for me, adding my +1 ! :) | 14:43 |
| JayF | thank you | 14:43 |
| *** mtreinish_ is now known as mtreinish | 14:43 | |
| frickler | hberaud: yes, I saw, amended patch is already prepared | 14:44 |
| hberaud | cool, thx | 14:44 |
| zigo | Now, waiting on Nova and Heat to tag RC1 ... | 14:46 |
| zigo | And Glance ... | 14:46 |
| opendevreview | Dr. Jens Harbott proposed openstack/releases master: oslo.db 14.1.0 https://review.opendev.org/c/openstack/releases/+/895776 | 14:53 |
| frickler | stephenfin: hberaud: ^^ updated to the latest hash | 14:54 |
| hberaud | thx | 14:54 |
| hberaud | ttx: if you are around, please can validate this patch ^ | 14:55 |
| hberaud | s/you/ | 14:55 |
| opendevreview | Vishal Manchanda proposed openstack/releases master: Release Horizon 23.2.1 as the final tag for 2023.2 https://review.opendev.org/c/openstack/releases/+/895823 | 15:38 |
| opendevreview | Vishal Manchanda proposed openstack/releases master: Release Horizon 23.2.1 as the final tag for 2023.2 https://review.opendev.org/c/openstack/releases/+/895823 | 15:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!