| *** elodilles_pto is now known as elodilles | 09:06 | |
| frickler | elodilles: after this topic came up in the TC meeting yesterday, can we proceed with stein EOL for req + qa? those shouldn't be blocked by the remaining deployment projects, right? | 09:17 |
|---|---|---|
| elodilles | frickler: well, we can i guess, i just wanted to eol all the still-open repos that exist under deliverables/stein/*yaml before we move on with the req + qa, let me check where we are | 09:37 |
| elodilles | frickler: so these are still open: https://review.opendev.org/q/topic:stein-eol+is:open , I +2'd the osa-roles (additional) patch + the rpm-packaging probably we can proceed with all of them | 09:47 |
| elodilles | hberaud ttx : when you are around and have some spare time to review the stein-eol remaining patches ^^^ that would be awesome | 09:47 |
| opendevreview | Elod Illes proposed openstack/releases master: [OpenStackAnsible] Transition Stein to End of Life https://review.opendev.org/c/openstack/releases/+/893891 | 09:57 |
| elodilles | noonedeadpunk: sorry for pinging with this, but could you have a quick look at this stein-eol OSA patch? ^^^ | 09:59 |
| noonedeadpunk | elodilles: I need to prepare patch for the repo before marking it as eol... | 10:21 |
| noonedeadpunk | Was quite into master releasing rather then stein EOLing | 10:21 |
| elodilles | noonedeadpunk: yepp, that's completely understandable | 10:25 |
| elodilles | noonedeadpunk: speaking of that, if you think we don't need to wait anymore with the final release, then i can upgrade my +1 here: https://review.opendev.org/c/openstack/releases/+/903328/1 | 10:26 |
| noonedeadpunk | well.. I mean, I don;t think we have time anyway for rc2, despite we've spotted some bugs already - we'll do just bugfix release shortly instead | 10:27 |
| noonedeadpunk | so yeah, I guess makes sense to do final out of rc1 now | 10:28 |
| elodilles | noonedeadpunk: ACK, +2+W'd! | 10:32 |
| opendevreview | Merged openstack/releases master: Final release of OpenStack-Ansible for Bobcat https://review.opendev.org/c/openstack/releases/+/903328 | 10:55 |
| opendevreview | Merged openstack/releases master: [Packaging-rpm] Transition Stein to End of Life https://review.opendev.org/c/openstack/releases/+/902439 | 13:00 |
| opendevreview | Merged openstack/releases master: [OpenStackAnsible Roles] Transition Stein to End of Life - fix https://review.opendev.org/c/openstack/releases/+/902440 | 13:04 |
| *** d34dh0r5- is now known as d34dh0r53 | 14:59 | |
| elodilles | btw, the release-job-failure is related to the osa-roles stein-eol patch, see my comment here: https://review.opendev.org/c/openstack/releases/+/902440/comments/d27c51a1_f42c3cf5 | 17:00 |
| jrosser | elodilles: i don't believe there is any use of git submodules in openstack-ansible-ops, there is no .gitmodules file | 17:20 |
| jrosser | i'm not sure why `git submodule foreach cp -p .git/hooks/commit-msg "$(git rev-parse --git-dir)/hooks/"` was run in that job? | 17:22 |
| elodilles | neither am I, but it fails on that, but by running 'git rm --cached grafana/roles/grafana' solves the issue (or make it disappear) | 17:31 |
| elodilles | jrosser: so however there's no .gitmodules, it seems there is a cached submodule under grafana/roles/grafana, afaiu | 17:32 |
| jrosser | interesting | 17:34 |
| elodilles | jrosser: possible fix https://review.opendev.org/c/openstack/openstack-ansible-ops/+/903600 | 17:36 |
| jrosser | looks like that was added in 8ee8ec0832307898d534b8026f2b5bb8c5dfe732 | 17:37 |
| jrosser | but perhaps the .gitmodules file was forgotton to be committed? | 17:37 |
| elodilles | indeed | 17:39 |
| elodilles | yeah, probably that's the issue | 17:39 |
| elodilles | so yes, probably that is a better way to fix (adding the .gitmodule), rather than the workaround to remove the submodule | 17:43 |
| jrosser | i think we should remove the submodule, they're not nice anyway, and the readme.rst tells gives instructions for a more appropriate approach anyway | 17:45 |
| elodilles | ACK, ++, let's see if we can merge then the above workaround | 17:49 |
| elodilles | jrosser: i've added you then as reviewer o:) https://review.opendev.org/c/openstack/openstack-ansible-ops/+/903600 | 17:55 |
| elodilles | thanks o/ | 17:56 |
| elodilles | i'll propose another stein-eol patch against osa-roles after this has merged. | 17:56 |
| opendevreview | Elod Illes proposed openstack/releases master: [OpenStackAnsible Roles] Transition Stein to End of Life - fix2 https://review.opendev.org/c/openstack/releases/+/903607 | 18:07 |
| elodilles | noonedeadpunk: ^^^ | 18:09 |
| elodilles | jrosser noonedeadpunk : note that the submodule issue was fixed only in ussuri ( https://review.opendev.org/c/openstack/openstack-ansible-ops/+/701350 ) so either that patch or the above workaround has to be backported to train as well | 18:13 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!