| *** dtantsur_ is now known as dtantsur | 01:50 | |
| opendevreview | Tony Breeds proposed openstack/releases master: Add Redirection support for unmaintained branches and releases https://review.opendev.org/c/openstack/releases/+/907517 | 03:43 |
|---|---|---|
| opendevreview | Merged openstack/releases master: Release ironic-inspector 12.0.0 for caracal https://review.opendev.org/c/openstack/releases/+/907217 | 13:11 |
| opendevreview | Merged openstack/releases master: zuul: Add irrelevant-files for py311 job https://review.opendev.org/c/openstack/releases/+/907353 | 13:41 |
| opendevreview | Merged openstack/releases master: Return list-changes results as zuul artifact https://review.opendev.org/c/openstack/releases/+/907354 | 13:41 |
| *** blarnath is now known as d34dh0r53 | 14:53 | |
| tkajinam | https://zuul.opendev.org/t/openstack/build/2dcfcf09444949d29fea318d345f56ae | 14:58 |
| tkajinam | seems something got broken because of transition to unmaintained/yoga ? | 14:59 |
| tkajinam | 2024-02-02 14:50:37.248678 | ubuntu-jammy | Sphinx parallel build error: | 14:59 |
| tkajinam | 2024-02-02 14:50:37.248733 | ubuntu-jammy | ValueError: Unknown reference 'stable/yoga' | 14:59 |
| elodilles | oh, thanks tkajinam , looks interesting :S | 15:37 |
| tkajinam | probably we have to fix something in reno ? | 15:38 |
| tkajinam | a bit annoying thing, at my first look, is that reno has branch_name_prefix option but it accepts only a single value apparently | 15:39 |
| elodilles | i haven't looked the exact problem, but it is interesting that it misses stable/yoga, while it didn't miss the older branches previously when we deleted them | 15:41 |
| frickler | seem reno checks for the -eol tag and replaces that as surrogate for the stable/ branch. seems we'll want to do the same with the -eom tag | 16:04 |
| tkajinam | ahh yeah | 16:05 |
| frickler | the question is do we want to publish releasenotes from unmaintained/yoga? | 16:05 |
| frickler | or keep them at the yoga-eom state? | 16:05 |
| frickler | I guess the latter, since there are to be no releases from unmaintained, right? | 16:06 |
| tkajinam | For me it does not make much sense to publish release notes for yoga because we no longer get a new release | 16:06 |
| tkajinam | we probably should have exclude the stable branches in EM status | 16:06 |
| tkajinam | s/exclude/excluded/ | 16:06 |
| tkajinam | frickler, yeah I agree | 16:07 |
| frickler | tkajinam: actually this is a per-project config option, see e.g. https://opendev.org/openstack/ceilometer/src/branch/master/reno.yaml#L4 , so you can add that for aodh similarly and likely use something like "-eo?[lm]" (with a bit of fuzz) | 16:10 |
| elodilles | frickler: i don't think we want to publish releasenotes for unmaintained/<series>, to keeping the last stable release or <series>-eom should be fine | 16:11 |
| frickler | I'm not sure whether we want to change the default in reno or add the above config to all openstack projects, currently only a few of them have this | 16:13 |
| frickler | rosmaita: JayF: ^^ | 16:13 |
| elodilles | (weird, recently i have problem with git clone. it's slow and e.g. errors out around 99% when cloning a fresh aodh repo :S) | 16:13 |
| frickler | are you cloning from opendev.org? there have been some network performance issues with vexxhost | 16:14 |
| elodilles | yepp, opendev.org | 16:14 |
| frickler | mostly in th EU afternoon/evening | 16:14 |
| elodilles | then that's the issue probably | 16:14 |
| frickler | you can clone from github instead, though it is a bit sad having to recommend this | 16:15 |
| elodilles | :/ | 16:15 |
| JayF | elodilles: frickler: we publish release notes for unreleased projects currently. Why would we stop for unmaintained? | 16:16 |
| JayF | I understand if there's some technical barrier and we need to find someone to do the work to enable that. I just don't think there is value in saying no for the sake of saying no | 16:16 |
| frickler | JayF: what unreleased projects? we publish in-progress release notes before an official release, but unmaintained is never going to be released | 16:17 |
| JayF | Given it a per project config option.. it just makes me wonder if letting the projects who care enable it is the path of least resistance | 16:17 |
| JayF | frickler: in current day, unreleased commits on the tip of an em branch | 16:17 |
| JayF | Those are also never going to be released but are still documented. As someone who has been the downstream from one of those em branches, release notes are pretty crucial tool for it being useful | 16:18 |
| frickler | the other option we have is just changing from stable to unmaintained here I guess https://opendev.org/openstack/aodh/raw/branch/master/releasenotes/source/yoga.rst | 16:18 |
| frickler | maybe that could even be integrated into the bot generated patches | 16:19 |
| JayF | I was thinking that if it came down to per project, I would probably enable it for ironic and edit those templates to indicate the line between final supported release and unmaintained commits afterward | 16:19 |
| JayF | I need to AFK for a couple of hours, but I'll check the backlog when I'm back | 16:20 |
| tkajinam | hmm I tried a few patterns like closed_branch_tag_re: "(.+)-(eol|eom)" but none of these work so far | 16:22 |
| tkajinam | frickler, updating that file didn't work either. for some reason it still attempts to search stable/yoga | 16:24 |
| tkajinam | Exception occurred: | 16:24 |
| tkajinam | File "/home/tkajinam/git/openstack/aodh/.tox/releasenotes/lib/python3.11/site-packages/reno/scanner.py", line 588, in _get_ref | 16:24 |
| tkajinam | raise ValueError('Unknown reference {!r}'.format(name)) | 16:24 |
| tkajinam | ValueError: Unknown reference 'stable/yoga' | 16:24 |
| tkajinam | sorry I'm dropping off | 16:27 |
| tkajinam | will make a few more trials but I vaguely guess this may need some logic change in reno | 16:28 |
| rosmaita | looks like the use-eol-tag-if-stable-branch-does-not-exist behavior is hard coded into the scanner | 16:30 |
| rosmaita | https://opendev.org/openstack/reno/src/branch/master/reno/scanner.py#L557 | 16:30 |
| rosmaita | maybe the thing to do is what frickler suggested earlier, we could add '-eom' to the list of candidates, the line before '-eol' is added in the scanner ^^ | 16:34 |
| frickler | rosmaita: that would freeze yoga renos, but it seems JayF wants to still see updates | 16:42 |
| frickler | I've done https://review.opendev.org/c/openstack/aodh/+/907619 for testing, it works for me locally, let's see what CI says | 16:43 |
| gmann | elodilles: what you think of this https://review.opendev.org/c/openstack/releases/+/907493 | 17:54 |
| elodilles | gmann: thanks for pointing to this release patch, i've commented on it | 18:08 |
| gmann | elodilles: cool, thanks | 18:09 |
| elodilles | np | 18:09 |
| elodilles | frickler: based on your fix: https://review.opendev.org/c/openstack/project-config/+/907626 | 19:16 |
| *** priteau_ is now known as priteau | 21:44 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!