opendevreview | Jake Yip proposed openstack/releases master: [magnum] release magnum 17.0.2 https://review.opendev.org/c/openstack/releases/+/907693 | 02:58 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/releases master: storlets: EOL wallaby and xena https://review.opendev.org/c/openstack/releases/+/907695 | 03:28 |
opendevreview | Takashi Kajinami proposed openstack/releases master: storlets: EOL wallaby and xena https://review.opendev.org/c/openstack/releases/+/907695 | 07:22 |
opendevreview | Takashi Kajinami proposed openstack/releases master: storlets: Transition stable/yoga to EOL https://review.opendev.org/c/openstack/releases/+/907709 | 08:20 |
tkajinam | I've added a comment in the original review but I wonder if we can directly transition stable/yoga to eol in case no one is interested in backports ? | 08:21 |
elodilles | tkajinam: with the victoria and ussuri branch of storlets i'm completely OK, though about yoga i'd say let's stick to Unmaintained for now. i understand your point and that there most probably won't be any maintainer backport fixes, but the point is to make it possible anyway. furthermore, the unmaintained process is still not super steady and everything else transitions to unmaintained | 08:53 |
elodilles | there, let's just stick to that with storlets, too, for now | 08:53 |
tkajinam | ok | 08:54 |
tkajinam | if that is easier then I won't strongly argue it | 08:54 |
*** ralonsoh_ is now known as ralonsoh | 08:56 | |
elodilles | thanks tkajinam o/ | 09:10 |
tkajinam | elodilles, give me short time to get my question in #openstack-tc answered. just would like to double-check governance of the unmaintained branch (mainly how we retire these) | 09:12 |
tkajinam | once I get an answer then I'll flip my vote | 09:13 |
elodilles | ACK. (in general the whole process is to EOL branches directly if a team does not want to keep it open, so this shouldn't be a problem in the future) | 09:21 |
tkajinam | frickler, thanks for the patch to fix release note build. I don't know why it did not work in my local when I tried it (IIRC) but the job is passing. | 10:34 |
tkajinam | frickler, I've seen the same error in a few other repos such as barbican so will steal your fix (with co-author). | 10:34 |
tkajinam | probably we may want to update the release bot to update the release note file. | 10:35 |
frickler | tkajinam: ack, elodilles already made a patch https://review.opendev.org/c/openstack/project-config/+/907626 | 10:42 |
frickler | elodilles: https://review.opendev.org/c/openstack/project-config/+/907626 was merged. not sure if testing with release-test will work, since that already migrated to unmaintained? we could use kolla or designate instead IMO, I can fix those patches up manually if things go wrong | 13:08 |
elodilles | frickler: yepp, that is the best way forward o/ let's test it with either kolla or designate | 13:29 |
elodilles | (i have +2 on both) | 13:36 |
frickler | ok, moving on with 906579 | 13:53 |
opendevreview | Merged openstack/releases master: [designate] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906579 | 14:02 |
opendevreview | Merged openstack/releases master: [oslo] Transition Ussuri to End of Life https://review.opendev.org/c/openstack/releases/+/903281 | 14:27 |
elodilles | patches are looking good: https://review.opendev.org/q/topic:reno-eom-yoga | 14:57 |
elodilles | so the script is working | 14:57 |
elodilles | as intended | 14:57 |
frickler | ack, just approved them. so ... let's go on then? or is there anything we're still waiting for? | 15:07 |
elodilles | i think we can proceed | 15:08 |
frickler | ok, I'm reviewing+approving all yoga patches that have another +2 and no pending comments then | 15:29 |
elodilles | thanks \o/ | 15:35 |
opendevreview | Merged openstack/releases master: [cyborg] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906556 | 15:39 |
opendevreview | Merged openstack/releases master: [zun] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906552 | 15:50 |
opendevreview | Merged openstack/releases master: [zaqar] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906563 | 15:50 |
opendevreview | Merged openstack/releases master: [watcher] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906575 | 15:53 |
opendevreview | Merged openstack/releases master: [adjutant] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906585 | 15:53 |
opendevreview | Merged openstack/releases master: [tacker] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906591 | 15:53 |
frickler | hmm, I guess https://review.opendev.org/c/openstack/releases/+/907517 might have needed review first. will give it a deeper look now | 15:54 |
opendevreview | Merged openstack/releases master: [ec2-api] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906554 | 15:57 |
opendevreview | Merged openstack/releases master: [kolla] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906573 | 16:03 |
opendevreview | Merged openstack/releases master: [OpenStackSDK] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906576 | 16:04 |
opendevreview | Takashi Kajinami proposed openstack/releases master: [Puppet OpenStack] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906571 | 16:05 |
frickler | ah, no, that redirect patch can only work on top of the reqs patch anyway | 16:26 |
opendevreview | Merged openstack/releases master: [cloudkitty] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906553 | 16:39 |
opendevreview | Merged openstack/releases master: [cinder] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906572 | 16:39 |
opendevreview | Merged openstack/releases master: [neutron] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906564 | 16:41 |
opendevreview | Merged openstack/releases master: [heat] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906567 | 16:42 |
elodilles | OK, it seems we will have some 'lost' patches: https://review.opendev.org/q/branch:stable/yoga+is:merged | 16:46 |
elodilles | * cloudkitty | 16:46 |
frickler | yeah, but what can we do? people don't listen. the reviews are visible in gerrit and people can repropose them against unmaintained, so not completely lost | 16:49 |
frickler | next question is what do we do with the ~20 patches without PTL feedback? wait more? until when? or just merge them without PTL+1? | 16:50 |
opendevreview | Merged openstack/releases master: [blazar] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906593 | 16:51 |
opendevreview | Merged openstack/releases master: [storlets] Transition Yoga to Unmaintained https://review.opendev.org/c/openstack/releases/+/906558 | 16:51 |
fungi | elodilles: is the eom script done now, or is it at a point where it can be paused. we're looking at doing a restart of zuul executors and would rather avoid any risk of impacting release jobs | 16:52 |
fungi | s/./?/ | 16:52 |
frickler | elodilles: do you want to update the ironic patch or should I ask the ironic team? (I'm assuming that this is just rerunning the release script) | 16:52 |
frickler | fungi: that was my manual approving. if there is nothing more in the queue, that should be all for now | 16:53 |
fungi | frickler: aha, thanks! | 16:53 |
elodilles | frickler: i'll ping the PTL's 1st via the patch, after that via IRC / mail if needed. | 16:53 |
frickler | fungi: so best wait until the *post and tag pipelines are cleared | 16:54 |
fungi | release managers: please hold any further release change approvals and i'll let you know as soon as we're done with the restarts | 16:54 |
fungi | frickler: yep, we will | 16:54 |
elodilles | fungi: ACK, thanks | 16:54 |
frickler | oh, that's another key to add to my notify list I guess | 16:54 |
fungi | i don't know if the release managers have a defined string they use for irc group notifications, but maybe choosing one would be a good topic for the next meeting if not | 16:55 |
fungi | and then i'll be sure to use it | 16:56 |
elodilles | fungi: i'll run the EOM branch cleanup script early tomorrow if that is OK (like 11-12 UTC or so) | 16:56 |
fungi | elodilles: that's great, thanks! | 16:56 |
fungi | the semaphore on the release notes job is biting us again, looks like. i wonder if there's an easier way to toggle it off for bulk approvals affecting a single branch | 16:57 |
elodilles | frickler: i usually just update the hashes, it's usually easier and quicker. (process_auto_releases.sh is a quick way to generate release patches, but a simple update is better for an existing patch) | 16:58 |
frickler | fungi: but this is just slowing things down, not blocking anything, or is it? also I didn't see a note about the restart in #opendev, was this discussed elsewhere or planned earlier? | 17:01 |
fungi | it's to address a potential security vulnerability in the zuul-executor containers. looking at the jobs that are still running/queued they should all be safe to automatically rerun if interrupted by an ungraceful executor restart, so i don't think we need to wait for them | 17:36 |
fungi | it's down to just release notes and releases site updates, and zuul will restart those builds automatically | 17:37 |
fungi | we shouldn't have to manually reenqueue anything | 17:37 |
clarkb | the restarts are done now | 18:09 |
fungi | thanks! | 18:09 |
fungi | release managers: feel free to go back to approving release requests et cetera | 18:09 |
*** mtreinish_ is now known as mtreinish | 18:24 | |
elodilles | ACK, thanks o/ | 18:30 |
elodilles | (though i'm already done for the day o:)) | 18:31 |
elodilles | note that we have 3 failed release jobs ( https://lists.openstack.org/archives/list/release-job-failures@lists.openstack.org/ ), actually tag-releases job failed on all three cases: https://zuul.openstack.org/builds?job_name=tag-releases&result=FAILURE&skip=0 | 18:43 |
elodilles | and i don't see why. the unmaintained/yoga branches were cut successfully, just as the yoga-eom tagging | 18:44 |
clarkb | I think all of those failures occurred before I restarted any services | 18:46 |
clarkb | just to rule that out | 18:46 |
elodilles | these don't look related to the zuul restarts, yepp | 18:47 |
frickler | I think this is one of the failures: sed: can't read releasenotes/source/yoga.rst: No such file or directory | 19:45 |
frickler | https://opendev.org/openstack/python-zaqarclient/src/branch/master/releasenotes/source only ussuri and older | 19:45 |
frickler | yes, same for the other two. so need to amend the script with a check for the actual series.rst file to exist, testing for the repo is not enough | 19:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!