*** tkajinam is now known as Guest1349 | 01:24 | |
*** elodilles_pto is now known as elodilles | 08:29 | |
noonedeadpunk | hm, but still renos are borked for us :( as now Zed can't distinguish properly where it should start | 08:37 |
---|---|---|
noonedeadpunk | so it feels not catching diff-start properly somehow... | 08:39 |
noonedeadpunk | ok, reno really needs some love fram what I do see... | 08:46 |
opendevreview | Dmitriy Rabotyagov proposed openstack/reno master: Respect EOM tag for branches in unmaintained status https://review.opendev.org/c/openstack/reno/+/910547 | 09:04 |
noonedeadpunk | this is really dirty hack :( | 09:04 |
noonedeadpunk | I'm not sure though how we can override config of reno through sphinx though | 09:05 |
noonedeadpunk | and this really blocks us from merging anything to master right now | 09:15 |
opendevreview | Gregory Thiemonge proposed openstack/releases master: Release final python-octaviaclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910207 | 09:25 |
opendevreview | Elod Illes proposed openstack/releases master: Release final python-masakariclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910179 | 09:33 |
opendevreview | Merged openstack/releases master: Release final python-troveclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910211 | 09:37 |
opendevreview | Elod Illes proposed openstack/releases master: Release final python-cloudkittyclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910165 | 09:38 |
opendevreview | Merged openstack/releases master: Release final python-zaqarclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910215 | 09:43 |
opendevreview | Elod Illes proposed openstack/releases master: Release final python-heatclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910170 | 09:45 |
noonedeadpunk | well, I found a way forward for us, by creating a releasenotes/config.yaml with `closed_branch_tag_re: '(.+)-eo[l,m]'` but I'd assume all projects would need that... | 09:46 |
opendevreview | Merged openstack/releases master: Release final python-neutronclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910204 | 09:53 |
opendevreview | Merged openstack/releases master: Release final python-ironic-inspector-client for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910171 | 09:53 |
elodilles | noonedeadpunk: i remember a similar issue some weeks ago, i have to dig a bit what was the outcome of that as I don't remember the details... :/ thanks for bringing it up here! | 10:26 |
noonedeadpunk | but eventualy I'd guess that https://review.opendev.org/c/openstack/reno/+/910547 will fix for everyone. And I'd assume that some fix like that must-have before moving more branches to unmaintained | 10:27 |
opendevreview | Merged openstack/releases master: 2023.1/Antelope release python-aodhclient 3.2.1 https://review.opendev.org/c/openstack/releases/+/909946 | 10:37 |
opendevreview | Riccardo Pittau proposed openstack/releases master: Release final python-ironicclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910172 | 11:09 |
frickler | ttx: hberaud: elodilles: I agree with noonedeadpunk that we should defer merging further eom patches until the reno situation is resolved. also added some comments on https://review.opendev.org/c/openstack/reno/+/910547 and would like to hear your opinion about it | 11:26 |
opendevreview | Dmitriy Rabotyagov proposed openstack/reno master: Respect EOM tag for branches in unmaintained status https://review.opendev.org/c/openstack/reno/+/910547 | 11:29 |
*** tosky_ is now known as tosky | 11:48 | |
noonedeadpunk | Well, it was early to celebrate, https://review.opendev.org/c/openstack/openstack-ansible/+/908499 is still not passing... | 11:57 |
noonedeadpunk | but locally it worked... | 11:57 |
elodilles | i think changing to unmaintained/yoga from stable/yoga in yoga.rst should be enough | 12:15 |
elodilles | the real issue is : releasenotes/source/zed.rst:3:Duplicate explicit target name: "bug". | 12:15 |
noonedeadpunk | elodilles: tis was fixed by the config | 12:16 |
elodilles | so there is some wrong formatting somewhere (something changed in sphinx if i'm not mistaken) | 12:16 |
noonedeadpunk | ie https://review.opendev.org/c/openstack/openstack-ansible/+/908499/6/releasenotes/config.yaml | 12:16 |
frickler | elodilles: yes, iiuc this happens because reno does not detect that yoga came before zed. instead looks at all old...zed | 12:16 |
elodilles | at least we fixed the formatting in some other repo and the issue disappeared | 12:17 |
noonedeadpunk | but somnehow now changing to unmaintained/yoga doesn't work again :( | 12:17 |
frickler | elodilles: it will only appear if there a renos of a certain type in old enough branches | 12:17 |
frickler | maybe we need to change the branch_re after all as I noted in the review? | 12:17 |
noonedeadpunk | like - having config does neglect what is provided in sphinx | 12:17 |
noonedeadpunk | frickler: I don't think you've mentioned branch_re there | 12:26 |
noonedeadpunk | or I'm jsut blind... | 12:27 |
noonedeadpunk | ah, ok | 12:27 |
noonedeadpunk | now I see :D | 12:27 |
noonedeadpunk | So, the question with unmantained branches is valid one. but I'm not sure that release notes from unmaintained branches should be included at all? | 12:28 |
noonedeadpunk | Or be mixed with non-unmaintained ones | 12:28 |
noonedeadpunk | since no releasing will happen on unmaintained - it might create quite some mess | 12:28 |
noonedeadpunk | As it should be some solid distinguishment between these 2 I belive | 12:29 |
noonedeadpunk | Especially given that core teams don't have even access to unmaintained branches... | 12:29 |
frickler | noonedeadpunk: well it was argued that that is same thing that happened with EM branches before. happy to see you join the TC and join me in policy discussions ;-) | 12:29 |
noonedeadpunk | except it was different... | 12:30 |
* noonedeadpunk need to justify time spent on such discussions/activities these days | 12:31 | |
noonedeadpunk | but now unmaintained has quite significat differences form the state it was originally discussed when I was part of discussions... | 12:31 |
noonedeadpunk | Or I again misunderstood what was written/said | 12:32 |
noonedeadpunk | anyway | 12:32 |
frickler | I personally would very much like to treat eom the same as eol, but I wasn't able to convince others when I tried to | 12:32 |
noonedeadpunk | yeah, I know. | 12:33 |
frickler | see also kind of unrelated the discussion whether grenade should keep testing yoga=>zed or =>2023.1 | 12:33 |
noonedeadpunk | while I get arguments, but I don't fully share them | 12:33 |
frickler | I also don't understand why https://review.opendev.org/c/openstack/openstack-ansible/+/908499/7 is still failing, maybe it actually needs a new reno release. do you want to try to remove releasenotes/source/yoga.rst completely as a gate blocker? people might be able to live without these for a couple of days? | 12:37 |
elodilles | it's interesting as i could not reproduce the issue locally either | 12:39 |
elodilles | for me it's passing and the generated reno pages (zed, yoga) seem to be correct | 12:39 |
frickler | elodilles: yes, seems to be something to do with our precloned images. guess I'll have to hold a node to debug | 12:39 |
frickler | *with the precloned repos in our images | 12:40 |
frickler | elodilles: although I do get the same error locally now, after using a fresh clone of the repo | 12:43 |
elodilles | at least we should add a -vvv to releasenotes tox target's sphinx command | 12:43 |
frickler | and the error goes away if I use noonedeadpunk's reno version from 910547 | 12:45 |
elodilles | for me PS2 is enough to make things pass :) | 12:46 |
frickler | elodilles: PS2 of the reno patch? | 12:48 |
elodilles | yepp | 12:51 |
frickler | elodilles: yes, but that's because noonedeadpunk overrides the closed_branch_re in his osa patch. let me try without that | 12:51 |
elodilles | in PS2 it's still not there i think | 12:52 |
elodilles | (the regex) | 12:53 |
frickler | elodilles: exactly, and when removing releasenotes/config.yaml from the osa patch, the original error is back | 12:54 |
elodilles | PS2 contains only the stable/yoga to unmaintained/yoga change in yoga.rst. anyway, let's see what the gate fails on. | 12:55 |
frickler | this happens when trying to find the starting point for zed: ValueError: Unknown reference 'stable/yoga' | 12:56 |
noonedeadpunk | ah... so would still need the patch or changing regexp I guess | 12:58 |
opendevreview | Merged openstack/releases master: Create new oslo.context release for 2024.1 https://review.opendev.org/c/openstack/releases/+/910450 | 13:03 |
opendevreview | Merged openstack/releases master: Release final python-swiftclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910210 | 13:03 |
frickler | noonedeadpunk: seems the reno patch is needed in any case. so now to convince elodilles about that ;) | 13:05 |
opendevreview | Merged openstack/releases master: Release octavia-lib for stable/zed https://review.opendev.org/c/openstack/releases/+/906866 | 13:05 |
opendevreview | Merged openstack/releases master: Release octavia-dashboard for stable/zed https://review.opendev.org/c/openstack/releases/+/906865 | 13:05 |
opendevreview | Merged openstack/releases master: Release octavia for stable/zed https://review.opendev.org/c/openstack/releases/+/906867 | 13:05 |
opendevreview | Merged openstack/releases master: Release python-octaviaclient for stable/zed https://review.opendev.org/c/openstack/releases/+/906875 | 13:05 |
opendevreview | Merged openstack/releases master: Release final oslotest for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910352 | 13:08 |
opendevreview | Merged openstack/releases master: Release final python-masakariclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910179 | 13:08 |
opendevreview | Merged openstack/releases master: Release final python-cloudkittyclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910165 | 13:10 |
*** ralonsoh_ is now known as ralonsoh | 13:59 | |
rpittau | elodilles: hi! Saw your comment in https://review.opendev.org/c/openstack/releases/+/910172 and replied, curious to see if I'm doing something wrong with my git-fu :) | 14:30 |
rpittau | oh sorry, just saw you approved, nvm! | 14:31 |
rpittau | errrr.. wrong patch :D | 14:31 |
elodilles | rpittau: the hash is OK, my bad o:) will check the logs and change my review | 14:44 |
rpittau | elodilles: thanks! | 14:45 |
elodilles | +2+W'd | 14:46 |
elodilles | sorry :S | 14:46 |
rpittau | elodilles: no worries! thanks for checking :) | 14:47 |
frickler | elodilles: rpittau: noticed another issue on that patch, maybe hold the approval? | 14:52 |
rpittau | frickler: thanks for checking, that's not exactly related to the version though, can we do the change in a follow up? I think we have more to fix anyway | 14:53 |
rpittau | probably all to fix :D | 14:55 |
frickler | I was just worried about this coming out wrong in the release announcement. not sure who still reads those, though | 14:55 |
elodilles | yes, please push a separate change for that | 14:55 |
rpittau | I will push a change with all the fixes, I just realized we haven't changed any of our projects! | 14:56 |
opendevreview | Merged openstack/releases master: Release final python-ironicclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910172 | 14:56 |
elodilles | anyway, the patch has merged ^^^ | 14:57 |
* rpittau thumbsup | 14:57 | |
frickler | elodilles: different question, as discussed in the oslo channel, this branch https://review.opendev.org/q/project:openstack/oslo.messaging+branch:feature/nats-driver was created via https://review.opendev.org/c/openstack/releases/+/695979 but now needs to be deleted because it is no longer needed and causing zuul config errors. do we need a patch for that or can I simply push the delete to | 15:00 |
frickler | gerrit? | 15:00 |
frickler | similar issue for a feature branch in glance, but I didn't get feedback there yet | 15:01 |
opendevreview | Riccardo Pittau proposed openstack/releases master: Move ironic projects to launchpad https://review.opendev.org/c/openstack/releases/+/910634 | 15:02 |
opendevreview | Merged openstack/releases master: Release final python-octaviaclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910207 | 15:02 |
opendevreview | Riccardo Pittau proposed openstack/releases master: Move ironic projects to launchpad https://review.opendev.org/c/openstack/releases/+/910634 | 15:04 |
mtreinish | I was wondering if there was a plan to have a new reno release anytime soon? We've been using it from git on a few projects to get access to the subsections support, but it be good to have a proper release of it | 17:46 |
opendevreview | Carlos Eduardo proposed openstack/releases master: Release final python-manilaclient for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/910176 | 18:57 |
clarkb | fungi: should we ask openstack to stop making releases? | 19:38 |
clarkb | but also doc builds will write to the RW location... | 19:38 |
clarkb | or try to? | 19:38 |
fungi | short of pausing zuul i'm not sure we can do much to stop executors from writing into afs | 19:43 |
fungi | but yes, not approving new releases right this moment would be good | 19:43 |
fungi | fileserver crisis is basically over now, so should be fine to approve more release requests whenever | 21:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!