*** elodilles_pto is now known as elodilles | 08:03 | |
damani[m] | hi | 10:07 |
---|---|---|
elodilles | hi o/ | 10:09 |
damani[m] | elodilles, do you need help with the epoxy releases? | 10:29 |
damani[m] | elodilles, i can for example update this patch with the good sha https://review.opendev.org/c/openstack/releases/+/934615?usp=dashboard | 10:30 |
hberaud[m] | damani: I think the release team is waiting for your approval on all the milestone 1 patches related to oslo https://review.opendev.org/q/topic:%22epoxy-milestone-1%22 | 10:36 |
damani[m] | i have already made all the code review | 10:36 |
damani[m] | for example https://review.opendev.org/c/openstack/releases/+/934610 | 10:37 |
damani[m] | hberaud, and i have discussed about it with elodilles already :) | 10:37 |
damani[m] | but now my question is if i need help with the update and so on | 10:38 |
hberaud[m] | I think you missed to vote on some of them https://review.opendev.org/c/openstack/releases/+/934616 | 10:38 |
hberaud[m] | and without your vote the PTL approved flag won't be triggered | 10:38 |
hberaud[m] | apart if the release team add it manually | 10:38 |
damani[m] | i have put comment on it | 10:39 |
hberaud[m] | same thing here https://review.opendev.org/c/openstack/releases/+/934616 | 10:39 |
damani[m] | i have made the code review | 10:39 |
damani[m] | and i ask something in a comment | 10:39 |
hberaud[m] | hm you said that the patches "LGTM", that's all | 10:40 |
damani[m] | no i said | 10:41 |
damani[m] | Looks good to merge. Verified that the SHA corresponds to the latest commit in the repository. See1 for details. | 10:41 |
hberaud[m] | https://review.opendev.org/c/openstack/releases/+/934616/comments/09ee6cae_7181dcbb | 10:41 |
hberaud[m] | yes, is not like saying that the patch "LGTM", I'm not sure to follow you | 10:42 |
damani[m] | here i have put -1 https://review.opendev.org/c/openstack/releases/+/934610 | 10:42 |
hberaud[m] | what did you ask? | 10:42 |
damani[m] | and so on | 10:42 |
hberaud[m] | on this one yes, but on the other patches no | 10:42 |
hberaud[m] | I mean on some other patches, not all | 10:43 |
hberaud[m] | like this one https://review.opendev.org/c/openstack/releases/+/934616 | 10:43 |
damani[m] | i have check all the patches | 10:43 |
damani[m] | and comment all | 10:43 |
damani[m] | for example https://review.opendev.org/c/openstack/releases/+/934618 | 10:44 |
hberaud[m] | ok, but is this patch ok? https://review.opendev.org/c/openstack/releases/+/934616 | 10:44 |
hberaud[m] | and this one? according to your comment I suppose that yes https://review.opendev.org/c/openstack/releases/+/934619 | 10:46 |
hberaud[m] | damani: I left comments on the patches missing the PTL flag and where you put comments that seems to validate that the patch is ok | 10:49 |
hberaud[m] | damani: seen your confirmations, thank you | 10:51 |
opendevreview | Merged openstack/releases master: Release oslo.metrics for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934616 | 11:01 |
elodilles | thanks damani[m] and hberaud[m] i'll go through the patches and ping you damani[m] if needed | 11:03 |
elodilles | damani[m]: yes, please update this patch: https://review.opendev.org/c/openstack/releases/+/934615 | 11:04 |
opendevreview | Merged openstack/releases master: Release oslo.middleware for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934617 | 11:05 |
opendevreview | Merged openstack/releases master: Release castellan for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934596 | 11:05 |
opendevreview | Daniel Bengtsson proposed openstack/releases master: Release oslo.messaging for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934615 | 11:09 |
opendevreview | Merged openstack/releases master: Release oslo.versionedobjects for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934624 | 11:09 |
opendevreview | Daniel Bengtsson proposed openstack/releases master: Release oslo.context for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934610 | 11:11 |
damani[m] | elodilles, done | 11:12 |
elodilles | thx o/ | 11:12 |
damani[m] | no problem :) | 11:12 |
opendevreview | Merged openstack/releases master: Release oslo.config for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934609 | 11:13 |
opendevreview | Merged openstack/releases master: Release oslo.rootwrap for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934621 | 11:13 |
damani[m] | elodilles, thanks a lot for the patches | 11:13 |
elodilles | no problem either ;) | 11:15 |
opendevreview | Merged openstack/releases master: Release oslo.serialization for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934622 | 11:28 |
opendevreview | Merged openstack/releases master: Release oslo.limit for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934613 | 11:37 |
opendevreview | Merged openstack/releases master: Release oslo.privsep for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934618 | 12:04 |
sean-k-mooney | hi whats teh process for proposing uc bumps manually? yappi has not been bumped for a long time and it looks liek its not explcitly pinned for python 3.13 we are going to need to move to 1.6.10 i belive to fix a complieation issue so im wondering should i just propose a patch updateing uc or if we shoudl figure out why it was not bumped already | 12:19 |
hberaud[m] | I think that's more a question for the requirements team | 12:22 |
sean-k-mooney | ah fair | 12:22 |
hberaud[m] | AFAIK you are free to propose a patch to bump it manually | 12:23 |
sean-k-mooney | i can submit the patch but that just leads to ModuleNotFoundError: No module named 'cgi' | 12:23 |
sean-k-mooney | i think i have don that before its just been a while | 12:23 |
hberaud[m] | but indeed, the last update of yappi was in 2022 | 12:23 |
hberaud[m] | that's quite long now | 12:24 |
sean-k-mooney | normally that is because of a pin somewhere else but i did see it at a glance | 12:24 |
sean-k-mooney | my guess is three is a pin in some other package somewhre but if i push the bump that might help find it | 12:24 |
hberaud[m] | maybe | 12:25 |
frickler | sean-k-mooney: for the cgi failure you need WebOb==1.8.9 | 12:25 |
frickler | s/for/to fix/ | 12:25 |
sean-k-mooney | ack is that bump propsoed already | 12:25 |
frickler | all u-c bumps are regularly proposed (once a week), but regularly fail CI because a lot of fixes are still missing | 12:26 |
sean-k-mooney | i noticed the generate srcip currently still has py38 in the list of python but no 3.12 or 3.13 | 12:26 |
frickler | see https://review.opendev.org/c/openstack/requirements/+/933484 and https://review.opendev.org/c/openstack/requirements/+/907665 | 12:26 |
frickler | current u-c has 3.9 - 3.12, 3.13 is still considered out of scope | 12:27 |
sean-k-mooney | i was looking at the tox target | 12:27 |
sean-k-mooney | https://github.com/openstack/requirements/blob/master/tox.ini#L52 | 12:27 |
sean-k-mooney | that has not been updated to replace 3.8 with 3.12 | 12:28 |
frickler | that's not actually used by the weekly job | 12:28 |
sean-k-mooney | oh ok | 12:29 |
frickler | but maybe let's switch to the reqs channel if you want to discuss further | 12:29 |
sean-k-mooney | right i was going to ask is that #openstack-requirements | 12:29 |
frickler | yes | 12:29 |
opendevreview | Merged openstack/releases master: Release oslo.i18n for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934612 | 13:06 |
opendevreview | Merged openstack/releases master: Release oslo.reports for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934619 | 13:06 |
opendevreview | Merged openstack/releases master: Release oslo.context for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934610 | 13:06 |
opendevreview | Elod Illes proposed openstack/releases master: Release stevedore for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934633 | 13:12 |
elodilles | damani[m]: if you could revisit this patch, that would be awesome: https://review.opendev.org/c/openstack/releases/+/934633 | 13:13 |
elodilles | (i've updated the hash to include the latest merged patch) | 13:13 |
opendevreview | Elod Illes proposed openstack/releases master: Release oslo.db for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934611 | 13:20 |
elodilles | damani[m]: and this too ^^^ thanks in advance o/ | 13:21 |
frickler | elodilles: the commits that gtema mentioned in https://review.opendev.org/c/openstack/releases/+/934599 have all merged, so this could also get updated I guess? (just because you're currently at it, otherwise I'd also update it myself ;) | 13:25 |
opendevreview | Elod Illes proposed openstack/releases master: Release oslo.log for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934614 | 13:26 |
gtema | not yet, there was a pipe of stale changes behind those few and stephenfin is still rechecking things to get them landed | 13:26 |
gtema | frickler, elodilles: https://review.opendev.org/q/project:openstack/keystoneauth+status:open+topic:typing has few still in gate | 13:27 |
elodilles | gtema: ACK, ping me when i can update the patch | 13:28 |
gtema | ok | 13:29 |
elodilles | gtema: note that this is just the 1st milestone release, so no worries if some patches get only to 2nd or 3rd milestone releases. (though the most we release early is the best) | 13:30 |
gtema | we explicitly wanted to get typing changes as early as possible to ensure they do not break consumers | 13:30 |
elodilles | +1 | 13:35 |
elodilles | from release perspective i fully support the idea o:) | 13:36 |
opendevreview | Elod Illes proposed openstack/releases master: Release oslo.messaging for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934615 | 13:54 |
opendevreview | Elod Illes proposed openstack/releases master: Release python-aodhclient for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934625 | 14:06 |
opendevreview | Elod Illes proposed openstack/releases master: Release mistral-extra for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934601 | 14:27 |
opendevreview | Elod Illes proposed openstack/releases master: Release keystonemiddleware for Epoxy-1 milestone https://review.opendev.org/c/openstack/releases/+/934600 | 14:42 |
elodilles | damani[m]: ah, i've found another patch that would be awesome if you could review: https://review.opendev.org/c/openstack/releases/+/934465 | 14:51 |
fungi | today's oslo releases triggered a slew of deprecation notifications to our owner account address, stating that in the future pypi will start rejecting sdist uploads where the project name is not pep 345 normalized (the "." should be replaced with "_") per pep 625: https://peps.python.org/pep-0625/#specification | 14:54 |
fungi | i suspect the same goes for the wheels, since their distribution names are similarly non-normal | 14:55 |
fungi | the notifications don't mention a sunset date, so there's probably ample time to tackle it | 14:56 |
elodilles | oh :/ thanks for the heads up fungi . so that means we have to rename all the oslo deliverables? O.o | 15:01 |
fungi | the distribution name rules are documented at https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode | 15:03 |
fungi | i don't think we need to rename anything in metadata necessarily, just need to make sure that the distribution name as encoded in sdist (and wheel) fulenames uses _ instead of . | 15:04 |
fungi | s/fulenames/filenames/ | 15:04 |
elodilles | ah, i see | 15:06 |
fungi | an example of one of the e-mails they sent: https://paste.opendev.org/show/biqcqlH7ycdWaQYyCnJH/ | 15:07 |
elodilles | ACK, thanks o/ | 15:09 |
clarkb | fungi: idea! maybe twine should have an option to rename the files for you | 15:38 |
clarkb | of course that requires upstreaming features to twine but I could see how that would be generally useful outside of openstack too | 15:39 |
noonedeadpunk | elodilles: do you know how files like this getting generated for the new cycle? https://opendev.org/openstack/releases/src/branch/master/deliverables/epoxy/openstack-ansible-roles.yaml | 17:06 |
noonedeadpunk | as I'd really love to fix some things, as it's always super outdated content out there | 17:06 |
clarkb | I'm guessing it comes out of reference/projects.yaml | 17:11 |
clarkb | sorry openstack/goverance/reference/projects.yaml | 17:11 |
noonedeadpunk | I doubt it is. There's no os_searchlight there at least: https://opendev.org/openstack/governance/src/branch/master/reference/projects.yaml#L1636-L1697 | 17:13 |
noonedeadpunk | or os_zaqar | 17:14 |
noonedeadpunk | and then there's a ansible-role-uwsgi and ansible-role-pki in governance but not in releases | 17:14 |
noonedeadpunk | there're quite some differences between these 2 lists | 17:14 |
frickler | I think it is mostly just copied from the previous cycle | 17:33 |
frickler | that's also what the commit message says | 17:33 |
noonedeadpunk | so it's just because release is trailing, so whenever new one is created, old one is not updated yet? | 17:37 |
frickler | release-team: please check https://review.opendev.org/c/openstack/releases/+/934416 needed to fix api-ref jobs | 18:50 |
opendevreview | Merged openstack/releases master: Release os-api-ref fix https://review.opendev.org/c/openstack/releases/+/934416 | 19:28 |
fungi | os-api-ref release resulted in a similar warning from pypi, wants the filename to use os_api_ref now | 19:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!