| *** ykarel__ is now known as ykarel | 04:46 | |
| opendevreview | Merged openstack/releases master: Tag governance 0.21.0 for API changes https://review.opendev.org/c/openstack/releases/+/990482 | 09:28 |
|---|---|---|
| frickler | iirc last time we had a similar issue, fungi found something wrong with our release? or is this just pypi being borekd? HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/ | 10:03 |
| elodilles | frickler: you mean the release job failure? https://zuul.opendev.org/t/openstack/build/2ccb441c9f0543cc9ca4c38f7e9c1248 | 10:36 |
| elodilles | yes, as far as i remember there were something wrong in the pyproject.toml | 10:36 |
| elodilles | some typo | 10:37 |
| elodilles | but then a pyproject.toml validator was introduced as i remember | 10:37 |
| elodilles | or is the patch still waiting for merge? :-o | 10:37 |
| elodilles | though validate-pyproject doesn't show any issue with governance's pyproject.toml | 10:39 |
| elodilles | hmm | 10:39 |
| elodilles | AI says that the issue is the "Private :: Do Not Upload" classifier. i don't know if that is true | 10:49 |
| elodilles | that is odd that the validator didn't say anything about this | 10:49 |
| elodilles | stephenfin: any idea? or is it really the mentioned classifier? ^^^ | 10:53 |
| frickler | well if pyproject.toml really says "Do Not Upload", then why do we try that? seems very reasonable to me from pypi to complain | 10:54 |
| frickler | so yes, this was introduced in https://review.opendev.org/c/openstack/governance/+/989151 without any explanation. previous tags did get uploaded https://pypi.org/project/openstack-governance/#history | 10:57 |
| frickler | maybe this discussion should move to the tc channel, then | 10:57 |
| elodilles | it makes sense that that is the root cause, but i'm no pyproject.toml expert o:) | 11:02 |
| elodilles | yes, this can be continued on tc channel, though i guess it's stephenfin who'll have the final word on this o:) | 11:02 |
| frickler | yes, would be good to hear the reasoning for that, since I don't see any matching statement in the deleted setup.cfg | 11:06 |
| fungi | sounds like a corner case. i wouldn't expect `validate-pyproject` to consider that necessarily *invalid* content for a pyproject.toml file, though i understand why warehouse does. maybe `twine --check` would be the better place to catch that? | 12:42 |
| elodilles | or a warning in verbose output of validate-pyproject. o:) | 12:43 |
| stephenfin | elodilles: oh, I may have borked that /o\ | 12:51 |
| stephenfin | I added that classifier on the assumption that we shouldn't push that library to PyPI but I think we actually *do* want to do that | 12:51 |
| elodilles | i see. then if you also say that it is the cause of the upload "error" then it should be removed and we can try another release, right? | 12:53 |
| stephenfin | Yes, I think that's the best course of action | 12:54 |
| stephenfin | Apologies for the misunderstanding /o\ | 12:54 |
| elodilles | cool :) then let's do that | 12:55 |
| elodilles | no problem, the important thing is that now we know a way forward o:) | 12:55 |
| fungi | i suppose it's also a specific enough case that we could introduce a check of our own in the job to make sure that string doesn't appear in the metadata | 13:01 |
| fungi | if we expect this to come up often | 13:01 |
| fungi | a clearer error in the upload api response would have been great though | 13:01 |
| stephenfin | I'd imagine that will never happen again | 13:01 |
| elodilles | fungi: yes, a better explanation instead of a HTTP 400: Bad Request would be better :/ | 13:02 |
| fungi | with people using llms to write everything these days, i don't say "never" any more | 13:02 |
| elodilles | but i agree with stephenfin that this likely won't happen in the future, as Stephen added it intentionally as he said | 13:03 |
| fungi | some llm has already been trained that the classifier is useful to include because it saw that in the openstack/governance repo at one point | 13:03 |
| fungi | but yeah, the risk is low, and we know to look for it if it does recur | 13:04 |
| elodilles | :) | 13:04 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!