*** dims has quit IRC | 00:21 | |
*** jgriffit1 has joined #openstack-relmgr-office | 01:00 | |
*** jgriffit1 has quit IRC | 01:10 | |
*** jgriffit1 has joined #openstack-relmgr-office | 01:10 | |
*** jgriffit1 has quit IRC | 01:26 | |
*** bdr7 has joined #openstack-relmgr-office | 01:27 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 01:49 | |
sigmavirus24 | dhellmann: so I have you to blame? =P | 01:54 |
---|---|---|
dhellmann | sigmavirus24: for? | 01:55 |
sigmavirus24 | cinderclient bug mail | 01:55 |
sigmavirus24 | I'm only kidding | 01:55 |
dhellmann | sigmavirus24: nah, blame the cinder team for not marking their bugs "fixed released" :-) | 01:56 |
*** sigmavirus24 is now known as sigmavirus24_awa | 02:17 | |
*** bdr7 has quit IRC | 03:06 | |
*** bdr7 has joined #openstack-relmgr-office | 03:07 | |
*** bdr7 has quit IRC | 03:30 | |
*** dims_ has joined #openstack-relmgr-office | 03:46 | |
*** dims_ has joined #openstack-relmgr-office | 03:46 | |
*** dims_ has quit IRC | 04:14 | |
*** dims has joined #openstack-relmgr-office | 04:15 | |
*** dims has quit IRC | 04:20 | |
*** dims has joined #openstack-relmgr-office | 05:01 | |
*** dims_ has joined #openstack-relmgr-office | 05:02 | |
*** dims has quit IRC | 05:06 | |
*** dims_ has quit IRC | 05:14 | |
*** ig0r_ has joined #openstack-relmgr-office | 05:51 | |
*** ig0r__ has quit IRC | 05:55 | |
*** dims has joined #openstack-relmgr-office | 06:15 | |
*** dims has quit IRC | 06:20 | |
ttx | lifeless: for something slightly more solid than an etherpad, we have wiki pages under https://wiki.openstack.org/wiki/Release_Cycle_Management, like https://wiki.openstack.org/wiki/Release_Cycle_Management/Milestone_Checklist | 07:31 |
*** dims has joined #openstack-relmgr-office | 08:16 | |
*** dims has quit IRC | 08:21 | |
ttx | dhellmann: | 09:58 |
ttx | Neutron stadium ACL patch https://review.openstack.org/#/c/198749/ was merged by AJaeger and sdague yesterday despite your -1 on it | 09:59 |
ttx | dhellmann: did you hear clarification from mestery on their release model ? | 09:59 |
sdague | ttx: oh, I didn't realize dhellman was -1 on a previous version of that patch | 10:05 |
sdague | so there was no active -1 when I saw it | 10:06 |
ttx | sdague: also known as patchset-washing | 10:06 |
sdague | yeh, ok, sorry, I assume good faith on things like those | 10:06 |
sdague | you want it reverted? | 10:06 |
ttx | I guess mestery should have more clearly wipped it while we were clarifying what he wants | 10:07 |
ttx | Well, it doesn't hurt US to have extra rights we won't exercise | 10:07 |
sdague | ok | 10:07 |
ttx | so I would wait until we get clarification from him | 10:07 |
sdague | ok, that's fine | 10:07 |
ttx | they /might/ adopt a library-like model and we /might/ agree to support them | 10:08 |
ttx | it's just one of several possible outcomes | 10:08 |
sdague | gotcha | 10:09 |
ttx | I just want to make it clear that the ACL doesn't drive what we end up managing :) | 10:10 |
ttx | it's the other way around. | 10:10 |
sdague | yeh, I think that's fair | 10:11 |
*** isviridov_away is now known as isviridov | 10:11 | |
*** dims has joined #openstack-relmgr-office | 10:17 | |
*** dims has quit IRC | 10:21 | |
*** isviridov is now known as isviridov_away | 12:17 | |
*** dims has joined #openstack-relmgr-office | 12:17 | |
*** dims has quit IRC | 12:22 | |
*** dims has joined #openstack-relmgr-office | 12:40 | |
*** pserebryakov has joined #openstack-relmgr-office | 12:50 | |
mestery | ttx: We're going with the option where we manage the releases ourselves, and those patches merged so we're good | 13:09 |
mestery | thanks sdague for the merges there! :) | 13:09 |
ttx | mestery: oh, that was what the latest patchset did ? | 13:10 |
ttx | I missed that switch | 13:11 |
ttx | in which case yes we are good | 13:11 |
mestery | yes, we're good | 13:14 |
mestery | And I switched it, including commit message :) | 13:14 |
ttx | sure, I just didn't expect a complete reverse in a patchset ;) | 13:15 |
mestery | The ML thread resulted in rather quick consensus, which was nice | 13:26 |
ttx | dhellmann: I think we have enough material on the CFP etherpad to justify a submission. I pushed a possible outline; once the story there sounds interesting we can turn it into teaser prose for submission | 13:42 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:47 | |
mestery | ttx: closed the loop on https://review.openstack.org/#/c/198749/ with some comments to our discussion here | 13:56 |
ttx | ack, thx | 13:57 |
*** pserebryakov has quit IRC | 14:00 | |
*** bdr7 has joined #openstack-relmgr-office | 14:34 | |
*** dims has quit IRC | 14:45 | |
*** bdr7 has quit IRC | 14:48 | |
*** bdr7 has joined #openstack-relmgr-office | 14:48 | |
*** dims has joined #openstack-relmgr-office | 14:50 | |
*** bswartz has joined #openstack-relmgr-office | 14:54 | |
*** bdr7 has quit IRC | 14:55 | |
bswartz | Can someone help me understand the right way to keep the version numbers of a project in sync? | 14:56 |
*** bdr7 has joined #openstack-relmgr-office | 14:56 | |
*** bdr7 has quit IRC | 14:56 | |
bswartz | does the setup.cfg version need to match the git tag? | 14:56 |
bswartz | and if so, in what order to I update them? | 14:56 |
bswartz | ttx, dhellmann ^ | 14:57 |
bswartz | I'm asking in particular about openstack/manila-ui, which needs to have a 1.0.1 version cut from stable/kilo | 14:57 |
*** dims has quit IRC | 15:30 | |
*** dims has joined #openstack-relmgr-office | 15:32 | |
*** dims has joined #openstack-relmgr-office | 15:33 | |
*** bdr768 has joined #openstack-relmgr-office | 15:35 | |
*** bdr768 is now known as jgriffith | 15:35 | |
*** dims_ has joined #openstack-relmgr-office | 16:05 | |
ttx | bswartz: sorry, was on a call | 16:08 |
*** dims has quit IRC | 16:09 | |
ttx | bswartz: you don't need to update setup.cfg if you're doing semver postversioning. | 16:09 |
ttx | Basically things can be versioned in two ways | 16:09 |
ttx | You can go toward a target version, like we did with 2015.1 | 16:09 |
ttx | in which case commits leading to that are numbered like 2015.1.0.0b1 | 16:10 |
ttx | betas, rcs etc | 16:10 |
ttx | That's called preversioning, and needs setup.cfg to tell it which version is the target one | 16:10 |
ttx | The other way is to move away from the last version, like we do for libraries | 16:10 |
ttx | so commits after a given version are numbered like 1.2.0.0post21 | 16:11 |
ttx | That's called postversioning, and you don't need setup.cfg to indicate anything | 16:11 |
ttx | libraries are semver, so they use postversioning. | 16:12 |
ttx | for manila-ui, I would remove 1.1.0 from setup.cfg on all branches. And tag 1.0.1 on kilo | 16:13 |
ttx | (and also consider tagging 1.1.0 on master. release early & often and all) | 16:15 |
*** jgriffith has quit IRC | 16:42 | |
bswartz | ttx: https://review.openstack.org/#/c/200166/ <-- this is what I tried and I don't understand why it failed | 17:02 |
bswartz | from reading your comments it seems like I did the wrong thing | 17:03 |
bswartz | this is the change I'm trying to fix: https://review.openstack.org/#/c/200130/ | 17:03 |
bswartz | it failed with a semver error | 17:03 |
bswartz | if it's just a matter of pushing some more tags I'm fine with that | 17:04 |
bswartz | I think manila-ui is postversioned though so this shouldn't be necessary | 17:05 |
* bswartz thinks he needs to read more about semver | 17:05 | |
bswartz | bbias I need to switch to wireless to go to a meeting | 17:06 |
*** bswartz has quit IRC | 17:06 | |
*** bswartz has joined #openstack-relmgr-office | 17:08 | |
bswartz | back | 17:08 |
*** dims_ has quit IRC | 17:35 | |
*** dims has joined #openstack-relmgr-office | 17:37 | |
dhellmann | ttx: I had one comment, but otherwise I like the outline. I took a stab at a summary and title, but both need work | 17:43 |
dhellmann | bswartz: I'm here now, sorry for the delay. Are you still stuck? | 17:45 |
bswartz | dhellmann: if you can take a look at https://review.openstack.org/#/c/200130/ and tell me what I did wrong w.r.t. pbr versioning | 17:52 |
bswartz | the setup.cfg for that branch has a version of 1.0.0 | 17:52 |
bswartz | we want to release 1.0.1 after this patch goes in | 17:52 |
bswartz | so when is the right time to update the version? | 17:52 |
*** bdr768 has joined #openstack-relmgr-office | 17:54 | |
dhellmann | bswartz: let me look at your branch... | 17:56 |
dhellmann | bswartz: ok, the issue is that you're mixing tags and the setup.cfg. Let me submit a patch. | 17:58 |
bswartz | dhellmann: I like the idea of post-versioning and treating this plugin as a library | 17:59 |
bswartz | so if that is the goal, what are we doing wrong? | 17:59 |
dhellmann | bswartz: https://review.openstack.org/200193 should fix it, and the dependent patch will make it easier to submit things to the branch properly | 18:02 |
dhellmann | bswartz: for post-versioning, you don't include the version in setup.cfg at all | 18:02 |
bswartz | dhellmann: ah that looks easy enough | 18:02 |
bswartz | thanks | 18:02 |
bswartz | we will need to tag master first, and then do a similar change there, correct? | 18:03 |
dhellmann | pbr will produce versions like 1.0.0.0devN for commits after 1.0.0 and then when you tag again, it starts using the version from that tag | 18:03 |
*** bdr768 is now known as jgriffith | 18:03 | |
dhellmann | bswartz: yes, you should tag first | 18:03 |
*** jgriffith is now known as Guest77747 | 18:04 | |
bswartz | dhellmann: so then after stable/liberty branches, we will want to tag master as 1.2.0 immediately? | 18:06 |
dhellmann | bswartz: only if you want to release from master right away | 18:06 |
*** Guest77747 has quit IRC | 18:07 | |
*** bdr768 has joined #openstack-relmgr-office | 18:08 | |
bswartz | oh okay | 18:08 |
bswartz | well in that case what is the danger of NOT tagging current master as 1.1.0 before switching the master branch to post versioning? | 18:08 |
dhellmann | bswartz: it looks like I'll have to squash my commits together to make them pass, but there's also some other issue with the py27 test job and a bad import | 18:09 |
dhellmann | bswartz: anyone deploying from master would suddenly see the version number drop | 18:09 |
*** bdr768 has quit IRC | 18:09 | |
bswartz | oh you noticed the missing gitreview file | 18:10 |
bswartz | that was something I was planning to fix but it wasn't urgent | 18:10 |
*** jgriffit1 has joined #openstack-relmgr-office | 18:10 | |
dhellmann | bswartz: see https://review.openstack.org/#/c/200192/ | 18:11 |
*** jgriffit1 is now known as jdg | 18:13 | |
bswartz | dhellmann: still a problem with imports | 18:21 |
bswartz | we can probably fix those problems if you don't want to spend the time | 18:21 |
dhellmann | bswartz: yeah, I don't know what's going on there. Is manila-ui importing part of the incubator synced into that library? | 18:21 |
*** dims has quit IRC | 18:21 | |
dhellmann | bswartz: sure, feel free to take over my patch and fix it up as you need to get things working. A requirements cap might do it, for example. | 18:22 |
*** jdg is now known as jgriffith | 18:24 | |
*** bswartz has quit IRC | 18:24 | |
*** jgriffith is now known as Guest43643 | 18:25 | |
*** Guest43643 is now known as jgriffith | 18:27 | |
*** dims has joined #openstack-relmgr-office | 19:10 | |
*** jgriffith has quit IRC | 19:10 | |
*** jgriffith has joined #openstack-relmgr-office | 19:11 | |
*** dims has quit IRC | 21:05 | |
*** dims has joined #openstack-relmgr-office | 21:07 | |
*** sigmavirus24 is now known as emacsraptor | 21:10 | |
*** emacsraptor is now known as sigmavirus24 | 21:10 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 21:59 | |
*** dims has quit IRC | 22:03 | |
*** dims has joined #openstack-relmgr-office | 22:03 | |
*** jgriffith is now known as Guest85831 | 22:06 | |
*** openstack has joined #openstack-relmgr-office | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!