prometheanfire | tonyb: can you +w this https://review.openstack.org/342344 | 00:04 |
---|---|---|
prometheanfire | tonyb: it's blocking everything in requirements | 00:04 |
*** coolsvap has joined #openstack-requirements | 00:28 | |
coolsvap | prometheanfire, hey | 00:44 |
prometheanfire | coolsvap: thanks :D | 00:44 |
coolsvap | thanks for? | 00:45 |
coolsvap | prometheanfire, you could have acked https://review.openstack.org/#/c/342344/ | 00:46 |
patchbot | coolsvap: patch 342344 - requirements - Remove mistral-extra from projects list | 00:46 |
prometheanfire | coolsvap: I did... | 00:48 |
coolsvap | prometheanfire, W+ i meant | 00:48 |
prometheanfire | I was going to +W it if no one responded by the time I slept | 00:48 |
coolsvap | oh ok | 00:48 |
prometheanfire | :D | 00:48 |
prometheanfire | I'd rather do it right if possible | 00:49 |
coolsvap | yes | 00:49 |
coolsvap | we need better handling of projects removing requirements jobs | 00:50 |
prometheanfire | ya, it's annoying, odyssey4me was saying that we doc the need to order the removal, but project-config doesn't | 00:51 |
prometheanfire | well addition/removal | 00:51 |
prometheanfire | not that I think that'd help much, at least at first | 00:51 |
prometheanfire | it's just not something people think about much | 00:52 |
coolsvap | since we have voting gate on it is | 00:53 |
prometheanfire | cross project gates could be nice :P | 00:53 |
coolsvap | haha yes but still we might need some intelligence in our gates to handle this kinda situation | 00:54 |
prometheanfire | well, the error was fairly obvious, so the bot that says this is a known bug could help maybe | 00:55 |
coolsvap | on the other hand i think it is better as it is, just we need better watch and documentation in project-config | 00:57 |
prometheanfire | ya | 01:14 |
coolsvap | prometheanfire, i think we are good for https://review.openstack.org/341323/ today's results look good | 01:21 |
coolsvap | still waiting for couple of projects jenkins jobs | 01:21 |
prometheanfire | ya, was thinking so | 01:24 |
prometheanfire | have been watching | 01:25 |
openstackgerrit | Merged openstack/requirements: Remove mistral-extra from projects list https://review.openstack.org/342344 | 01:33 |
coolsvap | nova is still not happy | 01:53 |
coolsvap | prometheanfire, https://review.openstack.org/#/c/341323/ | 02:38 |
patchbot | coolsvap: patch 341323 - requirements - Updated from generate-constraints | 02:38 |
coolsvap | and https://review.openstack.org/#/c/341509/ | 02:39 |
patchbot | coolsvap: patch 341509 - requirements - Add all openstack-ansible repositories to projects... | 02:39 |
prometheanfire | coolsvap: nova not happy? | 02:41 |
prometheanfire | so why +2? | 02:41 |
coolsvap | prometheanfire, nova failures do not entirely seem related to u-c | 02:47 |
coolsvap | let me confirm have you seen logs http://logs.openstack.org/45/303345/155/check/gate-nova-python27-db/70e814a/console.html | 02:48 |
coolsvap | similar tests have been passed in glance & designate | 02:54 |
tonyb | Looks like oslo.context broke nova to me. Tracking back the change to see if it was intentional | 03:00 |
prometheanfire | tonyb: oh, nice | 03:02 |
prometheanfire | iirc context broke things recently | 03:02 |
tonyb | Ie48fedb8092e33e9645a37ea3fe44b88d34ad3b8 broke it | 03:02 |
tonyb | bnow to work out how to handle that ... | 03:02 |
prometheanfire | which review is that? | 03:03 |
coolsvap | in trove | 03:03 |
prometheanfire | ah | 03:03 |
tonyb | that Change ID is in oslo.context | 03:04 |
coolsvap | tonyb, https://review.openstack.org/#/c/341543/ | 03:05 |
patchbot | coolsvap: patch 341543 - requirements - update constraint for oslo.context to new release ... | 03:05 |
prometheanfire | ya, was reading that | 03:06 |
tonyb | right. | 03:06 |
coolsvap | so there was a request expedite since trove was broken | 03:06 |
tonyb | so we can't expidite it | 03:06 |
coolsvap | hmm yes | 03:06 |
prometheanfire | ya, unreviewed and rechecked | 03:06 |
coolsvap | prometheanfire, recheck will not provide any different update afaics | 03:07 |
prometheanfire | I thought it was failing because of the projects thing | 03:08 |
coolsvap | prometheanfire, this is failing https://review.openstack.org/#/c/303345/ | 03:09 |
patchbot | coolsvap: patch 303345 - nova - [WIP] Testing latest u-c | 03:09 |
prometheanfire | I get that | 03:10 |
tonyb | So we need to find and example of the trove failure to verify that u-c will fix them | 03:11 |
tonyb | can eitehr of you look for that? | 03:11 |
tonyb | I'll try to work out how to handle this in nova | 03:11 |
prometheanfire | ok | 03:12 |
coolsvap | sure | 03:12 |
tonyb | This will probably come up if other projects are doign very careful checking of the context | 03:12 |
tonyb | Also https://review.openstack.org/#/c/335549/7 "#winner of bext commit message ever" | 03:15 |
patchbot | tonyb: patch 335549 - nova - DO NOT MERGE - ROOAAAAAARRRR ! Testing live migrat... | 03:15 |
prometheanfire | lol | 03:15 |
prometheanfire | https://review.openstack.org/342509 should be failing soon in trove | 03:18 |
prometheanfire | and is a small change, so should work as a good test for us | 03:18 |
coolsvap | trove failures are mostly due to versioning | 03:19 |
coolsvap | http://logs.openstack.org/09/342509/1/check/gate-trove-python34-db/643e2f8/console.html#_2016-07-15_02_07_21_383068 | 03:19 |
tonyb | coolsvap: Are you sure those are releasted to the context change? | 03:22 |
prometheanfire | 2016-07-15 02:07:22.220766 | oslo.context==2.5.0 # git sha 0617412 | 03:22 |
prometheanfire | context change is 2.6.0 I thought | 03:22 |
coolsvap | so tonyb there are couple of changes submitted in nova | 03:23 |
coolsvap | related to the oslo.context change | 03:23 |
coolsvap | https://review.openstack.org/341905 | 03:23 |
coolsvap | https://review.openstack.org/#/c/340195/ | 03:23 |
patchbot | coolsvap: patch 340195 - cinder - Use to_policy_values for enforcing policy | 03:23 |
coolsvap | prometheanfire, trove will not have 2.6.0 | 03:24 |
prometheanfire | let me get this straigt then | 03:25 |
prometheanfire | oslo.context updated, adding a value | 03:25 |
prometheanfire | this caused nova to fail | 03:25 |
prometheanfire | not sure what to do about trove, why is it failing | 03:26 |
tonyb | prometheanfire: (when using the new 2.6.0 release) | 03:26 |
prometheanfire | tonyb: trove? | 03:26 |
prometheanfire | or nova | 03:26 |
coolsvap | https://bugs.launchpad.net/neutron/+bug/1602081 | 03:26 |
openstack | Launchpad bug 1602081 in OpenStack Compute (nova) "Use oslo.context's policy dict" [Undecided,In progress] - Assigned to Jamie Lennox (jamielennox) | 03:26 |
tonyb | prometheanfire: All O knwo abotu trove is: Any chance we could expedite this change? The Trove gate is broken since we don't use upper-contraints when we build our guest image so there's now an API mismatch ... | 03:27 |
prometheanfire | ya | 03:27 |
prometheanfire | oh, I didn't see that second part | 03:27 |
prometheanfire | after 'since' | 03:27 |
prometheanfire | ok | 03:27 |
tonyb | prometheanfire: which matches the log that coolsvap posted but it lacks details to work out which version of oslo.context is the problem | 03:27 |
prometheanfire | an error on their part is not an emergency on ours | 03:28 |
prometheanfire | so, focusing on nova et all... | 03:28 |
tonyb | prometheanfire: Right but we have to balance the needs of trove, nova, oslo and keystone here | 03:28 |
prometheanfire | right | 03:28 |
coolsvap | tonyb, yes the trove failures are not sufficient to relate to oslo.context | 03:28 |
tonyb | so undertanding *excatly* what has broken in trove will help us to fix it in nova | 03:29 |
prometheanfire | tonyb: from the sounds of it, it was the introduction of the new policy value (as far as nova/neutron go) | 03:30 |
tonyb | prometheanfire: neutron? | 03:31 |
prometheanfire | sorry, the bug | 03:31 |
prometheanfire | https://bugs.launchpad.net/neutron/+bug/1602081 | 03:31 |
openstack | Launchpad bug 1602081 in OpenStack Compute (nova) "Use oslo.context's policy dict" [Undecided,In progress] - Assigned to Jamie Lennox (jamielennox) | 03:31 |
coolsvap | tonyb, the bug cross-project | 03:32 |
coolsvap | http://logs.openstack.org/36/318436/53/check/gate-glance-python34-db/4441178/console.html#_2016-07-14_10_15_15_259041 | 03:33 |
tonyb | coolsvap: okay, that bug report is a feature/bp tracker not an actual things went bad when .... bug reports | 03:33 |
prometheanfire | right, related though, tangentially | 03:33 |
tonyb | prometheanfire: Sure it describes what keystone need to do and how they'er doing it. | 03:33 |
prometheanfire | coolsvap: the result is success there | 03:35 |
coolsvap | yes | 03:35 |
prometheanfire | ok? | 03:35 |
coolsvap | but http://logs.openstack.org/45/303345/155/check/gate-nova-python27-db/70e814a/console.html#_2016-07-15_00_41_17_165451 | 03:36 |
coolsvap | it seems like a false success in glance :/ | 03:37 |
openstackgerrit | Merged openstack/requirements: Block futurist 0.15.0 https://review.openstack.org/342447 | 03:38 |
tonyb | okay so I have a hack for nova | 03:39 |
prometheanfire | coolsvap: so, it seems like what happened is that context 2.6.0 added a value that breaks things before downstream consumers could consume | 03:40 |
tonyb | coolsvap: or they're not as 'detailed' in what a context shoudl look like | 03:40 |
tonyb | prometheanfire: more or less yes | 03:40 |
prometheanfire | why is https://review.openstack.org/#/c/341905/ not good then (at least to fix nova) | 03:40 |
patchbot | prometheanfire: patch 341905 - nova - Use to_policy_values for policy credentials | 03:40 |
prometheanfire | if we don't want to wait for projects to fix themselves we can mask (temp) | 03:40 |
tonyb | prometheanfire: becuse that's workin on polcu from context not the context itself | 03:41 |
prometheanfire | so it requires the new context to work? | 03:41 |
prometheanfire | https://review.openstack.org/#/c/341895/ too | 03:42 |
patchbot | prometheanfire: patch 341895 - nova - Pass kwargs through to base context | 03:42 |
tonyb | so we need to a) idetify projects that break with 2.6.0 ; b) add shims to them to work with 2.5.0 and 2.6.0 ; c) merge the 2.6.0 u-c change ; d) bump the minium in g-r to 2.6.0 and e) remove items from 'a' | 03:42 |
tonyb | prometheanfire: I'll tidy up my hack and publish ASAP | 03:44 |
tonyb | we still need to grok the trove breakage but that's less critical | 03:44 |
prometheanfire | we can also a) idetify projects that break with 2.6.0; b) mask 2.6.0; c) add shims to them to work with 2.5.0 and 2.6.0; d) unmask 2.6.0 and bump gr/uc | 03:44 |
tonyb | prometheanfire: Ummm what does "mask 2.6.0" mean? | 03:46 |
openstackgerrit | Merged openstack/requirements: Add all openstack-ansible repositories to projects.txt https://review.openstack.org/341509 | 03:46 |
prometheanfire | tonyb: sorry, gentoo speak | 03:47 |
prometheanfire | add !=2.6.0 to oslo.context in gr | 03:47 |
tonyb | prometheanfire: Sure we can do that but my gut tells me it wont work | 03:49 |
prometheanfire | the only reason I advocate for it is that it will unbreak things quicker | 03:50 |
prometheanfire | I haven't seen any ml activity about the oslo.context breakage, should we start one asking? | 03:50 |
prometheanfire | I'm not sure about your gut :P | 03:50 |
* coolsvap brb | 03:52 | |
tonyb | prometheanfire: We shoudl probably say something on the m/l I'll do it after I finish this nova patch | 03:54 |
tonyb | prometheanfire: I'll also ponder the masking approach try to undertsand what my gut is saying ... it could be I need lunch | 03:55 |
prometheanfire | it's a bit late here, brushing teeth now :P | 03:56 |
prometheanfire | it's why I'm a bit thick atm | 03:56 |
tonyb | prometheanfire: rest well | 04:07 |
coolsvap | prometheanfire, see you tomorrow | 04:08 |
coolsvap | tonyb, yes let us know once you do | 04:08 |
prometheanfire | lol | 04:08 |
prometheanfire | I'm not dead yet | 04:08 |
coolsvap | prometheanfire, i was away | 04:09 |
coolsvap | :) | 04:09 |
prometheanfire | :P | 04:09 |
prometheanfire | well, nn now :P | 04:17 |
prometheanfire | tonyb: I'll check for the email in the morn | 04:17 |
tonyb | prometheanfire: :) | 04:18 |
coolsvap | tonyb, i think there is a series of ROOAAAAAARRRR commits in nova | 04:20 |
coolsvap | all are different | 04:21 |
tonyb | coolsvap: Yeah I see that but the one with the T-Rex as the commit message spoke to me | 04:21 |
coolsvap | :) | 04:21 |
*** coolsvap_ has joined #openstack-requirements | 04:42 | |
*** coolsvap has quit IRC | 04:48 | |
*** coolsvap_ has quit IRC | 04:48 | |
*** coolsvap_ has joined #openstack-requirements | 04:49 | |
*** coolsvap_ is now known as coolsvap | 04:49 | |
openstackgerrit | Tony Breeds proposed openstack/requirements: Bump olso.context minimum to 2.6.0 https://review.openstack.org/342603 | 04:59 |
*** coolsvap has quit IRC | 05:42 | |
*** coolsvap has joined #openstack-requirements | 05:42 | |
*** openstackgerrit has quit IRC | 06:33 | |
*** openstackgerrit has joined #openstack-requirements | 06:33 | |
coolsvap | tonyb, https://review.openstack.org/#/c/332409/ | 06:38 |
patchbot | coolsvap: patch 332409 - requirements (stable/mitaka) - update constraint for python-glanceclient to new r... | 06:38 |
tonyb | coolsvap: Hmm I wonder why that isn't in my review queue? | 06:39 |
coolsvap | tonyb, #openstack-nova | 06:41 |
*** coolsvap_ has joined #openstack-requirements | 06:51 | |
*** coolsvap_ has quit IRC | 06:52 | |
*** coolsvap has quit IRC | 07:31 | |
*** coolsvap has joined #openstack-requirements | 07:31 | |
*** coolsvap has quit IRC | 07:37 | |
*** coolsvap has joined #openstack-requirements | 07:37 | |
openstackgerrit | Vipin Balachandran proposed openstack/requirements: Bump oslo.vmware to 2.11.0 https://review.openstack.org/342653 | 07:45 |
openstackgerrit | Renat Akhmerov proposed openstack/requirements: Add "mistral-lib" to the list of projects https://review.openstack.org/342678 | 08:47 |
*** rcarrillocruz has joined #openstack-requirements | 08:58 | |
rcarrillocruz | heya folks | 08:58 |
rcarrillocruz | any core mind checking https://review.openstack.org/#/c/341542/ to approve? | 08:59 |
patchbot | rcarrillocruz: patch 341542 - requirements - update constraint for oslo.config to new release 3... | 08:59 |
rcarrillocruz | i'm seeing packaging issues on oslo-config 3.12: | 08:59 |
rcarrillocruz | http://paste.openstack.org/show/532918/ | 08:59 |
coolsvap | rcarrillocruz, just a min checking the paste provided | 09:01 |
rcarrillocruz | ++ | 09:01 |
rcarrillocruz | that nova-api log, corresponding to failures on tests like: | 09:02 |
coolsvap | rcarrillocruz, have you tested with 3.13 | 09:02 |
rcarrillocruz | http://logs.openstack.org/23/322823/10/check/gate-ansible-role-cloud-launcher-dsvm-ansible-func-centos-7/e00cf86/console.html | 09:02 |
rcarrillocruz | i've rechecked with a depends-on the requirements bump | 09:03 |
rcarrillocruz | it's ongoing | 09:03 |
rcarrillocruz | https://review.openstack.org/342099 | 09:03 |
rcarrillocruz | on check running tests now... | 09:03 |
coolsvap | rcarrillocruz, would you mind if i wait for another 20-25 mins to verify? | 09:05 |
rcarrillocruz | not at all, thx | 09:05 |
coolsvap | rcarrillocruz, i will ack as soon as I verify | 09:05 |
rcarrillocruz | coolsvap: the test got past the oslo-config issue, but now fails with oslo-utils :/ | 09:26 |
rcarrillocruz | http://paste.openstack.org/show/533028/ | 09:26 |
rcarrillocruz | i just added https://review.openstack.org/#/c/342155/1 to the dependency chain of my change | 09:27 |
patchbot | rcarrillocruz: patch 342155 - requirements - update constraint for oslo.utils to new release 3.... | 09:27 |
rcarrillocruz | yep | 09:27 |
coolsvap | rcarrillocruz, can you add https://review.openstack.org/#/c/341323/ as dependency | 09:28 |
patchbot | coolsvap: patch 341323 - requirements - Updated from generate-constraints | 09:28 |
coolsvap | ? | 09:28 |
rcarrillocruz | yep, already did and pushed to the gates | 09:29 |
coolsvap | rcarrillocruz, the patch i mentioned has all the u-c updates but lets see the resutls with only oslo.utils | 09:32 |
rcarrillocruz | ++ | 09:32 |
rcarrillocruz | if it fails with the individual deps, i'll push a new patchset with 341323 | 09:34 |
openstackgerrit | Balazs Gibizer proposed openstack/requirements: Bump oslo versioned object version to latest https://review.openstack.org/342704 | 09:35 |
coolsvap | tonyb, still around? | 09:38 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/341323 | 09:41 |
rcarrillocruz | coolsvap: so yeah, now complaining about oslo-i18n | 09:54 |
rcarrillocruz | i'll put as dep the big change you pasted earlier | 09:54 |
rcarrillocruz | sec | 09:54 |
rcarrillocruz | coolsvap: on your latest patchset, oslo-utils is not on 3.16 | 09:55 |
rcarrillocruz | you want to amend? | 09:55 |
coolsvap | rcarrillocruz, wait | 09:56 |
coolsvap | rcarrillocruz, can you add two dependent changes | 09:56 |
rcarrillocruz | which ones | 09:56 |
coolsvap | i just amended it to exclude oslo.context | 09:56 |
coolsvap | 341323 and 342155 | 09:57 |
rcarrillocruz | k | 09:57 |
coolsvap | i am checking for nova failures | 09:57 |
rcarrillocruz | pushed for tests... | 09:58 |
coolsvap | rcarrillocruz, thanks | 09:59 |
rcarrillocruz | oh | 10:01 |
rcarrillocruz | it seems i can't | 10:01 |
rcarrillocruz | cos the deps are unmergeable | 10:01 |
rcarrillocruz | This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. | 10:01 |
rcarrillocruz | ? | 10:01 |
rcarrillocruz | coolsvap: ^ | 10:02 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/341323 | 10:04 |
coolsvap | rcarrillocruz, alright let me update oslo.utils | 10:05 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/341323 | 10:06 |
coolsvap | rcarrillocruz, ^^ | 10:06 |
rcarrillocruz | thx, now it's running tests | 10:07 |
coolsvap | prometheanfire, ping once you are online | 10:23 |
coolsvap | toabctl, please do not approve any of the u-c changes | 10:27 |
toabctl | coolsvap, did I? | 10:27 |
coolsvap | toabctl, just a side note | 10:28 |
toabctl | coolsvap, ok. thanks | 10:28 |
coolsvap | i just saw a +2 so wanted to tell you | 10:28 |
toabctl | coolsvap, and why not? | 10:28 |
coolsvap | there is an issue due to oslo.context | 10:28 |
toabctl | ok. good to know. | 10:28 |
coolsvap | debugging that | 10:28 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/requirements: Bump manilaclient version https://review.openstack.org/342727 | 10:37 |
rcarrillocruz | coolsvap: getting failures now due to pytz | 10:45 |
rcarrillocruz | IOError: [Errno 2] No such file or directory: '/usr/local/lib/python2.7/dist-packages/pytz-2016.6.dist-info/METADATA' | 10:45 |
rcarrillocruz | per pypi, there's pytz-2016.6.1 | 10:45 |
coolsvap | rcarrillocruz, you will need to submit change for g-r and u-c | 10:47 |
coolsvap | uc is at pytz===2016.4 | 10:47 |
coolsvap | it might get updated in next u-c update | 10:48 |
rcarrillocruz | let me see | 10:48 |
coolsvap | but g-r is at pytz>=2013.6 | 10:48 |
coolsvap | https://github.com/openstack/requirements/blob/master/global-requirements.txt#L215 | 10:48 |
openstackgerrit | Ricardo Carrillo Cruz proposed openstack/requirements: Bump pytz version to 2016.6.1 on g-r and u-r https://review.openstack.org/342733 | 10:51 |
rcarrillocruz | coolsvap: ^ let me know it looks good | 10:51 |
rcarrillocruz | not sure if i should have two different changes | 10:51 |
coolsvap | rcarrillocruz, one change is good | 10:52 |
rcarrillocruz | ++ | 10:52 |
coolsvap | because it validates g-r & u-c values | 10:52 |
coolsvap | dims, prometheanfire have a look at https://review.openstack.org/#/c/341323/ whenever you are online, I updated it to exclude oslo.context, futurist and included oslo.utils which was breaking for rcarrillocruz | 11:25 |
patchbot | coolsvap: patch 341323 - requirements - Updated from generate-constraints | 11:25 |
coolsvap | we can keep the oslo.context in check till we get the updates from tonyb and jamielennox | 11:26 |
rcarrillocruz | coolsvap: change 342733 passed check tests | 11:43 |
coolsvap | rcarrillocruz, yes | 11:44 |
coolsvap | dims, thx | 11:50 |
dims | coolsvap : thank you for keeping an eye on these! | 11:56 |
rcarrillocruz | dims: could you also please check https://review.openstack.org/#/c/342733/ ? | 11:59 |
patchbot | rcarrillocruz: patch 342733 - requirements - Bump pytz version to 2016.6.1 on g-r and u-r | 11:59 |
dims | rcarrillocruz : needs some context in the commit message (why it's being updated etc) | 12:00 |
coolsvap | rcarrillocruz, sorry I missed the commit message since i already knew the context | 12:03 |
odyssey4me | hmm a question for you all | 12:12 |
odyssey4me | obviously all projects make use of pip, and therefore setuptools and sometimes wheel | 12:12 |
odyssey4me | we have all experienced issues where the latest versions of these packages break things | 12:12 |
odyssey4me | is there a reason why we do not include the versions of these in upper-constraints? | 12:13 |
coolsvap | odyssey4me, seems like a fair point to me but from what I have seen in my experience with requirements, 1] upper constraints are adoption is very less 2] various projects are not very keen on using upper-constraints for different reasons, primary being end users are likely not going to adapt | 12:19 |
odyssey4me | coolsvap we (OpenStack-Ansible) use them heavily, and many other deployers who build from source do the same - also, packagers are using them too | 12:20 |
coolsvap | internally i am not sure how many infra projects use u-c | 12:20 |
odyssey4me | whether the projects actually use them or not is really for them to decide - it gives us a known, tested upper limit - that's why we use it | 12:21 |
odyssey4me | it's equivalent to pinning, but without pinning | 12:21 |
coolsvap | odyssey4me, I am pretty much up for it, I am adding this to weekly meeting agenda | 12:21 |
coolsvap | will you be able to join for sometime next meeting? | 12:21 |
odyssey4me | anyway, so the point is that I'd like to have those packages in u-c so that we can ensure they're pinned to an upper bound for any particular requirements SHA | 12:22 |
coolsvap | Wednesdays @ 12:00 UTC | 12:22 |
odyssey4me | yes, I can make that | 12:22 |
coolsvap | cool I will add it first thing in agenda to free you up early | 12:22 |
dims | odyssey4me : because some of these tools are baked into the image built by infra folks. we can talk to lifeless and dhellmann for history... | 12:23 |
dims | and ttx of course | 12:24 |
* coolsvap back later | 12:30 | |
*** coolsvap is now known as coolsvap|afk | 12:43 | |
openstackgerrit | Merged openstack/requirements: Updated from generate-constraints https://review.openstack.org/341323 | 12:47 |
openstackgerrit | Balazs Gibizer proposed openstack/requirements: Bump oslo versioned object version to latest https://review.openstack.org/342704 | 13:29 |
prometheanfire | coolsvap|afk: ? | 14:08 |
prometheanfire | odyssey4me: submit a review :P | 14:10 |
odyssey4me | prometheanfire I'll be at the meeting to discuss it before I put that effort in. | 14:12 |
prometheanfire | odyssey4me: ok | 14:14 |
prometheanfire | odyssey4me: I do agree that it seems like a good idea though | 14:15 |
-openstackstatus- NOTICE: Gerrit is restarting to correct memory/performance issues. | 14:18 | |
prometheanfire | coolsvap|afk: tonyb I did notice that the email didn't go out | 14:35 |
dhellmann | odyssey4me , dims : we can't include pip, et al in upper-constraints.txt because pip is what enforces the constraints | 15:01 |
odyssey4me | dhellmann that makes sense, but it does appear that pip can downgrade itself if need be | 15:04 |
prometheanfire | dhellmann: it's self re-enforcing, but why can't it work? | 15:05 |
prometheanfire | I'm guessing it has to do with how we use get-pip.py? | 15:06 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/requirements: Update constraint for python-manilaclient to new release 1.10.0 https://review.openstack.org/342919 | 15:08 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/requirements: Bump manilaclient version https://review.openstack.org/342727 | 15:10 |
dhellmann | odyssey4me , prometheanfire : sometimes downgrading works, sometimes it doesn't. Why do you want to use constraints on those tools? | 15:32 |
prometheanfire | personally I don't think it's needed for pip, but I know setuptools had an issue recently | 15:33 |
odyssey4me | dhellmann to provide the same protection as the rest of upper-constraints - a known, good, working version at that point in time | 15:33 |
odyssey4me | dhellmann specifically for openstack-ansible, it provides complete build repeatability - at the SHA we're fixed on, the build will always use the same version of everything installed... forever | 15:34 |
odyssey4me | it wasn't that long ago that pip 8.0 was released, and all hell broke loose | 15:35 |
odyssey4me | different wheel versions result in different package name schemes | 15:35 |
odyssey4me | and setuptools isn't always perfect either | 15:35 |
odyssey4me | so for us, when we tag, we want that tag to always use the same version of the things it was tested with | 15:36 |
dhellmann | I'm not 100% clear of the details of why those packages are unconstrained, but IIRC it was a combination of lacking a reliable way to do it and a desire to be testing with newish tools. Maybe because we can't assume developers are installing constrained versions on their systems? | 15:36 |
odyssey4me | back then there wasn't the u-c system we have today, where we update the u-c regularly after testing the newer versions | 15:37 |
odyssey4me | to be clear, it's not crucial to us - we just implement the pins in a different way to achieve the same goal... but I thought it worth discussing for the benefit of a broader group | 15:38 |
openstackgerrit | Ricardo Carrillo Cruz proposed openstack/requirements: update constraint for oslo.context to new release 2.6.0 https://review.openstack.org/341543 | 15:40 |
prometheanfire | odyssey4me: the main issue we'd have is with pip I think | 15:45 |
prometheanfire | odyssey4me: given our use of get-pip.py infra side | 15:45 |
prometheanfire | but for setuptools and wheel it should be doable I think | 15:46 |
dhellmann | if we can make it work, it's worth looking into. I'd like to understand why we didn't include them in the constraints system when we implemented that, though, before we change that decision and end up with an unintended consequence | 15:47 |
dhellmann | we might need to get lifeless and ttx to explain that, since I don't think I was involved | 15:47 |
dhellmann | fungi might remember | 15:48 |
odyssey4me | prometheanfire using get-pip.py you can tell it which version to install | 15:49 |
odyssey4me | prometheanfire see the usage here: https://github.com/pypa/get-pip | 15:50 |
*** coolsvap|afk has quit IRC | 15:50 | |
*** coolsvap|afk has joined #openstack-requirements | 15:51 | |
odyssey4me | to enforce the right versions, we set the version of pip, setuptools and wheel when installing pip using get-pip | 15:51 |
*** coolsvap|afk is now known as coolsvap | 15:51 | |
odyssey4me | https://github.com/openstack/openstack-ansible-pip_install/blob/master/tasks/install_online.yml#L45 | 15:51 |
coolsvap | prometheanfire, yes the email did not go out | 15:52 |
prometheanfire | dhellmann: fair enough, this is something odyssey4me is bringing up in the next meeting | 15:52 |
prometheanfire | odyssey4me: true, I don't think we use that yet | 15:52 |
coolsvap | prometheanfire, i updated the bot review to exclude the oslo.context till jamie works on it | 15:59 |
coolsvap | and we can check that later | 16:00 |
coolsvap | i brought up the issue of mistral-extras in infra | 16:00 |
coolsvap | so that project-config is not updated before requirements/projects.txt is updated | 16:00 |
prometheanfire | ah, cool | 16:05 |
odyssey4me | coolsvap yeah, currently there's a job to validate that anything put into requirements/project.txt has a check-requirements job | 16:29 |
odyssey4me | what needs to be added is a check that anything that has the check-requirements job removed has already been removed from requirements/project.txt | 16:30 |
odyssey4me | that's the missing link | 16:30 |
odyssey4me | I'd be happy to try and figure out where to put that, but I won't get to it within the next week or two I don't think. | 16:31 |
coolsvap | odyssey4me, yes i am looking to tackle that, if not iwill let you know | 16:54 |
rcarrillocruz | hey folks | 19:14 |
rcarrillocruz | can any core +A https://review.openstack.org/#/c/341543/ ? | 19:14 |
patchbot | rcarrillocruz: patch 341543 - requirements - update constraint for oslo.context to new release ... | 19:14 |
rcarrillocruz | i rebased it | 19:14 |
rcarrillocruz | i'm getting 500 nova errors due to current oslo.context version package | 19:14 |
rcarrillocruz | dims, prometheanfire ^ | 19:18 |
prometheanfire | rcarrillocruz: other projects are breaking with 2.6.0 iirc, which is why it's being held back atm | 19:19 |
rcarrillocruz | oh? | 19:19 |
rcarrillocruz | :/ | 19:19 |
prometheanfire | ya... | 19:19 |
prometheanfire | https://bugs.launchpad.net/neutron/+bug/1602081 | 19:20 |
openstack | Launchpad bug 1602081 in OpenStack Compute (nova) "Use oslo.context's policy dict" [Undecided,In progress] - Assigned to Jamie Lennox (jamielennox) | 19:20 |
rcarrillocruz | i'm getting this fine exception on nova with 2.5.0 :/ | 19:20 |
rcarrillocruz | http://paste.openstack.org/show/533092/ | 19:20 |
rcarrillocruz | sigh | 19:20 |
dims | rcarrillocruz : is there evidence of the nova 500 problem in the CI? | 19:21 |
prometheanfire | commenting on the 1543 review with it would be helpful if so | 19:22 |
rcarrillocruz | dims: dunno, have asked since yerd | 19:23 |
rcarrillocruz | yesterday and except coolsvap seeing similar issues this morning nothing | 19:23 |
rcarrillocruz | but i've seen this similar issue with other packages, it just i got past them cos the packages i had issues with got versions bump on requirements | 19:24 |
dims | rcarrillocruz : let me share what we do.. for example when the releases happened yesterday, the bot proposed an update (https://review.openstack.org/#/c/341323/) then we have a script that updates a bunch of reviews against individual projects to see if the bot proposed update breaks something (https://review.openstack.org/#/q/status:open+branch:master+topic:dims/test/constraints). Those are the reviews we go look for | 19:35 |
dims | problems. | 19:35 |
patchbot | dims: patch 341323 - requirements - Updated from generate-constraints (MERGED) | 19:35 |
dims | rcarrillocruz : looks like coolsvap had to touch up that review | 19:35 |
rcarrillocruz | yeah, i was looking into it this morning, he touched as i was getting oslo-utils issues on 3.15 | 19:37 |
rcarrillocruz | but anyway | 19:37 |
rcarrillocruz | bumping | 19:37 |
rcarrillocruz | is masking the issue | 19:37 |
rcarrillocruz | we must know why the current versions are broken per the test failures | 19:37 |
rcarrillocruz | i'm checking current oslo-context on a venv to see | 19:37 |
dims | rcarrillocruz : looks like coolsvap did not trigger all the reviews after he touched up the bot proposed review, so i am doing that now | 19:39 |
dims | rcarrillocruz : you should see all the review refreshed in https://review.openstack.org/#/q/status:open+branch:master+topic:dims/test/constraints | 19:40 |
dims | let's watch that and see if we made a mistake merging something this morning | 19:40 |
rcarrillocruz | sweet, thx! | 19:40 |
*** MarleenLazard63 has joined #openstack-requirements | 20:59 | |
*** MarleenLazard63 has quit IRC | 21:17 | |
*** MarleenLazard63 has joined #openstack-requirements | 21:52 | |
*** MarleenLazard63 has quit IRC | 23:06 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!