*** edmondsw has joined #openstack-requirements | 03:07 | |
*** edmondsw has quit IRC | 03:11 | |
*** udesale has joined #openstack-requirements | 04:13 | |
prometheanfire | tonyb: what about with an ack from the mistral people | 06:14 |
---|---|---|
*** ameeda has joined #openstack-requirements | 06:17 | |
ameeda | Morning :) | 06:17 |
ameeda | please check this bug https://bugs.launchpad.net/placement-osc-plugin/+bug/1745471 Doug reported it, he asked me to check this bug with you here | 06:18 |
openstack | Launchpad bug 1745471 in placement-osc-plugin "tox.ini settings for global constraints are out of date" [Undecided,New] - Assigned to Ameed Ashour (ameeda) | 06:18 |
ameeda | as he mentioned he notice differences between oslo.config tox.ini and placement-osc-plugin tox.ini | 06:19 |
ameeda | please check his comment " Compare the tox.ini settings in the orc-placement repo (http://git.openstack.org/cgit/openstack/osc-placement/tree/tox.ini) to the ones in oslo.config (http://git.openstack.org/cgit/openstack/oslo.config/tree/tox.ini). Note that the install_command and deps entries are different." | 06:19 |
prometheanfire | ameeda: prety sure we talked before about it | 06:20 |
prometheanfire | looking at the diff | 06:20 |
ameeda | prometheanfire: Thanks for reply, yes please check it and let me know | 06:21 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.openstack.org/538556 | 06:26 |
prometheanfire | ameeda: ya, making it look more like oslo.config sounds right | 06:27 |
ameeda | prometheanfire: Thank you for the help :) | 06:30 |
prometheanfire | ameeda: lol, I didn't do anything | 06:35 |
ameeda | prometheanfire: it's some of kind words, also you help me to do the right thing with that :) so Thank you again :D | 06:36 |
prometheanfire | np then | 06:37 |
tonyb | prometheanfire: Sure that'd be fine I guess | 06:37 |
*** adrianreza has joined #openstack-requirements | 06:39 | |
ameeda | prometheanfire: should I update the whole file or just install_command and deps entries ? | 06:40 |
prometheanfire | ameeda: just those two look like enough | 06:41 |
tonyb | ameeda: You'll need to update install_command and deps | 06:41 |
tonyb | ameeda: Also I think that there may be some "magic" with tox-silbings | 06:41 |
ameeda | Thank you, I did that, but I want to be sure , I submit the review here https://review.openstack.org/#/c/543348/ | 06:42 |
ameeda | tonyb: there are something should I do for that ? | 06:42 |
tonyb | ameeda: I'm not sure where that settled I'll review your chnage after zuul has voted on it | 06:44 |
ameeda | tonyb: I will ping you after zuul voted on it. :) | 06:45 |
tonyb | ameeda: I'm loggin off now, it'll be tomorrow | 06:45 |
tonyb | I have the tab open in my broswer | 06:45 |
ameeda | tonyb: its okay, take your time :) | 06:46 |
*** ralonsoh has joined #openstack-requirements | 08:17 | |
*** florianf has joined #openstack-requirements | 08:19 | |
*** jpich has joined #openstack-requirements | 08:54 | |
*** dirk has quit IRC | 09:33 | |
*** dirk has joined #openstack-requirements | 09:34 | |
toabctl | tonyb, dirk prometheanfire is https://review.openstack.org/#/c/543395/ acceptable for stable/pike ? otherwise we would need a bump for pymod2pkg | 09:34 |
openstackgerrit | Amir Mofakhar proposed openstack/requirements master: upgraded monasca-common to 2.7.0 because of oslo-poilicy enforcement engine implementation in this version and other monasca projects which have oslo-policy can not work with lower version of monasca-common. https://review.openstack.org/543415 | 10:22 |
*** udesale_ has joined #openstack-requirements | 10:58 | |
*** udesale has quit IRC | 11:01 | |
*** ralonsoh_ has joined #openstack-requirements | 11:06 | |
*** udesale_ has quit IRC | 11:07 | |
*** ralonsoh has quit IRC | 11:10 | |
dirk | toabctl: the alternative.would be to branch for pike and backport the freezer change | 11:14 |
*** coreycb has quit IRC | 11:19 | |
*** coreycb has joined #openstack-requirements | 11:20 | |
toabctl | dirk, hm. but it doesn't make sense to branch it imo | 12:44 |
*** ralonsoh__ has joined #openstack-requirements | 12:46 | |
*** ralonsoh_ has quit IRC | 12:50 | |
*** edmondsw has joined #openstack-requirements | 13:15 | |
*** edmondsw has quit IRC | 13:15 | |
*** edmondsw_ has joined #openstack-requirements | 13:16 | |
*** edmondsw_ is now known as edmondsw | 13:37 | |
*** ralonsoh__ is now known as ralonsoh | 14:11 | |
*** udesale has joined #openstack-requirements | 14:20 | |
*** udesale_ has joined #openstack-requirements | 14:24 | |
*** udesale has quit IRC | 14:25 | |
*** edmondsw has quit IRC | 14:38 | |
*** lbragstad has joined #openstack-requirements | 14:39 | |
*** edmondsw has joined #openstack-requirements | 14:52 | |
*** jaosorior has joined #openstack-requirements | 14:55 | |
prometheanfire | tonyb: ya, I think it's fine | 14:56 |
jaosorior | Hey folks, is it expected that the update-requirements tools also changes the copyright https://review.openstack.org/#/c/543479/1/setup.py ? | 14:56 |
prometheanfire | that does seem odd, though I'm not sure it's wrong, since the file is managed by a diferent tool if the copyright changes that's normal, maybe | 15:09 |
jaosorior | right, was a bit confused about that | 15:11 |
jaosorior | if it's not a big deal I might just change the copyright back to what it was | 15:11 |
prometheanfire | I don't think it was | 15:35 |
prometheanfire | jaosorior: I'd bug tonyb about it when he wakes up though (AUS) | 15:35 |
jaosorior | alright | 15:36 |
jaosorior | in the meantime I removed that copyright header | 15:36 |
jaosorior | thanks | 15:36 |
prometheanfire | he was around when the tool was written | 15:36 |
*** udesale has joined #openstack-requirements | 15:53 | |
*** udesale_ has quit IRC | 15:53 | |
*** jpich has quit IRC | 17:07 | |
*** udesale has quit IRC | 17:17 | |
*** ralonsoh has quit IRC | 18:07 | |
*** florianf has quit IRC | 19:40 | |
*** lbragstad_ has joined #openstack-requirements | 19:41 | |
*** lbragstad_ has quit IRC | 19:43 | |
tonyb | jaosorior: Reverting the copyright thing is fine but the bot will re-write it everytime it runs so it probably isn't a great use of time. As to how it has a Red Hat copyright at all I'm a little confused | 20:24 |
jaosorior | tonyb: no, it has an HP copyright | 20:51 |
jaosorior | tonyb: well, the script | 20:51 |
jaosorior | or whatever | 20:51 |
jaosorior | anyway, so... any reason the script generates a copyright at all? | 20:51 |
tonyb | jaosorior: setup.py has a copyright in your repo it's Red Hat and the bot wants to set it to HP | 20:53 |
jaosorior | tonyb: right | 20:53 |
jaosorior | shouldn't the copyright actually be for the OpenStack foundation? thought that was part of signing the CLA and all | 20:53 |
tonyb | jaosorior: Well that's a seperate issue | 20:53 |
prometheanfire | copyright assignment fight | 20:54 |
tonyb | jaosorior: We'd need to think about what happens if we remove that copyright. | 20:55 |
tonyb | prometheanfire: Yeah :( | 20:55 |
prometheanfire | been dealing with that lately in gentoo | 20:55 |
prometheanfire | https://dev.gentoo.org/~ulm/glep-copyrightpolicy.html | 20:55 |
tonyb | This specific situation is simultaneously trivial and complex :( | 20:56 |
tonyb | jaosorior: I guess in the short term it's just a question of manually editing the bot changes :( | 20:56 |
*** edmondsw has quit IRC | 21:39 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!