*** hongbin has joined #openstack-requirements | 00:57 | |
*** edmondsw has joined #openstack-requirements | 01:18 | |
*** edmondsw has quit IRC | 01:22 | |
*** andreas_s has joined #openstack-requirements | 02:15 | |
*** andreas_s has quit IRC | 02:19 | |
openstackgerrit | Nguyen Van Trung proposed openstack/requirements master: Allow Pygments in openstack/requirements https://review.openstack.org/568729 | 02:55 |
---|---|---|
*** hongbin has quit IRC | 02:57 | |
openstackgerrit | Nguyen Van Trung proposed openstack/requirements master: Allow Pygments in openstack/requirements https://review.openstack.org/568729 | 03:11 |
*** edmondsw has joined #openstack-requirements | 04:32 | |
*** udesale has joined #openstack-requirements | 05:11 | |
*** snapiri has joined #openstack-requirements | 05:32 | |
*** andreas_s has joined #openstack-requirements | 06:14 | |
*** udesale has quit IRC | 06:27 | |
*** udesale has joined #openstack-requirements | 06:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.openstack.org/568758 | 06:32 |
*** edmondsw has quit IRC | 06:49 | |
*** udesale has quit IRC | 06:58 | |
openstackgerrit | Tony Breeds proposed openstack/requirements master: Bump zVMCloudConnector to 1.1.1 https://review.openstack.org/568763 | 07:01 |
*** udesale has joined #openstack-requirements | 07:07 | |
*** udesale has quit IRC | 07:19 | |
*** udesale has joined #openstack-requirements | 07:24 | |
*** florianf has joined #openstack-requirements | 07:34 | |
*** dims has quit IRC | 07:59 | |
*** dims has joined #openstack-requirements | 08:02 | |
*** dims has quit IRC | 08:07 | |
*** dims has joined #openstack-requirements | 08:07 | |
*** edmondsw has joined #openstack-requirements | 08:20 | |
*** edmondsw has quit IRC | 08:25 | |
*** edmondsw has joined #openstack-requirements | 10:08 | |
*** edmondsw has quit IRC | 10:13 | |
*** lxkong has left #openstack-requirements | 11:15 | |
*** edmondsw has joined #openstack-requirements | 11:57 | |
*** edmondsw has quit IRC | 12:01 | |
*** edmondsw has joined #openstack-requirements | 12:07 | |
*** edmondsw has quit IRC | 12:07 | |
*** mriedem has joined #openstack-requirements | 12:25 | |
mriedem | prometheanfire: if i'm reading this error correctly, http://logs.openstack.org/25/524425/13/check/requirements-check/e0b71dc/job-output.txt.gz#_2018-05-15_21_31_07_114195 is because i've got oslo.policy>=1.35.0 in nova's requirements.txt https://review.openstack.org/#/c/524425/13/requirements.txt but it's only 1.30.0 in lower-constraints.txt in openstack/requirements https://github.com/openstack/requirements/blob/mast | 12:25 |
mriedem | ower-constraints.txt#L440 is that correct? | 12:25 |
mriedem | it would be nice if https://docs.openstack.org/requirements/latest/ gave more instruction on updating requirements.txt in a project now regarding any related changes to lower-constraints.txt | 12:31 |
*** edmondsw has joined #openstack-requirements | 12:36 | |
openstackgerrit | Matt Riedemann proposed openstack/requirements master: Bump oslo.policy to 1.35.0 in lower-constraints https://review.openstack.org/568835 | 12:54 |
openstackgerrit | Matt Riedemann proposed openstack/requirements master: Require wsgi-intercept 1.7.0 https://review.openstack.org/561687 | 13:13 |
mriedem | oh maybe this is because nova has a lower-constraints file now... https://github.com/openstack/nova/blob/master/lower-constraints.txt#L86 | 13:19 |
mriedem | guess i need to rebase | 13:19 |
mriedem | smcginnis: dhellmann: do you know if we need to bump lower-constraints in the requirements repo if we also bump requirements in our own repo (nova in this case)? | 13:20 |
mriedem | that's how g-r used to work, but i know things are different and weird now | 13:20 |
dhellmann | mriedem : no, you do not need to modify the lower-constraints list in the requirements repo | 13:20 |
dhellmann | we're going to eventually deprecate that, but need to build a tool to merge lower-constraints files from other sources first | 13:20 |
mriedem | ok, why does it exist? | 13:20 |
mriedem | ok | 13:20 |
dhellmann | it was an early attempt to provide some guidance to deployers/packagers about the overall global lower bounds | 13:21 |
dhellmann | but we've determined that it's not the right way to do that | 13:21 |
dhellmann | mriedem : I would appreciate your feedback on the basic steps outlined for updating requirements in https://docs.openstack.org/project-team-guide/dependency-management.html#update-processes | 13:31 |
dhellmann | we probably need to do a better job of communicating those | 13:31 |
dhellmann | s/we/I/ | 13:31 |
mriedem | dhellmann: oh i wouldn't have even thought to look there, i was looking in the requirements repo docs | 13:32 |
mriedem | yeah i can check out those docs | 13:32 |
dhellmann | I guess we need a link then :-) | 13:32 |
dhellmann | yeah, I've been trying to encourage cross-project teams to update the team guide with stuff we assume to be standard, because often folks don't even know there *is* a team managing something | 13:33 |
mriedem | yeah i wouldn't expect someone new to know there is a requirements specific repo with it's own docs and process | 13:42 |
*** cjloader has joined #openstack-requirements | 13:47 | |
*** udesale_ has joined #openstack-requirements | 13:55 | |
*** udesale has quit IRC | 13:58 | |
prometheanfire | mriedem: still need help? | 15:06 |
mriedem | prometheanfire: don't think so, got my patch passing the requirements job now | 15:10 |
mriedem | thanks | 15:10 |
prometheanfire | :D | 15:11 |
prometheanfire | dhellmann: mind poking https://review.openstack.org/568763 ? would like to get the webob fix done today | 15:14 |
mriedem | dhellmann: assume https://docs.openstack.org/project-team-guide/dependency-management.html#format "Version specifiers" should be removed now? | 15:15 |
mriedem | g-r doesn't have versions in it anymore b/c l-c and u-c handle those now | 15:15 |
mriedem | https://docs.openstack.org/project-team-guide/dependency-management.html#tox is also way out of date i think, everything should be using u-c by now | 15:15 |
mriedem | https://docs.openstack.org/project-team-guide/dependency-management.html#updating-the-minimum-version-of-a-dependency lgtm and is what i was missing earlier | 15:16 |
prometheanfire | mriedem: format, version specifiers are still permitted, but just for exclusions (and maybe caps if absolutely needed), the section is fine other than that | 15:18 |
prometheanfire | ya, the tox section should be killed | 15:19 |
mriedem | ok | 15:19 |
dhellmann | prometheanfire : done | 15:23 |
dhellmann | mriedem : the stuff on version specifiers should be updated to say that we don't take minimum values (>= or >) but do take != | 15:24 |
*** kiennt26 has joined #openstack-requirements | 15:24 | |
mriedem | dhellmann: prometheanfire: want me to push a docs change for those two things? | 15:25 |
dhellmann | mriedem : sure, that would be great, thanks! | 15:25 |
*** kiennt26 has quit IRC | 15:28 | |
*** andreas_s has quit IRC | 15:30 | |
*** andreas_s has joined #openstack-requirements | 15:30 | |
mriedem | https://review.openstack.org/568883 | 15:35 |
*** andreas_s has quit IRC | 15:44 | |
*** andreas_s has joined #openstack-requirements | 15:49 | |
mugsie | prometheanfire: re https://review.openstack.org/568729 - I think sphinx is bringing it in when it hits a code block? | 15:54 |
mugsie | I really can't tell though | 15:54 |
*** mriedem has left #openstack-requirements | 15:54 | |
openstackgerrit | Graham Hayes proposed openstack/requirements master: Allow Pygments in openstack/requirements https://review.openstack.org/568729 | 15:56 |
*** andreas_s has quit IRC | 15:58 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements stable/queens: update constraint for ovsdbapp to new release 0.10.1 https://review.openstack.org/568891 | 16:00 |
*** andreas_s has joined #openstack-requirements | 16:01 | |
*** udesale_ has quit IRC | 16:02 | |
prometheanfire | mugsie: it's possible, but if so, shouldn't it be a dep of sphinx? | 16:05 |
mugsie | it is .... | 16:05 |
mugsie | https://github.com/sphinx-doc/sphinx/blob/master/setup.py#L21 | 16:06 |
mugsie | why didnt that get picked up :/ | 16:06 |
*** andreas_s has quit IRC | 16:06 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/requirements master: Restore Sphinx in upper-constraints.txt https://review.openstack.org/568248 | 16:07 |
*** andreas_s has joined #openstack-requirements | 16:13 | |
*** edmondsw has quit IRC | 16:15 | |
*** andreas_s has quit IRC | 16:18 | |
*** edmondsw_ has joined #openstack-requirements | 16:18 | |
prometheanfire | mugsie: not sure, we are using sphinx-1.6.7 though | 16:22 |
prometheanfire | see https://review.openstack.org/568248 | 16:22 |
*** edmondsw_ has quit IRC | 16:23 | |
*** florianf has quit IRC | 16:26 | |
*** ralonsoh has joined #openstack-requirements | 17:04 | |
*** ralonsoh has quit IRC | 17:04 | |
openstackgerrit | Merged openstack/requirements master: Bump zVMCloudConnector to 1.1.1 https://review.openstack.org/568763 | 17:24 |
*** edmondsw has joined #openstack-requirements | 18:57 | |
openstackgerrit | Merged openstack/requirements master: update constraint for oslo.rootwrap to new release 5.14.1 https://review.openstack.org/568437 | 19:17 |
prometheanfire | ~1h10m til meeting | 19:21 |
*** dtroyer has quit IRC | 19:28 | |
*** dtroyer has joined #openstack-requirements | 19:28 | |
*** andreas_s has joined #openstack-requirements | 20:15 | |
*** andreas_s has quit IRC | 20:19 | |
prometheanfire | #startmeeting requirements | 20:31 |
openstack | Meeting started Wed May 16 20:31:13 2018 UTC and is due to finish in 60 minutes. The chair is prometheanfire. Information about MeetBot at http://wiki.debian.org/MeetBot. | 20:31 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 20:31 |
*** openstack changes topic to " (Meeting topic: requirements)" | 20:31 | |
openstack | The meeting name has been set to 'requirements' | 20:31 |
prometheanfire | #topic rollcall | 20:31 |
*** openstack changes topic to "rollcall (Meeting topic: requirements)" | 20:31 | |
prometheanfire | tonyb, prometheanfire, number80, dirk, coolsvap, toabctl, smcginnis, dhellmann | 20:31 |
prometheanfire | o/ | 20:31 |
dhellmann | o/ | 20:31 |
tonyb | \o | 20:31 |
smcginnis | o/ | 20:31 |
prometheanfire | :D | 20:33 |
prometheanfire | #topic Any controversies in the Queue? | 20:33 |
*** openstack changes topic to "Any controversies in the Queue? (Meeting topic: requirements)" | 20:33 | |
prometheanfire | https://review.openstack.org/558604 I'd say | 20:33 |
smcginnis | Hmm, I think you are right about it being a security issue. | 20:35 |
tonyb | I though we discuessed that | 20:35 |
tonyb | how is it a security issue? | 20:35 |
prometheanfire | tonyb: I think we did, the main change now is that 3.25.1 is out | 20:35 |
smcginnis | Isn't not exposing plain text passwords a security issue? | 20:36 |
prometheanfire | https://github.com/openstack/oslo.concurrency/commit/0c4718fcb77e9f4e3a22ae458869b7294b7bc91f | 20:36 |
prometheanfire | #link https://github.com/openstack/oslo.concurrency/commit/0c4718fcb77e9f4e3a22ae458869b7294b7bc91f | 20:37 |
tonyb | smcginnis: IIIUC it's transalating /dev/mapper/vg-my-lv-called-password into /dev/mapper/vg-my-lv-called-p*** | 20:37 |
tonyb | which seems to be doing to opposite to exposing passwords ;P | 20:37 |
prometheanfire | #link https://bugs.launchpad.net/oslo.utils/+bug/1482382 | 20:38 |
openstack | Launchpad bug 1482382 in Cinder "mask_password is overzealous" [Undecided,In progress] - Assigned to prashkre (prashkre) | 20:38 |
prometheanfire | ya, bug title makes it sound like it's going the other way | 20:38 |
tonyb | So if my reading is right *and* the fix is in 3.25.1 we can close the requirements bump | 20:39 |
tonyb | then the cinder team can just backport the fix | 20:39 |
prometheanfire | it is looking like that | 20:40 |
tonyb | ideally it'd add an extra hunk to detect the version of oslo.concurrency and "do the rigth thing" but IMO that isn't *required* | 20:40 |
smcginnis | So you're saying Cinder would detect which version of oslo.concurreny is being used and perform the santization itself if it's an older one? | 20:41 |
tonyb | smcginnis: No | 20:41 |
tonyb | smcginnis: cinder would detect the version of oslo.concurreny and bypass it to *avoid* sanitizin the output on older versions (or those without the sanitize_stdout kwarg | 20:42 |
tonyb | smcginnis: but I don't really think that's required | 20:43 |
smcginnis | Since it's pretty much the only thing in 3.25.1, it seems like bumping that would be the safer approach. | 20:45 |
tonyb | smcginnis: We'd need to look at the versions that $distros have packaged | 20:46 |
prometheanfire | safer, but since queens still should be syncing reqs that means re-releases | 20:46 |
prometheanfire | Available versions: 3.21.1 3.25.0 ~3.25.1 {test PYTHON_TARGETS="python2_7 python3_4 python3_5 python3_6"} | 20:46 |
prometheanfire | here | 20:46 |
smcginnis | Yeah | 20:46 |
prometheanfire | isn't stable yet, but 'soon' | 20:47 |
tonyb | smcginnis: we don't bump minimums on stable branches as that makes all the distros do extar work which they've balked at befoer | 20:47 |
dhellmann | we usually just update the constraint for the new release and leave it up to downstream to pull it in | 20:47 |
prometheanfire | if it's not a security vuln that's fixed (and it doesn't look like this is) then we don't need to bump or exclude anything I don't think | 20:48 |
dhellmann | it could offer a dos vector if the volume can't be deleted | 20:48 |
tonyb | dhellmann: Yup, and that's what I'm proposing as I don't think this meets our guidlines for minimum bumps on stable/* | 20:48 |
dhellmann | it's not clear why the parameters to the command are being sanitized though | 20:49 |
dhellmann | before it's run, that is | 20:49 |
dhellmann | oh, looking at the patch I get it | 20:49 |
tonyb | we're calling command_b with the output from command_b and that output is being sanitized IIUC | 20:49 |
dhellmann | so yeah, I don't think cinder needs to do anything here if we update the constraint | 20:50 |
prometheanfire | https://github.com/openstack/requirements/blob/stable/queens/upper-constraints.txt#L24 | 20:50 |
prometheanfire | already updated | 20:50 |
dhellmann | cool | 20:51 |
prometheanfire | ok, going to close it | 20:51 |
smcginnis | +1 | 20:51 |
prometheanfire | I'll abandon with a message | 20:51 |
dhellmann | thinking about this sort of thing for the future, we may want to automate some sort of block on changing minimum values on stable branches | 20:52 |
dhellmann | although that can lead to broken gates, I guess | 20:52 |
smcginnis | Yeah, I think there's always exceptions that need subjective evaluation. | 20:52 |
dhellmann | but now that the lower bounds are controlled by project teams, it will be harder to catch "but we had a bug in a library" updates | 20:52 |
smcginnis | Automatic blocking could cause issues. | 20:53 |
smcginnis | True | 20:53 |
tonyb | Yup | 20:53 |
prometheanfire | I'm going to abandon the rsd-lib and rsdclient bumps as well | 20:53 |
tonyb | we can brainstorm it befoer August ;P | 20:53 |
dhellmann | so maybe it's just a matter of reminding folks about that | 20:53 |
tonyb | prometheanfire: I thought they were okay just waiting for input? | 20:53 |
prometheanfire | the sphinx 1.7.x change needs a ml thread, because it's a breaking thing | 20:53 |
prometheanfire | tonyb: it's been a week | 20:53 |
tonyb | prometheanfire: your call but I'm not sure they need to be rejected | 20:54 |
tonyb | prometheanfire: Yeah it seems like we can't use 1.6 or 1.7 without braking someone | 20:54 |
prometheanfire | they can be re-opened (and I'll note as such) | 20:54 |
tonyb | my feel is go back to 1.7.4 and get the affetced projects to fix the docs | 20:55 |
prometheanfire | agreed | 20:55 |
prometheanfire | guess I'll email the list about that | 20:55 |
tonyb | prometheanfire: danke | 20:56 |
prometheanfire | nothing else for me | 20:56 |
prometheanfire | I'd like someone to review the uc bot bump (finally on the new webob :D | 20:56 |
tonyb | prometheanfire: Okay I'll look it over today | 20:57 |
prometheanfire | thanks | 20:57 |
prometheanfire | the only thing we should have to chage in the bot update is pika now | 20:57 |
* tonyb was thinking we should add a "manual-updates.txt" into the repo so that as we find $things that we know are broken we can add them to that file and therefore avoid the bot updating those things | 20:58 | |
tonyb | I feel like that'd save a bunch of manual messing with the generated changes | 20:59 |
prometheanfire | I kinda like having the anoying stuff | 21:00 |
prometheanfire | makes me want to fix it | 21:00 |
prometheanfire | #topic Open Discussion | 21:00 |
*** openstack changes topic to "Open Discussion (Meeting topic: requirements)" | 21:00 | |
tonyb | prometheanfire: Okay, I feel like it slows us down | 21:00 |
prometheanfire | tonyb: probably does | 21:01 |
prometheanfire | gonna close this unless someone speaks up | 21:02 |
* tonyb is good | 21:02 | |
prometheanfire | eyes on https://review.openstack.org/568729 would be nice, but that's it | 21:02 |
prometheanfire | #endmeeting | 21:03 |
*** openstack changes topic to "OpenStack Requirements - IRC meetngs on Wednesdays @ 07:00 UTC in here in #openstack-requirements - See agenda @ http://tinyurl.com/h44ryuw - IRC channel is *LOGGED* @ http://tinyurl.com/j38rk24" | 21:03 | |
openstack | Meeting ended Wed May 16 21:03:50 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:03 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/requirements/2018/requirements.2018-05-16-20.31.html | 21:03 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/requirements/2018/requirements.2018-05-16-20.31.txt | 21:03 |
openstack | Log: http://eavesdrop.openstack.org/meetings/requirements/2018/requirements.2018-05-16-20.31.log.html | 21:03 |
tonyb | I looked at it but need to mul it over, I think we need it added to blacklist.txt and possible lower-constarints.txt | 21:04 |
smcginnis | o/ | 21:04 |
prometheanfire | was wondering why we didn't get fails for it, I did see it in UC.txt at least | 21:04 |
prometheanfire | still wondering why they need to pull it in explicitly | 21:04 |
*** cjloader_ has joined #openstack-requirements | 21:57 | |
*** cjloader has quit IRC | 21:57 | |
*** cjloader has joined #openstack-requirements | 22:02 | |
*** cjloader_ has quit IRC | 22:02 | |
*** cjloader has quit IRC | 22:07 | |
*** otherwiseguy has quit IRC | 22:15 | |
*** pabelanger has quit IRC | 22:15 | |
*** otherwiseguy has joined #openstack-requirements | 22:22 | |
*** otherwiseguy has quit IRC | 22:26 | |
*** pabelanger has joined #openstack-requirements | 22:34 | |
*** otherwiseguy has joined #openstack-requirements | 22:36 | |
*** edmondsw has quit IRC | 22:50 | |
openstackgerrit | Merged openstack/requirements master: Updated from generate-constraints https://review.openstack.org/568451 | 22:56 |
*** edmondsw has joined #openstack-requirements | 23:11 | |
*** pabelanger has quit IRC | 23:17 | |
*** otherwiseguy has quit IRC | 23:18 | |
*** pabelanger has joined #openstack-requirements | 23:20 | |
*** otherwiseguy has joined #openstack-requirements | 23:21 | |
openstackgerrit | Merged openstack/requirements master: Restore Sphinx in upper-constraints.txt https://review.openstack.org/568248 | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!