| *** hongbin has joined #openstack-requirements | 02:02 | |
| *** cjloader has joined #openstack-requirements | 02:23 | |
| *** cjloader has quit IRC | 02:28 | |
| *** hongbin has quit IRC | 03:26 | |
| *** udesale has joined #openstack-requirements | 03:52 | |
| *** udesale has quit IRC | 06:18 | |
| *** udesale has joined #openstack-requirements | 06:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.openstack.org/574573 | 06:27 |
|---|---|---|
| *** florianf has joined #openstack-requirements | 06:34 | |
| *** tosky has joined #openstack-requirements | 07:07 | |
| *** amoralej|off is now known as amoralej | 07:11 | |
| *** florianf has quit IRC | 07:18 | |
| *** florianf has joined #openstack-requirements | 07:18 | |
| *** jpich has joined #openstack-requirements | 07:55 | |
| openstackgerrit | Shachar Snapiri proposed openstack/requirements master: Bump up lc of jsonmodels to 2.1.5 https://review.openstack.org/574655 | 08:51 |
| *** dtantsur|afk is now known as dtantsur | 09:35 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/requirements master: Bump upper-constraints for metalsmith to the recent release https://review.openstack.org/574678 | 09:39 |
| *** amoralej is now known as amoralej|lunch | 11:48 | |
| *** edmondsw has joined #openstack-requirements | 12:03 | |
| *** amoralej|lunch is now known as amoralej | 13:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements stable/pike: update constraint for django_openstack_auth to new release 3.6.1 https://review.openstack.org/574733 | 13:48 |
| *** CrayZee has joined #openstack-requirements | 14:33 | |
| *** cjloader has joined #openstack-requirements | 14:54 | |
| *** mordred has quit IRC | 14:55 | |
| *** mordred has joined #openstack-requirements | 15:08 | |
| *** cjloader has quit IRC | 15:13 | |
| *** cjloader has joined #openstack-requirements | 15:13 | |
| *** kiennt26 has joined #openstack-requirements | 15:22 | |
| *** cjloader has quit IRC | 15:26 | |
| *** CrayZee has quit IRC | 15:28 | |
| *** vpickard is now known as vpickard_ | 15:38 | |
| *** kiennt26 has quit IRC | 15:47 | |
| *** mordred has quit IRC | 15:48 | |
| *** mordred has joined #openstack-requirements | 15:51 | |
| *** cjloader has joined #openstack-requirements | 16:07 | |
| *** dhellmann[m] has quit IRC | 16:08 | |
| *** lbragstad[m] has quit IRC | 16:08 | |
| *** smcginnis[m] has quit IRC | 16:08 | |
| *** jpich has quit IRC | 16:35 | |
| *** smcginnis[m] has joined #openstack-requirements | 16:35 | |
| *** electrofelix has joined #openstack-requirements | 16:37 | |
| *** dtantsur is now known as dtantsur|afk | 16:41 | |
| *** udesale has quit IRC | 16:55 | |
| *** toabctl has quit IRC | 17:05 | |
| *** lbragstad[m] has joined #openstack-requirements | 17:06 | |
| *** dhellmann[m] has joined #openstack-requirements | 17:06 | |
| *** amoralej is now known as amoralej|off | 17:22 | |
| *** cjloader has quit IRC | 18:03 | |
| *** cjloader_ has joined #openstack-requirements | 18:08 | |
| *** electrofelix has quit IRC | 18:16 | |
| *** cjloader_ has quit IRC | 18:25 | |
| *** cjloader has joined #openstack-requirements | 18:27 | |
| *** cjloader has quit IRC | 18:32 | |
| *** cjloader has joined #openstack-requirements | 18:33 | |
| *** cjloader has quit IRC | 19:11 | |
| *** cjloader has joined #openstack-requirements | 19:12 | |
| *** cjloader has quit IRC | 19:33 | |
| *** cjloader has joined #openstack-requirements | 19:45 | |
| *** pelix has joined #openstack-requirements | 19:55 | |
| *** cjloader has quit IRC | 20:00 | |
| *** cjloader_ has joined #openstack-requirements | 20:03 | |
| pelix | I had enabled check-requirements on a few peripheral projects as a handy way of making sure any requirements I added were ok | 20:13 |
| pelix | but now that I'm pulling in a new dependency (loremipsum in https://review.openstack.org/557301) not included I'm not sure if it makes sense propose it or drop the check-requirements job? | 20:13 |
| pelix | the project is a test helper for patch management tool (git-upstream) for downstream consumers of openstack | 20:14 |
| *** pelix is now known as electrofelix | 20:14 | |
| electrofelix | whoops, forgot to update my nick, sorry | 20:14 |
| electrofelix | looking at the review guidelines it seems like I should probably drop this job rather than suggest this library is needed by proposing it to the global-requirements, but just a little hazy on whether I'm following it correctly | 20:15 |
| dhellmann | electrofelix : if you're going to use fixtures-git in the test-requirements for projects that follow the global requirements list, it will be simpler to consume if you do add loremipsum to the global list | 20:19 |
| dhellmann | because that way we'll be able to manage the version used for everything | 20:20 |
| dhellmann | if you don't add it there, we'll still end up adding it to the upper-constraints.txt list when the bot calculates the shared dependencies | 20:20 |
| dhellmann | but that won't be as obvious as doing it in a separate patch | 20:21 |
| dhellmann | electrofelix : otoh, which review guidelines are you reading? | 20:21 |
| electrofelix | dhellmann: was looking at https://docs.openstack.org/project-team-guide/dependency-management.html | 20:22 |
| electrofelix | specifically the paragraph that made me hesitate is "Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)? By adding something to OpenStack global-requirements.txt we are basically demanding that Linux Distros package this for the next release of OpenStack. If they already have, great. If not, we should be cautious of adding it. Finding Distro Status" | 20:22 |
| dhellmann | well, if the tool ends up being needed for tests to run I think they're going to want to package it | 20:23 |
| dhellmann | what are you using loremipsum for? | 20:23 |
| dhellmann | based on https://pypi.org/project/loremipsum/ I'm seeing a lot of red badges. I'm not sure I'd pick that one as a dependency if it's not actively maintained. | 20:24 |
| dhellmann | wow, 2014? | 20:24 |
| dhellmann | https://pypi.org/project/loremipsum/#history | 20:24 |
| electrofelix | was used to generate fake text, I'm looking around to see if there is anything else | 20:24 |
| dhellmann | oh, and GPL, too | 20:25 |
| dhellmann | yeah, I think I'd find another way to do that | 20:25 |
| electrofelix | yeah I just spotted that, not sure how I missed that .... | 20:25 |
| dhellmann | no worries, that's why we do these reviews :-) | 20:28 |
| electrofelix | kind of points out why making use of check-requirements is a good idea in general as well ;-) | 20:29 |
| dhellmann | ++ | 20:29 |
| *** cjloader_ has quit IRC | 20:37 | |
| electrofelix | would https://github.com/joke2k/faker be acceptable? looks like it has a dep on text-unidecode which is artistic license and python-dateutil is already part of global reqs, or do the test deps also need to be looked at? | 20:37 |
| *** cjloader has joined #openstack-requirements | 20:37 | |
| electrofelix | oh I know why I thought I could use loremipsum, I must have thought that the one on pypi is from https://github.com/monkeython/loremipsum which is BSD 3 clause based on https://github.com/monkeython/loremipsum/blob/master/LICENSE.rst | 20:42 |
| *** lbragstad[m] has quit IRC | 20:49 | |
| dhellmann | faker looks like it would be a better option | 20:53 |
| *** dhellmann[m] has quit IRC | 20:53 | |
| *** smcginnis[m] has quit IRC | 20:53 | |
| *** smcginnis[m] has joined #openstack-requirements | 21:09 | |
| *** tosky has quit IRC | 21:25 | |
| openstackgerrit | Darragh Bailey proposed openstack/requirements master: Adding faker to global requirements https://review.openstack.org/574898 | 21:40 |
| electrofelix | I need to check about it's inclusion in fedora/ubuntu, but looks like a better option, will upload a revised patch tomorrow once confirmed | 21:41 |
| *** electrofelix has quit IRC | 21:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for os-brick to new release 2.5.1 https://review.openstack.org/574903 | 21:55 |
| *** cjloader has quit IRC | 21:56 | |
| *** edmondsw has quit IRC | 22:26 | |
| *** edmondsw has joined #openstack-requirements | 22:26 | |
| *** edmondsw has quit IRC | 22:31 | |
| *** florianf has quit IRC | 22:36 | |
| *** smcginnis[m] has quit IRC | 23:15 | |
| *** cjloader has joined #openstack-requirements | 23:29 | |
| *** smcginnis[m] has joined #openstack-requirements | 23:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!