*** udesale has joined #openstack-requirements | 04:28 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-requirements | 04:33 | |
*** e0ne has joined #openstack-requirements | 05:36 | |
*** e0ne has quit IRC | 05:40 | |
*** e0ne has joined #openstack-requirements | 06:07 | |
*** e0ne has quit IRC | 06:12 | |
*** e0ne has joined #openstack-requirements | 06:38 | |
*** e0ne has quit IRC | 06:43 | |
*** ccamacho has joined #openstack-requirements | 06:47 | |
*** rpittau|afk is now known as rpittau | 06:51 | |
*** ccamacho has quit IRC | 07:02 | |
*** e0ne has joined #openstack-requirements | 07:21 | |
*** e0ne has quit IRC | 07:25 | |
*** dtantsur|afk is now known as dtantsur | 07:28 | |
*** ccamacho has joined #openstack-requirements | 07:29 | |
*** vishalmanchanda has joined #openstack-requirements | 07:31 | |
*** e0ne has joined #openstack-requirements | 07:52 | |
*** e0ne has quit IRC | 07:57 | |
*** e0ne has joined #openstack-requirements | 08:24 | |
*** e0ne has quit IRC | 08:29 | |
*** e0ne has joined #openstack-requirements | 08:55 | |
*** e0ne has quit IRC | 09:00 | |
*** e0ne has joined #openstack-requirements | 09:26 | |
*** e0ne has quit IRC | 09:31 | |
*** e0ne has joined #openstack-requirements | 09:58 | |
*** e0ne has quit IRC | 10:02 | |
*** rpittau is now known as rpittau|bbl | 10:21 | |
*** e0ne has joined #openstack-requirements | 10:29 | |
*** e0ne has quit IRC | 10:34 | |
*** tosky has joined #openstack-requirements | 10:57 | |
*** e0ne has joined #openstack-requirements | 11:00 | |
*** udesale has quit IRC | 11:02 | |
*** udesale has joined #openstack-requirements | 11:02 | |
*** e0ne has quit IRC | 11:05 | |
*** e0ne has joined #openstack-requirements | 11:31 | |
*** e0ne has quit IRC | 11:36 | |
*** rpittau|bbl is now known as rpittau | 12:00 | |
*** e0ne has joined #openstack-requirements | 12:03 | |
*** e0ne has quit IRC | 12:07 | |
*** ianw is now known as ianw_pto | 12:13 | |
*** udesale_ has joined #openstack-requirements | 12:20 | |
*** udesale has quit IRC | 12:22 | |
*** e0ne has joined #openstack-requirements | 12:34 | |
*** e0ne has quit IRC | 12:39 | |
*** e0ne has joined #openstack-requirements | 12:44 | |
*** lbragstad has joined #openstack-requirements | 12:45 | |
*** e0ne has quit IRC | 12:50 | |
openstackgerrit | Sean McGinnis proposed openstack/requirements master: Use venv instead of virtualenv in generate script https://review.opendev.org/738227 | 13:18 |
---|---|---|
smcginnis | Latest attempt. May need to look at completely refactoring that unit test. | 13:19 |
*** rosmaita has joined #openstack-requirements | 13:26 | |
rosmaita | hello requirements peeps ... i'm seeing the requirements-check job failing in stable/stein because it can't find virtualenv -- i didn't see a patch up to include the ensure-virtualenv role, but may have missed it | 13:28 |
rosmaita | guess that would have to go into stable/train first? do you need me to put up a patch, or is someone working on it already? | 13:28 |
smcginnis | rosmaita: I think I have a set of them. Need to take a look again to see what has gone through and what hasn't yet. | 13:37 |
rosmaita | smcginnis: thanks ... i realize that it's very hard to keep track of all these changes | 13:37 |
smcginnis | It's just been a game of whack-a-mole. :) | 13:38 |
rosmaita | lol | 13:38 |
*** hrw has joined #openstack-requirements | 14:02 | |
hrw | morning | 14:02 |
hrw | I see that requirements-tox-py38-check-uc-aarch64 job works great ;) | 14:02 |
smcginnis | hrw: Looks good so far. | 14:06 |
hrw | just like expected | 14:18 |
tosky | should we cap requests for now? It seems 2.24 is causing havoc (https://bugs.launchpad.net/cinder/+bug/1885526) | 16:02 |
openstack | Launchpad bug 1885526 in Cinder "Unity driver not working with requests version 2.24.0 " [Undecided,New] | 16:02 |
smcginnis | tosky: I think frickler was working on that. I don't think I've seen a patch yet though. | 16:05 |
tosky | oki | 16:10 |
openstackgerrit | Sean McGinnis proposed openstack/requirements master: Use venv instead of virtualenv in generate script https://review.opendev.org/738227 | 16:16 |
*** vishalmanchanda has quit IRC | 16:17 | |
*** udesale_ has quit IRC | 16:23 | |
openstackgerrit | Sean McGinnis proposed openstack/requirements master: Lower upper-constraints for requests https://review.opendev.org/738476 | 16:35 |
smcginnis | tosky: I double checked and didn't see anything out there, so ^ | 16:36 |
tosky | thanks! | 16:36 |
*** ccamacho has quit IRC | 17:26 | |
*** ccamacho has joined #openstack-requirements | 17:34 | |
*** lbragstad_ has joined #openstack-requirements | 17:37 | |
*** lbragstad has quit IRC | 17:40 | |
openstackgerrit | Sean McGinnis proposed openstack/requirements master: Remove skydive-client from global requirements https://review.opendev.org/737645 | 17:42 |
*** hrw has left #openstack-requirements | 17:43 | |
openstackgerrit | Sean McGinnis proposed openstack/requirements master: Use venv instead of virtualenv in generate script https://review.opendev.org/738227 | 17:50 |
*** dtantsur is now known as dtantsur|afk | 17:51 | |
openstackgerrit | Sean McGinnis proposed openstack/requirements master: Lower upper-constraints for requests https://review.opendev.org/738476 | 18:23 |
openstackgerrit | Brian Rosmaita proposed openstack/requirements stable/train: Ensure virtualenv is installed locally https://review.opendev.org/738518 | 21:44 |
openstackgerrit | Sean McGinnis proposed openstack/requirements stable/stein: Requirements-check: use local repo like any other library https://review.opendev.org/738519 | 21:46 |
rosmaita | smcginnis: am i off track with https://review.opendev.org/738518? | 21:48 |
smcginnis | rosmaita: I don't think that's really needed on train, but that could be another way to fix stein. | 21:48 |
smcginnis | Let's leave them both for now and see. | 21:48 |
smcginnis | The other change eliminates the need to have virtualenv. | 21:49 |
rosmaita | ok | 21:50 |
smcginnis | rosmaita: If we want to test out that stein one while we wait, the cinder patch could have a Depends-on added to it to pick that up and see if it gets around it. | 21:51 |
smcginnis | But we can wait and make sure local tests pass first. ;) | 21:51 |
smcginnis | rosmaita: I think that ensure-virtualenv can actually skip stable/train. I see a job that ran on train earlier today that passed fine. | 21:58 |
smcginnis | rosmaita: So we either need to add virtualenv to stein and later, or we backport the change that makes it not necessary. | 21:59 |
rosmaita | smcginnis: whatever you prefer | 21:59 |
rosmaita | i thought we needed it, but i see your point about the CI itself running in py3, so it can create a venv, and then in there, the py27 check can create a virtualenv | 22:00 |
smcginnis | rosmaita: Well, the other change gets rid of creating a virtualenv entirely and just assumes the job is already running in an environment that has things locally installed. So py version shouldn't matter too much. | 22:01 |
smcginnis | It's probably a bigger change though. So I defer that decision to prometheanfire. :) | 22:02 |
rosmaita | that works for me ... i don't have any preference except to get stein unstuck | 22:02 |
prometheanfire | smcginnis: wat, hi? | 22:09 |
prometheanfire | guess I'll read backlog in a min, dealing with breakage at work :| | 22:09 |
smcginnis | prometheanfire: tldr; our requirements-check job is failing on stable/stein and older due to missing virtualenv. | 22:10 |
smcginnis | prometheanfire: tonyb fixed it in train and later by refactoring the job to not try to create a virtualenv. | 22:10 |
smcginnis | So two options: add ensure-virtualenv to make sure it's available (rosmaita's patch) or backport the change to the script to not need it (my patch). | 22:10 |
smcginnis | Either one if fine. But I think rosmaita's needs to be directly to stable/stein as it's not an issue in stable/train. | 22:11 |
smcginnis | prometheanfire: for reference - get rid of need for virtualenv (https://review.opendev.org/#/c/738519/) and add ensure-virtualenv (https://review.opendev.org/738518) | 22:12 |
prometheanfire | so it sounds like those need to be backported? | 22:16 |
* prometheanfire goes to look at the review | 22:17 | |
smcginnis | One or the other. | 22:18 |
prometheanfire | I like the ensure virtualenv more as it's a 'smaller' change to an old branch, but I'll let the tests finish first | 22:20 |
tonyb[m] | FWIW: I think either is a fine option. IT's a testing only change not anything we 'release' to pypi | 22:44 |
tonyb[m] | I suspect that Brian's change is slightly less risky but only slightly | 22:45 |
*** tosky has quit IRC | 22:46 | |
prometheanfire | yep | 23:00 |
prometheanfire | also, ltns, how you been tonyb[m] ? | 23:00 |
tonyb | prometheanfire: Yeah mostly well, just stupid busy and 99.9% downstream | 23:14 |
tonyb | prometheanfire: It's looking like I'll slowly be able to do more in the community so #yay | 23:14 |
prometheanfire | tonyb: I feel kinda similiar | 23:17 |
tonyb | prometheanfire: :( rough times all round | 23:19 |
prometheanfire | ya, here in tx is not going well | 23:30 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!