| adriant | can we potentially pin upperconstraints for toml to 0.10.0 because of: https://github.com/uiri/toml/issues/295 ? | 01:50 |
|---|---|---|
| prometheanfire | pin, no, mask known bad versions, yes | 01:52 |
| prometheanfire | pin/cap | 01:52 |
| adriant | 0.10.1 breaks for Adjutant so I've pinned it to 0.10.0 in a library I have and it causes a conflict with upperconstraints | 01:52 |
| adriant | prometheanfire, thanks, should I just propose a patch then? | 01:53 |
| prometheanfire | right, what you do is mask the known bad version in global-constraints, then in upper-constraints change the version to 0.10.0 | 01:53 |
| prometheanfire | yep | 01:53 |
| prometheanfire | make sure to refrence the upstream bug (in commit message at least) | 01:53 |
| adriant | prometheanfire, and for any libraries I'm using in Adjutant I really should be making sure they are added to openstack/requirements ? | 01:54 |
| prometheanfire | ya, there should be a requirements check job to verify that | 01:54 |
| prometheanfire | licence issues, etc | 01:55 |
| adriant | I've got a library of my own that I wrote for it https://gitlab.com/catalyst-cloud/confspirator | 01:55 |
| adriant | ^ apache 2 so that's fine | 01:55 |
| adriant | so I guess I'll propose it to requirements | 01:55 |
| prometheanfire | main things are, python version, testing, responsive upstream | 01:55 |
| prometheanfire | not duplicating existing lib | 01:55 |
| prometheanfire | answer these in the commit message for it https://docs.openstack.org/project-team-guide/dependency-management.html#for-new-requirements | 01:56 |
| adriant | prometheanfire: thanks! in CONFspirators case it technically meets those criteria, and I only wrote the damn thing because oslo.config didn't satisfy my requirements (or support yaml/toml with nested groups) | 01:58 |
| adriant | and I guess at some stage I'll also need to propose adding https://dramatiq.io/ since I want to use it for Adjutant, but there isn't any rush there yet | 01:59 |
| prometheanfire | what did oslo.config upstream say about adding support? | 02:15 |
| prometheanfire | I'd also email the discuss list about adding the lib | 02:15 |
| adriant | prometheanfire, my requirements were a little special, and the kind of features I needed I felt didn't make sense to try and add to oslo.config without a major rewrite, and I desperately needed a better way to manage config in Adjutant. | 02:28 |
| prometheanfire | asking the wider community still helps in not having to re-invent the wheel | 02:29 |
| adriant | definitely, which is why I did take some of the type logic bits from oslo.config as a starting point, but very quickly I ended up having to write everything else around it differently :P | 02:31 |
| adriant | I'll throw up an email to the list | 02:33 |
| adriant | but, i am already using the library in Adjutant. If oslo.config decided it wants some of my features I can switch to it later, but until more likely I'll end up maintaining my library and promoting it for people who want toml/yaml and weird nesting/dynamic loading config | 02:34 |
| prometheanfire | ok | 02:43 |
| adriant | prometheanfire, I'll put it to the list, and see what people say :) | 02:45 |
| openstackgerrit | Adrian Turjak proposed openstack/requirements master: cap toml library because of nested dict bug https://review.opendev.org/746434 | 03:40 |
| adriant | prometheanfire: ^ | 03:41 |
| prometheanfire | cool | 03:42 |
| prometheanfire | hmm, that's also explicitly adding tomp to global-requirements | 03:43 |
| prometheanfire | will have to discuss this tomorrow | 03:43 |
| prometheanfire | it's probably fine to add, MIT license, active enough, etc | 03:44 |
| prometheanfire | if you want to preempt and answer the questions for new entries to the commit message that may save you a step | 03:44 |
| adriant | oh, prometheanfire, should I not have added it to global-requirements? | 04:06 |
| adriant | just upperconstraints? | 04:07 |
| prometheanfire | adriant: in order to add the exclusion it needs to be added to upper-constraints | 04:07 |
| prometheanfire | adriant: in order to add the exclusion it needs to be added to global-requirements | 04:07 |
| adriant | ahh, cool | 04:07 |
| adriant | yeah that's what I interpreted from your: "what you do is mask the known bad version in global-constraints" | 04:07 |
| prometheanfire | we really should have another requirements file that's concatenated with the current one for 'unapproved but we still need to manage versions' | 04:08 |
| openstackgerrit | Adrian Turjak proposed openstack/requirements master: Add CONFspirator to requirements https://review.opendev.org/746436 | 04:11 |
| adriant | need to update the commit to include links to it's docs and such... | 04:11 |
| openstackgerrit | Adrian Turjak proposed openstack/requirements master: Add CONFspirator to requirements https://review.opendev.org/746436 | 04:12 |
| prometheanfire | this type of format for the questions would be appreciated https://github.com/openstack/requirements/commit/7828bed0febabfa11a0a8f6960f4c7cc8acec841#diff-d7d5c6fa7118ea10d88f3afeaef4da77 | 04:12 |
| adriant | prometheanfire, can do | 04:13 |
| prometheanfire | thanks | 04:13 |
| adriant | prometheanfire, done | 04:19 |
| openstackgerrit | Adrian Turjak proposed openstack/requirements master: Add CONFspirator to requirements https://review.opendev.org/746436 | 04:19 |
| adriant | although: "Is the library good code?" is a silly question to say yes to when I wrote it :P | 04:19 |
| adriant | but "probably" doesn't sound right in such a commit | 04:19 |
| prometheanfire | thanks | 04:20 |
| adriant | and will send something to the mailing list and link that review | 04:20 |
| prometheanfire | yarp, thanks | 04:24 |
| *** e0ne has joined #openstack-requirements | 04:32 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-requirements | 04:33 | |
| *** e0ne has quit IRC | 04:37 | |
| openstackgerrit | Merged openstack/requirements master: Updated from generate-constraints https://review.opendev.org/746394 | 04:41 |
| *** e0ne has joined #openstack-requirements | 04:52 | |
| *** e0ne has quit IRC | 04:56 | |
| *** e0ne has joined #openstack-requirements | 05:11 | |
| *** e0ne has quit IRC | 05:16 | |
| openstackgerrit | Adrian Turjak proposed openstack/requirements master: Add CONFspirator to requirements https://review.opendev.org/746436 | 05:26 |
| *** e0ne has joined #openstack-requirements | 05:28 | |
| *** e0ne has quit IRC | 05:33 | |
| openstackgerrit | Adrian Turjak proposed openstack/requirements master: Add CONFspirator to requirements https://review.opendev.org/746436 | 06:08 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/746440 | 06:22 |
| *** vishalmanchanda has joined #openstack-requirements | 06:49 | |
| *** e0ne has joined #openstack-requirements | 07:14 | |
| *** hberaud has joined #openstack-requirements | 07:36 | |
| *** dtantsur|afk is now known as dtantsur | 07:55 | |
| *** tosky has joined #openstack-requirements | 07:56 | |
| openstackgerrit | Elod Illes proposed openstack/requirements stable/queens: Revert "[stable-only] Upper constrain wheel to 0.34.2" https://review.opendev.org/746484 | 11:31 |
| *** hberaud has quit IRC | 12:20 | |
| *** hberaud has joined #openstack-requirements | 12:21 | |
| *** lbragstad has quit IRC | 12:32 | |
| *** dhellmann has joined #openstack-requirements | 12:35 | |
| *** hberaud has quit IRC | 12:36 | |
| *** hberaud has joined #openstack-requirements | 12:39 | |
| *** lbragstad has joined #openstack-requirements | 12:43 | |
| *** hberaud has quit IRC | 13:08 | |
| *** dtantsur has quit IRC | 13:32 | |
| *** hberaud has joined #openstack-requirements | 13:34 | |
| *** dtantsur has joined #openstack-requirements | 13:38 | |
| *** hberaud has quit IRC | 13:43 | |
| *** hberaud has joined #openstack-requirements | 13:57 | |
| openstackgerrit | Hervé Beraud proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/746440 | 15:07 |
| prometheanfire | hberaud: commented | 15:29 |
| prometheanfire | speaking of, I've been meaning to bug nova about mock | 15:29 |
| *** hberaud has quit IRC | 15:52 | |
| *** hberaud has joined #openstack-requirements | 15:55 | |
| *** dtantsur is now known as dtantsur|afk | 16:59 | |
| openstackgerrit | Merged openstack/requirements stable/queens: Revert "[stable-only] Upper constrain wheel to 0.34.2" https://review.opendev.org/746484 | 17:30 |
| *** vishalmanchanda has quit IRC | 17:37 | |
| *** e0ne has quit IRC | 18:48 | |
| *** e0ne has joined #openstack-requirements | 19:03 | |
| *** e0ne has quit IRC | 19:03 | |
| *** smcginnis has quit IRC | 19:19 | |
| *** smcginnis has joined #openstack-requirements | 19:21 | |
| *** e0ne has joined #openstack-requirements | 19:29 | |
| *** e0ne has quit IRC | 21:14 | |
| *** e0ne has joined #openstack-requirements | 21:31 | |
| *** e0ne has quit IRC | 21:37 | |
| *** tosky has quit IRC | 22:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!