| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/907647 | 08:40 |
|---|---|---|
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Block scrypt==0.8.21 https://review.opendev.org/c/openstack/requirements/+/907677 | 09:56 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update https://review.opendev.org/c/openstack/requirements/+/907665 | 09:59 |
| frickler | the "netaddr===1.0.0" bump seems to be a nasty one, too :-( that said, my idea of having a rebaseable commit (or two) for sure did bring down the work required to keeping things up to date. now let's see what this latest batch brings | 09:59 |
| frickler | hmm, I was hoping 1.1.0 would fix some things, but it seems tkajinam was faster already ... https://github.com/netaddr/netaddr/issues/368, so it looks like we'll have to fix some projects | 10:05 |
| frickler | yeah, things have gotten rather worse than better with 1.1.0. not sure if some further discussion with the maintainer would help after seeing the above issue https://zuul.opendev.org/t/openstack/build/8cfad48dcfb84be893fe78a1f965c5e6 | 10:57 |
| tkajinam | hmmm | 11:09 |
| tkajinam | I'm pretty sure the maintainer just says "this is not what we intend to support". | 11:11 |
| tkajinam | seeing how my early report was closed | 11:11 |
| tkajinam | I've not yet looked into that error in detail but my first guess is that the new validation logic for IPv4 address killed some usages | 11:13 |
| tkajinam | which accepted very wired values such as None or 1 | 11:13 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update https://review.opendev.org/c/openstack/requirements/+/907665 | 13:28 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Update netaddr to the latest version https://review.opendev.org/c/openstack/requirements/+/909300 | 13:30 |
| frickler | well there are two things to consider. a) something like None is certainly not a valid IP address, the question is whether each application needs to make that check on it's own or whether the netaddr library could simply include that and return False instead of an exception | 13:34 |
| frickler | b) IP addresses in the end are simply integers, so not accepting them as valid IP addresses is a bit more questionable IMO | 13:35 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update https://review.opendev.org/c/openstack/requirements/+/907665 | 13:41 |
| tkajinam | frickler, I sent out https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/Z4GLPDMBZFHNLCOXNRIOZPJVFD7F42QM/ | 17:34 |
| tkajinam | the first change (switch from INET_ATON to INET_PTON) may have huge impact on neutron, because it changes the ip address format it can accept. | 17:35 |
| tkajinam | and the other projects may follow the strategy in neutron later | 17:36 |
| tkajinam | I wasn't sure why we accepted some strange formats like '192.0' or even '1' but that's what we implemented in the past. I'm unsure how much impact it may have in case we drop support for these formats | 17:36 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!