| opendevreview | sean mooney proposed openstack/requirements master: cleanup after 'update-requirements' removal https://review.opendev.org/c/openstack/requirements/+/929857 | 01:04 |
|---|---|---|
| *** bauzas_ is now known as bauzas | 07:25 | |
| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for python-openstackclient to new release 7.1.2 https://review.opendev.org/c/openstack/requirements/+/929938 | 14:17 |
| opendevreview | Takashi Kajinami proposed openstack/requirements master: Bump tenacity to version 8.5.0 https://review.opendev.org/c/openstack/requirements/+/925058 | 14:47 |
| stephenfin | fungi: Weird one: your reply on https://review.opendev.org/c/openstack/releases/+/929915 does not appear as a comment, meaning I can't reply to it. I'm guessing you're using something other than the web UI? | 14:47 |
| stephenfin | sub "comment" for whatever the correct terminology is | 14:48 |
| fungi | stephenfin: it was an inline comment with the gertty client, but it was set to resolved automatically | 14:48 |
| stephenfin | Hmm, how's the different from submitting a comment by clicking the Reply button/pressing 'a'. Even if I mark that resolved, I still see a "rich" comment | 14:50 |
| fungi | i'm not sure, i'd have to look at what rest api call it's using | 14:50 |
| stephenfin | No big deal. Just noticed it and hadn't seen it before is all | 14:51 |
| fungi | yeah, i'm trying to track it back to the api calls, but i'm getting lost in urwid (the curses framework it uses) | 14:54 |
| fungi | it's whatever is stored by the activate action in the diff view | 14:55 |
| fungi | also possible it's changed by https://review.opendev.org/860588 because i'm running with that incomplete experimental patch applied | 14:59 |
| clarkb | stephenfin: fungi: modern gerrit's web ui posts top level change comments as a patchset level comment against a special meta file. This allows you to quote and reply to them among other things. Old gerrit (and the behavior that gertty supports) posts the comment as a proper change comment | 14:59 |
| clarkb | eventually this behavior will go away | 14:59 |
| clarkb | and gertty will have to update but gerrit has been slow in removing that (to the benefit of gertty users) | 15:00 |
| fungi | i think 860588 adds support for replying to comment threads but may not use the new-style inline comments when you make non-reply ones | 15:01 |
| clarkb | I think there is a patch corvus uses but it causes gertty to crash occasionally | 15:02 |
| stephenfin | TIL | 15:14 |
| opendevreview | Takashi Kajinami proposed openstack/requirements master: Bump tenacity to version 8.5.0 https://review.opendev.org/c/openstack/requirements/+/925058 | 16:26 |
| opendevreview | Takashi Kajinami proposed openstack/requirements master: Update netaddr to the latest version https://review.opendev.org/c/openstack/requirements/+/909300 | 16:27 |
| opendevreview | cid proposed openstack/requirements master: WIP: Update to compatible versions of pysnmp https://review.opendev.org/c/openstack/requirements/+/927864 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/requirements master: Update netaddr to the latest version https://review.opendev.org/c/openstack/requirements/+/909300 | 17:30 |
| *** bauzas_ is now known as bauzas | 22:13 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!