| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/950248 | 06:28 |
|---|---|---|
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update https://review.opendev.org/c/openstack/requirements/+/907665 | 06:28 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Add uc check alternative method https://review.opendev.org/c/openstack/requirements/+/948809 | 11:56 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/950248 | 11:56 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update https://review.opendev.org/c/openstack/requirements/+/907665 | 11:56 |
| opendevreview | Merged openstack/requirements master: update constraint for oslo.context to new release 6.0.0 https://review.opendev.org/c/openstack/requirements/+/950165 | 14:38 |
| sean-k-mooney | just an fyi with the oslo.context bump that went in 3 hours ago im not seeing some test failures in watcher | 17:50 |
| sean-k-mooney | i have not checked if its a watcher bug or not yet but it probaly is | 17:51 |
| sean-k-mooney | https://paste.opendev.org/show/bVYxl7Gu23DlwhT240Bc/ | 17:52 |
| JayF | sean-k-mooney: user has been deprecated iirc | 17:54 |
| JayF | let me find the commit | 17:54 |
| JayF | sean-k-mooney: https://opendev.org/openstack/oslo.context/commit/99b81ac42889d139c0975344d110808d4c3af8b4 | 17:54 |
| sean-k-mooney | yep and watcher has been inactivne for most of that time | 17:55 |
| sean-k-mooney | ill see if i can figure out how to move to its replacemnt | 17:55 |
| sean-k-mooney | although i dont see that in the commti message | 17:55 |
| sean-k-mooney | i guess its now user_id | 17:56 |
| sean-k-mooney | the quest is is the type the same but i suspect it is | 17:56 |
| sean-k-mooney | the other thing i need to do once this is passing is submit a patch to at least add watcher unit tests to the requirement gate | 17:57 |
| sean-k-mooney | we only have 2 test failure and it looks like someone mihgt have started mvoing already https://github.com/openstack/watcher/blob/master/watcher/common/context.py#L39-L43 | 17:59 |
| sean-k-mooney | https://github.com/openstack/watcher/commit/3861f1c8450b91c50e42e2891922f48dd7b7424d | 17:59 |
| sean-k-mooney | ok that was pretty trivial in the end https://review.opendev.org/c/openstack/watcher/+/950345 | 18:13 |
| sean-k-mooney | if i ignore this 9 year old fixme comment https://github.com/openstack/watcher/blob/master/watcher/common/context.py#L64-L66 ... | 18:14 |
| sean-k-mooney | i mena after 9 year its tradtion at this point right :) | 18:15 |
| sean-k-mooney | the realquestion is since that code is clearly cargo cultered form somewehre else, where did it come form and how did htey fix it :) | 18:17 |
| sean-k-mooney | knowing my luck the answer will be nova where the 9 year old coment is 10 years old and still not done :) | 18:18 |
| sean-k-mooney | lol dambit htat was ment to be a joke https://github.com/openstack/nova/commit/7a4136df187fc6d2f5813580e8868e591007c2e8 | 18:20 |
| sean-k-mooney | sigh https://github.com/openstack/nova/blob/master/nova/context.py#L163 i guess if i fix it in watcher i shoudl add nova and cyborg to the list | 18:22 |
| opendevreview | sean mooney proposed openstack/requirements master: add watcher cross job https://review.opendev.org/c/openstack/requirements/+/950360 | 19:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!