Saturday, 2025-07-05

opendevreviewOpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints  https://review.opendev.org/c/openstack/requirements/+/95417308:20
fricklerfungi: the commit message of ^^ looks like it can be improved, I'll do that for this change when I amend it with the necessary fixups, but maybe you can check in the script why this doesn't quite work out12:56
opendevreviewDr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update  https://review.opendev.org/c/openstack/requirements/+/90766513:00
fungifrickler: thanks for the heads up, looking now14:08
fungihuh, when i run the same command locally, the --trailer line shows up as intended...14:12
fungiGenerated-By: openstack/requirements:tools/noop-change.sh14:12
fungii wonder if it's a difference of git version?14:12
fungioh, wait, wrong script14:13
fungiokay, might be related to argument quoting in playbooks/proposal/propose_update.sh but i need to unravel it to test14:15
fungimmm, i'm still getting an okay-looking result:14:16
fungiGenerated-By: openstack/project-config:playbooks/proposal/propose_update.sh14:16
fungithough my testing suggests the quoting around the string isn't needed if it doesn't contain spaces14:18
fungiokay, i see it, some layering of quotes is causing those ' to get wrapped: https://zuul.opendev.org/t/openstack/build/e02fe710f98e412cbd5b09c51ee1222a/log/job-output.txt#77614:25
fungiso the command that's actually executed is...14:25
fungigit commit -a -F- -s '--trailer='\''Generated-By:openstack/project-config:playbooks/proposal/propose_update.sh'\'''14:25
fungifrickler: https://review.opendev.org/c/openstack/project-config/+/954184 Remove superfluous quoting on commit trailer14:29
fungithough i guess i should update all the scripts in there14:30
fungiah, no the rest of them should be fine because they don't have nested quoting and passing of argument lists in shell variables14:32
fungiso that one script is probably the only offender14:32

Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!