| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.opendev.org/c/openstack/requirements/+/954173 | 08:20 |
|---|---|---|
| frickler | fungi: the commit message of ^^ looks like it can be improved, I'll do that for this change when I amend it with the necessary fixups, but maybe you can check in the script why this doesn't quite work out | 12:56 |
| opendevreview | Dr. Jens Harbott proposed openstack/requirements master: Fix for automated upper-constraints.txt update https://review.opendev.org/c/openstack/requirements/+/907665 | 13:00 |
| fungi | frickler: thanks for the heads up, looking now | 14:08 |
| fungi | huh, when i run the same command locally, the --trailer line shows up as intended... | 14:12 |
| fungi | Generated-By: openstack/requirements:tools/noop-change.sh | 14:12 |
| fungi | i wonder if it's a difference of git version? | 14:12 |
| fungi | oh, wait, wrong script | 14:13 |
| fungi | okay, might be related to argument quoting in playbooks/proposal/propose_update.sh but i need to unravel it to test | 14:15 |
| fungi | mmm, i'm still getting an okay-looking result: | 14:16 |
| fungi | Generated-By: openstack/project-config:playbooks/proposal/propose_update.sh | 14:16 |
| fungi | though my testing suggests the quoting around the string isn't needed if it doesn't contain spaces | 14:18 |
| fungi | okay, i see it, some layering of quotes is causing those ' to get wrapped: https://zuul.opendev.org/t/openstack/build/e02fe710f98e412cbd5b09c51ee1222a/log/job-output.txt#776 | 14:25 |
| fungi | so the command that's actually executed is... | 14:25 |
| fungi | git commit -a -F- -s '--trailer='\''Generated-By:openstack/project-config:playbooks/proposal/propose_update.sh'\''' | 14:25 |
| fungi | frickler: https://review.opendev.org/c/openstack/project-config/+/954184 Remove superfluous quoting on commit trailer | 14:29 |
| fungi | though i guess i should update all the scripts in there | 14:30 |
| fungi | ah, no the rest of them should be fine because they don't have nested quoting and passing of argument lists in shell variables | 14:32 |
| fungi | so that one script is probably the only offender | 14:32 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!