| -opendevstatus- NOTICE: zuul processing is broken since about 03:00 UTC, investigation is in progress, please be patient | 08:03 | |
| *** tobias-u1 is now known as tobias-urdin | 08:19 | |
| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for pbr to new release 7.1.3 https://review.opendev.org/c/openstack/requirements/+/1009198 | 11:14 |
|---|---|---|
| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for networking-generic-switch to new release 10.2.0 https://review.opendev.org/c/openstack/requirements/+/1009204 | 11:17 |
| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for openstacksdk to new release 4.21.0 https://review.opendev.org/c/openstack/requirements/+/1009231 | 13:05 |
| opendevreview | Merged openstack/requirements master: update constraint for openstack-release-test to new release 8.6.0 https://review.opendev.org/c/openstack/requirements/+/1008829 | 13:48 |
| opendevreview | Merged openstack/requirements master: update constraint for sushy to new release 5.14.0 https://review.opendev.org/c/openstack/requirements/+/1009073 | 13:51 |
| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for keystoneauth1 to new release 5.18.0 https://review.opendev.org/c/openstack/requirements/+/1009260 | 14:30 |
| opendevreview | Merged openstack/requirements master: update constraint for networking-generic-switch to new release 10.2.0 https://review.opendev.org/c/openstack/requirements/+/1009204 | 14:42 |
| opendevreview | Merged openstack/requirements master: ruff: Enable E5 rules https://review.opendev.org/c/openstack/requirements/+/1007742 | 14:42 |
| opendevreview | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for taskflow to new release 6.5.0 https://review.opendev.org/c/openstack/requirements/+/1009285 | 15:14 |
| frickler | stephenfin: fyi this looks like a failure actually triggered by the keystoneauth1 bump https://zuul.opendev.org/t/openstack/build/381a96a08d294adcbb4407e7bef15914 | 15:33 |
| stephenfin | looks like nova is peeking into ksa internals :/ sigh | 15:34 |
| stephenfin | the downsides of mocking (vs e.g. dependency injection) | 15:35 |
| melwitt | stephenfin: uh oh, that looks like my bad. what is the best way to do it? | 15:38 |
| stephenfin | melwitt: personally, I don't think that tests belongs in nova. It's testing the behavior of ServiceTokenAuthWrapper, which is a ksa thing, not a Nova thing | 15:44 |
| melwitt | the entire test inappropriate? hm ok | 15:45 |
| melwitt | I'll look through and see if there is anything else testable about that part | 15:45 |
| stephenfin | err, let me rephrase 😅 the test as it stands doesn't belong in there | 15:50 |
| stephenfin | however, if we mocked ServiceTokenAuthWrapper then we stop at that boundry | 15:51 |
| stephenfin | ...though I think test_get_service_user_token_auth_plugin_user_auth is already sort of doing that. It's not mocking the class, but it is asserting only only public attribute of the object returned rather than internal calls from same | 15:52 |
| stephenfin | melwitt I can push up a nova patch with my thoughts on the matter if you haven't already started on this? | 15:53 |
| melwitt | stephenfin: sure sounds good | 15:53 |
| stephenfin | frickler: https://review.opendev.org/c/openstack/nova/+/1009297 should fix that ksa bump issue. We've deleted the test | 17:26 |
| stephenfin | it's going through the gate | 17:26 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!