| *** rbowen has quit IRC | 00:27 | |
| *** rbowen has joined #openstack-rpm-packaging | 00:42 | |
| *** rbowen has quit IRC | 01:05 | |
| openstackgerrit | Tony Xu proposed openstack/rpm-packaging: Update oslo.log to 3.17.0 https://review.openstack.org/388434 | 01:31 |
|---|---|---|
| openstackgerrit | Tony Xu proposed openstack/rpm-packaging: Update python-oneviewclient to 2.5.2 https://review.openstack.org/388959 | 02:00 |
| openstackgerrit | Tony Xu proposed openstack/rpm-packaging: Update python-solumclient to 2.1.1 https://review.openstack.org/388960 | 02:02 |
| *** coolsvap has joined #openstack-rpm-packaging | 03:30 | |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging: Add macros to handle -test packages https://review.openstack.org/388526 | 05:01 |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging: Add -test package for python-novaclient https://review.openstack.org/389000 | 05:03 |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging: Add -test package for python-novaclient https://review.openstack.org/389000 | 05:35 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.rootwrap to 5.2.0 https://review.openstack.org/388474 | 05:42 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.context to 2.10.0 https://review.openstack.org/388414 | 05:42 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.messaging 5.11.0 https://review.openstack.org/388444 | 05:43 |
| openstackgerrit | Merged openstack/rpm-packaging: Update debtcollector to 1.9.0 https://review.openstack.org/388407 | 05:43 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.vmware to 2.15.0 https://review.openstack.org/388484 | 05:44 |
| openstackgerrit | Tony Xu proposed openstack/rpm-packaging: Update stevedore to 1.18.0 https://review.openstack.org/388487 | 05:51 |
| *** itxaka has joined #openstack-rpm-packaging | 06:00 | |
| toabctl | number80, time for quick review on https://review.openstack.org/#/c/388526/ ? | 06:04 |
| *** pcaruana has joined #openstack-rpm-packaging | 06:18 | |
| number80 | toabctl: not sure about moving tests to a different directory part | 06:58 |
| toabctl | number80, the tests are not moved | 07:01 |
| number80 | so what's %openstack_test_package_dir ? | 07:02 |
| number80 | %openstack_test_package_install actually copying executable code to /var/lib which is a violation to FHS and then symlinking it to %python_sitelib | 07:04 |
| number80 | it's very unlikely that we can have that accepted by Fedora Packaging Committee | 07:05 |
| toabctl | number80, hm. so how does fedora do this stuff? | 07:06 |
| toabctl | the tests for testr should be in a subdirectory from where you call them iirc | 07:06 |
| toabctl | and the dir must be writeable (for .testrepository) | 07:06 |
| number80 | I have a doubt about what happens to .testrepository, but we just put stuff in %python_sitelib | 07:08 |
| number80 | lemme verify | 07:08 |
| toabctl | number80, and do you add setup.py to be able to run "python setup.py testr" ? | 07:08 |
| number80 | I think it's also shipped | 07:11 |
| toabctl | number80, so what "executable" code is copied? I still don't get it. pardon | 07:12 |
| * toabctl needs maybe more tee | 07:12 | |
| number80 | the macros is copying tests? directories | 07:15 |
| toabctl | number80, for novaclient, the content of the -test package is http://paste.openstack.org/show/586505/ | 07:16 |
| toabctl | and novaclient is a symlink | 07:17 |
| toabctl | hm. I can't remember why we copy tests/ . dirk? | 07:17 |
| number80 | for novaclient, it works as tests code is not at top-level | 07:19 |
| number80 | we need to check if nothing puts tests at top-level | 07:19 |
| toabctl | hm. if test code is at top-level then hopefully this would not be installed into site-packages. that would be an upstream bug imo because it would polute the namespace (import tests) | 07:19 |
| number80 | yeah | 07:21 |
| toabctl | number80, there can't be multiple packages install tests.py or tests/ dir into site-packages. we would have recognized that already due to conflict | 07:21 |
| *** amoralej|off is now known as amoralej | 07:21 | |
| toabctl | ah. pardon for repeating myself | 07:21 |
| dirk | toabctl: I think because for those (broken projects) that didn't have tests under the module, the tests directory didn't get installed | 07:21 |
| toabctl | but I think we could remove the test copy for now | 07:22 |
| number80 | then, it will be a minor naming issue for us | 07:22 |
| dirk | toabctl: but I'm not the original author of that macro, and I don't remember | 07:22 |
| dirk | number80: naming issue? | 07:22 |
| number80 | we put tests code into -tests packages (but do not ship the machinery around), I need to check how QE run unit tests | 07:22 |
| dirk | number80: just to explain, we don't ship those -test packages anywhere, they're used in our "functional testing" ci which is executing the functional tests against our openstack distribution | 07:23 |
| number80 | -test and -tests are a bit to close | 07:23 |
| number80 | dirk: I get it | 07:23 |
| number80 | I think it's fine but may I suggest that we make it a noop for RDO ? | 07:23 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.reports to 1.15.0 https://review.openstack.org/388472 | 07:25 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.concurrency to 3.15.0 https://review.openstack.org/388412 | 07:25 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.cache to 1.15.0 https://review.openstack.org/388410 | 07:26 |
| toabctl | number80, you mean the whole -test package creation ? | 07:26 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.middleware to 3.20.0 https://review.openstack.org/388461 | 07:27 |
| openstackgerrit | Merged openstack/rpm-packaging: Update automaton to 1.5.0 https://review.openstack.org/388405 | 07:27 |
| openstackgerrit | Merged openstack/rpm-packaging: Update futurist to 0.19.0 https://review.openstack.org/388408 | 07:27 |
| number80 | sorry, I'm a bit slow this morning, I spent part of the night, bootstrapping a new architecture | 07:28 |
| openstackgerrit | Merged openstack/rpm-packaging: Update toslo.versionedobjects to 1.18.0 https://review.openstack.org/388483 | 07:28 |
| openstackgerrit | Merged openstack/rpm-packaging: Update tooz to 1.44.0 https://review.openstack.org/388489 | 07:28 |
| toabctl | np | 07:29 |
| * number80 does not recommend testing v8 on qemu hardware emulation | 07:29 | |
| number80 | I've added it to the agenda | 07:31 |
| *** jpena|off is now known as jpena | 07:37 | |
| dirk | number80: v8? | 07:40 |
| dirk | number80: so you'd be okay with creating a -test package that has an empty dir in /var/lib inside ? or is /var/lib in general bad? | 07:45 |
| number80 | dirk: in this case, it's fine, I'm more worried to have -test and -tests packages (since we do not ship tests in production system, we put them in -tests) | 07:52 |
| number80 | in principle, the macros is fine in openstack context | 07:52 |
| number80 | I already hear QE engineers complaining that they installed -test when they meant -tests (and the reverse) and not getting what they expected to get :) | 07:53 |
| dirk | number80: ehm, sorry, I'm slow now.. what is the difference between -test and -tests ? | 07:56 |
| * dirk spent all night on hacking | 07:56 | |
| * toabctl spent all night sleeping and feels bad now | 08:02 | |
| dirk | toabctl: thats okay, you can go to work now and I'll relax ;) | 08:02 |
| number80 | dirk: we separate test code in -tests subpackage | 08:17 |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging: Use %autosetup instead of %setup https://review.openstack.org/384080 | 09:24 |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging: Use %autosetup instead of %setup https://review.openstack.org/384080 | 09:25 |
| dirk | number80: I have no problem with calling our package here -tests instead of -test | 09:27 |
| dirk | number80: its the content that matters (if we can add a compat provide on -test for now we're good) | 09:27 |
| dirk | jpena: any refresh on your previous +2 on this one ? https://review.openstack.org/#/c/384080/4 we could merge it then before more regressions creep in | 09:28 |
| number80 | dirk: actually, let's leave it as-is | 09:28 |
| * number80 +2+W the autosetup review | 09:28 | |
| jpena | dirk: sure, let's merge | 09:28 |
| openstackgerrit | Merged openstack/rpm-packaging: Use %autosetup instead of %setup https://review.openstack.org/384080 | 09:29 |
| *** apevec has joined #openstack-rpm-packaging | 09:39 | |
| *** jpena is now known as jpena|lunch | 11:43 | |
| *** rbowen has joined #openstack-rpm-packaging | 11:55 | |
| *** amoralej is now known as amoralej|lunch | 12:08 | |
| *** jpena|lunch is now known as jpena | 12:48 | |
| openstackgerrit | Merged openstack/rpm-packaging: Add macros to handle -test packages https://review.openstack.org/388526 | 13:16 |
| openstackgerrit | Javier Peña proposed openstack/rpm-packaging: Add py_prep macro to openstack-macros https://review.openstack.org/387345 | 13:28 |
| openstackgerrit | Javier Peña proposed openstack/rpm-packaging: Add py_prep macro to openstack-macros https://review.openstack.org/387345 | 13:30 |
| openstackgerrit | Javier Peña proposed openstack/rpm-packaging: Add py_req_cleanup macro to openstack-macros https://review.openstack.org/387345 | 13:39 |
| *** amoralej|lunch is now known as amoralej | 13:43 | |
| openstackgerrit | Merged openstack/renderspec: Updated from global requirements https://review.openstack.org/388403 | 13:46 |
| openstackgerrit | Merged openstack/pymod2pkg: Add upstream mapping rule for microversion_parse https://review.openstack.org/388646 | 13:47 |
| *** makowals has quit IRC | 13:57 | |
| *** makowals has joined #openstack-rpm-packaging | 14:00 | |
| *** makowals has quit IRC | 14:45 | |
| *** makowals has joined #openstack-rpm-packaging | 15:04 | |
| *** makowals has quit IRC | 15:33 | |
| openstackgerrit | Tony Xu proposed openstack/pymod2pkg: Delete duplicate k8s mapping https://review.openstack.org/389257 | 15:44 |
| openstackgerrit | Merged openstack/rpm-packaging: Update os-win to 1.2.1 https://review.openstack.org/385996 | 15:52 |
| *** openstackgerrit has quit IRC | 16:18 | |
| *** openstackgerrit has joined #openstack-rpm-packaging | 16:19 | |
| *** makowals has joined #openstack-rpm-packaging | 16:40 | |
| *** itxaka has quit IRC | 16:41 | |
| *** makowals has quit IRC | 16:53 | |
| *** apevec has quit IRC | 17:06 | |
| *** jpena is now known as jpena|off | 17:10 | |
| *** mat128 is now known as mat128|afk | 17:33 | |
| openstackgerrit | Merged openstack/rpm-packaging: Add -test package for python-novaclient https://review.openstack.org/389000 | 17:58 |
| *** amoralej is now known as amoralej|off | 18:00 | |
| *** rbowen has quit IRC | 19:55 | |
| *** rbowen has joined #openstack-rpm-packaging | 19:55 | |
| openstackgerrit | Merged openstack/rpm-packaging: Update os-client-config to 1.22.0 https://review.openstack.org/385999 | 19:59 |
| openstackgerrit | Merged openstack/rpm-packaging: Update stevedore to 1.18.0 https://review.openstack.org/388487 | 20:00 |
| openstackgerrit | Merged openstack/rpm-packaging: Update oslo.log to 3.17.0 https://review.openstack.org/388434 | 20:02 |
| *** mat128|afk is now known as mat128 | 20:43 | |
| *** mat128 is now known as mat128|gone | 20:44 | |
| openstackgerrit | Merged openstack/rpm-packaging: Update os-api-ref to 1.1.0 https://review.openstack.org/384077 | 20:56 |
| *** rbowen has quit IRC | 21:07 | |
| *** toabctl has quit IRC | 23:33 | |
| *** toabctl has joined #openstack-rpm-packaging | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!