| openstackgerrit | gecong proposed openstack/renderspec: Use assertEqual() instead of assertDictEqual() https://review.openstack.org/412249 | 02:16 |
|---|---|---|
| openstackgerrit | gecong proposed openstack/renderspec: Use assertEqual() instead of assertDictEqual() https://review.openstack.org/412249 | 02:18 |
| *** coolsvap has joined #openstack-rpm-packaging | 03:59 | |
| *** chandankumar has joined #openstack-rpm-packaging | 07:11 | |
| *** pcaruana has joined #openstack-rpm-packaging | 07:33 | |
| number80 | nice ones | 08:06 |
| openstackgerrit | Merged openstack/renderspec: Use assertEqual() instead of assertDictEqual() https://review.openstack.org/412249 | 08:09 |
| *** chandankumar has quit IRC | 08:29 | |
| *** chandankumar has joined #openstack-rpm-packaging | 08:30 | |
| *** jpena|off is now known as jpena | 08:32 | |
| *** chandankumar has quit IRC | 09:12 | |
| *** chandankumar has joined #openstack-rpm-packaging | 09:37 | |
| *** apevec has joined #openstack-rpm-packaging | 10:38 | |
| *** apevec has joined #openstack-rpm-packaging | 10:38 | |
| IgorYozhikov | number80, dirk, want to ask you to review - https://review.openstack.org/#/c/382196/ all tests passed, looks like %systemd macro works fine. :) | 11:01 |
| *** amoralej is now known as amoralej|brb | 11:05 | |
| dirk | IgorYozhikov: yep, on my todo.. somewhen tonight after work | 11:41 |
| IgorYozhikov | thanx | 11:41 |
| *** amoralej|brb is now known as amoralej | 12:15 | |
| *** chandankumar has quit IRC | 13:03 | |
| *** pradk has joined #openstack-rpm-packaging | 13:31 | |
| *** jpena is now known as jpena|lunch | 13:46 | |
| *** chandankumar has joined #openstack-rpm-packaging | 14:04 | |
| *** amoralej is now known as amoralej|lunch | 14:10 | |
| *** pradk has quit IRC | 14:25 | |
| *** rbowen has joined #openstack-rpm-packaging | 14:37 | |
| *** kaslcrof has joined #openstack-rpm-packaging | 14:38 | |
| openstackgerrit | Witold Bedyk proposed openstack/rpm-packaging: Add template for monasca-agent https://review.openstack.org/409820 | 14:46 |
| *** amoralej|lunch is now known as amoralej | 14:56 | |
| *** jpena|lunch is now known as jpena | 15:03 | |
| *** pradk has joined #openstack-rpm-packaging | 15:04 | |
| *** chandankumar has quit IRC | 15:33 | |
| *** chandankumar has joined #openstack-rpm-packaging | 16:00 | |
| IgorYozhikov | colleagues, I have a question about monasca-agent review ^^^^^^. https://github.com/openstack/monasca-agent/search?utf8=%E2%9C%93&q=supervisor looks like it uses old supervisor instead of systemd. | 16:01 |
| IgorYozhikov | ah, looks like agent is trying to examine amount of services launched by supervisor, sysv & systemd. Now it became more || less clear | 16:09 |
| *** pcaruana has quit IRC | 16:15 | |
| *** chandankumar has quit IRC | 16:16 | |
| jpena | yay, we got RDO CI reporting on reviews: https://review.openstack.org/#/c/382196/ | 17:11 |
| jpena | how can we get it listed in the CI view at the top of the gerrit page? | 17:11 |
| dirk | jpena: woohoo | 17:22 |
| dirk | jpena: can you recheck all pending reviews? | 17:24 |
| dirk | Jpena: which ci view? Link? | 17:24 |
| jpena | dirk: I mean, for every review, we have the output from "Jenkin check", "Fuel Packaging CI rpm_test" and "SUSE CI" at the top | 17:26 |
| jpena | but in https://review.openstack.org/#/c/382196/, the RDO CI reported but it doesn't show up with the other CIs | 17:27 |
| IgorYozhikov | assuming that jpena wants to add rdo ci to the list of CIs | 17:27 |
| jpena | IgorYozhikov, exact, non-voting for now | 17:27 |
| dirk | jpena: ah, you mean the box with the green and red report links? | 17:28 |
| jpena | dirk: exact | 17:29 |
| dirk | jpena: ah, that is some regexp on the comments | 17:29 |
| dirk | jpena: that basically means that the comment added to the review doesn't match the regexp | 17:30 |
| dirk | jpena: press toggle ci in the lower left corner | 17:30 |
| dirk | Then you see the full comment | 17:30 |
| dirk | And then you need to figure out how to make it match the regexp.. it just needs to be formatted in a special way | 17:30 |
| jpena | dirk: aha, I'll search the regexp | 17:30 |
| dirk | I don't know exactly where that regexp is, but i played a bit with the comment format until it was recognized | 17:31 |
| IgorYozhikov | jpena, may be this info could be useful - http://docs.openstack.org/infra/system-config/third_party.html | 17:47 |
| dirk | jpena: hmm, comment looks good, i can't see the mismatch | 18:03 |
| dirk | Maybe also verified needs to be set ? | 18:03 |
| jpena | we don't need the user to be listed in https://review.openstack.org/#/admin/groups/1008,members , do we? | 18:04 |
| *** jpena is now known as jpena|away | 18:09 | |
| dirk | jpena|away: no, i think this setting only specifies whether that user is allows to vote on a review | 18:33 |
| dirk | I think the issue might be a missing verified setting.. | 18:34 |
| *** openstack has joined #openstack-rpm-packaging | 19:15 | |
| *** amoralej is now known as amoralej|off | 20:17 | |
| *** jpena|away is now known as jpena | 20:57 | |
| *** jpena is now known as jpena|off | 22:26 | |
| *** pradk has quit IRC | 23:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!