| openstackgerrit | melissaml proposed openstack/rpm-packaging master: Update oslo.log to 3.24.0 https://review.openstack.org/455978 | 04:20 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/pymod2pkg master: Updated from global requirements https://review.openstack.org/455985 | 04:20 |
| openstackgerrit | melissaml proposed openstack/rpm-packaging master: Update oslo.rootwrap to 5.7.0 https://review.openstack.org/456040 | 04:27 |
| openstackgerrit | melissaml proposed openstack/rpm-packaging master: Update oslo.messaging to 5.21.0 https://review.openstack.org/456041 | 04:29 |
| *** cshastri has joined #openstack-rpm-packaging | 05:49 | |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging master: monasca-api: Install /var/lib/monasca-api https://review.openstack.org/456062 | 05:49 |
| *** pcaruana has joined #openstack-rpm-packaging | 06:30 | |
| *** cshastri_ has joined #openstack-rpm-packaging | 06:52 | |
| *** cshastri has quit IRC | 06:54 | |
| *** jruzicka has quit IRC | 06:55 | |
| *** jruzicka has joined #openstack-rpm-packaging | 06:57 | |
| *** cshastri_ is now known as cshastri | 07:07 | |
| *** leanderthal|afk is now known as leanderthal | 07:34 | |
| openstackgerrit | Thomas Bechtold proposed openstack/renderspec master: Allow remote files for dynamic version detection https://review.openstack.org/455538 | 07:43 |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging master: monasca-api: Install /var/lib/monasca-api https://review.openstack.org/456062 | 07:44 |
| openstackgerrit | Thomas Bechtold proposed openstack/rpm-packaging master: monasca-api: Log into /var/log/monasca-api https://review.openstack.org/456103 | 07:58 |
| *** jpena|off has joined #openstack-rpm-packaging | 08:22 | |
| *** apevec has joined #openstack-rpm-packaging | 08:43 | |
| *** apevec has joined #openstack-rpm-packaging | 08:43 | |
| *** vnogin has joined #openstack-rpm-packaging | 10:04 | |
| *** vnogin has quit IRC | 10:29 | |
| *** vnogin has joined #openstack-rpm-packaging | 11:02 | |
| openstackgerrit | Merged openstack/rpm-packaging master: monasca-api: Install /var/lib/monasca-api https://review.openstack.org/456062 | 12:21 |
| openstackgerrit | Merged openstack/rpm-packaging master: monasca-api: Log into /var/log/monasca-api https://review.openstack.org/456103 | 12:21 |
| toabctl | jpena|off, number80 jruzicka about https://review.openstack.org/#/c/455538/ | 13:24 |
| toabctl | you are not tracking stable branches, correct? | 13:24 |
| * toabctl wonders if there is a better solution to the problem | 13:24 | |
| jruzicka | toabctl, I thought we track stable branches in RDO but I don't maintain packages any more so not sure about hotest new trends :) What is your concern? | 13:42 |
| toabctl | jruzicka, a lot of magic in the upstream_version() function | 13:44 |
| toabctl | jruzicka, and the behavior is different between static versioning and dynamic versioning | 13:44 |
| toabctl | it feels ugly | 13:44 |
| jruzicka | toabctl, it does feel a little bit magicky ;) | 13:51 |
| toabctl | jruzicka, any ideas how to solve that in a nicer way? | 13:53 |
| jruzicka | toabctl, I was just going to ask if you are aware of any alternative because nothing comes to my mind. | 13:53 |
| toabctl | I was thinking about an extra source.yaml file with pypi-name + source-tarball pairs | 13:53 |
| toabctl | and use that for version detection and then pass the version and the source to the spec during the render step | 13:54 |
| toabctl | but not sure if that is better | 13:54 |
| jruzicka | toabctl, that is less likely to lead towards unexpected behavior, but extra file... meh. | 13:55 |
| jruzicka | toabctl, what is the problematic case you see with upstream_version()? | 13:56 |
| toabctl | we already have epochs.yaml and the requirements file | 13:56 |
| jruzicka | well right :) | 13:56 |
| toabctl | jruzicka, it's a chicken/egg problem. you need to extract the version from the tarball but you don't know the tarball before you did the rendering | 13:57 |
| toabctl | and due to that there is a race | 13:57 |
| toabctl | for the static versioning (setting version to eg. 1.2.3) it was easy. you 1) render the spec.j2 (no tarball needed for that) and 2) download the tarball | 13:59 |
| toabctl | for dynamic versioning, you need to download the tarball first to extract the version during rendering | 13:59 |
| openstackgerrit | Merged openstack/pymod2pkg master: Updated from global requirements https://review.openstack.org/455985 | 14:05 |
| toabctl | jruzicka, so ideas are welcome :) | 14:36 |
| jruzicka | toabctl, so maybe the file would be optional for and only used for dynamic versioning? | 14:40 |
| toabctl | the extra file? yes | 14:40 |
| toabctl | jruzicka, another thing would be that renderspec downloads the upstream_source tarball and puts it in the same dir as the output .spec file | 14:41 |
| toabctl | that way there would be no race | 14:41 |
| toabctl | and we could add a --skip-source-update switch to tell renderspec to skip the download | 14:41 |
| toabctl | maybe that is more elegant | 14:41 |
| toabctl | the extra file makes the whole thing a lot more complicated | 14:42 |
| *** cshastri has quit IRC | 14:43 | |
| jruzicka | toabctl, source next to .spec sounds perfectly OK to me. | 14:45 |
| jruzicka | I'd also evade extra file if at all possible... if human is able to extract the version information, machine should be able to do so too, right? :) | 14:45 |
| jruzicka | toabctl, btw downloading source by default will force/encourage correct Source URLs, that's pretty good. | 14:53 |
| openstackgerrit | Thomas Bechtold proposed openstack/renderspec master: Make output template dir available in the context https://review.openstack.org/456242 | 14:58 |
| toabctl | jruzicka, ^^ a first step | 14:58 |
| *** eggmaster has joined #openstack-rpm-packaging | 15:05 | |
| jruzicka | toabctl, found naming issues, as I tend to do :-p | 15:13 |
| toabctl | jruzicka, tell me :) | 15:13 |
| jruzicka | toabctl, commented on the review :) | 15:14 |
| jruzicka | tl;dr s/output template/output/ :D | 15:14 |
| *** DrBacchus has joined #openstack-rpm-packaging | 15:15 | |
| *** rbowen has quit IRC | 15:17 | |
| *** DrBacchus is now known as rbowen | 15:17 | |
| openstackgerrit | Thomas Bechtold proposed openstack/renderspec master: Make output dir available in the context https://review.openstack.org/456242 | 15:19 |
| toabctl | jruzicka, fixed | 15:19 |
| jruzicka | toabctl, LGTM -> +2 | 15:39 |
| openstackgerrit | Merged openstack/renderspec master: Make output dir available in the context https://review.openstack.org/456242 | 15:48 |
| *** rbowen has quit IRC | 15:51 | |
| *** rbowen has joined #openstack-rpm-packaging | 15:51 | |
| openstackgerrit | Thomas Bechtold proposed openstack/renderspec master: Allow remote files for dynamic version detection https://review.openstack.org/455538 | 15:55 |
| *** rbowen has quit IRC | 16:11 | |
| *** rbowen has joined #openstack-rpm-packaging | 16:13 | |
| *** leanderthal is now known as leanderthal|afk | 16:22 | |
| *** vnogin has quit IRC | 17:25 | |
| *** vnogin has joined #openstack-rpm-packaging | 18:29 | |
| *** rbowen has quit IRC | 21:08 | |
| *** pcaruana has quit IRC | 21:51 | |
| *** vnogin has quit IRC | 22:24 | |
| *** pradk has quit IRC | 22:45 | |
| *** apevec has quit IRC | 22:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!