| *** gyee has quit IRC | 01:22 | |
| openstackgerrit | zhangyc proposed openstack/rpm-packaging master: update python-tripleoclient.spec.j2 to 13.6.0 https://review.opendev.org/752876 | 01:52 |
|---|---|---|
| *** apevec_ has joined #openstack-rpm-packaging | 03:52 | |
| *** apevec has quit IRC | 03:54 | |
| *** ykarel|away has joined #openstack-rpm-packaging | 04:05 | |
| *** ykarel|away is now known as ykarel | 04:10 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-rpm-packaging | 04:33 | |
| *** ykarel has quit IRC | 04:44 | |
| *** ykarel has joined #openstack-rpm-packaging | 04:46 | |
| *** ykarel has quit IRC | 05:33 | |
| *** sboyron has joined #openstack-rpm-packaging | 05:38 | |
| *** ykarel has joined #openstack-rpm-packaging | 06:08 | |
| *** amoralej|off is now known as amoralej | 06:15 | |
| openstackgerrit | Merged openstack/rpm-packaging master: Update tripleo-common to 12.6.0 https://review.opendev.org/752454 | 06:18 |
| openstackgerrit | Merged openstack/rpm-packaging master: Upgrade futurist to 2.3.0 https://review.opendev.org/751666 | 06:20 |
| openstackgerrit | Merged openstack/rpm-packaging master: update virtualbmc.spec.j2 to 2.2.0 https://review.opendev.org/752903 | 06:21 |
| openstackgerrit | Merged openstack/rpm-packaging master: Update ovsdbapp to 1.5.0 https://review.opendev.org/751705 | 06:21 |
| openstackgerrit | Merged openstack/rpm-packaging master: Update pbr to 5.5.0 https://review.opendev.org/751707 | 06:21 |
| *** ykarel has quit IRC | 06:37 | |
| *** jpena|off is now known as jpena | 07:15 | |
| *** jpich has joined #openstack-rpm-packaging | 07:58 | |
| sboyron | Hi, I've got some questions with my review 751668. I cannot use my local CI for now (still facing an issue). The issue is, as dirk pointed, : No module named 'ansible' during dlrn-build-mock. This spec is using subpackages and I did not worked with it since several years. My understanding is related to this commit : https://github.com/openstack/metalsmith/commit/56066a20a476d33c8732279bed74cd8514b198e7 a new dependency has | 08:48 |
| sboyron | been added to ansible. My understanding is that it missed now a BuildRequires to ansible to solve this issue; then I cannot point if it will require a dependancy to ansible in a subpackage (I think -doc one) | 08:48 |
| sboyron | I don't want to randomly push on my keyboard until the CI pass; I would like to understand it better, if someone can help me a bit on this jpena, dirk, hberaud any idea ? | 08:49 |
| * hberaud take a look | 08:49 | |
| hberaud | sboyron: you could be surprised by the power of a random keystroke :) | 08:51 |
| sboyron | hberaud, let's code a bot for that, we will just run out of CPU I think, but we may improve openstack so much ... | 08:52 |
| hberaud | lol | 08:53 |
| jpena | sboyron: so in the case of 751668, we would need to add py3('ansible') as a BuildRequires for the main package (not in the -doc subpackage), and as a Requires for the python3-metalsmith subpackage | 08:56 |
| jpena | the convention we are following is: all build requirements go in the main spec, unless they are specific for documentation (sphinx, sphinxcontrib and friends) | 08:57 |
| jpena | runtime reqs will go to each specific subpackage. In the metalsmith case, that is python3-metalsmith | 08:57 |
| hberaud | yeah I think the culprit is this one https://github.com/openstack/metalsmith/commit/62b8b1d8b9697248d4a3368e921b9ee67b73fd0c where ansible have been added to test-requirements.txt so I think this is why we need ansible in BuildRequire | 08:58 |
| sboyron | jpena: thx, so adding {{ py3('ansible') }} will replace by ansible >= 2.8 ? | 09:02 |
| jpena | sboyron: yes, it should. You can check that with renderspec | 09:02 |
| sboyron | Then regarding the BuildRequire, I was thinking that there was only one "build" phase during rpm generation, so I didn't know we could have some buildreq relative to a specific subpackage. | 09:03 |
| jpena | sboyron: it's actually more a convention. In the build phase, it does not matter where the BuildRequires is placed, all of them are installed | 09:04 |
| sboyron | ok great, good to know, (and happy to know that I always followed the convention ^^) | 09:05 |
| sboyron | Finally, what I did not really understood here is why we add ansible as req for python3-metalsmith instead of -doc one since this require seems to be only relative to the documentation ? (or I did not understood the patch, this is possible too) | 09:05 |
| sboyron | and ansible is already a dependancy of ansible-role-{{ py2name() }}-deployment | 09:08 |
| sboyron | and this Require is to ansible instead of py3('ansible'). Should I change this dependanci to ensure matching the right version number ? | 09:09 |
| hberaud | sboyron: I guess it mostly depends on project's tree and where are hosted requirements, in the metalsmith they choosen to host doc requirements in test-requirements.txt (https://github.com/openstack/metalsmith/blob/master/test-requirements.txt#L10) and these requirements are needed for testenv (https://github.com/openstack/metalsmith/blob/master/tox.ini#L16) (related to tests and not to doc) | 09:15 |
| hberaud | s/choosen/chosen/ | 09:16 |
| sboyron | ok, then for the Req to ansible in package ansible-role-...; should I use py3('ansible') since it is now listed in requirements.txt ? | 09:23 |
| hberaud | sboyron: I think that yes | 10:49 |
| hberaud | sboyron: this project only support python 3 => https://github.com/openstack/metalsmith/blob/master/setup.cfg#L19,L22 | 10:50 |
| openstackgerrit | Boyron Sébastien proposed openstack/rpm-packaging master: Update metalsmith to 1.2.0 https://review.opendev.org/751668 | 11:11 |
| *** jpich has quit IRC | 11:25 | |
| *** jpich has joined #openstack-rpm-packaging | 11:25 | |
| *** amoralej is now known as amoralej|lunch | 11:27 | |
| openstackgerrit | Boyron Sébastien proposed openstack/rpm-packaging master: Update metalsmith to 1.2.0 https://review.opendev.org/751668 | 11:31 |
| *** jpena is now known as jpena|lunch | 11:33 | |
| *** ykarel has joined #openstack-rpm-packaging | 11:50 | |
| *** jpena|lunch is now known as jpena | 12:34 | |
| openstackgerrit | Boyron Sébastien proposed openstack/rpm-packaging master: Update metalsmith to 1.2.0 https://review.opendev.org/751668 | 12:36 |
| *** amoralej|lunch is now known as amoralej | 12:42 | |
| *** apevec_ has quit IRC | 13:31 | |
| openstackgerrit | Boyron Sébastien proposed openstack/rpm-packaging master: Update metalsmith to 1.2.0 https://review.opendev.org/751668 | 13:38 |
| openstackgerrit | Boyron Sébastien proposed openstack/rpm-packaging master: Update metalsmith to 1.2.0 https://review.opendev.org/751668 | 13:51 |
| sboyron | I am having some trouble to investigate suse CI... I get an issue on openstack cyborg apparently, but cannot find what is wrong | 14:26 |
| jpena | sboyron: we probably need to fix the cyborg spec, if it's using the master tarball. Something must have changed since the last update, and the SUSE CI rebuilds all packages that depend on the one being updated. So it catches errors on other packages | 14:34 |
| *** amoralej is now known as amoralej|off | 14:55 | |
| *** ykarel is now known as ykarel|away | 15:27 | |
| *** ykarel|away has quit IRC | 15:59 | |
| openstackgerrit | Boyron Sébastien proposed openstack/rpm-packaging master: switch to django_compressor https://review.opendev.org/725216 | 16:04 |
| *** irclogbot_2 has quit IRC | 16:08 | |
| *** irclogbot_0 has joined #openstack-rpm-packaging | 16:09 | |
| *** jpena is now known as jpena|off | 16:21 | |
| *** jpich has quit IRC | 16:26 | |
| *** sboyron has quit IRC | 17:02 | |
| *** gyee has joined #openstack-rpm-packaging | 18:34 | |
| openstackgerrit | Merged openstack/rpm-packaging master: Update oslo.policy to 3.5.0 https://review.opendev.org/751693 | 19:20 |
| openstackgerrit | Dirk Mueller proposed openstack/rpm-packaging master: cyborg: update filelist https://review.opendev.org/753434 | 19:31 |
| *** nicolasbock has quit IRC | 22:04 | |
| *** nicolasbock has joined #openstack-rpm-packaging | 22:05 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!