| openstackgerrit | hanjiangxue proposed openstack/rpm-packaging master: url fix https://review.opendev.org/757978 | 02:23 |
|---|---|---|
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-rpm-packaging | 04:33 | |
| *** amoralej|off is now known as amoralej | 06:38 | |
| *** sboyron has joined #openstack-rpm-packaging | 06:45 | |
| *** jpena|off is now known as jpena | 07:20 | |
| *** rpittau|afk is now known as rpittau | 07:26 | |
| *** number80 has quit IRC | 07:57 | |
| *** number80 has joined #openstack-rpm-packaging | 08:47 | |
| *** apevec has joined #openstack-rpm-packaging | 09:12 | |
| *** jpena is now known as jpena|lunch | 11:32 | |
| sboyron | Hi, | 11:41 |
| sboyron | There is a huge amount of review since several days on URL, all these patch are not always doing the same stuff... I think this should/could be standardize to always use the same syntax | 11:43 |
| sboyron | should we point to /latest or not since /latest is a redirection; should we standardize the usage of {{ pypi_name }} instead of the project name string ? | 11:44 |
| sboyron | Sometimes we point to th wiki, sometimes to the git code, why not creating an rpm macro to always use https://opendev.org/openstack/{{ pypi_name }} or https://opendev.org/openstack/{{ pypi_name }}/latest | 11:48 |
| sboyron | this could allow us to change it to https://opendev.org/openstack/{{ pypi_name }}/src/branch/stable/{{release}} when all branch are created to uniformize all project and ensure when we branch, all projects are pointing to the right location ? | 11:49 |
| sboyron | jpena, dirk, hberaud any feeling on it ? | 11:50 |
| hberaud | sboyron: ya IIRC dirk proposed a all in one patches so IMO 1. these patches could be ignored 2. I agree this could be uniformized to https://opendev.org/openstack/{{ pypi_name }} as we refer to a git repo (AFAIK latest doesn't exist on it) 3. stable branch could be uniformized too as you suggested | 11:53 |
| hberaud | sboyron: however prefer to submit a all in one patch for 2 and 3 | 11:54 |
| hberaud | sboyron: and 1 single patch per stable branch | 11:54 |
| hberaud | normally it could be done with ~4-5 patches | 11:55 |
| hberaud | but please let's wait for feedback from jpena|lunch and dirk too | 11:56 |
| sboyron | hberaud: all these patches has been done by zhangyc and he is not thereto have this discussion | 11:56 |
| hberaud | sboyron: yeah I know but we already discussed about this last week | 11:56 |
| hberaud | sboyron: and dirk proposed to ignore them | 11:57 |
| sboyron | hberaud: ok, so I missed this discussion ^^ sorry | 11:57 |
| hberaud | sboyron: https://review.opendev.org/#/c/757856/ | 11:58 |
| hberaud | sboyron: he already submited a related patch | 11:58 |
| sboyron | hberaud: my feeling is that it could be more relevant to generate directly a new macro to fix all in once with a new macro, that should be updated when branching to ensure all rpm URL description will point to the right version. | 11:58 |
| hberaud | agreed | 11:59 |
| hberaud | if a macro can be based on branch name and refer automatically to the right location then this is the path to follow | 12:00 |
| hberaud | sboyron: ^^ | 12:00 |
| *** amoralej is now known as amoralej|lunch | 12:01 | |
| sboyron | hberaud, ok great I missed this one in the list; all URL are not the same indeed ...I meand depends on project there is not always a pypi name or pypi name can be formated with upper case, so it would require a "| lower" .. maybe this coul be relevant to have the right var with a canonical name used for the repo to allow us to uniform this. This is not really related to this bunch of review, but more a reflexion for a minor | 12:02 |
| sboyron | evolution | 12:02 |
| hberaud | agreed, maybe few projects need a specific url, but it could be easily solved as we want to bring the git repo url so I agree a canonical name could be an elegant solution to standardize all these specfiles | 12:17 |
| hberaud | I think the specific part is around the pypi name | 12:17 |
| hberaud | sboyron: ^^ | 12:17 |
| hberaud | as normally all these projects are more or less under opendev.org/(openstack|x) it could be easily to standardize | 12:18 |
| sboyron | pypiname is not always "canonical" but pypiname could point to this canonical name the major part of the time. I think we could engage a small talk about this and maybe we should add it to next meeting subjects | 12:20 |
| hberaud | good idea | 12:21 |
| sboyron | Can't remember do we make a call this week ? | 12:22 |
| sboyron | I mean with the opendev summit | 12:22 |
| sboyron | the next meeting is the 22 or 29 ? | 12:24 |
| sboyron | I am updating the etherpad .... https://etherpad.opendev.org/p/openstack-rpm-packaging | 12:24 |
| sboyron | and there is not yet the next meeting, jpena|lunch ? | 12:24 |
| *** jpena|lunch is now known as jpena | 12:27 | |
| jpena | we did not say anything against a meeting this week, so let's update the schedule to do it on the 22nd | 12:29 |
| sboyron | ok jpena I was asking that to feel correctly th etherpad. | 12:32 |
| sboyron | I won't be there this week, I've got a training thursday, so I'll let the point on the following meeting the 29th of October | 12:33 |
| sboyron | by the way, I allowed myself to update the etherpad, I hope it's the right way to do ;) | 12:34 |
| jpena | of course, everyone can update the etherpad | 12:34 |
| *** amoralej|lunch is now known as amoralej | 13:08 | |
| *** sboyron_ has joined #openstack-rpm-packaging | 13:23 | |
| *** sboyron has quit IRC | 13:26 | |
| *** sboyron has joined #openstack-rpm-packaging | 13:31 | |
| *** sboyron_ has quit IRC | 13:32 | |
| *** gyee has joined #openstack-rpm-packaging | 15:31 | |
| *** amoralej is now known as amoralej|off | 15:39 | |
| openstackgerrit | Merged openstack/rpm-packaging master: update python-dracclient Uniform Resource Locator https://review.opendev.org/757731 | 16:14 |
| openstackgerrit | Merged openstack/rpm-packaging master: Fix several typos in some explanatory notes https://review.opendev.org/758650 | 16:17 |
| openstackgerrit | Merged openstack/rpm-packaging master: fix IRC channel url https://review.opendev.org/758036 | 16:17 |
| openstackgerrit | Merged openstack/rpm-packaging master: url fix https://review.opendev.org/757978 | 16:19 |
| *** jpena is now known as jpena|off | 16:41 | |
| *** rpittau is now known as rpittau|afk | 16:43 | |
| *** sboyron has quit IRC | 18:12 | |
| *** apevec has quit IRC | 19:02 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!