| openstackgerrit | zhangyc proposed openstack/rpm-packaging master: update reno Uniform Resource Locator https://review.opendev.org/757700 | 01:19 |
|---|---|---|
| *** ykarel has joined #openstack-rpm-packaging | 03:49 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-rpm-packaging | 05:33 | |
| *** sboyron has joined #openstack-rpm-packaging | 06:27 | |
| *** ykarel_ has joined #openstack-rpm-packaging | 07:21 | |
| *** ykarel has quit IRC | 07:24 | |
| *** jpena|off is now known as jpena | 07:35 | |
| *** ykarel_ is now known as ykarel | 07:39 | |
| openstackgerrit | zhangyc proposed openstack/rpm-packaging master: update reno Uniform Resource Locator https://review.opendev.org/757700 | 07:58 |
| *** amoralej|off is now known as amoralej | 08:05 | |
| *** apevec has joined #openstack-rpm-packaging | 08:36 | |
| *** rpittau|afk is now known as rpittau | 08:39 | |
| *** jaicaa has quit IRC | 09:01 | |
| *** jaicaa has joined #openstack-rpm-packaging | 09:02 | |
| *** jpich has joined #openstack-rpm-packaging | 09:11 | |
| *** sboyron has quit IRC | 11:49 | |
| *** sboyron has joined #openstack-rpm-packaging | 11:52 | |
| *** jpich has quit IRC | 12:11 | |
| *** jpich has joined #openstack-rpm-packaging | 12:11 | |
| *** jpena is now known as jpena|lunch | 12:32 | |
| *** amoralej is now known as amoralej|lunch | 12:59 | |
| *** jpena|lunch is now known as jpena | 13:31 | |
| jpena | it's meeting time | 13:32 |
| jpena | #startmeeting rpm_packaging | 13:32 |
| openstack | Meeting started Thu Nov 5 13:32:25 2020 UTC and is due to finish in 60 minutes. The chair is jpena. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:32 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:32 |
| *** openstack changes topic to " (Meeting topic: rpm_packaging)" | 13:32 | |
| jpena | ping toabctl, dirk, apevec, jpena, number80, kaslcrof, rha, hberaud, sboyron | 13:32 |
| openstack | The meeting name has been set to 'rpm_packaging' | 13:32 |
| jpena | #topic roll call | 13:32 |
| *** openstack changes topic to "roll call (Meeting topic: rpm_packaging)" | 13:32 | |
| hberaud | o/ | 13:32 |
| jpena | feel free to add any last-minute topic to the agenda at https://etherpad.opendev.org/p/openstack-rpm-packaging | 13:32 |
| jpena | #chair hberaud | 13:32 |
| openstack | Current chairs: hberaud jpena | 13:32 |
| sboyron | o/ | 13:38 |
| jpena | #chair sboyron | 13:38 |
| openstack | Current chairs: hberaud jpena sboyron | 13:38 |
| jpena | we don't have any topic on the agenda, so let's go straight to the open floor | 13:39 |
| jpena | #topic open floor | 13:39 |
| *** openstack changes topic to "open floor (Meeting topic: rpm_packaging)" | 13:39 | |
| jpena | Anything to discuss? | 13:40 |
| hberaud | nothing special from side | 13:40 |
| sboyron | nothing on my side. | 13:40 |
| hberaud | my* | 13:40 |
| sboyron | indeed, there is still this review : https://review.opendev.org/#/c/758990/ | 13:41 |
| sboyron | but I didn't find any time to work on it | 13:41 |
| sboyron | Oops wrong one | 13:41 |
| sboyron | Was thinking about this one : https://review.opendev.org/#/c/756383/ | 13:42 |
| hberaud | sboyron: I was wondering why you shared this link lol | 13:42 |
| jpena | :) | 13:43 |
| sboyron | jpena: you added some comments and asked for Joel if he had something to add | 13:43 |
| jpena | I'll ping Joel again, in case he can add something | 13:43 |
| sboyron | I think this could be great to continue working on it... | 13:43 |
| hberaud | +1 | 13:43 |
| sboyron | Will do as soon as I'll have some time to dedicate on it. | 13:44 |
| hberaud | same thing here | 13:44 |
| hberaud | but don't hesitate to iterate over it | 13:44 |
| hberaud | I mean to submit new PS on the top of it | 13:44 |
| sboyron | your remark jpena is good (it was one of my point ;) ) regarding the fact it is not doing a "full" check | 13:45 |
| sboyron | I think we should finished a version 1 of it not having the extra deps check | 13:45 |
| hberaud | maybe we could split features through follow up patches | 13:46 |
| sboyron | to ensure not requiring dependance that has been removed from the project | 13:46 |
| hberaud | to avoid tunnel effect | 13:46 |
| jpena | yes, that looks like a good feature for a follow-up patch | 13:46 |
| hberaud | and to release often | 13:46 |
| sboyron | I think it must be reworked to take care of your remark about virtualenv and non-voting, then merging it and develop new features after | 13:46 |
| hberaud | and see what need to be improve or not | 13:46 |
| jpena | agreed | 13:47 |
| hberaud | +1 | 13:47 |
| hberaud | sboyron: do you want to manage this last iteration? | 13:47 |
| hberaud | (venv + non-voting) | 13:47 |
| sboyron | hberaud: yep I can, but not sure will find some thime this week :/ | 13:47 |
| sboyron | I'll try | 13:47 |
| hberaud | np | 13:47 |
| hberaud | I haven't lot of spare time too so | 13:48 |
| sboyron | And one other point is, I would like to add tests on URL to avoid having to check at least if this return 404 issues. | 13:48 |
| hberaud | ok | 13:48 |
| hberaud | awesome | 13:49 |
| sboyron | The big mix of several review modifying some URL and creating a lot of duplicates boring me to be honest | 13:50 |
| sboyron | it's a big mess now | 13:50 |
| hberaud | we can't really avoid that | 13:51 |
| hberaud | the only manner is to formalize everything in one shot | 13:51 |
| sboyron | I think we can limit it by ci checking if the URL is matching a specific pattern | 13:51 |
| dirk | O/ | 13:52 |
| jpena | #chair dirk | 13:52 |
| openstack | Current chairs: dirk hberaud jpena sboyron | 13:52 |
| hberaud | I mean that people are not necessary aware of our check and could decide to submit patch even if checks exists | 13:52 |
| dirk | Which check are we talking about? | 13:53 |
| hberaud | doc url | 13:53 |
| hberaud | the DDOS of url updates | 13:53 |
| hberaud | recently submitted | 13:53 |
| sboyron | Hi dirk, We was talking about adding a new doc URL check in CI to avoid having some URL patch pointing to nothing | 13:54 |
| sboyron | at least | 13:54 |
| hberaud | anyway a check can't hurt | 13:54 |
| sboyron | or having a pattern to apply on the URL | 13:54 |
| dirk | Agreed, the question is if we just want to check for 404 or for a particular pattern | 13:55 |
| hberaud | IMO 404 is enough | 13:55 |
| sboyron | that was my question indeed | 13:55 |
| hberaud | at each cycle I seen people trying to update urls (lower-contraints by example) and back and forth with them each 2 weeks | 13:56 |
| hberaud | here are similar patches | 13:56 |
| dirk | I hope noone feels offended by the flood of url accesses then | 13:56 |
| *** amoralej|lunch is now known as amoralej | 13:56 | |
| dirk | Although that should be fine if we have a distinct user agent set | 13:58 |
| hberaud | this kind of check (404) could addressed against only the commited file | 13:58 |
| hberaud | *files | 13:58 |
| hberaud | to avoid flood | 13:58 |
| dirk | Yep, indeed | 13:58 |
| openstackgerrit | Merged openstack/rpm-packaging master: Remove setuotppls Requirement from karbor https://review.opendev.org/758310 | 13:58 |
| hberaud | however if someone decide to update all of them in one shot then it could trigger a DDOS | 13:59 |
| hberaud | so maybe the user agent is a good idea too | 13:59 |
| hberaud | to avoid to ignore this possiblity | 14:00 |
| sboyron | I think this test should be parformed only when the URL line is modified; otherwise it could block some other review if the doc site is down. | 14:01 |
| sboyron | and it should limit at the maximum this url flood | 14:01 |
| dirk | A single update doing all would still be fine I think | 14:01 |
| dirk | The one-url-per-review is the annoying one | 14:02 |
| dirk | Lots of clicking for not a lot of sense other than what feels like gamification | 14:02 |
| sboyron | dirk agreed for the one url per review ;) | 14:02 |
| sboyron | but the most boring now is that the new patches are offently duplicating some other review not yet abandonned ... | 14:03 |
| dirk | I am trying to cleanup duplicates by abandoning the newer one | 14:04 |
| sboyron | ok | 14:05 |
| sboyron | good luck ;) | 14:05 |
| sboyron | I tried to point them everytime I found some... | 14:05 |
| hberaud | +1 for the doc line modifed, however the doc site is constantly monitored and I don't expect to lot of failures on this point, I mean this is a rare case | 14:06 |
| hberaud | recheck are acceptable too | 14:06 |
| hberaud | feel free to introduce a related granular check | 14:08 |
| *** jpich has quit IRC | 14:09 | |
| hberaud | in this case I think that some functions of https://review.opendev.org/#/c/756383/ could become a lib for us and our tests instead of stay isolated within this test | 14:10 |
| *** jpich has joined #openstack-rpm-packaging | 14:10 | |
| hberaud | by example retrieve the last commited files is something common | 14:10 |
| hberaud | retrieving a specific modified line could be surrounded by a common feature too | 14:11 |
| hberaud | and our tests could "source" these common libs | 14:11 |
| dirk | The original idea was to use rpm-packaging-tools repo for this | 14:11 |
| hberaud | I see | 14:12 |
| dirk | So far it wasn't worth the cross repo dependency | 14:12 |
| dirk | But we can start that | 14:12 |
| hberaud | on openstack/releases similar things are centralized in our repo | 14:13 |
| dirk | To be honest retrieving the list of modified files is just a one liner | 14:13 |
| hberaud | yep | 14:13 |
| dirk | That's a good point, we need to build some release tooling | 14:14 |
| hberaud | example https://github.com/openstack/releases/blob/master/tools/functions | 14:14 |
| openstackgerrit | Merged openstack/rpm-packaging master: update reno Uniform Resource Locator https://review.opendev.org/757700 | 14:14 |
| hberaud | and an example of usage => https://github.com/openstack/releases/blob/56ad9230f4ec97ca05380699870dcd9531dd0d27/tools/process_auto_releases.sh#L97 | 14:15 |
| dirk | So how about starting a collection of functions? | 14:16 |
| hberaud | sourced here => https://github.com/openstack/releases/blob/56ad9230f4ec97ca05380699870dcd9531dd0d27/tools/process_auto_releases.sh#L35 | 14:16 |
| dirk | When that grows we can take the next step | 14:16 |
| hberaud | it could be a follow up of https://review.opendev.org/#/c/756383/ | 14:16 |
| hberaud | yes sure | 14:16 |
| hberaud | I think it's to early for now | 14:16 |
| dirk | Yep, or start with a functions for this check | 14:17 |
| dirk | Both is fine for me | 14:17 |
| hberaud | but when I see our discussions I imagine that something like this will emerge soon | 14:17 |
| hberaud | as sboyron propose other check with similar functionalities | 14:18 |
| dirk | Yep | 14:18 |
| sboyron | +1 | 14:18 |
| dirk | Let's do it incrementally | 14:18 |
| hberaud | +1 | 14:18 |
| hberaud | that's all for me | 14:18 |
| dirk | I have a topic | 14:19 |
| hberaud | the floor is yours | 14:19 |
| dirk | We still have some older branches around, like newton | 14:19 |
| dirk | And currently suse ci still handles it, although likely not successful | 14:20 |
| hberaud | I think they could be removed | 14:20 |
| jpena | +1 to removing old branches (after tagging their last commit as -eol) | 14:20 |
| hberaud | I seen similar discussion with queens/pike and octavia EM to EOL branches | 14:20 |
| sboyron | yes can be removed | 14:21 |
| hberaud | where octavia faced zuul failures | 14:21 |
| hberaud | due to EOL branches | 14:21 |
| dirk | I suggest to close newton and ocata | 14:21 |
| hberaud | +1 | 14:21 |
| sboyron | +1 | 14:21 |
| dirk | Okay, so I will try to figure out how to push tags | 14:22 |
| hberaud | this is a specific corner case of EM | 14:22 |
| hberaud | previously EOL branches was automatically removed but since EM stale branches remains | 14:23 |
| dirk | Which I think is fine as long as it still has activity | 14:24 |
| jpena | dirk: we can push tags just doing "git push gerrit tag xxxx" after it's created locally | 14:26 |
| hberaud | and as long of QA support if too | 14:26 |
| jpena | you're in the release group, see https://review.opendev.org/#/admin/groups/2109,members | 14:26 |
| hberaud | s/if/it/ | 14:26 |
| jpena | #agreed newton and ocata branches will be closed | 14:27 |
| jpena | if there's nothing else to discuss, we can close the meeting (it's time!) | 14:29 |
| sboyron | nothing from my side | 14:30 |
| dirk | Sounds good | 14:31 |
| dirk | Thanks for the productive meeting! | 14:31 |
| jpena | #endmeeting | 14:31 |
| *** openstack changes topic to "https://etherpad.openstack.org/p/openstack-rpm-packaging - Regular IRC Meeting Thursdays 13:30 PM UTC in openstack-rpm-packaging" | 14:31 | |
| openstack | Meeting ended Thu Nov 5 14:31:39 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:31 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/rpm_packaging/2020/rpm_packaging.2020-11-05-13.32.html | 14:31 |
| jpena | thanks for coming! | 14:31 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/rpm_packaging/2020/rpm_packaging.2020-11-05-13.32.txt | 14:31 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/rpm_packaging/2020/rpm_packaging.2020-11-05-13.32.log.html | 14:31 |
| sboyron | jpena: thx | 14:33 |
| hberaud | jpena: thanks | 14:33 |
| *** jpich has quit IRC | 16:04 | |
| *** jpich has joined #openstack-rpm-packaging | 16:05 | |
| *** jpena is now known as jpena|off | 16:43 | |
| *** ykarel has quit IRC | 17:04 | |
| *** ykarel has joined #openstack-rpm-packaging | 17:05 | |
| *** rpittau is now known as rpittau|afk | 17:21 | |
| *** jpich has quit IRC | 17:24 | |
| *** gyee has joined #openstack-rpm-packaging | 17:35 | |
| *** amoralej is now known as amoralej|off | 17:51 | |
| *** ykarel is now known as ykarel|away | 17:56 | |
| *** ykarel|away has quit IRC | 18:11 | |
| *** sboyron has quit IRC | 21:28 | |
| *** apevec has quit IRC | 22:22 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!