| *** tosky has quit IRC | 00:04 | |
| *** zhiyan_ is now known as zhiyan | 00:20 | |
| *** zhiyan is now known as zhiyan_ | 00:29 | |
| *** ViswaV has quit IRC | 00:31 | |
| *** ViswaV has joined #openstack-sahara | 00:35 | |
| *** IlyaE has quit IRC | 00:41 | |
| *** IlyaE has joined #openstack-sahara | 00:46 | |
| *** zhiyan_ is now known as zhiyan | 00:50 | |
| *** zhiyan is now known as zhiyan_ | 00:59 | |
| *** IlyaE has quit IRC | 01:02 | |
| *** bradd1 has joined #openstack-sahara | 01:08 | |
| *** bradd1 has quit IRC | 01:08 | |
| *** zhiyan_ is now known as zhiyan | 01:09 | |
| *** alazarev has quit IRC | 01:22 | |
| *** ViswaV has quit IRC | 01:25 | |
| *** bradd1 has joined #openstack-sahara | 01:57 | |
| *** ViswaV has joined #openstack-sahara | 02:19 | |
| *** bradd1 has quit IRC | 02:34 | |
| *** ViswaV has quit IRC | 02:37 | |
| *** ViswaV has joined #openstack-sahara | 02:41 | |
| *** ViswaV_ has joined #openstack-sahara | 02:47 | |
| *** ViswaV has quit IRC | 02:50 | |
| *** shakayumi has quit IRC | 02:58 | |
| *** rhodgin has joined #openstack-sahara | 03:05 | |
| *** akuznetsov has joined #openstack-sahara | 03:55 | |
| *** IlyaE has joined #openstack-sahara | 04:58 | |
| *** zhiyan is now known as zhiyan_ | 05:13 | |
| *** zhiyan_ is now known as zhiyan | 05:35 | |
| *** ViswaV_ has quit IRC | 05:43 | |
| *** ghenriks_ has joined #openstack-sahara | 05:46 | |
| *** zhiyan is now known as zhiyan_ | 05:47 | |
| *** alazarev has joined #openstack-sahara | 05:48 | |
| *** ghenriks has quit IRC | 05:49 | |
| *** zhiyan_ is now known as zhiyan | 06:03 | |
| *** zhiyan is now known as zhiyan_ | 06:19 | |
| *** IlyaE has quit IRC | 06:20 | |
| *** zhiyan_ is now known as zhiyan | 06:20 | |
| *** witlessb has joined #openstack-sahara | 06:30 | |
| *** tnovacik has joined #openstack-sahara | 06:32 | |
| *** alazarev has quit IRC | 06:36 | |
| *** bogdando has quit IRC | 06:42 | |
| *** bogdando has joined #openstack-sahara | 06:42 | |
| *** zhiyan is now known as zhiyan_ | 07:06 | |
| *** skolekonov has joined #openstack-sahara | 07:14 | |
| *** zhiyan_ is now known as zhiyan | 07:17 | |
| *** IvanBerezovskiy has joined #openstack-sahara | 07:27 | |
| *** jpich has joined #openstack-sahara | 07:59 | |
| *** tnovacik has quit IRC | 08:04 | |
| *** zhiyan is now known as zhiyan_ | 08:25 | |
| *** zhiyan_ is now known as zhiyan | 08:47 | |
| *** zhiyan is now known as zhiyan_ | 08:49 | |
| *** liusheng has joined #openstack-sahara | 08:54 | |
| *** zhiyan_ is now known as zhiyan | 09:49 | |
| *** zhiyan is now known as zhiyan_ | 09:59 | |
| *** vrovachev has joined #openstack-sahara | 10:02 | |
| *** juice has quit IRC | 10:49 | |
| *** zhiyan_ is now known as zhiyan | 10:50 | |
| *** juice has joined #openstack-sahara | 10:52 | |
| *** zhiyan is now known as zhiyan_ | 10:59 | |
| *** akuznetsov has quit IRC | 11:08 | |
| *** akuznetsov has joined #openstack-sahara | 11:12 | |
| *** tosky has joined #openstack-sahara | 11:12 | |
| *** openstackgerrit has joined #openstack-sahara | 11:18 | |
| *** openstackgerrit has quit IRC | 11:19 | |
| *** openstackgerrit has joined #openstack-sahara | 11:25 | |
| *** ylobankov has joined #openstack-sahara | 11:35 | |
| *** zhiyan_ is now known as zhiyan | 11:51 | |
| *** zhiyan is now known as zhiyan_ | 12:00 | |
| *** openstackgerrit has quit IRC | 12:22 | |
| *** openstackgerrit has joined #openstack-sahara | 12:22 | |
| openstackgerrit | Sergey Kolekonov proposed a change to stackforge/sahara-ci-config: Add HDP2 job https://review.openstack.org/96746 | 12:30 |
|---|---|---|
| *** _elmiko is now known as elmiko | 12:30 | |
| openstackgerrit | Sergey Kolekonov proposed a change to stackforge/sahara-ci-config: Add HDP2 job https://review.openstack.org/96746 | 12:32 |
| openstackgerrit | Sergey Kolekonov proposed a change to stackforge/sahara-ci-config: Add HDP2 job https://review.openstack.org/96746 | 12:40 |
| *** zhiyan_ is now known as zhiyan | 12:51 | |
| *** zhiyan is now known as zhiyan_ | 13:03 | |
| crobertsrh | Anyone have any thoughts on writing unit tests for the dashboard (horizon merge)? The only tests that I see other projects have are the api tests. Currently our sahara api only has a "client" method. Should I go back and rewrite the api so that it exposes all the individual calls and write tests that way, or is there another, less intrusive way I can write the tests? | 13:21 |
| tosky | crobertsrh: https://wiki.openstack.org/wiki/Horizon/Testing/UI | 13:21 |
| jpich | tosky: Note that this link is specific to the integration tests that are still pretty new and being figured out, fwiw | 13:23 |
| crobertsrh | Right. Those will be coming at some point as well. | 13:23 |
| tosky | jpich: but which will be in a better shape in the not so far future, hopefully | 13:23 |
| crobertsrh | any thoughts on ^^, jpich? | 13:24 |
| jpich | crobertsrh: Most panels/dashboards would have a set of unit tests included as well that checks things like the page displays and has the data expected, etc - is this what you're talking about? | 13:24 |
| tosky | crobertsrh: oh, I missed the "unit" word in your message :) | 13:24 |
| crobertsrh | jpich: Oh...maybe I missed those tests. Do you have a pointer to one? | 13:25 |
| crobertsrh | I might just be having a "slow" morning. | 13:25 |
| jpich | tosky: That's the hope! It'd be of course lovely to have, though I'd recommend waiting a bit while things like "how do we handle test data consistently" are figured out... unless you're interested in helping out of course :-) | 13:26 |
| jpich | crobertsrh: Sure! /me looks for a nice one | 13:26 |
| jpich | crobertsrh: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tests.py has a bit too much in it nowadays I suppose. https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/tests.py may be more human parsable | 13:27 |
| jpich | crobertsrh: The first test usually simply check the index page renders correctly (status 200) + with the correct templates | 13:28 |
| crobertsrh | Ah, great. Not sure how I missed those :) | 13:28 |
| jpich | Sleep deprivation? :) | 13:29 |
| crobertsrh | I do have an 18 month old :) | 13:29 |
| crobertsrh | "Where do I find the tests?"....."um, try the file named "tests.py"" | 13:30 |
| crobertsrh | you were very polite though, thanks | 13:30 |
| jpich | crobertsrh: FWIW I wrote http://www.jpichon.net/blog/2013/07/testing-in-horizon/ a year ago when I started learning about Horizon, because I found the whole unit testing very confusing. Maybe you'll find a useful tidbit or two in there too | 13:30 |
| jpich | Otherwise the folks at #openstack-horizon are generally happy to help :-) | 13:30 |
| crobertsrh | I bet I will. Thanks | 13:31 |
| jpich | crobertsrh: We all have slow days ;) | 13:31 |
| crobertsrh | Off hand, can you tell me if our current api/sahara.py is going to be a problem? It only contains "client" and the code currently takes care of everything else. Nobody has mentioned it on a review yet, but it does seem to not be the "horizon" way. | 13:32 |
| crobertsrh | https://review.openstack.org/#/c/86648/21/openstack_dashboard/api/sahara.py | 13:32 |
| jpich | crobertsrh: I'm afraid it's probably going to be brought up yeah | 13:33 |
| crobertsrh | I thought so. I might as well get that reworked sooner rather than later. Thanks. | 13:34 |
| jpich | We use our own thin API layer to protect ourselves (somewhat) from the API evolving and breaking us, it also helps up make "transparent" changes when we know every horizon call will need to adapt the results a little | 13:34 |
| jpich | Well spotted. Good luck :-) | 13:34 |
| crobertsrh | Yeah, it totally makes sense. | 13:35 |
| *** zhiyan_ is now known as zhiyan | 13:54 | |
| *** IlyaE has joined #openstack-sahara | 14:00 | |
| *** zhiyan is now known as zhiyan_ | 14:03 | |
| *** skolekonov has quit IRC | 14:04 | |
| *** skolekonov has joined #openstack-sahara | 14:05 | |
| *** skolekonov has quit IRC | 14:06 | |
| *** skolekonov has joined #openstack-sahara | 14:07 | |
| *** tmckay has joined #openstack-sahara | 14:11 | |
| *** ViswaV has joined #openstack-sahara | 14:18 | |
| *** shakamunyi has joined #openstack-sahara | 14:22 | |
| *** alazarev has joined #openstack-sahara | 14:27 | |
| *** skolekonov has quit IRC | 14:28 | |
| *** skolekonov has joined #openstack-sahara | 14:28 | |
| *** ViswaV has quit IRC | 14:29 | |
| *** rhodgin has quit IRC | 14:31 | |
| openstackgerrit | A change was merged to openstack/sahara: Fixed oozie component name in HDP exception https://review.openstack.org/96622 | 14:31 |
| *** aboutGod has joined #openstack-sahara | 14:33 | |
| *** openstackgerrit has quit IRC | 14:36 | |
| *** openstackgerrit has joined #openstack-sahara | 14:37 | |
| *** aboutGod has left #openstack-sahara | 14:38 | |
| *** ViswaV has joined #openstack-sahara | 14:48 | |
| *** zhiyan_ is now known as zhiyan | 14:55 | |
| *** skolekonov has quit IRC | 15:00 | |
| *** bradd1 has joined #openstack-sahara | 15:00 | |
| *** ViswaV has quit IRC | 15:02 | |
| *** zhiyan is now known as zhiyan_ | 15:04 | |
| *** alazarev has quit IRC | 15:11 | |
| *** rhodgin has joined #openstack-sahara | 15:14 | |
| *** ViswaV has joined #openstack-sahara | 15:26 | |
| *** ViswaV_ has joined #openstack-sahara | 15:27 | |
| *** ViswaV has quit IRC | 15:30 | |
| *** ViswaV has joined #openstack-sahara | 15:50 | |
| *** ViswaV_ has quit IRC | 15:50 | |
| *** alazarev has joined #openstack-sahara | 15:55 | |
| *** zhiyan_ is now known as zhiyan | 15:56 | |
| *** IvanBerezovskiy has left #openstack-sahara | 16:02 | |
| *** mattf is now known as _mattf | 16:03 | |
| *** zhiyan is now known as zhiyan_ | 16:05 | |
| *** tmckay has quit IRC | 16:10 | |
| *** vrovachev has quit IRC | 16:17 | |
| *** shakamunyi has quit IRC | 16:20 | |
| openstackgerrit | Andrew Lazarev proposed a change to openstack/sahara: Sync the latest DB code from oslo-incubator https://review.openstack.org/96592 | 16:24 |
| *** jpich has quit IRC | 16:30 | |
| *** ylobankov has quit IRC | 16:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-saharaclient: Updated from global requirements https://review.openstack.org/96828 | 16:33 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/sahara: Updated from global requirements https://review.openstack.org/96510 | 16:33 |
| *** bradd11 has joined #openstack-sahara | 16:50 | |
| *** bradd1 has quit IRC | 16:53 | |
| *** zhiyan_ is now known as zhiyan | 16:56 | |
| *** tmckay has joined #openstack-sahara | 17:00 | |
| *** alazarev has quit IRC | 17:02 | |
| *** alazarev has joined #openstack-sahara | 17:05 | |
| *** IlyaE has quit IRC | 17:06 | |
| *** zhiyan is now known as zhiyan_ | 17:06 | |
| *** ViswaV has quit IRC | 17:07 | |
| *** ViswaV has joined #openstack-sahara | 17:08 | |
| elmiko | SergeyLukjanov: i'm noticing many reviews recently have no blueprint or bug associated with them, how strict do we want to be about keeping track of theses? | 17:09 |
| *** alazarev has quit IRC | 17:15 | |
| *** sreshetnyak has quit IRC | 17:17 | |
| *** alazarev has joined #openstack-sahara | 17:17 | |
| *** miqui has quit IRC | 17:18 | |
| *** IlyaE has joined #openstack-sahara | 17:24 | |
| *** miqui has joined #openstack-sahara | 17:29 | |
| *** sreshetnyak has joined #openstack-sahara | 17:42 | |
| *** sreshetnyak has quit IRC | 17:44 | |
| *** tellesnobrega_ has joined #openstack-sahara | 17:46 | |
| *** bradd1 has joined #openstack-sahara | 17:49 | |
| *** bradd11 has quit IRC | 17:52 | |
| *** zhiyan_ is now known as zhiyan | 17:57 | |
| *** IlyaE has quit IRC | 18:06 | |
| *** zhiyan is now known as zhiyan_ | 18:06 | |
| *** akuznetsov has quit IRC | 18:07 | |
| *** bradd1 has quit IRC | 18:07 | |
| *** IlyaE has joined #openstack-sahara | 18:09 | |
| *** akuznetsov has joined #openstack-sahara | 18:11 | |
| *** alazarev has quit IRC | 18:23 | |
| *** alazarev has joined #openstack-sahara | 18:36 | |
| *** bradd1 has joined #openstack-sahara | 18:42 | |
| *** sreshetnyak has joined #openstack-sahara | 18:45 | |
| *** IlyaE has quit IRC | 18:49 | |
| *** tellesnobrega_ has left #openstack-sahara | 18:57 | |
| *** zhiyan_ is now known as zhiyan | 18:58 | |
| *** zhiyan is now known as zhiyan_ | 19:07 | |
| *** elmiko has quit IRC | 19:25 | |
| *** bradd1 has quit IRC | 19:26 | |
| *** bradd1 has joined #openstack-sahara | 19:27 | |
| *** elmiko has joined #openstack-sahara | 19:29 | |
| *** akuznetsov has quit IRC | 19:29 | |
| *** alazarev has quit IRC | 19:30 | |
| *** IlyaE has joined #openstack-sahara | 19:44 | |
| *** _mattf is now known as mattf | 19:46 | |
| *** zhiyan_ is now known as zhiyan | 19:59 | |
| *** zhiyan is now known as zhiyan_ | 20:08 | |
| SergeyLukjanov | elmiko, it's better to always have bp or issue | 20:15 |
| SergeyLukjanov | elmiko, if it's non-trivial it's fair to -1 | 20:15 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/python-saharaclient: Remove timeutils from openstack-common.conf https://review.openstack.org/96931 | 20:20 |
| mattf | SergeyLukjanov, tmckay, easy ^^ | 20:21 |
| *** alazarev has joined #openstack-sahara | 20:22 | |
| mattf | alazarev, https://review.openstack.org/96931 easy one | 20:22 |
| SergeyLukjanov | mattf, lgtm | 20:23 |
| alazarev | mattf: +2 | 20:23 |
| tmckay | I got there first so gave it +1 :) | 20:24 |
| elmiko | SergeyLukjanov: ok, thanks | 20:24 |
| elmiko | mattf: -1, where's the bug report... /s | 20:26 |
| mattf | lol | 20:30 |
| dmitryme | elmiko, others: do we really need bug reports / blueprints for ‘internal’ changes? By internal I mean changes which does not concern users like the one above | 20:33 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/python-saharaclient: Update oslo-incubator strutils (and gettextutils) https://review.openstack.org/96934 | 20:33 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/python-saharaclient: Update oslo-incubator importutils https://review.openstack.org/96935 | 20:33 |
| mattf | SergeyLukjanov, alazarev, tmckay (~elmiko) ^^ another easy one | 20:33 |
| dmitryme | elmiko: ok, I’ve noticed you’ve set +1 for the CR, so it was a joke :-) | 20:34 |
| elmiko | dmitryme: yea | 20:34 |
| elmiko | dmitryme: i've been doing some horizon reviews and they seem more strict about bps and bug reports | 20:35 |
| elmiko | my personal feeling is that we should have a bp/br whenever possible, but if it's a one line change maybe not | 20:36 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/python-saharaclient: Update oslo-incubator apiclient.exceptions https://review.openstack.org/96936 | 20:36 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/python-saharaclient: Update oslo-incubator cliutils https://review.openstack.org/96937 | 20:36 |
| elmiko | mattf: can't believe you kicked me off those reviews... /cry | 20:37 |
| mattf | lol | 20:37 |
| *** miqui has quit IRC | 20:38 | |
| *** mattf is now known as _mattf | 20:51 | |
| *** crobertsrh is now known as _crobertsrh | 20:58 | |
| *** zhiyan_ is now known as zhiyan | 20:59 | |
| *** openstackgerrit has quit IRC | 21:01 | |
| *** zhiyan is now known as zhiyan_ | 21:09 | |
| *** IlyaE has quit IRC | 21:13 | |
| *** elmiko is now known as _elmiko | 21:26 | |
| *** IlyaE has joined #openstack-sahara | 21:36 | |
| *** bradd1 has quit IRC | 21:42 | |
| *** bradd1 has joined #openstack-sahara | 21:43 | |
| *** ViswaV has quit IRC | 21:49 | |
| *** ViswaV has joined #openstack-sahara | 21:54 | |
| *** IlyaE has quit IRC | 21:55 | |
| *** zhiyan_ is now known as zhiyan | 22:00 | |
| *** ViswaV has quit IRC | 22:02 | |
| *** zhiyan is now known as zhiyan_ | 22:09 | |
| *** ViswaV has joined #openstack-sahara | 22:12 | |
| *** ViswaV has quit IRC | 22:17 | |
| *** witlessb has quit IRC | 22:18 | |
| *** ViswaV has joined #openstack-sahara | 22:19 | |
| *** ViswaV has quit IRC | 22:28 | |
| *** openstackgerrit has joined #openstack-sahara | 22:31 | |
| *** ViswaV has joined #openstack-sahara | 22:33 | |
| *** openstackgerrit has quit IRC | 22:35 | |
| *** openstackgerrit has joined #openstack-sahara | 22:35 | |
| *** ViswaV has quit IRC | 22:40 | |
| *** ViswaV has joined #openstack-sahara | 22:41 | |
| *** rhodgin has quit IRC | 22:46 | |
| *** zhiyan_ is now known as zhiyan | 23:01 | |
| *** zhiyan is now known as zhiyan_ | 23:10 | |
| *** ViswaV has quit IRC | 23:14 | |
| *** _crobertsrh has left #openstack-sahara | 23:38 | |
| openstackgerrit | Andrew Lazarev proposed a change to openstack/sahara: Migrated unit tests to testtools https://review.openstack.org/96979 | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!