*** tellesnobrega has joined #openstack-sahara | 00:07 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Add indirect VMs access implementation https://review.openstack.org/133590 | 00:15 |
---|---|---|
*** tellesnobrega has quit IRC | 00:17 | |
*** tellesnobrega has joined #openstack-sahara | 00:30 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Fixed pep8 after oslo.db config update https://review.openstack.org/135136 | 00:37 |
*** hogepodge has quit IRC | 01:21 | |
*** hogepodge has joined #openstack-sahara | 01:39 | |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/python-saharaclient: Replacing data_processing with data-processing https://review.openstack.org/135148 | 01:54 |
*** tellesnobrega has quit IRC | 02:21 | |
*** Viswanath has joined #openstack-sahara | 02:38 | |
*** Viswanath has quit IRC | 02:41 | |
*** tellesnobrega has joined #openstack-sahara | 03:17 | |
*** tellesnobrega has quit IRC | 03:52 | |
*** macjack has joined #openstack-sahara | 03:52 | |
*** tellesnobrega has joined #openstack-sahara | 03:53 | |
*** chandankumar has joined #openstack-sahara | 03:57 | |
*** chandankumar has quit IRC | 04:02 | |
*** Networkn3rd has quit IRC | 04:07 | |
*** tellesnobrega has quit IRC | 04:34 | |
openstackgerrit | Merged openstack/sahara: Fixed pep8 after oslo.db config update https://review.openstack.org/135136 | 05:05 |
*** chandankumar has joined #openstack-sahara | 05:36 | |
*** miqui has joined #openstack-sahara | 05:38 | |
*** _crobertsrh has quit IRC | 05:55 | |
*** crobertsrh has joined #openstack-sahara | 06:05 | |
openstackgerrit | Thomas Bechtold proposed openstack/sahara-image-elements: Add openSUSE support for diskimage-create.sh https://review.openstack.org/135176 | 06:14 |
openstackgerrit | Thomas Bechtold proposed openstack/sahara-image-elements: Add openSUSE support for diskimage-create.sh https://review.openstack.org/135176 | 06:29 |
*** Longgeek has joined #openstack-sahara | 06:34 | |
*** k4n0 has joined #openstack-sahara | 06:57 | |
*** macjack has quit IRC | 07:47 | |
*** Longgeek has quit IRC | 07:53 | |
*** Longgeek has joined #openstack-sahara | 07:53 | |
*** Longgeek_ has joined #openstack-sahara | 07:57 | |
*** Longgeek has quit IRC | 08:00 | |
*** Longgeek_ has quit IRC | 08:09 | |
*** Longgeek has joined #openstack-sahara | 08:10 | |
*** miqui has quit IRC | 08:11 | |
*** Longgeek_ has joined #openstack-sahara | 08:14 | |
*** Longgeek has quit IRC | 08:18 | |
*** stannie has joined #openstack-sahara | 08:42 | |
openstackgerrit | Merged stackforge/sahara-ci-config: Fix node label for ui tests https://review.openstack.org/135033 | 08:55 |
*** venza has quit IRC | 09:03 | |
*** venza has joined #openstack-sahara | 09:04 | |
openstackgerrit | Denis Egorenko proposed openstack/sahara-image-elements: Add CentOS-6.6 cloud image https://review.openstack.org/135198 | 09:08 |
*** witlessb has joined #openstack-sahara | 09:24 | |
*** Poornima has joined #openstack-sahara | 09:46 | |
*** tellesnobrega has joined #openstack-sahara | 10:05 | |
*** nikunj2512 has joined #openstack-sahara | 10:08 | |
nikunj2512 | in launch cluster, what does base image means??? | 10:08 |
*** tellesnobrega has quit IRC | 10:16 | |
nikunj2512 | jpich: Will having a "upload keypair" button will be benifical?? | 10:24 |
*** tosky has joined #openstack-sahara | 10:34 | |
*** tellesnobrega has joined #openstack-sahara | 10:47 | |
*** Longgeek_ has quit IRC | 11:04 | |
*** Longgeek has joined #openstack-sahara | 11:05 | |
*** tellesnobrega has quit IRC | 11:10 | |
*** chandan_kumar has joined #openstack-sahara | 11:37 | |
*** chandankumar has quit IRC | 11:40 | |
*** Poornima has quit IRC | 11:43 | |
openstackgerrit | Luigi Toscano proposed stackforge/sahara-ci-config: Explicitly enable/disable all set of tests (every plugin) https://review.openstack.org/134509 | 12:02 |
tellesnobrega_ | alazarev, ping | 12:05 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: And new endpoint and periodic task with events ops https://review.openstack.org/134504 | 12:08 |
openstackgerrit | Abbass Marouni proposed openstack/sahara: Enable HDFS NameNode High Availability with HDP 2.0.6 plugin https://review.openstack.org/132051 | 12:11 |
*** nikunj2512 has quit IRC | 12:19 | |
openstackgerrit | Merged openstack/sahara-dashboard: Refactoring UI tests https://review.openstack.org/109622 | 12:26 |
openstackgerrit | Luigi Toscano proposed stackforge/sahara-ci-config: Explicitly enable/disable all set of tests (every plugin) https://review.openstack.org/134509 | 12:29 |
*** chandan_kumar has quit IRC | 12:32 | |
openstackgerrit | Abbass Marouni proposed openstack/sahara: Enable HDFS NameNode High Availability with HDP 2.0.6 plugin https://review.openstack.org/132051 | 12:36 |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Add tempest tests for python-saharaclient https://review.openstack.org/135272 | 12:43 |
*** chandan_kumar has joined #openstack-sahara | 12:50 | |
*** chandan_kumar has quit IRC | 12:50 | |
*** chandankumar has joined #openstack-sahara | 12:50 | |
*** nikunj2512 has joined #openstack-sahara | 12:54 | |
*** nikunj2512 has left #openstack-sahara | 12:54 | |
*** DenisEgorenko has joined #openstack-sahara | 12:58 | |
*** k4n0 has quit IRC | 13:01 | |
tellesnobrega_ | have you guys set up a multinode devstack with sahara? | 13:06 |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Fixed bug with Hive jobs fail https://review.openstack.org/133952 | 13:07 |
*** stannie1 has joined #openstack-sahara | 13:08 | |
elmiko | tellesnobrega_: i have not, but i think crobertsrh has | 13:13 |
crobertsrh | I have indeed | 13:13 |
openstackgerrit | Ken Chen proposed openstack/sahara: Use first_run to Start Services https://review.openstack.org/134471 | 13:13 |
openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Fix for getting auth url for hadoop-swift https://review.openstack.org/135278 | 13:13 |
crobertsrh | Essentially, I run one machine with "compute only" and the other with "everything" | 13:13 |
tellesnobrega_ | do i need to enable sahara only at the controller node or on all of them? | 13:14 |
crobertsrh | I believe just the controller node. | 13:14 |
tellesnobrega_ | i see | 13:14 |
tellesnobrega_ | how about swift? | 13:14 |
crobertsrh | controller node only, I think. | 13:14 |
crobertsrh | I wish I had my old multinode local.conf handy, but I'm pretty sure I only had the compute services running on my non-controller host. | 13:15 |
crobertsrh | It was probably 6 months ago though. | 13:15 |
crobertsrh | I will brb | 13:15 |
tellesnobrega_ | hum, i'm following the configs from the devstack page, im getting a cinder error | 13:15 |
tellesnobrega_ | ok | 13:15 |
crobertsrh | I don't recall cinder problems, but I suspect a lot might have changed since I tried it. | 13:17 |
tellesnobrega_ | i just found a bug report related to that | 13:18 |
tellesnobrega_ | https://bugs.launchpad.net/devstack/+bug/1393721 | 13:18 |
uvirtbot | Launchpad bug 1393721 in devstack "devstack multinode fails during cinder volume type creation" [Undecided,Confirmed] | 13:18 |
openstackgerrit | Andrey Pavlov proposed openstack/python-saharaclient: Saharaclient tests for tempest https://review.openstack.org/130767 | 13:22 |
tellesnobrega_ | just removing cinder from compute node | 13:24 |
elmiko | is it just a problem with cinder on compute? | 13:25 |
tellesnobrega_ | apparently yes | 13:27 |
tellesnobrega_ | removed and it seems to be working | 13:28 |
elmiko | cool! | 13:34 |
openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Refactoring integration tests for Vanilla 1 plugin https://review.openstack.org/131155 | 13:38 |
openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Enable auto security group for vanilla integration tests https://review.openstack.org/135282 | 13:38 |
openstackgerrit | Andrey Pavlov proposed openstack/python-saharaclient: Saharaclient tests for tempest https://review.openstack.org/130767 | 13:41 |
*** egafford has joined #openstack-sahara | 13:43 | |
*** miqui has joined #openstack-sahara | 14:01 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: And new endpoint and periodic task with events ops https://review.openstack.org/134504 | 14:10 |
*** tmckay has joined #openstack-sahara | 14:19 | |
tellesnobrega_ | elmiko, crobertsrh the multinode worked | 14:29 |
crobertsrh | great! | 14:30 |
elmiko | nice | 14:30 |
*** macjack has joined #openstack-sahara | 14:37 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add provision step in creating cluster with direct engine https://review.openstack.org/134490 | 14:38 |
openstackgerrit | Chad Roberts proposed openstack/sahara: Adding CDH to the list of default plugins https://review.openstack.org/124835 | 14:42 |
*** tosky has quit IRC | 14:45 | |
*** chandankumar has quit IRC | 14:46 | |
*** tosky has joined #openstack-sahara | 14:47 | |
*** Poornima has joined #openstack-sahara | 14:50 | |
*** tmckay1 has joined #openstack-sahara | 14:50 | |
*** tmckay has quit IRC | 14:50 | |
*** Poornima has quit IRC | 14:51 | |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Add tempest tests for python-saharaclient https://review.openstack.org/135272 | 14:52 |
*** Poornima has joined #openstack-sahara | 14:52 | |
openstackgerrit | Michael McCune proposed openstack/sahara-specs: Specification Repository Backlog Refactor https://review.openstack.org/135313 | 14:56 |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Add tempest tests for python-saharaclient https://review.openstack.org/135272 | 15:03 |
*** openstackgerrit has quit IRC | 15:04 | |
*** openstackgerrit has joined #openstack-sahara | 15:04 | |
openstackgerrit | Andrey Pavlov proposed openstack/python-saharaclient: Saharaclient tests for tempest https://review.openstack.org/130767 | 15:14 |
openstackgerrit | Chad Roberts proposed openstack/sahara: Adding CDH to the list of default plugins https://review.openstack.org/124835 | 15:24 |
openstackgerrit | Andrey Pavlov proposed openstack/python-saharaclient: Saharaclient tests for tempest https://review.openstack.org/130767 | 15:33 |
*** chandankumar has joined #openstack-sahara | 15:54 | |
*** mattf is now known as _mattf | 16:03 | |
*** tmckay1 has quit IRC | 16:21 | |
*** Poornima has quit IRC | 16:29 | |
*** Poornima has joined #openstack-sahara | 16:30 | |
*** tmckay has joined #openstack-sahara | 16:36 | |
*** Longgeek has quit IRC | 16:55 | |
tellesnobrega_ | i'm playing here with cluster creation, and i noticed that I cannot edit a node group or cluster template | 16:58 |
tellesnobrega_ | is there a reason for that? | 16:58 |
tellesnobrega_ | i can copy it and create a new one based on the other, but i cant edit it | 16:58 |
elmiko | tellesnobrega_: yes, there is no update for those currently. | 17:00 |
elmiko | we talked about it at summit and i think we are going to fix it this cycle | 17:01 |
tellesnobrega_ | awesome, let me know when that is happening | 17:01 |
tellesnobrega_ | i want to help out | 17:01 |
elmiko | cool | 17:01 |
elmiko | i think there are some problems to work out, like dependent objects referencing updated templates and the like | 17:02 |
tellesnobrega_ | that happens as well when trying to delete | 17:02 |
tellesnobrega_ | i'm not sure, but maybe we could allow recursive delete | 17:02 |
crobertsrh | Yeah. At one point, someone took a crack at a patch set to allow editing (at least in the UI), but I think it eventually got abandoned. | 17:02 |
elmiko | maybe, i think it's something we should bring up at the meeting | 17:03 |
tellesnobrega_ | sure | 17:03 |
tellesnobrega_ | what you think about recursive delete? for example, i want to delete a node group and it deletes all templates and cluster that are using this ng | 17:04 |
tellesnobrega_ | of course that would have to require a confirmation from the user | 17:04 |
elmiko | yea, i dunno, that could get really weird if there are multiple clusters using a node group or something | 17:04 |
tellesnobrega_ | but it may be a good thing, i find kinda "hard" having to remove everything by hand | 17:04 |
*** IvanBerezovskiy has left #openstack-sahara | 17:04 | |
elmiko | agreed, the current workflow needs improvement | 17:05 |
*** egafford has quit IRC | 17:06 | |
*** crobertsrh has quit IRC | 17:14 | |
*** elmiko is now known as elmiko_lunch | 17:17 | |
*** elmiko_lunch is now known as elmiko | 17:17 | |
*** Poornima has quit IRC | 17:37 | |
tellesnobrega_ | hi, i'm getting a weird error when launching a cluster. It fails saying that the publicURL for the network can't be found. I can create instances by hand and access them, but the heat stack fails | 17:39 |
tellesnobrega_ | i listed the services now, and there is no network endpoint | 17:39 |
tellesnobrega_ | elmiko, do you use sahara with nova-network or neutron? | 18:00 |
elmiko | tellesnobrega_: neutron | 18:03 |
*** jodah has quit IRC | 18:03 | |
tellesnobrega_ | i think its better that i start using it as well | 18:03 |
tellesnobrega_ | facing problems with n-net | 18:03 |
*** jodah has joined #openstack-sahara | 18:05 | |
*** crobertsrh has joined #openstack-sahara | 19:12 | |
tmckay | Hi folks, preview item for Thursday meeting. https://review.openstack.org/#/c/130153/ | 19:12 |
tmckay | alazarev, aignatov, SergeyLukjanov, elmiko, _mattf, ^^ | 19:13 |
tmckay | interesting question | 19:13 |
tmckay | I wonder if there is an option to carry a library under the CDH plugin somehow. Rather than make it an openstack requirement | 19:14 |
elmiko | yea, good spot | 19:14 |
tmckay | imho it's up to vendors in general to push libs into Fedora/Ubuntu/Centos if they are going to be listed as requirements | 19:15 |
tmckay | but that's just my opinion | 19:15 |
elmiko | it's a tough question | 19:16 |
tmckay | carrying under the plugin, though, is different. Although I'm not sure how that would work logistically. | 19:16 |
tmckay | It would have to be source in that case, not an rpm | 19:16 |
tmckay | which would be tough to maintain | 19:16 |
elmiko | plus, in this case, the package is in pypi | 19:16 |
tmckay | but, it might bridge the gap until packaging could happen | 19:16 |
tmckay | elmiko, hmm, are global requirements pulled from rpms or pypi? Quote from 3rd comment: | 19:18 |
tmckay | "By adding something to OpenStack global-requirements.txt we are basically demanding that Linux Distros package this for the next release of OpenStack. If they already have, great. If not, we should be cautious of adding it." | 19:19 |
elmiko | tmckay: good question, i imagine it depends on how the requirements are consumed. e.g. how are you installing locally, i think pip is probably the default | 19:19 |
*** egafford has joined #openstack-sahara | 19:23 | |
tmckay | elmiko, that quote is from https://github.com/openstack/requirements/blob/master/README.rst#id1 | 19:28 |
tmckay | I'm unclear on the relationship of pip, rpms, and global requirements | 19:30 |
* elmiko looks | 19:30 | |
elmiko | tmckay: here's my take on the requirements.txt and test-requirements.txt | 19:31 |
elmiko | if you install with `python setup.py install` it will try to install those requirements, likewise you can use pip like `pip install -r requirements.txt` | 19:32 |
elmiko | those are using pip to do the installs, nothing to do with rpm, or deb if using debian/ubuntu | 19:33 |
elmiko | in most cases that i have seen, the version numbers coming out of the requirements file don't always sync up with what the distro provides | 19:33 |
tmckay | right, but this statement that adding a package to global requirements essentially requires the distros to package that requirement for the next OS release suggests non-pip | 19:34 |
tmckay | so, maybe RDO is yum based | 19:35 |
tmckay | for instance | 19:35 |
tmckay | not sure what stack.sh is doing | 19:35 |
elmiko | well yea, i think that's more what Sean is talking about. supporting distros that release full versions of openstack | 19:35 |
elmiko | stack.sh is using pip | 19:35 |
tmckay | that would make sense | 19:36 |
elmiko | if you just install these source repos(Nova, Keystone, Sahara, etc) then you would be doing so outside the normal packagers anyway | 19:36 |
tmckay | haven't dabbled in this stuff before | 19:36 |
elmiko | but if i'm packaging Sahara for Fedora or RDO, then i need to be able to use the packaging system to install because no one wants stuff installed by pip without their knowledge | 19:37 |
tmckay | right | 19:37 |
elmiko | i think that's his main point, with regards to packaging | 19:37 |
tmckay | yeah, that makes perfect sense now that we've chatted about it | 19:40 |
tmckay | taking a look to see how cdh uses cm-api | 19:40 |
tmckay | we could just leave it up to a documentation issue. If you want to run the cdh plugin, go get cm-api on your system. | 19:41 |
*** tosky has quit IRC | 19:41 | |
tmckay | if you're a cloudera fan, you've probably got it already | 19:41 |
elmiko | that sounds like a lot of work for our users. not saying i have a better idea, just opining | 19:42 |
tmckay | agreed. But I'm sensitive to the issue of adding a requirement that is not packaged yet. In that case, someone from the Sahara/CDH community needs to take on the work of packaging for supported OSs | 19:44 |
tmckay | otherwise it breaks anyway | 19:45 |
tmckay | and, *all* of Sahara breaks | 19:45 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/sahara-dashboard: Updated from global requirements https://review.openstack.org/132799 | 19:45 |
tmckay | unless for instance RDO specifically doesn't include the requirement. That would be the only choice | 19:45 |
elmiko | agreed, we most certainly can't include a requirement that is not packaged | 19:45 |
tmckay | # cm_api client is not present in OS requirements | 19:46 |
tmckay | try: | 19:46 |
tmckay | from cm_api import api_client | 19:46 |
tmckay | from cm_api.endpoints import services | 19:46 |
tmckay | except ImportError: | 19:46 |
tmckay | api_client = None | 19:46 |
tmckay | services = None | 19:46 |
tmckay | that's the current solution in Sahara. | 19:46 |
elmiko | unfortunately, that's probably the best we can do for now | 19:46 |
tellesnobrega_ | elmiko, i started devstack with neutron, set not to use floating ips (i need this) and started a cluster. its getting an ip address, but it is never reachable | 19:54 |
tellesnobrega_ | anyone had this problem? | 19:54 |
elmiko | tellesnobrega_: i think without floating ips you might need to enable namespace access. i'm not 100% sure about that though. | 19:55 |
tellesnobrega_ | hum | 20:00 |
openstackgerrit | Chad Roberts proposed openstack/sahara-specs: Adding query filtering support to Sahara https://review.openstack.org/134319 | 20:05 |
crobertsrh | can you ping the server manually? | 20:06 |
crobertsrh | or ssh to it? | 20:06 |
tellesnobrega_ | no | 20:10 |
tellesnobrega_ | trying again after setting use_neutron=True and namespace=True | 20:11 |
crobertsrh | Also, might want to try running a "regular" non-sahara instance to see if it's a neutron problem in general or if it's somehow related to Sahara. | 20:12 |
tellesnobrega_ | will do | 20:13 |
tellesnobrega_ | cant ping to any instance :( | 20:17 |
tellesnobrega_ | dont know what i did wrong | 20:18 |
elmiko | tellesnobrega_: if they don't have floating ips, you would probably need to use the namespace in your ping to hit them | 20:18 |
tellesnobrega_ | so i ping with the instance name? | 20:19 |
elmiko | not quite, you would need to use the namespace created for the instances to route your calls. let me see if i can dig something up | 20:19 |
tellesnobrega_ | thanks | 20:21 |
elmiko | tellesnobrega_: here's a little something, http://www.opencloudblog.com/?p=42 , look at the section "Executing a command in a network namespace" | 20:21 |
elmiko | you will need to determine the namespace created, i think the last time i did this i used the openvswitch commands to dump the namespaces | 20:22 |
*** chandankumar has quit IRC | 20:27 | |
openstackgerrit | Merged openstack/sahara: Fixed auto security group cleanup in case of creation error https://review.openstack.org/134345 | 20:29 |
tellesnobrega_ | elmiko, i have zero experience with this kind of stuff, but i will find my way around | 20:30 |
elmiko | tellesnobrega_: ok, sorry for the brief explanation. it gets pretty deep. | 20:30 |
tellesnobrega_ | i'm reading a presentation from mirantis, explaining how namespaces work | 20:31 |
elmiko | in a nutshell, when using namespaces, the kernel creates a named grouping for the virtual network. you can use this name to access the virtual group. | 20:31 |
elmiko | cool, that's a good start | 20:31 |
*** witlessb has quit IRC | 20:40 | |
*** witlessb has joined #openstack-sahara | 20:40 | |
tmckay | crobertsrh, you know your comment yesterday about 30 lines of code for filtering? | 20:44 |
tmckay | I think you're right | 20:44 |
crobertsrh | heh :) I had faith in you :) | 20:44 |
tmckay | query.filter_by(**search_opts) looks like it will do it | 20:44 |
crobertsrh | awesome. That's pretty close to the db.magicstuff() call that I was thinking of. | 20:45 |
tmckay | we just have to pass the dict down, maybe handle exceptions on crappy search args, and I think that's it | 20:45 |
tmckay | gonna hack a POC for templates or something | 20:46 |
crobertsrh | Way more lines in the spec than code to do the whole thing! | 20:46 |
tmckay | lol, yes | 20:46 |
tmckay | I feel guilty about this | 20:46 |
crobertsrh | We can estimate it as a "medium" and then take a few days off to go and get donuts! | 20:46 |
tmckay | sssh | 20:47 |
crobertsrh | I guess I should get going on the UI side so I don't finish last! | 20:47 |
crobertsrh | Not sure I can beat 30 lines though. Probably about 10 lines per table I want to filter. | 20:47 |
tmckay | my kids race to see who gets their teeth brushed first. I'm over it :) | 20:47 |
crobertsrh | I'll think overtime though to bring that down | 20:47 |
crobertsrh | wow...good problem to have! | 20:48 |
tmckay | they'll compete on anything | 20:48 |
crobertsrh | fastest room cleanup...go! | 20:48 |
tellesnobrega_ | elmiko, i was able to ssh | 20:59 |
elmiko | yay! | 20:59 |
tellesnobrega_ | it was a security groups problem | 20:59 |
elmiko | ahh, well that was easy then =) | 20:59 |
tellesnobrega_ | missing the rule that allowed me ssh | 20:59 |
tellesnobrega_ | or ping | 20:59 |
elmiko | cool, glad you got it worked out | 21:00 |
tellesnobrega_ | better than find out who namespace works from scratch | 21:00 |
tellesnobrega_ | thanks | 21:00 |
tellesnobrega_ | *how | 21:00 |
elmiko | lol, yes. much better | 21:00 |
tellesnobrega_ | i gotta go | 21:02 |
tellesnobrega_ | i will be back later | 21:02 |
crobertsrh | tellesnobrega...if you're using devstack, try putting those rules in your local.sh script. That way you'll never forget them :) | 21:04 |
tellesnobrega_ | will do | 21:05 |
tellesnobrega_ | thanks | 21:05 |
*** stannie has quit IRC | 21:11 | |
*** miqui has quit IRC | 21:44 | |
*** _mattf is now known as mattf | 21:52 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Add indirect VMs access implementation https://review.openstack.org/133590 | 21:55 |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Add indirect VMs access implementation https://review.openstack.org/133590 | 21:58 |
tmckay | crobertsrh, so filtering looks pretty simple. I wonder if we should do any validation of the filter values passed in? | 22:03 |
crobertsrh | Hmm. What do the other servies do? | 22:03 |
tmckay | so, if like me you search for clusters with {'goat': 'cheese'} you get some sqlalchemy-ese saying there is no such entity | 22:04 |
crobertsrh | I assume something is at least preventing sql injection, right? | 22:04 |
tmckay | I don't know | 22:04 |
crobertsrh | empty result sets are fine | 22:04 |
tmckay | I would guess so. It's still wrapped in query.filter_by() | 22:04 |
tmckay | so squash the exception, and return {}? | 22:04 |
crobertsrh | Yeah | 22:05 |
tmckay | that sounds good to me. | 22:05 |
crobertsrh | garbage in -> nothing out | 22:05 |
tmckay | I can key off the particular exception | 22:05 |
tmckay | from the UI, it shouldn't be possible to ask for the wrong thing anyway | 22:05 |
tmckay | crobertsrh, okay, I should be able to post this tomorrow. I might do a patch set for each object type | 22:06 |
tmckay | It will make the review simple | 22:07 |
elmiko | crobertsrh: it shouldn't be possible sql exploit from the url with what we are using. _shouldn't_ being the operative there | 22:07 |
tmckay | otherwise I think people will get lost in all the **kwargs | 22:07 |
crobertsrh | Sounds good. I will probably get the UI done tomorrow too. | 22:07 |
tmckay | elmiko, yeah, I am trusting the query.filter_by() stuff in sqlalchemy is checking | 22:07 |
elmiko | tmckay: i think flask also does filtering on the url requested to properly escape the input | 22:09 |
*** tmckay has left #openstack-sahara | 22:10 | |
*** crobertsrh has quit IRC | 22:12 | |
openstackgerrit | Merged openstack/sahara-specs: Adding query filtering support to Sahara https://review.openstack.org/134319 | 22:16 |
*** egafford has quit IRC | 22:20 | |
openstackgerrit | Merged openstack/sahara-image-elements: Add openSUSE support for diskimage-create.sh https://review.openstack.org/135176 | 22:24 |
*** tellesnobrega has joined #openstack-sahara | 22:33 | |
tellesnobrega | alazarev, i'm working on the data_processing to data-processing bug. In horizon, as you pointed out, we need to change the definition of the service right? | 23:07 |
alazarev | tellesnobrega, yeap | 23:08 |
tellesnobrega | what i'm working on is, changing the definition in saharaclient | 23:08 |
tellesnobrega | horizon and devstack | 23:08 |
alazarev | tellesnobrega, in Sahara it is docs only | 23:08 |
tellesnobrega | i already have a patch for the saharaclient | 23:08 |
tellesnobrega | cool | 23:09 |
tellesnobrega | but it failed, i think the problem is that the devstack that runs the tempest is still using data_processing | 23:09 |
tellesnobrega | so i will submit a patch for devstack first | 23:10 |
alazarev | tellesnobrega, it is good question what should we do with pythonclient | 23:11 |
alazarev | pythonclient is supposed to work with old versions of openstack | 23:11 |
tellesnobrega | thats true | 23:11 |
tellesnobrega | thats what i submitted https://review.openstack.org/#/c/135148/ | 23:12 |
tellesnobrega | but now that you pointed this out, maybe we need to rethink this patch | 23:12 |
tellesnobrega | https://review.openstack.org/#/c/135454/1 the devstack portion of the code | 23:14 |
alazarev | tellesnobrega, voted on both patches | 23:16 |
tellesnobrega | thanks | 23:16 |
tellesnobrega | still horizon to submit | 23:16 |
tellesnobrega | horizon: https://review.openstack.org/135458 | 23:35 |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/python-saharaclient: Replacing data_processing with data-processing https://review.openstack.org/135148 | 23:48 |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Pylint check was broken after pylint update https://review.openstack.org/135464 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!