| *** hdd has quit IRC | 00:06 | |
| *** saneax has quit IRC | 00:21 | |
| openstackgerrit | Colleen Murphy proposed openstack/puppet-sahara: Fix inifile version dependency in metadata https://review.openstack.org/197798 | 01:16 |
|---|---|---|
| *** Poornima has joined #openstack-sahara | 02:57 | |
| *** hdd has joined #openstack-sahara | 02:59 | |
| *** ViswaV has quit IRC | 03:07 | |
| openstackgerrit | lu huichun proposed openstack/sahara: [EDP] Delete edp job if raise exception https://review.openstack.org/196981 | 03:08 |
| *** ViswaV has joined #openstack-sahara | 03:10 | |
| *** ViswaV has quit IRC | 03:41 | |
| *** coolsvap|away is now known as coolsvap | 03:45 | |
| *** ViswaV has joined #openstack-sahara | 03:48 | |
| *** sgotliv has joined #openstack-sahara | 03:52 | |
| *** ViswaV has quit IRC | 04:14 | |
| *** ViswaV has joined #openstack-sahara | 04:20 | |
| *** vgridnev has joined #openstack-sahara | 04:33 | |
| *** nkrinner has joined #openstack-sahara | 04:54 | |
| *** Poornima has quit IRC | 04:56 | |
| *** ViswaV has quit IRC | 04:57 | |
| *** saneax has joined #openstack-sahara | 05:06 | |
| *** hdd has quit IRC | 05:08 | |
| *** Poornima has joined #openstack-sahara | 05:14 | |
| *** saneax has quit IRC | 05:33 | |
| *** saneax has joined #openstack-sahara | 05:34 | |
| *** coolsvap is now known as coolsvap|away | 05:37 | |
| *** coolsvap|away is now known as coolsvap | 05:38 | |
| *** Longgeek has joined #openstack-sahara | 05:52 | |
| *** coolsvap is now known as coolsvap|away | 05:54 | |
| *** coolsvap|away is now known as coolsvap | 06:02 | |
| *** coolsvap is now known as coolsvap|away | 06:16 | |
| *** kun_huang has left #openstack-sahara | 06:24 | |
| *** pino|work has joined #openstack-sahara | 06:27 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add CM API support for enable hdfs HA https://review.openstack.org/195901 | 06:33 |
| *** witlessb has joined #openstack-sahara | 06:43 | |
| *** esikachev has joined #openstack-sahara | 07:07 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: [EDP] Add scheduling EDP jobs in sahara(oozie engine implementation) https://review.openstack.org/182310 | 07:08 |
| *** coolsvap|away has quit IRC | 07:20 | |
| *** coolsvap|away has joined #openstack-sahara | 07:23 | |
| *** vgridnev has quit IRC | 07:33 | |
| openstackgerrit | lu huichun proposed openstack/sahara-specs: [EDP]enable recurrence edp job in sahara https://review.openstack.org/192097 | 08:03 |
| *** esikachev has quit IRC | 08:06 | |
| openstackgerrit | lu huichun proposed openstack/sahara-specs: [EDP]enable recurrence edp job in sahara https://review.openstack.org/192097 | 08:08 |
| *** jamielennox is now known as jamielennox|away | 08:20 | |
| *** esikachev has joined #openstack-sahara | 08:26 | |
| openstackgerrit | Evgeny Sikachev proposed openstack/sahara: [WIP] Add cluster validation https://review.openstack.org/196713 | 08:31 |
| *** jamielennox|away is now known as jamielennox | 08:41 | |
| openstackgerrit | Nikita Konovalov proposed openstack/sahara: Added scaling support for HDP 2.2 https://review.openstack.org/193081 | 08:45 |
| *** Longgeek has quit IRC | 08:52 | |
| *** Longgeek has joined #openstack-sahara | 08:53 | |
| *** esikachev has quit IRC | 09:00 | |
| *** openstackgerrit has quit IRC | 09:19 | |
| *** openstackgerrit has joined #openstack-sahara | 09:20 | |
| openstackgerrit | Merged openstack/sahara: Add CM API support for enable hdfs HA https://review.openstack.org/195901 | 09:20 |
| *** esikachev has joined #openstack-sahara | 09:24 | |
| *** tosky has joined #openstack-sahara | 09:40 | |
| openstackgerrit | Evgeny Sikachev proposed openstack/sahara-specs: Add cluster verification checks https://review.openstack.org/196576 | 09:47 |
| *** esikachev has quit IRC | 09:52 | |
| *** esikachev has joined #openstack-sahara | 09:57 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Implement recommendations for vanilla 2.6.0 https://review.openstack.org/177280 | 09:59 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Enable all plugins in devstack code https://review.openstack.org/197902 | 10:00 |
| openstackgerrit | Evgeny Sikachev proposed openstack/sahara: [WIP] Add cluster validation https://review.openstack.org/196713 | 10:02 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Fix Devstack docs to enable Sahara in-tree plugin https://review.openstack.org/197903 | 10:02 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Fix Devstack docs to enable Sahara in-tree plugin https://review.openstack.org/197903 | 10:05 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Remove bin/ scripts support from in-tree devstack plugin https://review.openstack.org/197905 | 10:10 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: [CDH] Provide ability to configure gateway configs https://review.openstack.org/191830 | 10:10 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Stop creating old service endpoints https://review.openstack.org/197906 | 10:15 |
| openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_execution_update api call https://review.openstack.org/197914 | 10:45 |
| openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_execution_update api call https://review.openstack.org/197914 | 10:47 |
| *** esikachev has quit IRC | 11:02 | |
| *** Poornima has quit IRC | 11:04 | |
| openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_update api call https://review.openstack.org/197924 | 11:25 |
| *** egafford has joined #openstack-sahara | 11:58 | |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: [WIP] Add additional HDP services https://review.openstack.org/195726 | 12:20 |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: [WIP] Add base services support for HDP 2.2 https://review.openstack.org/185100 | 12:20 |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: [WIP] Add EDP services to new HDP plugin https://review.openstack.org/194580 | 12:20 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Implement recommendations for vanilla 2.6.0 https://review.openstack.org/177280 | 12:28 |
| openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Add py34 to envlist https://review.openstack.org/197941 | 12:33 |
| *** nkrinner has quit IRC | 12:38 | |
| *** esikachev has joined #openstack-sahara | 12:59 | |
| *** vgridnev has joined #openstack-sahara | 13:11 | |
| *** Networkn3rd has joined #openstack-sahara | 13:15 | |
| *** saneax has quit IRC | 13:23 | |
| *** esikachev has quit IRC | 13:45 | |
| *** esikachev has joined #openstack-sahara | 13:49 | |
| *** weiting has joined #openstack-sahara | 13:53 | |
| SergeyLukjanov | hey folks, sahara meeting will be in 6 mins | 13:54 |
| venza | hi! today the meeting is at 14UTC or 18UTC ? | 13:54 |
| venza | ok :) | 13:54 |
| *** hdd has joined #openstack-sahara | 13:55 | |
| tosky | SergeyLukjanov: is it time to update the channel topic? | 13:55 |
| tellesnobrega | alt-3 | 13:56 |
| tosky | SergeyLukjanov: "launchpad openid is down" was solved long time ago I think | 13:56 |
| SergeyLukjanov | tosky, good point | 13:56 |
| *** ChanServ sets mode: +o SergeyLukjanov | 13:56 | |
| *** SergeyLukjanov changes topic to "OpenStack Sahara // IRC Meetings - http://eavesdrop.openstack.org/#OpenStack_Data_Processing_(Sahara)_Team_Meeting" | 13:57 | |
| SergeyLukjanov | tosky, done | 13:57 |
| tosky | better, thanks :) | 13:57 |
| openstackgerrit | Merged openstack/sahara: Add bashate check for devstack scripts https://review.openstack.org/197663 | 14:06 |
| openstackgerrit | Evgeny Sikachev proposed openstack/sahara: [WIP] Add cluster verification https://review.openstack.org/196713 | 14:21 |
| tosky | egafford: meeting in #openstack-meeting-3 ! | 14:21 |
| tosky | egafford: NikitaKonovalov found issues with NameNode HA while implementing support for HDP 2.2 | 14:22 |
| egafford | tosky: In meeting now; thanks. | 14:22 |
| degorenko | venza, hi, are you here? | 14:25 |
| venza | yep | 14:26 |
| degorenko | i'm about https://review.openstack.org/#/c/195054/4 | 14:27 |
| venza | yes :) | 14:27 |
| degorenko | okay :) i'll try to explain what i mean | 14:27 |
| degorenko | so, if HADOOP_VERSION is empty you set it with 5.3 - good | 14:27 |
| degorenko | but when this variable already sets to 5.3 - it's wrong | 14:28 |
| degorenko | i don't understand why | 14:28 |
| *** hogepodge has quit IRC | 14:28 | |
| venza | no, if it is already 5.3 I do nothing because of the ;; at the end of the line | 14:28 |
| degorenko | oooh | 14:28 |
| degorenko | sorry man | 14:28 |
| degorenko | you rigth :( | 14:29 |
| venza | no problem! thanks for looking at the code! | 14:29 |
| degorenko | i miss that is new line here | 14:29 |
| * pino|work gives degorenko a hot chocolate cup to make him happier | 14:29 | |
| tosky | degorenko: hi! I was saying right now on the meeting that I will propose a bp/spec to allow the scenario test runner to consume templates directly | 14:30 |
| tosky | degorenko: so that sahara-ci code won't need to replace the keys manually (== less code); how does it sound to you? | 14:31 |
| degorenko | venza, i've started tests on your patch already. :-) | 14:31 |
| degorenko | tosky, hi :-) | 14:31 |
| venza | degorenko: thanks :) | 14:31 |
| degorenko | tosky, actually, i've created new function similar to devstack iniset, named it iniyaml) and this function can set any section with needed value. But if you can propose something, that can help us - welcome :) and how do you want to do this? | 14:32 |
| tosky | degorenko: runner.py already depends on mako, so it should be quite easy to read environement variables and replace the values | 14:33 |
| degorenko | so, this script will do work which for now doing by our sed replacement, right? | 14:34 |
| degorenko | tosky, ^ | 14:34 |
| tosky | degorenko: the only think I'm not sure about is: the current insert_scenario_value in sahara-ci code can also use some parameters like stop_key or sub_key, which won't be supported | 14:34 |
| degorenko | tosky, it's ok. This is just for right replacement inside yaml with correct section | 14:35 |
| tosky | degorenko: I guess that we could just define non ambiguous variable names and forget about that | 14:36 |
| degorenko | tosky, i agree | 14:36 |
| degorenko | but variables like image name or cluster name will take from bash env? | 14:36 |
| tosky | perfect, thanks! Better gather some feedback before than throw out all the specs after writing it | 14:36 |
| degorenko | tosky, but variables like image name or cluster name will take from bash env? | 14:37 |
| tosky | degorenko: I was still thinking if it's easier to take from bash env variables or directly from a file | 14:37 |
| degorenko | tosky, i think, we should not hardcode this variables | 14:38 |
| pino|work | file = better | 14:38 |
| egafford | tosky: +1 any solution that doesn't involve magic envvars. | 14:38 |
| degorenko | :D | 14:38 |
| pino|work | egafford: stop reading my mind over the ocean! | 14:38 |
| egafford | pino|work: We've talked about this. I no longer need to read your mind to know that you hate magic envvars. | 14:39 |
| tosky | uhm, okidoki | 14:39 |
| degorenko | tosky, when you be ready - feel free to add patch on ci-config :) | 14:39 |
| tosky | most of the needed variables are already available in CI environment, they are written down in a special config file | 14:39 |
| tosky | but yeah | 14:39 |
| tosky | oki | 14:39 |
| degorenko | tosky, btw, credentials file should contain templates variable anyway | 14:40 |
| tosky | degorenko: yes, it will be marked as template and the runner will do the magic replacement as well | 14:41 |
| tosky | before using it | 14:41 |
| degorenko | tosky, okay :) | 14:41 |
| tosky | degorenko: I will put in copy in the review for the spec, of course, so you will see all the plan | 14:42 |
| tosky | in a more structured way | 14:42 |
| tosky | thanks all for the feedback! | 14:42 |
| degorenko | tosky, okay, thanks :-) also, we need to decide what are image names and cluster names should be :-) | 14:43 |
| tosky | oh, no, no, also templates, so everything will be decided on the ci :) | 14:43 |
| *** sreshetnyak has quit IRC | 14:44 | |
| degorenko | tosky, oh, great! | 14:44 |
| *** sreshetnyak has joined #openstack-sahara | 14:44 | |
| degorenko | tosky, please add me to review your patches for this, when they will ready :-) thanks | 14:45 |
| tosky | degorenko: sure :) | 14:45 |
| degorenko | venza, job failed. But it is because your patch to sahara is not merged yet. | 14:48 |
| degorenko | i'll try to avoid this problem | 14:49 |
| venza | degorenko: ok | 14:51 |
| SergeyLukjanov | egafford, we have stable releases for sahara-image-elements | 15:00 |
| *** hogepodge has joined #openstack-sahara | 15:01 | |
| SergeyLukjanov | and IMO this images works good | 15:01 |
| *** weiting has quit IRC | 15:01 | |
| elmiko | SergeyLukjanov, egafford, maybe it makes more sense, with regards to validated images, for the project to only release "blessed" images when we do full releases, i.e. Kilo, Juno, etc... | 15:02 |
| elmiko | and just let those stand as reference images when we release prior to summit. so , no point released images. | 15:02 |
| egafford | elmiko: I think allowing point release images (and image-elements) builds when necessary is a good idea. We could find bugs in the service that demand image changes. | 15:03 |
| egafford | But as a general rule, outside of those rare circumstances, I agree. | 15:04 |
| elmiko | egafford: well yea, but my idea is more that during a release cycle, we have experimental images, and only on final release do we have validated images released. | 15:05 |
| elmiko | and then perhaps update those images when we do backport releases, if necessary | 15:05 |
| elmiko | so, for example, during the L cycle we are updating spark. | 15:06 |
| elmiko | we have experimental spark images up somewhere | 15:06 |
| elmiko | then when we release the final Liberty version, we test and release the images associated with the final release of L | 15:06 |
| egafford | SergeyLukjanov: Perhaps I misunderstand; if our problem really is only about master, then I don't think we have a problem. elmiko: Right, and we can use our experimental images in our CI pipelines to make sure we don't fall out of sync. That's all fine. | 15:06 |
| elmiko | that gives us time to validate those images | 15:06 |
| egafford | Okay, I think I was misunderstanding the scope of the problems/suggestions. | 15:07 |
| venza | in a few minutes I will have to go. After the 1.3.1 pathces are in, I will submit the deprecation stuff for 0.9.1 and 1.0.0 | 15:10 |
| venza | and start testing 1.4 | 15:11 |
| *** vgridnev has quit IRC | 15:14 | |
| elmiko | thanks venza ! | 15:14 |
| *** chlong has quit IRC | 15:23 | |
| *** degorenko has quit IRC | 15:33 | |
| pino|work | elmiko: patch series coming: | 15:42 |
| openstackgerrit | Pino Toscano proposed openstack/sahara-image-elements: openjdk: revert to a semi-manual installation https://review.openstack.org/198034 | 15:42 |
| openstackgerrit | Pino Toscano proposed openstack/sahara-image-elements: openjdk: add mappings for openjdk-8 https://review.openstack.org/198035 | 15:42 |
| openstackgerrit | Pino Toscano proposed openstack/sahara-image-elements: openjdk: install openjdk 8 for fedora >= 21 https://review.openstack.org/198036 | 15:42 |
| *** degorenko has joined #openstack-sahara | 15:45 | |
| elmiko | pino|work: awesome! | 15:45 |
| pino|work | slightly uglier than package-installs :/ but at least flexible for adapting to different distro versions | 15:46 |
| pino|work | elmiko: feel free to test at will, even if will doesn't want to test it ;0 | 15:47 |
| pino|work | ;) | 15:47 |
| elmiko | lol | 15:47 |
| openstackgerrit | Merged openstack/sahara: Use right oslo.service entry points https://review.openstack.org/196111 | 15:52 |
| *** pino|work has quit IRC | 16:05 | |
| tosky | what about patching package-installs to use some templates and be flexible for the version? | 16:06 |
| tosky | I guess it would complicate things more | 16:06 |
| * tosky shuts up | 16:06 | |
| elmiko | tosky: you've got templates on the brain ;) | 16:08 |
| tellesnobrega | have you guys seen this http://paste.openstack.org/show/336039/?? | 16:40 |
| elmiko | tellesnobrega: not me | 16:41 |
| tellesnobrega | its happening everytime time i try to create a cluster | 16:43 |
| tellesnobrega | i dont see how that can be related to the changes i'm making | 16:43 |
| tosky | how is that field defined? | 16:43 |
| tosky | in the database | 16:43 |
| * tosky checks | 16:43 | |
| tellesnobrega | sa.Column(sa.String(15)) | 16:44 |
| tellesnobrega | internal_ip = sa.Column(sa.String(15)) | 16:44 |
| tellesnobrega | tosky, ^ | 16:44 |
| egafford | tellesnobrega: Yeah, that's clearly defined for IPv4. | 16:44 |
| tosky | | internal_ip | varchar(15) | YES | | NULL | | | 16:44 |
| tosky | yep | 16:45 |
| tosky | so the question is: how is using IPv6? | 16:45 |
| tosky | and the other question is: is there a bug which tracks IPv6 related-issues for Sahara? | 16:45 |
| egafford | tellesnobrega: You can certainly respin your DB with those columns set to 36 characters, and see if there are other bugs hiding behind this bug. | 16:46 |
| egafford | tellesnobrega: (Anyone can, for that matter.) If it is just a field length issue, then it's a bug and easy fix; if there's more, it's probable a new feature worth more discussion. | 16:47 |
| tellesnobrega | +1 | 16:48 |
| tellesnobrega | i will change the db here and see if it works | 16:48 |
| tellesnobrega | when did the default changed to ipv6? | 16:48 |
| tosky | I don't think the default switched to IPv6; I would investigate more your setup | 16:49 |
| egafford | Oh, wow, are you thinking that Nova changed out from under us? Hope not. That'd be dramatic. | 16:49 |
| egafford | (Or Neutron, I suppose, depending on where you're networking.) | 16:50 |
| tellesnobrega | im gonna check neutron.conf | 16:51 |
| *** esikachev has quit IRC | 16:51 | |
| elmiko | that would be crazy... | 16:52 |
| egafford | elmiko: Ayup. | 16:52 |
| tellesnobrega | there is nothing here explicit to use ipv6 | 16:52 |
| tellesnobrega | that did it | 16:56 |
| tellesnobrega | updated internal_ip and management_ip | 16:57 |
| tellesnobrega | working now | 16:57 |
| tellesnobrega | i get 10.0.0.20 - fd0d:3303:6977:0:f816:3eff:fe2e:2dd8 two ips for the instance | 16:57 |
| *** saneax has joined #openstack-sahara | 17:07 | |
| tellesnobrega | the internal_ip and management_ip is set to the ipv6 | 17:12 |
| tellesnobrega | which is a problem for me... in devstack, the host cant login to the vms | 17:12 |
| tellesnobrega | egafford, elmiko, tosky do you have any clues what happened? i checked nova and neutron, there is no ipv6 specific config | 17:13 |
| elmiko | tellesnobrega: sorry, not specifically. i imagine those values might have been automagically inserted, but i can't imagine by what... | 17:14 |
| tellesnobrega | i like the term automagically | 17:14 |
| tellesnobrega | lol | 17:14 |
| elmiko | =) | 17:14 |
| elmiko | we do has some substitution style commands that take ip address, but i would think if that happened then the host system would need to be configured to return ipv6 | 17:15 |
| elmiko | (that is pure speculation bytw) | 17:15 |
| tosky | linux-based systems by default enables both stacks, so maybe for some reasons both values are returned | 17:15 |
| elmiko | right, i was thinking something along those lines | 17:16 |
| tosky | but I don't know more in the context of OpenStack networking | 17:16 |
| tosky | I didn't have to figh... deal with it | 17:16 |
| elmiko | hehe | 17:17 |
| tellesnobrega | since sahara internal_ip and management_ip is being set to the ipv6 here, the host cant connect to the vms, which is not very good | 17:18 |
| tellesnobrega | maybe i should report a bug regarding the db column size (change from 15 to 36) | 17:18 |
| elmiko | maybe, at least we could discuss it in the bug report | 17:18 |
| elmiko | just be sure to mention the whole ipv6 thing | 17:19 |
| tellesnobrega | sure | 17:20 |
| tosky | I would say that the real issue is choosing the proper IP (4 vs 6), as other things could not work properly then | 17:20 |
| tellesnobrega | +1 | 17:20 |
| tosky | extending the table size is needed, but just fixing it could hide some other issues | 17:20 |
| elmiko | right | 17:21 |
| tellesnobrega | i'm looking at my routers details now, and i found that the interface for the ipv4 is down and the ipv6 is up, for private network | 17:21 |
| tosky | ah | 17:24 |
| tosky | strange | 17:24 |
| tellesnobrega | i'm gonna see if i change that, what happens | 17:25 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara: Allow multiple clusters creation https://review.openstack.org/193586 | 17:26 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara: Allow multiple clusters creation https://review.openstack.org/193586 | 17:45 |
| tellesnobrega | elmiko, egafford ^ if you can take a look | 18:01 |
| tellesnobrega | i'm also submitting the client patch in a bit | 18:01 |
| elmiko | tellesnobrega: ack, i'll take a look later | 18:01 |
| tellesnobrega | sure, np | 18:01 |
| *** logan2 has quit IRC | 18:03 | |
| egafford | tellesnobrega: Took a look. :) | 18:17 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-specs: Use Templates for Scenario Tests Configuration https://review.openstack.org/198085 | 18:35 |
| *** tosky has quit IRC | 18:42 | |
| *** Longgeek has quit IRC | 18:43 | |
| *** Longgeek has joined #openstack-sahara | 18:43 | |
| *** logan2 has joined #openstack-sahara | 18:49 | |
| tellesnobrega | egafford, thanks, working on it now | 18:52 |
| *** Longgeek has quit IRC | 18:54 | |
| egafford | tellesnobrega: NP! | 18:57 |
| *** Longgeek has joined #openstack-sahara | 19:02 | |
| tellesnobrega | egafford, i'm thinking on creating a whole new validator for the multiple clusters case | 19:09 |
| tellesnobrega | will be pretty much the same code as the validator for creating cluster, just don't want to put too much ifs in the first one | 19:10 |
| tellesnobrega | it will solve all your comments | 19:11 |
| *** Longgeek has quit IRC | 19:14 | |
| *** hdd has quit IRC | 19:23 | |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: [DO NOT MERGE] Test change https://review.openstack.org/198103 | 19:31 |
| egafford | tellesnobrega: I don't think you need too much copy code. | 19:31 |
| openstackgerrit | Sergey Lukjanov proposed openstack/python-saharaclient: [DO NOT MERGE] Test change https://review.openstack.org/198104 | 19:32 |
| egafford | tellesnobrega: I think you can reuse the main validator method with one if/else (on get('count')), and just assert that count actually does exist in the multiple clusters case. | 19:33 |
| egafford | Or you can just create a shared private method with all the shared checks, which might be cleaner. | 19:33 |
| tellesnobrega | egafford, i was thinking this second option | 19:34 |
| egafford | tellesnobrega: You have options. :) No need to copy though. Sounds perfectly reasonable. | 19:34 |
| egafford | (If I misunderstood you and you were always planning the shared private method path, then awesome.) | 19:34 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara: Allow multiple clusters creation https://review.openstack.org/193586 | 19:40 |
| tellesnobrega | egafford, at first i did copy to test if would work, than refactoring was the plan | 19:41 |
| tellesnobrega | lol | 19:41 |
| egafford | tellesnobrega: Cool. I'll wait for the refactor to review again. :) | 19:41 |
| tellesnobrega | it is already refactored lol | 19:42 |
| tellesnobrega | i think it is ok now | 19:42 |
| egafford | Oh, I see. Right, looking at the wrong file. Dumbadumb. | 19:42 |
| egafford | Don't Mind Me. | 19:42 |
| tellesnobrega | np | 19:47 |
| elmiko | tellesnobrega: so, where you going to add 'count' to the required properties? | 20:07 |
| elmiko | er *were you | 20:08 |
| elmiko | oh wait, just saw your update | 20:09 |
| egafford | elmiko: Actually, tellesnobrega, you could totally make a new schema now that is a deep copy of the cluster schema with the count field added, and require it there. | 20:10 |
| elmiko | egafford: +1, i think there are other ways to solve without adding a new funct | 20:11 |
| egafford | elmiko: Well, the new funct is actually useful to test duplicate names. | 20:11 |
| egafford | That's not something jsonschema can do. | 20:12 |
| egafford | And, you know, functs are cheap, so long as there's not a ton of duplicate code lying around. | 20:12 |
| elmiko | ok, fair | 20:14 |
| elmiko | and the duplicate names is a good point | 20:14 |
| *** Longgeek has joined #openstack-sahara | 20:14 | |
| egafford | elmiko: Yeah, that's really the only excuse for the function. But it is adequate. :) | 20:15 |
| elmiko | agreed | 20:15 |
| elmiko | yea, the only thing i don't like is breaking the count out separately from the jsonschema stuff. it just introduces brittleness | 20:16 |
| egafford | elmiko: That's fair. | 20:16 |
| *** hogepodge has quit IRC | 20:17 | |
| egafford | elmiko: And if you go too far that route (adding optional fields to a single schema that's made for a bunch of different use cases,) you do end up with a horrifically degenerate object. | 20:18 |
| egafford | elmiko: (Which isn't to say we're there, but.) | 20:18 |
| *** hogepodge has joined #openstack-sahara | 20:18 | |
| elmiko | egafford: true | 20:18 |
| elmiko | egafford: i'm ok with the update of the schema, but akin to what you were saying about functions being cheap, so are variables, might as well just craft a new one and be explicit. but i'm not gonna -1 for that. | 20:19 |
| egafford | All of this is, basically, to say that we agree on everything we're talking about here. :) Yeah, totally. | 20:19 |
| tellesnobrega | egafford, doing it now | 20:19 |
| elmiko | tellesnobrega: lol, i'll save my comment on the review ;) | 20:20 |
| elmiko | (i thought maybe you were out) | 20:20 |
| tellesnobrega | was for a second | 20:20 |
| egafford | elmiko: Maybe variables are cheap where you come from. Up here in Boston there was a recent run on variables; they're up to like $8 a kilo. | 20:20 |
| elmiko | sure, np | 20:20 |
| elmiko | egafford: holy shit! | 20:20 |
| elmiko | 32bit or 64? | 20:21 |
| tellesnobrega | lol | 20:21 |
| egafford | 32bits are only up to around $5. Lotta folks going that way to make ends meet. Sad state of affairs. | 20:22 |
| egafford | Thanks, Obama. | 20:22 |
| elmiko | haha | 20:23 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara: Allow multiple clusters creation https://review.openstack.org/193586 | 20:47 |
| tellesnobrega | elmiko, egafford ^ | 20:47 |
| elmiko | awesome | 20:48 |
| tellesnobrega | elmiko, i hope i can get egafford to +1 this time... its been a hard one to get lol | 20:50 |
| elmiko | haha | 20:50 |
| elmiko | yea, i'm a push-over. egafford is tough! | 20:50 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Fix devstack plugin - sahara repo already cloned https://review.openstack.org/198128 | 20:50 |
| tellesnobrega | lol | 20:50 |
| *** egafford has quit IRC | 20:56 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/python-saharaclient: Allow multiple clusters creation https://review.openstack.org/198130 | 20:58 |
| tellesnobrega | elmiko, if you can take a look at this one as well :) | 20:59 |
| elmiko | ack, still reading the first one | 20:59 |
| tellesnobrega | thanks | 20:59 |
| tellesnobrega | i'm off for today, i will work on the reviews tomorrow, thanks again | 21:00 |
| elmiko | cool, we're out tomorrow for holiday, so see you monday =) | 21:00 |
| openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Use keystone service catalog for getting auth urls https://review.openstack.org/168684 | 21:09 |
| *** Longgeek has quit IRC | 21:20 | |
| *** logan2 has quit IRC | 21:31 | |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: [DO NOT MERGE] Test change https://review.openstack.org/198103 | 21:32 |
| openstackgerrit | Sergey Lukjanov proposed openstack/python-saharaclient: [DO NOT MERGE] Test change https://review.openstack.org/198104 | 21:33 |
| openstackgerrit | Sergey Lukjanov proposed openstack/sahara: Return back devstack exercise to in-tree plugin https://review.openstack.org/198139 | 21:38 |
| *** logan2 has joined #openstack-sahara | 21:56 | |
| openstackgerrit | Merged openstack/sahara: Fix devstack plugin - sahara repo already cloned https://review.openstack.org/198128 | 21:59 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-specs: Use Templates for Scenario Tests Configuration https://review.openstack.org/198085 | 22:11 |
| *** Longgeek has joined #openstack-sahara | 22:17 | |
| *** chlong has joined #openstack-sahara | 22:18 | |
| *** witlessb has quit IRC | 22:22 | |
| *** Longgeek has quit IRC | 22:25 | |
| *** chlong has quit IRC | 23:36 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara: Allow multiple clusters creation https://review.openstack.org/193586 | 23:51 |
| *** hdd has joined #openstack-sahara | 23:54 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/python-saharaclient: Allow multiple clusters creation https://review.openstack.org/198130 | 23:55 |
| *** hdd has quit IRC | 23:57 | |
| *** hdd has joined #openstack-sahara | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!