*** chlong has joined #openstack-sahara | 00:03 | |
*** saneax has quit IRC | 00:04 | |
*** jamielennox is now known as jamielennox|away | 01:08 | |
openstackgerrit | li,chen proposed openstack/sahara: Rename oozie_job_id https://review.openstack.org/205930 | 01:08 |
---|---|---|
openstackgerrit | li,chen proposed openstack/sahara: Add CLUSTER_STATUS https://review.openstack.org/199916 | 01:14 |
openstackgerrit | li,chen proposed openstack/sahara: Remove cluster status change in HDP plugin https://review.openstack.org/203457 | 01:14 |
*** coolsvap|away is now known as coolsvap | 03:40 | |
*** hdd has joined #openstack-sahara | 03:40 | |
*** hdd has quit IRC | 03:46 | |
*** saneax has joined #openstack-sahara | 04:19 | |
*** Poornima has joined #openstack-sahara | 04:37 | |
*** jamielennox|away is now known as jamielennox | 04:38 | |
*** hdd has joined #openstack-sahara | 05:20 | |
*** hdd has quit IRC | 05:27 | |
*** ig0r_ has joined #openstack-sahara | 05:33 | |
*** ig0r_ has quit IRC | 05:53 | |
*** ig0r_ has joined #openstack-sahara | 05:56 | |
*** pcaruana has quit IRC | 06:09 | |
*** saneax has quit IRC | 06:58 | |
*** witlessb has joined #openstack-sahara | 07:06 | |
*** sgotliv has quit IRC | 07:09 | |
*** saneax has joined #openstack-sahara | 07:17 | |
*** pino|work has joined #openstack-sahara | 07:33 | |
*** chlong has quit IRC | 07:38 | |
*** pcaruana has joined #openstack-sahara | 07:40 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-image-elements: Fix version of Centos in Mapr plugin https://review.openstack.org/206344 | 07:51 |
*** jamielennox is now known as jamielennox|away | 07:57 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: [DO NOT MERGE] Workaround for mapr https://review.openstack.org/204548 | 08:22 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Implement ability of creating flavor for scenario tests https://review.openstack.org/203567 | 08:24 |
*** sgotliv has joined #openstack-sahara | 08:50 | |
*** Nikolay_St has joined #openstack-sahara | 09:02 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara-specs: Addding spec for Objects update support in Sahara API https://review.openstack.org/208378 | 09:04 |
*** tosky has joined #openstack-sahara | 09:04 | |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of Hive 1.0 to MapR plugin https://review.openstack.org/208400 | 09:50 |
*** sgotliv has quit IRC | 09:58 | |
*** witlessb_ has joined #openstack-sahara | 10:02 | |
*** sanjayu_ has joined #openstack-sahara | 10:07 | |
*** witlessb has quit IRC | 10:08 | |
*** sanjayu has quit IRC | 10:08 | |
*** logan2 has quit IRC | 10:08 | |
*** witlessb_ is now known as witlessb | 10:08 | |
*** logan2 has joined #openstack-sahara | 10:08 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding clusters_update api call https://review.openstack.org/195024 | 10:28 |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of Mahout 0.10 to MapR plugin https://review.openstack.org/208414 | 10:47 |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of HBase 0.98.12 to MapR plugin https://review.openstack.org/208418 | 10:54 |
*** tmckay has joined #openstack-sahara | 10:55 | |
*** degorenko has joined #openstack-sahara | 10:56 | |
*** pcaruana has quit IRC | 10:57 | |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of Drill 1.1 to MapR plugin https://review.openstack.org/208420 | 11:01 |
*** coolsvap is now known as coolsvap|away | 11:06 | |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of Mahout 0.10 to MapR plugin https://review.openstack.org/208414 | 11:09 |
*** tmckay has quit IRC | 11:11 | |
*** tmckay has joined #openstack-sahara | 11:11 | |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of HBase 0.98.12 to MapR plugin https://review.openstack.org/208418 | 11:13 |
*** sgotliv has joined #openstack-sahara | 11:14 | |
*** pcaruana has joined #openstack-sahara | 11:14 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Small refactoring for vanilla 2 https://review.openstack.org/208424 | 11:15 |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of Drill 1.1 to MapR plugin https://review.openstack.org/208420 | 11:18 |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support of Hadoop 2.7.0 to MapR plugin https://review.openstack.org/208443 | 11:40 |
*** hdd has joined #openstack-sahara | 11:55 | |
*** htruta_ has joined #openstack-sahara | 11:58 | |
*** coolsvap|away is now known as coolsvap | 11:58 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding clusters_update api call https://review.openstack.org/195024 | 12:04 |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_update api call https://review.openstack.org/197924 | 12:05 |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Added support for MapR v5.0.0 https://review.openstack.org/208454 | 12:09 |
*** raildo has joined #openstack-sahara | 12:18 | |
*** chlong has joined #openstack-sahara | 12:35 | |
*** hdd has quit IRC | 12:35 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_update api call https://review.openstack.org/197924 | 12:37 |
*** Poornima has quit IRC | 12:39 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_execution_update api call https://review.openstack.org/197914 | 12:55 |
*** tmckay has quit IRC | 13:03 | |
*** esikachev has joined #openstack-sahara | 13:03 | |
*** esikachev has quit IRC | 13:11 | |
*** esikachev has joined #openstack-sahara | 13:11 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Make starting scripts module for vanilla 2 plugin https://review.openstack.org/208474 | 13:20 |
*** ig0r_ has quit IRC | 13:26 | |
*** ig0r__ has joined #openstack-sahara | 13:33 | |
*** egafford has joined #openstack-sahara | 13:36 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org has been restarted in an attempt to improve performance. | 13:41 | |
*** hdd has joined #openstack-sahara | 13:42 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Drop support of deprecated 2.4.1 Vanilla plugin https://review.openstack.org/206011 | 13:43 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Make starting scripts module for vanilla 2 plugin https://review.openstack.org/208474 | 13:44 |
*** ig0r__ has quit IRC | 13:44 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Make starting scripts module for vanilla 2 plugin https://review.openstack.org/208474 | 13:46 |
*** h00327910__ has quit IRC | 13:48 | |
*** esikachev has quit IRC | 13:48 | |
*** Nikolay_St has quit IRC | 13:49 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara-specs: Addding spec for Objects update support in Sahara API https://review.openstack.org/208378 | 13:54 |
*** esikachev has joined #openstack-sahara | 13:56 | |
*** tmckay has joined #openstack-sahara | 13:57 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Formatting and mounting methods changed for ironic https://review.openstack.org/200483 | 14:00 |
*** saneax has quit IRC | 14:01 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Make starting scripts module for vanilla 2 plugin https://review.openstack.org/208474 | 14:06 |
*** ig0r__ has joined #openstack-sahara | 14:14 | |
openstackgerrit | Andrey Pavlov proposed openstack/sahara: Adding job_binary_internal_update api call https://review.openstack.org/208496 | 14:18 |
*** elmiko_ has joined #openstack-sahara | 14:32 | |
*** elmiko_ is now known as __elmiko | 14:32 | |
*** __elmiko is now known as _el_miko | 14:32 | |
*** _el_miko has left #openstack-sahara | 14:33 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Update vanilla plugin to the latest version https://review.openstack.org/208510 | 14:33 |
openstackgerrit | Merged openstack/sahara: Made 'files' dict as member field of ClusterStack https://review.openstack.org/203271 | 14:42 |
openstackgerrit | Chad Roberts proposed openstack/sahara: Support manila shares as binary store https://review.openstack.org/204690 | 14:48 |
*** barra204 has joined #openstack-sahara | 14:57 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-specs: Add cluster verification checks https://review.openstack.org/196576 | 15:04 |
*** ig0r__ has quit IRC | 15:09 | |
*** barra204 has quit IRC | 15:09 | |
*** pcaruana has quit IRC | 15:13 | |
*** shakamunyi has joined #openstack-sahara | 15:14 | |
*** shakamunyi is now known as barra204 | 15:16 | |
*** esikachev has quit IRC | 15:20 | |
*** barra204 has quit IRC | 15:26 | |
*** saneax has joined #openstack-sahara | 15:34 | |
tmckay | SergeyLukjanov, others, okay the hdp 2.0.6 gate test is becoming a real issue. Can we make it non-voting, and get a volunteer to find the reason for the failure in the meantime? | 15:39 |
tmckay | I would chase hdp on my own devstack but I don't have time at the moment | 15:39 |
tmckay | but, it's slowing down merges quite a bit | 15:39 |
*** barra204 has joined #openstack-sahara | 15:40 | |
openstackgerrit | Trevor McKay proposed stackforge/sahara-ci-config: Temporarily make gate-sahara-nova-heat-hdp_2.0.6-c6.6 non-voting https://review.openstack.org/208538 | 15:51 |
tmckay | there, taking the bull by the horns. Please comment if I did this incorrectly, or if you disagree ^^ | 15:52 |
*** openstackgerrit_ has joined #openstack-sahara | 15:53 | |
openstackgerrit | Trevor McKay proposed openstack/sahara: Remove test for job type in get_data_sources https://review.openstack.org/208542 | 16:00 |
*** ig0r_ has joined #openstack-sahara | 16:08 | |
*** melaks has joined #openstack-sahara | 16:09 | |
*** sgotliv has quit IRC | 16:40 | |
*** tosky has quit IRC | 16:42 | |
*** tosky has joined #openstack-sahara | 16:47 | |
*** ig0r_ has quit IRC | 16:49 | |
*** ig0r_ has joined #openstack-sahara | 16:54 | |
*** ig0r_ has quit IRC | 16:55 | |
*** coolsvap is now known as coolsvap|away | 16:58 | |
openstackgerrit | Merged stackforge/sahara-ci-config: Temporarily make gate-sahara-nova-heat-hdp_2.0.6-c6.6 non-voting https://review.openstack.org/208538 | 17:03 |
*** ig0r_ has joined #openstack-sahara | 17:04 | |
*** pcaruana has joined #openstack-sahara | 17:06 | |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara: Increase internal_ip and management_ip column size https://review.openstack.org/203067 | 17:15 |
*** ig0r_ has quit IRC | 17:25 | |
*** melaks has quit IRC | 17:30 | |
*** chlong has quit IRC | 17:31 | |
*** melaks has joined #openstack-sahara | 17:31 | |
*** ig0r_ has joined #openstack-sahara | 17:33 | |
*** Nikolay_St has joined #openstack-sahara | 17:39 | |
*** ig0r_ has quit IRC | 17:44 | |
*** tosky has quit IRC | 17:54 | |
*** pino|work has quit IRC | 17:54 | |
*** openstackgerrit_ has quit IRC | 18:07 | |
crobertsrh | Is the ci stuff totally hosed at the moment? | 18:29 |
*** melaks has quit IRC | 18:31 | |
tmckay | uh oh | 18:31 |
tmckay | Maybe my merge broke it? | 18:32 |
*** htruta_ has quit IRC | 18:32 | |
tmckay | degorenko, ^^ | 18:32 |
crobertsrh | novaclient.exceptions.BadRequest: Keypair data is invalid: failed to generate fingerprint | 18:32 |
tmckay | oh, that seems different. elmiko ^^ | 18:32 |
crobertsrh | Seems to be same message for all the tests | 18:33 |
crobertsrh | (at least the 3 I've tracked down so far) | 18:33 |
elmiko | weird... | 18:33 |
tmckay | hmm, create_keypair in the scenario tests failing | 18:35 |
tmckay | seems like | 18:35 |
tmckay | I don't think it was me then :) | 18:35 |
elmiko | yea, sounds like a stack or config issue | 18:36 |
*** htruta_ has joined #openstack-sahara | 18:44 | |
*** shakamunyi has joined #openstack-sahara | 18:46 | |
*** esikachev has joined #openstack-sahara | 19:05 | |
tmckay | elmiko, crobertsrh, looks like that issue has to come from nova/nova/crypto.py, generate_fingerprint (based on latest nova source) | 19:07 |
*** sgotliv has joined #openstack-sahara | 19:07 | |
tmckay | that is the only place that "failed to generate fingerprint" shows up | 19:07 |
crobertsrh | oh, did we pick up (or fail to pick up) a new lib somewhere? | 19:07 |
tmckay | don't know. I wonder if we ping on #openstack-nova. Maybe search launchpad first | 19:08 |
*** vgridnev has joined #openstack-sahara | 19:08 | |
tmckay | vgridnev, hi! We were just discussing nova create_keypair failures in Sahara CI | 19:09 |
tmckay | looks like all scenario tests are breaking | 19:09 |
vgridnev | yeah, I see | 19:09 |
tmckay | I thought maybe my change to make hdp non-voting was an issue, but I can't see how it is related | 19:09 |
*** esikachev has quit IRC | 19:09 | |
tmckay | but it was the latest change to the CI | 19:09 |
vgridnev | Seems that CI failures started at about one day ago | 19:10 |
vgridnev | Aslo, CI lab was reinstalled today | 19:11 |
tmckay | ah, okay. Looks like the error is from nova/nova/crypto.py, generate_fingerprint | 19:11 |
crobertsrh | makes sense that the new fingerprints for the new boxes might not match | 19:12 |
tmckay | could even be different serialization of the key, maybe | 19:12 |
tmckay | trouble is we don't have the real exception | 19:12 |
tmckay | hmm, I wonder if there is a way to tweak nova on the CI, and get more information in the reason field for what is going in | 19:13 |
tmckay | "on | 19:13 |
crobertsrh | There probably is, but it's probably painful for us to try :) | 19:14 |
tmckay | vgridnev, ^^ | 19:14 |
elmiko | hmm | 19:14 |
tmckay | it's not a very long routine | 19:14 |
elmiko | did something in nova.crypto change recently? | 19:14 |
elmiko | or did the ci lab reinstall come with new versions of openssl or something? | 19:14 |
elmiko | (or more likely, old versions of openssl) | 19:15 |
tmckay | elmiko, https://review.openstack.org/#/c/197748/ ?? | 19:16 |
tmckay | just merged a few weeks ago | 19:16 |
vgridnev | tmckay, hm, intresting | 19:17 |
elmiko | you think we would have seen it sooner | 19:17 |
tmckay | vgridnev, not sure if there is anything here ^^ but it touches nova crypto and it's recent | 19:17 |
tmckay | oh, you saw :) | 19:17 |
tmckay | ssh_encrypt_text() changed | 19:18 |
elmiko | certinaly sounds plausible | 19:18 |
tmckay | so, maybe something in the Sahara env does not match the nova instance? | 19:18 |
tmckay | like, maybe we're passing ascii instead of unicode, or unicode instead of ascii? | 19:20 |
elmiko | i dunno | 19:22 |
elmiko | this is a 400 coming back from the nova api server | 19:23 |
elmiko | like, novaclient POSTs to create a key, and something about the request is most likely not working | 19:23 |
tmckay | something weird with my repo, I don't seem to be seeing the same code | 19:24 |
tmckay | oh, duh, there were multiple changes | 19:26 |
tmckay | elmiko, so, to answer your question, yes, a whole bunch of stuff has changed in nova crypto lately :) | 19:26 |
vgridnev | which log of nova is most useful? | 19:27 |
vgridnev | I devstack screen | 19:27 |
vgridnev | *In | 19:27 |
tmckay | I don't know, maybe the nova-api log? | 19:27 |
elmiko | i'm looking at http://paste.openstack.org/show/406785/ from a failed test | 19:27 |
elmiko | yea, nova-api is probably a good one. see if we can line up the keypair request to a bad call | 19:28 |
tmckay | right, what I was doing was grepping for "failed to generate fingerprint" in nova code | 19:28 |
tmckay | only place is crypto.generate_finger_print | 19:28 |
tmckay | but the real exception is suppressed | 19:29 |
tmckay | we could hack nova and return the traceback as the reason string :) | 19:29 |
tmckay | or just dump it with traceback.print_exc() but I don't know where it would go | 19:30 |
elmiko | that would be one way, i think it might help to trace back from the 400 returned on the call. find out what endpoint is being hit, then start to drill down | 19:32 |
elmiko | i'm guessing this is the call, http://developer.openstack.org/api-ref-compute-v2.1.html#keypairs-v2.1 | 19:32 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Small refactoring for vanilla 2 https://review.openstack.org/208424 | 19:35 |
elmiko | tmckay: looks like crypto@L151 | 19:37 |
elmiko | assuming that's the call, but i can't imagine what we are passing that could create that | 19:38 |
*** sgotliv has quit IRC | 19:40 | |
elmiko | tmckay: also, is it possible that our novaclient is out of date? | 19:40 |
elmiko | and, has anyone started asking in -nova? | 19:41 |
tmckay | elmiko, yeah, line 151 for sure. I haven't ask in -nova | 19:45 |
elmiko | i'm guessing this is probably going to be an issue on our end, looking at sahara.utils.crypto | 19:45 |
elmiko | which is generating the keypair info that makes the call blow up | 19:45 |
tmckay | yeah, hmm, I wonder if the nova version is available in the CI output. Seems to be I've seen info like that before | 19:45 |
tmckay | ack | 19:46 |
elmiko | yea, would be nice to see the nova logs, but i think we'd need to know what it expects | 19:46 |
elmiko | i mean, to me, a returned 400 means that we sent the wrong thing to the server | 19:47 |
elmiko | which is what the novaclient is telling us | 19:47 |
tmckay | elmiko, well, I have devstack running. I could restack it, then try to do the same thing the scenario tests are doing. | 19:49 |
tmckay | or, is it easy to run the scenario tests on a local stack? I've never tried | 19:49 |
*** raildo has quit IRC | 19:49 | |
tmckay | some tox command, maybe | 19:49 |
elmiko | tmckay: you could try writing a small test to do the same thing as sahara.test.scenario.base@L561 | 19:50 |
tmckay | yeah | 19:50 |
elmiko | should be easy, just use the sahara crypto to generate a keypair, then try to create it with nova client | 19:51 |
tmckay | k, I'll give it a shot. First, restack :) | 19:51 |
elmiko | and make sure to set RECLONE=yes i suppose | 19:53 |
vgridnev | seems that there are nothing intresting in nova-api-logs | 19:54 |
tmckay | elmiko, one better than reclone, rm -rf /opt/stack ;-) | 19:54 |
elmiko | vgridnev: too bad =( | 19:55 |
elmiko | tmckay: nice | 19:55 |
vgridnev | http://paste.openstack.org/show/406791/ | 19:55 |
vgridnev | actually I generated public key using https://github.com/openstack/sahara/blob/master/sahara/utils/crypto.py#L32 | 19:55 |
elmiko | same as the test, not sure why it doesn't like that data | 19:56 |
elmiko | is it possible the trailing newline is screwing things up? | 19:57 |
tmckay | ah, nice. but now if it is reproducible, we can step through the nova code | 19:57 |
elmiko | Generated by Sahara\\n" | 19:57 |
tmckay | hmm, maybe | 19:57 |
tmckay | elmiko, hah! reproducible on by devstack with openstack client and key from Sahara | 20:09 |
tmckay | elmiko, now to jam pdb into nova .... | 20:09 |
tmckay | I love this stuff | 20:09 |
tmckay | wait, did you guys find it already? :) | 20:09 |
elmiko | tmckay: i'm going the other way, generating a keypair and calling nova client | 20:10 |
elmiko | but the nova-api server is being wonky to me | 20:10 |
tmckay | anyone know how to just restart nova in a devstack, without running the whole thing again? | 20:11 |
elmiko | hmm, not off-hand | 20:11 |
elmiko | i think you can restart the httpd service and this will cause a restart | 20:12 |
elmiko | well, of the client code at least | 20:12 |
elmiko | er the api-server that is | 20:12 |
crobertsrh | tmckay: you can stop/restart things from the rejoin-stack.sh window-o-screens | 20:13 |
crobertsrh | find the service you want, then usually ctrl-c | 20:13 |
crobertsrh | up arrow and enter to restart is usually also fine | 20:13 |
tmckay | crobertsrh, screen noob. How do I select one? | 20:14 |
crobertsrh | ctrl-a then " | 20:14 |
crobertsrh | that brings up a screen where you can use up and down arrows to select | 20:14 |
crobertsrh | enter to select | 20:14 |
crobertsrh | ctrl-a, then d to exit the screen session | 20:15 |
tmckay | nice, thanks! | 20:15 |
crobertsrh | np | 20:15 |
tmckay | Traceback (most recent call last): | 20:18 |
tmckay | File "/opt/stack/nova/nova/crypto.py", line 140, in generate_fingerprint | 20:18 |
tmckay | pub_bytes, backends.default_backend()) | 20:18 |
tmckay | File "/usr/lib/python2.7/site-packages/cryptography/hazmat/primitives/serialization.py", line 40, in load_ssh_public_key | 20:18 |
tmckay | 'Key is not in the proper format or contains extra data.') | 20:18 |
tmckay | ValueError: Key is not in the proper format or contains extra data. | 20:18 |
tmckay | elmiko, maybe you're right about the trailing newline, I'll try without it | 20:19 |
elmiko | makes sense | 20:19 |
elmiko | i seem to have lost all endpoints in my catalog, wtf | 20:21 |
tmckay | awesome, inserted pdb into nova, stepping through the code using rejoin.sh. thanks crobertsrh! | 20:24 |
tmckay | so far, don't think it's the newline. Removed with the debugger, same error | 20:25 |
crobertsrh | glad I could help :) | 20:25 |
elmiko | oh wel | 20:25 |
elmiko | i'm gonna jump off this fire brigade then | 20:25 |
tmckay | elmiko, hah! | 20:26 |
tmckay | it's the "Generated by Sahara" | 20:27 |
tmckay | key is split on spaces | 20:27 |
tmckay | it sees this as a key with 5 components instead of 3 | 20:27 |
tmckay | let me verify .... | 20:27 |
elmiko | lol | 20:28 |
elmiko | could be a nova bug then, i think you are allowed to have spaces in that end part | 20:28 |
tmckay | hot darn | 20:29 |
elmiko | might be worth mentioning in -nova | 20:29 |
tmckay | vgridnev, ^^ | 20:29 |
tmckay | "Generated by Sahara" is the culprit | 20:29 |
elmiko | funny | 20:29 |
elmiko | good catch tmckay | 20:29 |
tmckay | question is, do we fix our public key really fast so our tests work? | 20:29 |
tmckay | then ping nova? | 20:30 |
elmiko | hmm | 20:30 |
elmiko | probably | 20:30 |
elmiko | man, my stack is fubar. openstack endpoint list shows nothing, wtf | 20:32 |
elmiko | and novaclient keeps giving 404 | 20:33 |
*** ig0r_ has joined #openstack-sahara | 20:36 | |
vgridnev | let's fix ci first, then ping nova team | 20:37 |
vgridnev | generated_by_sahara is good solution, I think | 20:38 |
elmiko | +1 | 20:40 |
elmiko | assuming there are no other spaces causing issues | 20:41 |
elmiko | tmckay: are you making a patch for the sahara stuff? | 20:49 |
openstackgerrit | Trevor McKay proposed openstack/sahara: Remove spaces from Sahara key comment https://review.openstack.org/208644 | 20:49 |
tmckay | yep :) | 20:49 |
tmckay | probably filing a nova bug too | 20:50 |
elmiko | hehe nice | 20:50 |
tmckay | still unclear whether spaces in the key comment should be allowed | 20:50 |
elmiko | yea, there is probably an rfc about that | 20:50 |
*** ig0r__ has joined #openstack-sahara | 20:50 | |
*** ig0r_ has quit IRC | 20:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/sahara: Updated from global requirements https://review.openstack.org/206854 | 21:03 |
openstackgerrit | Trevor McKay proposed openstack/sahara: Remove spaces from Sahara key comment https://review.openstack.org/208644 | 21:03 |
*** crobertsrh is now known as _crobertsrh | 21:04 | |
elmiko | tmckay: i'm trying to track down an answer about the comment, it might be that spaces are not allowed | 21:05 |
elmiko | by default that field is initialized to user@host | 21:05 |
tmckay | elmiko, dims on -nova found a statement from the rfc that says that the rest of the line should be ignored | 21:06 |
tmckay | elmiko, ie, at the end of the key text everything else should be tossed before it's parsed | 21:06 |
tmckay | so nothing is illegal | 21:06 |
elmiko | ah, very good | 21:06 |
tmckay | elmiko, sims like the split that happens prior to the split in the serializer changed | 21:07 |
tmckay | "seems" | 21:07 |
tmckay | so the comment is never supposed to get that far | 21:07 |
tmckay | elmiko, (04:54:56 PM) dims: tmckay: "The optional comment field continues to the end of the line, and is not used." from sshd man page | 21:07 |
elmiko | yea, sounds like a bug | 21:08 |
elmiko | tmckay: sounds like we've covered all bases | 21:09 |
openstackgerrit | Trevor McKay proposed openstack/sahara: Remove spaces from Sahara key comment https://review.openstack.org/208644 | 21:09 |
tmckay | fixed up my comment, just because | 21:10 |
tmckay | no more changes from me, so the CI has a chance to run :) | 21:10 |
tmckay | elmiko, crobertsrh, that was some awesome debugging. Thank you for the suggestions, I just put the legos together | 21:11 |
tmckay | and vgridnev, for the suggestion to use the key generator method from Sahara utils | 21:11 |
elmiko | tmckay: there might be an upstream crypto bug you can file as well, just tracking it down now | 21:12 |
tmckay | okey doke, I have to run. I'll check in on the CI later. If something goes wrong, feel free to take over my commit\ | 21:13 |
elmiko | tmckay: relavant rfc section https://tools.ietf.org/html/rfc4716#section-3.3.2 | 21:13 |
tmckay | yeah, nothing about spaces in there | 21:14 |
*** tmckay has quit IRC | 21:15 | |
*** ig0r__ has quit IRC | 21:21 | |
vgridnev | elmiko, ci passed | 21:52 |
vgridnev | maybe merge? | 21:52 |
vgridnev | alazarev, ^^ could you please review change https://review.openstack.org/#/c/208644/ and merge that to fix ci? | 21:53 |
alazarev | vgridnev, done | 21:56 |
vgridnev | thanks | 21:56 |
elmiko | cool, bugs filed upstream too and nova has a fix as well lol | 22:00 |
*** hdd has quit IRC | 22:03 | |
*** egafford has quit IRC | 22:22 | |
*** witlessb has quit IRC | 22:22 | |
*** witlessb has joined #openstack-sahara | 22:23 | |
*** witlessb has quit IRC | 22:23 | |
*** shakamunyi has quit IRC | 22:51 | |
*** egafford has joined #openstack-sahara | 23:13 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!