*** sgotliv has quit IRC | 00:11 | |
*** jriveram has quit IRC | 00:17 | |
*** hdd has joined #openstack-sahara | 00:48 | |
*** witlessb has quit IRC | 00:50 | |
*** egafford has joined #openstack-sahara | 01:07 | |
*** hdd has quit IRC | 01:28 | |
*** hdd has joined #openstack-sahara | 01:28 | |
*** egafford has quit IRC | 01:31 | |
*** david-lyle has quit IRC | 01:36 | |
*** egafford has joined #openstack-sahara | 02:12 | |
*** hdd has quit IRC | 02:16 | |
*** egafford has quit IRC | 02:17 | |
*** egafford has joined #openstack-sahara | 02:35 | |
*** egafford has quit IRC | 02:40 | |
*** Taz_ has quit IRC | 03:25 | |
*** tellesnobrega is now known as tellesnobrega_af | 03:33 | |
*** hdd has joined #openstack-sahara | 03:41 | |
zigo | Where should I report bugs for sahara-dashboard stuff? | 03:56 |
---|---|---|
*** Poornima has joined #openstack-sahara | 04:07 | |
*** hdd has quit IRC | 04:23 | |
*** david-lyle has joined #openstack-sahara | 04:25 | |
*** david-lyle has quit IRC | 04:25 | |
*** coolsvap|away is now known as coolsvap | 04:31 | |
*** david-lyle has joined #openstack-sahara | 04:37 | |
*** Poornima has quit IRC | 04:54 | |
*** Poornima has joined #openstack-sahara | 05:12 | |
*** hdd has joined #openstack-sahara | 05:22 | |
openstackgerrit | Jinxing Fang proposed openstack/sahara: Update the devstack.rst document https://review.openstack.org/271688 | 05:31 |
*** nkrinner has joined #openstack-sahara | 06:05 | |
*** vgridnev has joined #openstack-sahara | 06:07 | |
*** sgotliv has joined #openstack-sahara | 06:11 | |
*** hdd has quit IRC | 06:15 | |
*** macjack has quit IRC | 06:32 | |
openstackgerrit | Jaxon Wang proposed openstack/sahara: Refine the code for CDH PluginUtils class https://review.openstack.org/250810 | 06:53 |
openstackgerrit | Jaxon Wang proposed openstack/sahara: Add unit test cases for cdh plugin utils https://review.openstack.org/248068 | 06:53 |
*** vgridnev has quit IRC | 07:00 | |
openstackgerrit | javeme proposed openstack/sahara: Move notifications options into oslo_messaging_notifications https://review.openstack.org/270055 | 07:13 |
*** esikachev has joined #openstack-sahara | 07:23 | |
openstackgerrit | Merged openstack/sahara: Updated from global requirements https://review.openstack.org/272829 | 07:23 |
*** rcernin has joined #openstack-sahara | 07:27 | |
*** chlong_zzz is now known as chlong | 07:31 | |
*** vgridnev has joined #openstack-sahara | 07:38 | |
openstackgerrit | lu huichun proposed openstack/sahara: [EDP] Add suspend_job() for sahara edp engine(oozie implementation) https://review.openstack.org/201448 | 07:45 |
openstackgerrit | lu huichun proposed openstack/sahara: [EDP] Add suspend_job() for sahara edp engine(oozie implementation) https://review.openstack.org/201448 | 07:46 |
openstackgerrit | lu huichun proposed openstack/sahara: Remove vanilla 2.6.0 code https://review.openstack.org/255111 | 07:52 |
*** sgotliv has quit IRC | 08:08 | |
*** vgridnev has quit IRC | 08:36 | |
*** witlessb has joined #openstack-sahara | 08:38 | |
*** vgridnev has joined #openstack-sahara | 08:44 | |
*** vgridnev has quit IRC | 08:46 | |
openstackgerrit | Merged openstack/python-saharaclient: Updated from global requirements https://review.openstack.org/264463 | 09:10 |
*** sgotliv has joined #openstack-sahara | 09:20 | |
*** AndreyPavlov has joined #openstack-sahara | 09:33 | |
*** vgridnev has joined #openstack-sahara | 09:45 | |
*** vgridnev has quit IRC | 09:57 | |
*** vgridnev has joined #openstack-sahara | 09:58 | |
*** vgridnev has quit IRC | 09:58 | |
*** vgridnev has joined #openstack-sahara | 09:59 | |
*** esikachev has quit IRC | 10:11 | |
openstackgerrit | Timur Sufiev proposed openstack/sahara-dashboard: Adapt for all horizon i9n refactoring changes https://review.openstack.org/262747 | 10:12 |
*** esikachev has joined #openstack-sahara | 10:13 | |
*** tellesnobrega_af is now known as tellesnobrega | 10:30 | |
*** tosky has joined #openstack-sahara | 10:34 | |
openstackgerrit | Timur Sufiev proposed openstack/sahara-dashboard: Adapt for all horizon i9n refactoring changes https://review.openstack.org/262747 | 10:58 |
openstackgerrit | lu huichun proposed openstack/sahara: [EDP] Add suspend_job() for sahara edp engine(oozie implementation) https://review.openstack.org/201448 | 11:00 |
*** tellesnobrega is now known as tellesnobrega_af | 11:12 | |
*** pcaruana has joined #openstack-sahara | 11:44 | |
*** egafford has joined #openstack-sahara | 12:01 | |
*** vgridnev has quit IRC | 12:07 | |
*** vgridnev has joined #openstack-sahara | 12:10 | |
openstackgerrit | Matt Riedemann proposed openstack/sahara: Change ignore-errors to ignore_errors https://review.openstack.org/273011 | 12:13 |
*** vgridnev has quit IRC | 12:15 | |
*** vgridnev has joined #openstack-sahara | 12:21 | |
*** pcaruana has quit IRC | 12:37 | |
*** Poornima has quit IRC | 12:54 | |
*** david-lyle has quit IRC | 13:08 | |
*** coolsvap is now known as coolsvap|away | 13:11 | |
*** chlong has quit IRC | 13:15 | |
*** tellesnobrega_af is now known as tellesnobrega | 13:27 | |
*** chlong has joined #openstack-sahara | 13:28 | |
openstackgerrit | Georgy Dyuldin proposed openstack/sahara-dashboard: Add test 'cluster create-delete with fake plugin' https://review.openstack.org/272558 | 13:31 |
*** raildo-afk is now known as raildo | 13:36 | |
*** hdd has joined #openstack-sahara | 13:36 | |
elmiko | zigo: i think we are considering creating a launchpad for sahara-dashboard, but until then you can create them in the sahara launchpad with "[UI]" in the subject | 13:37 |
zigo | elmiko: Thanks. | 13:37 |
*** vgridnev has quit IRC | 13:39 | |
*** vgridnev has joined #openstack-sahara | 13:39 | |
*** hdd has quit IRC | 13:45 | |
*** akuznetsov has joined #openstack-sahara | 13:46 | |
openstackgerrit | Merged openstack/sahara-dashboard: Added duplicate action buttons https://review.openstack.org/262742 | 13:50 |
*** tmckay1 has joined #openstack-sahara | 13:51 | |
*** egafford has quit IRC | 13:52 | |
*** tmckay has quit IRC | 13:54 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-dashboard: ACL support in Sahara UI https://review.openstack.org/253418 | 13:55 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-specs: Cluster verifications spec https://review.openstack.org/270156 | 13:57 |
*** crobertsrh has joined #openstack-sahara | 13:57 | |
elmiko | vgridnev: that cluster verification spec had a minor regression | 13:59 |
vgridnev | elmiko, oh | 13:59 |
elmiko | i added a comment | 13:59 |
vgridnev | I forgot that last edit was done directly in gerrit | 14:00 |
elmiko | no worries | 14:00 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-specs: Cluster verifications spec https://review.openstack.org/270156 | 14:01 |
vgridnev | elmiko, doe | 14:01 |
vgridnev | done* | 14:01 |
elmiko | thanks | 14:01 |
*** tmckay1 has quit IRC | 14:02 | |
*** tmckay has joined #openstack-sahara | 14:02 | |
vgridnev | elmiko, actually I did another update in this spec: don't store history and use ceilometer instead | 14:02 |
elmiko | vgridnev: yup, saw that | 14:05 |
elmiko | sounds like a good idea | 14:05 |
*** david-lyle has joined #openstack-sahara | 14:17 | |
*** _degorenko|afk is now known as degorenko | 14:20 | |
openstackgerrit | Michael Ionkin proposed openstack/python-saharaclient: Keystoneclient to keystoneauth migration https://review.openstack.org/273064 | 14:22 |
*** tellesnobrega is now known as tellesnobrega_af | 14:24 | |
AndreyPavlov | could you guys check this patch and tell me if this approach is ok or not? https://review.openstack.org/#/c/272503 i wrote about it in openstack-dev yesterday. thanks. | 14:29 |
elmiko | AndreyPavlov: i'll take a look | 14:30 |
openstackgerrit | Georgy Dyuldin proposed openstack/sahara-dashboard: Add test 'cluster create-delete with fake plugin' https://review.openstack.org/272558 | 14:30 |
crobertsrh | AndreyPavlov: I kind of like it. We gain clarity and functionality, plus it's not particularly complicated. | 14:31 |
AndreyPavlov | crobertsrh: yep, pretty simple and does what we need, thanks for review) | 14:34 |
openstackgerrit | Andrey Pavlov proposed openstack/python-saharaclient: Example of import/export for ngt https://review.openstack.org/273076 | 14:37 |
openstackgerrit | Michael Ionkin proposed openstack/python-saharaclient: Keystoneclient to keystoneauth migration https://review.openstack.org/273064 | 14:37 |
elmiko | AndreyPavlov: with this patch, you can unset a variable by setting it to None? | 14:37 |
AndreyPavlov | elmiko: yes | 14:38 |
elmiko | thanks | 14:38 |
*** hdd has joined #openstack-sahara | 14:40 | |
*** david-lyle has quit IRC | 14:44 | |
openstackgerrit | Georgy Dyuldin proposed openstack/sahara-dashboard: Add test 'cluster create-delete with fake plugin' https://review.openstack.org/272558 | 14:46 |
*** david-lyle has joined #openstack-sahara | 14:48 | |
*** tellesnobrega_af is now known as tellesnobrega | 14:50 | |
*** akuznetsov has quit IRC | 14:51 | |
*** david-lyle has quit IRC | 14:53 | |
*** egafford has joined #openstack-sahara | 14:54 | |
*** tmckay has quit IRC | 15:01 | |
*** tmckay has joined #openstack-sahara | 15:07 | |
*** hdd has quit IRC | 15:18 | |
*** tosky has quit IRC | 15:21 | |
vgridnev | elmiko, I have another question about health check and API methods. Since we will not store history in DB, we will have the only verification for each cluster. Do we really need additional parameter to get verifications in API? The only purpose of that is to hide health checks, but I'm not sure it worth | 15:21 |
elmiko | hmm | 15:22 |
elmiko | i guess not | 15:23 |
elmiko | if there is no history, and you get the current verification state from the cluster. | 15:23 |
elmiko | vgridnev: will the cluster record show the most recent verification record? | 15:23 |
*** hdd has joined #openstack-sahara | 15:24 | |
vgridnev | yes | 15:24 |
vgridnev | and it will be the only record | 15:24 |
elmiko | then yea, we could probably drop the extra endpoint | 15:24 |
elmiko | unless we want to wrap a call to ceilometer? | 15:25 |
vgridnev | I think not. If user need some history, he use ceilo for that directly | 15:28 |
vgridnev | ok, I going to remove endpoint | 15:30 |
elmiko | ok | 15:30 |
*** jriveram has joined #openstack-sahara | 15:34 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-specs: Cluster verifications spec https://review.openstack.org/270156 | 15:35 |
*** tosky has joined #openstack-sahara | 15:35 | |
*** vgridnev has quit IRC | 15:38 | |
*** esikachev has quit IRC | 15:42 | |
*** vgridnev has joined #openstack-sahara | 15:43 | |
*** nkrinner has quit IRC | 15:44 | |
tmckay | elmiko, vgridnev, crobertsrh, on the subject of filtering ... nova decides exact/substring by field. I think that's a good idea. For instance, substring on tenant doesn't make sense. | 15:45 |
*** crobertsrh has quit IRC | 15:45 | |
tmckay | so, I'm thinking that object by object, we have a set of columns that we add the "like" filter for, the rest are exact | 15:46 |
elmiko | hmm, interesting thought | 15:46 |
tmckay | also, do you like the pattern of adding "blah_blah_get_all_glob" routines (maybe "substring" instead of "glob") in a call chain from the api instead of adding boolean flags to all the existing get_all() routines? I could after all add "substring=False" -- I think that will still work with kwargs, I forget | 15:48 |
tmckay | the point of get_all_glob() was to keep all internal search in sahara unchanged | 15:49 |
tmckay | if we could do it with a flag, though, and same default behavior ... prob better | 15:49 |
elmiko | hmm, i need to think about that one | 15:50 |
elmiko | good suggestion though | 15:51 |
*** AndreyPavlov has quit IRC | 15:51 | |
tmckay | elmiko, think about flag vs new routine, or providing an (optional) explicit set to name substring fields? | 15:52 |
* tmckay goes to try the flag version | 15:52 | |
elmiko | flag v new routine | 15:53 |
*** egafford has quit IRC | 15:58 | |
elmiko | tmckay: if we are going to do this object by object, i wonder if we should create some sort of mapping object to collect all the search types, or maybe add a specialized search function to the objects? | 15:58 |
*** vgridnev has quit IRC | 15:59 | |
*** vgridnev has joined #openstack-sahara | 15:59 | |
*** vgridnev has quit IRC | 15:59 | |
*** egafford has joined #openstack-sahara | 16:00 | |
tmckay | elmiko, maybe. Looping through the search values and adding the % and the like filter is pretty general. | 16:00 |
elmiko | k | 16:00 |
tmckay | I was thinking of just sticking a list inside the blah_blah_get_all_glob() routine in sqlalchemy/api.py, and passing to the filter generating routine | 16:01 |
tmckay | it would be pretty easy to find and edit | 16:01 |
elmiko | ok, easy is nice =) | 16:03 |
*** rcernin has quit IRC | 16:09 | |
*** esikachev has joined #openstack-sahara | 16:13 | |
*** david-lyle has joined #openstack-sahara | 16:14 | |
*** sgotliv has quit IRC | 16:14 | |
tmckay | elmiko, we can see how it looks and tweak the impl if need be. | 16:16 |
elmiko | tmckay: sounds good, let's fight it out on review =) | 16:16 |
tmckay | lol | 16:17 |
elmiko | it's like, in all things, write the code first. then figure out everything else, whether that be spec/review/preso/etc... | 16:17 |
elmiko | ;) | 16:17 |
*** esikachev has quit IRC | 16:37 | |
*** david-lyle has quit IRC | 16:38 | |
*** david-lyle has joined #openstack-sahara | 16:40 | |
openstackgerrit | Michael McCune proposed openstack/sahara-ci-config: fix saharaclient tests for new scenario location https://review.openstack.org/273146 | 16:50 |
elmiko | SergeyLukjanov: would you mind taking a look at ^^ , saharaclient gate tests are broken currently | 16:53 |
openstackgerrit | Michael McCune proposed openstack/sahara-ci-config: fix saharaclient tests for new scenario location https://review.openstack.org/273146 | 16:57 |
*** crobertsrh has joined #openstack-sahara | 16:57 | |
*** crobertsrh has quit IRC | 16:57 | |
*** crobertsrh has joined #openstack-sahara | 16:58 | |
*** AndreyPavlov has joined #openstack-sahara | 17:09 | |
openstackgerrit | Denis Egorenko proposed openstack/sahara-ci-config: Add sahara-ci to sahara-scenario https://review.openstack.org/268150 | 17:15 |
*** tosky has quit IRC | 17:29 | |
*** esikachev has joined #openstack-sahara | 17:30 | |
openstackgerrit | Chad Roberts proposed openstack/sahara-dashboard: Reorganizing cluster panels into tabs https://review.openstack.org/266566 | 17:45 |
*** degorenko is now known as _degorenko|afk | 17:50 | |
*** tosky has joined #openstack-sahara | 17:57 | |
*** rcernin has joined #openstack-sahara | 18:00 | |
*** esikachev has quit IRC | 18:15 | |
openstackgerrit | Chad Roberts proposed openstack/sahara-dashboard: Reorganizing job-related panels into tabs https://review.openstack.org/269778 | 18:26 |
*** sgotliv has joined #openstack-sahara | 19:04 | |
openstackgerrit | Chad Roberts proposed openstack/sahara-dashboard: Reorganizing job and cluster guide pages https://review.openstack.org/270478 | 19:36 |
openstackgerrit | Trevor McKay proposed openstack/sahara: Add substring matching for cluster_templates_list() https://review.openstack.org/232067 | 19:40 |
tmckay | elmiko, crobertsrh, vgridnev, egafford, ^^ what do you think of this call chain as opposed to the previous patch set? Preference? (new routine vs extra flag) | 19:41 |
tmckay | semantics are the same, just bike shedding internals since this would be replicated for all object types in Sahara (so the new routine case makes lots of new routines) | 19:41 |
tmckay | I think I like the flag | 19:42 |
elmiko | tmckay: ack, i'll take a look | 19:42 |
egafford | tmckay: +1 to flag over new routine. It really is an overload of the same function (we wouldn't introduce a new method for, say, pagination, either, and if we did we could end up in permutational crazytown.) | 19:46 |
*** witlessb has quit IRC | 19:46 | |
*** witlessb has joined #openstack-sahara | 19:48 | |
tmckay | egafford, ack, don't know why I did it that way the first time | 19:48 |
tmckay | elmiko, and doing it this way would let us potentially add the "exact" bool to the endpoint | 19:49 |
tmckay | just set substr_search accordingly | 19:49 |
egafford | tmckay: Mm; I mean, it's a somewhat major change to the contract; I can see it as a first impulse, but I do agree that this is a big improvement (esp. as we expand use of this pattern.) | 19:49 |
elmiko | tmckay: so, this is just an internal change? (we don't expose the functionality of switching to the rest api) | 19:52 |
tmckay | elmiko, yes, at this point calls through the REST api just have substring search enabled on certain string fields of particular objects | 19:53 |
tmckay | "name" and "description" are obvious ones, probably plugin_name too | 19:53 |
tmckay | and I'm sure there are others | 19:53 |
elmiko | yea, ok | 19:53 |
tmckay | I haven't added the "list" yet ... | 19:53 |
elmiko | i'm cool with this | 19:53 |
tmckay | cool, thanks, wanted some feedback before I write more :) | 19:54 |
elmiko | np, added a comment to the reivew | 19:54 |
tmckay | thanks | 19:54 |
*** tmckay is now known as tmckay_bbl | 19:55 | |
crobertsrh | tmckay_bbl: Seems pretty reasonable, I like it. | 19:57 |
*** crobertsrh has quit IRC | 19:58 | |
*** crobertsrh has joined #openstack-sahara | 20:02 | |
*** barra204 has quit IRC | 20:06 | |
*** crobertsrh has quit IRC | 20:32 | |
*** rcernin has quit IRC | 21:16 | |
*** raildo is now known as raildo-afk | 21:20 | |
openstackgerrit | Mark Vanderwiel proposed openstack/sahara-dashboard: fix integration test screen shots https://review.openstack.org/273255 | 22:02 |
*** egafford has quit IRC | 22:08 | |
*** AndreyPavlov has quit IRC | 22:38 | |
*** chlong has quit IRC | 23:18 | |
*** chlong has joined #openstack-sahara | 23:30 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!