Wednesday, 2016-01-27

*** sgotliv has quit IRC00:11
*** jriveram has quit IRC00:17
*** hdd has joined #openstack-sahara00:48
*** witlessb has quit IRC00:50
*** egafford has joined #openstack-sahara01:07
*** hdd has quit IRC01:28
*** hdd has joined #openstack-sahara01:28
*** egafford has quit IRC01:31
*** david-lyle has quit IRC01:36
*** egafford has joined #openstack-sahara02:12
*** hdd has quit IRC02:16
*** egafford has quit IRC02:17
*** egafford has joined #openstack-sahara02:35
*** egafford has quit IRC02:40
*** Taz_ has quit IRC03:25
*** tellesnobrega is now known as tellesnobrega_af03:33
*** hdd has joined #openstack-sahara03:41
zigoWhere should I report bugs for sahara-dashboard stuff?03:56
*** Poornima has joined #openstack-sahara04:07
*** hdd has quit IRC04:23
*** david-lyle has joined #openstack-sahara04:25
*** david-lyle has quit IRC04:25
*** coolsvap|away is now known as coolsvap04:31
*** david-lyle has joined #openstack-sahara04:37
*** Poornima has quit IRC04:54
*** Poornima has joined #openstack-sahara05:12
*** hdd has joined #openstack-sahara05:22
openstackgerritJinxing Fang proposed openstack/sahara: Update the devstack.rst document  https://review.openstack.org/27168805:31
*** nkrinner has joined #openstack-sahara06:05
*** vgridnev has joined #openstack-sahara06:07
*** sgotliv has joined #openstack-sahara06:11
*** hdd has quit IRC06:15
*** macjack has quit IRC06:32
openstackgerritJaxon Wang proposed openstack/sahara: Refine the code for CDH PluginUtils class  https://review.openstack.org/25081006:53
openstackgerritJaxon Wang proposed openstack/sahara: Add unit test cases for cdh plugin utils  https://review.openstack.org/24806806:53
*** vgridnev has quit IRC07:00
openstackgerritjaveme proposed openstack/sahara: Move notifications options into oslo_messaging_notifications  https://review.openstack.org/27005507:13
*** esikachev has joined #openstack-sahara07:23
openstackgerritMerged openstack/sahara: Updated from global requirements  https://review.openstack.org/27282907:23
*** rcernin has joined #openstack-sahara07:27
*** chlong_zzz is now known as chlong07:31
*** vgridnev has joined #openstack-sahara07:38
openstackgerritlu huichun proposed openstack/sahara: [EDP] Add suspend_job() for sahara edp engine(oozie implementation)  https://review.openstack.org/20144807:45
openstackgerritlu huichun proposed openstack/sahara: [EDP] Add suspend_job() for sahara edp engine(oozie implementation)  https://review.openstack.org/20144807:46
openstackgerritlu huichun proposed openstack/sahara: Remove vanilla 2.6.0 code  https://review.openstack.org/25511107:52
*** sgotliv has quit IRC08:08
*** vgridnev has quit IRC08:36
*** witlessb has joined #openstack-sahara08:38
*** vgridnev has joined #openstack-sahara08:44
*** vgridnev has quit IRC08:46
openstackgerritMerged openstack/python-saharaclient: Updated from global requirements  https://review.openstack.org/26446309:10
*** sgotliv has joined #openstack-sahara09:20
*** AndreyPavlov has joined #openstack-sahara09:33
*** vgridnev has joined #openstack-sahara09:45
*** vgridnev has quit IRC09:57
*** vgridnev has joined #openstack-sahara09:58
*** vgridnev has quit IRC09:58
*** vgridnev has joined #openstack-sahara09:59
*** esikachev has quit IRC10:11
openstackgerritTimur Sufiev proposed openstack/sahara-dashboard: Adapt for all horizon i9n refactoring changes  https://review.openstack.org/26274710:12
*** esikachev has joined #openstack-sahara10:13
*** tellesnobrega_af is now known as tellesnobrega10:30
*** tosky has joined #openstack-sahara10:34
openstackgerritTimur Sufiev proposed openstack/sahara-dashboard: Adapt for all horizon i9n refactoring changes  https://review.openstack.org/26274710:58
openstackgerritlu huichun proposed openstack/sahara: [EDP] Add suspend_job() for sahara edp engine(oozie implementation)  https://review.openstack.org/20144811:00
*** tellesnobrega is now known as tellesnobrega_af11:12
*** pcaruana has joined #openstack-sahara11:44
*** egafford has joined #openstack-sahara12:01
*** vgridnev has quit IRC12:07
*** vgridnev has joined #openstack-sahara12:10
openstackgerritMatt Riedemann proposed openstack/sahara: Change ignore-errors to ignore_errors  https://review.openstack.org/27301112:13
*** vgridnev has quit IRC12:15
*** vgridnev has joined #openstack-sahara12:21
*** pcaruana has quit IRC12:37
*** Poornima has quit IRC12:54
*** david-lyle has quit IRC13:08
*** coolsvap is now known as coolsvap|away13:11
*** chlong has quit IRC13:15
*** tellesnobrega_af is now known as tellesnobrega13:27
*** chlong has joined #openstack-sahara13:28
openstackgerritGeorgy Dyuldin proposed openstack/sahara-dashboard: Add test 'cluster create-delete with fake plugin'  https://review.openstack.org/27255813:31
*** raildo-afk is now known as raildo13:36
*** hdd has joined #openstack-sahara13:36
elmikozigo: i think we are considering creating a launchpad for sahara-dashboard, but until then you can create them in the sahara launchpad with "[UI]" in the subject13:37
zigoelmiko: Thanks.13:37
*** vgridnev has quit IRC13:39
*** vgridnev has joined #openstack-sahara13:39
*** hdd has quit IRC13:45
*** akuznetsov has joined #openstack-sahara13:46
openstackgerritMerged openstack/sahara-dashboard: Added duplicate action buttons  https://review.openstack.org/26274213:50
*** tmckay1 has joined #openstack-sahara13:51
*** egafford has quit IRC13:52
*** tmckay has quit IRC13:54
openstackgerritVitaly Gridnev proposed openstack/sahara-dashboard: ACL support in Sahara UI  https://review.openstack.org/25341813:55
openstackgerritVitaly Gridnev proposed openstack/sahara-specs: Cluster verifications spec  https://review.openstack.org/27015613:57
*** crobertsrh has joined #openstack-sahara13:57
elmikovgridnev: that cluster verification spec had a minor regression13:59
vgridnevelmiko, oh13:59
elmikoi added a comment13:59
vgridnevI forgot that last edit was done directly in gerrit14:00
elmikono worries14:00
openstackgerritVitaly Gridnev proposed openstack/sahara-specs: Cluster verifications spec  https://review.openstack.org/27015614:01
vgridnevelmiko, doe14:01
vgridnevdone*14:01
elmikothanks14:01
*** tmckay1 has quit IRC14:02
*** tmckay has joined #openstack-sahara14:02
vgridnevelmiko, actually I did another update in this spec: don't store history and use ceilometer instead14:02
elmikovgridnev: yup, saw that14:05
elmikosounds like a good idea14:05
*** david-lyle has joined #openstack-sahara14:17
*** _degorenko|afk is now known as degorenko14:20
openstackgerritMichael Ionkin proposed openstack/python-saharaclient: Keystoneclient to keystoneauth migration  https://review.openstack.org/27306414:22
*** tellesnobrega is now known as tellesnobrega_af14:24
AndreyPavlovcould you guys check this patch and tell me if this approach is ok or not? https://review.openstack.org/#/c/272503 i wrote about it in openstack-dev yesterday. thanks.14:29
elmikoAndreyPavlov: i'll take a look14:30
openstackgerritGeorgy Dyuldin proposed openstack/sahara-dashboard: Add test 'cluster create-delete with fake plugin'  https://review.openstack.org/27255814:30
crobertsrhAndreyPavlov:  I kind of like it.  We gain clarity and functionality, plus it's not particularly complicated.14:31
AndreyPavlovcrobertsrh: yep, pretty simple and does what we need, thanks for review)14:34
openstackgerritAndrey Pavlov proposed openstack/python-saharaclient: Example of import/export for ngt  https://review.openstack.org/27307614:37
openstackgerritMichael Ionkin proposed openstack/python-saharaclient: Keystoneclient to keystoneauth migration  https://review.openstack.org/27306414:37
elmikoAndreyPavlov: with this patch, you can unset a variable by setting it to None?14:37
AndreyPavlovelmiko: yes14:38
elmikothanks14:38
*** hdd has joined #openstack-sahara14:40
*** david-lyle has quit IRC14:44
openstackgerritGeorgy Dyuldin proposed openstack/sahara-dashboard: Add test 'cluster create-delete with fake plugin'  https://review.openstack.org/27255814:46
*** david-lyle has joined #openstack-sahara14:48
*** tellesnobrega_af is now known as tellesnobrega14:50
*** akuznetsov has quit IRC14:51
*** david-lyle has quit IRC14:53
*** egafford has joined #openstack-sahara14:54
*** tmckay has quit IRC15:01
*** tmckay has joined #openstack-sahara15:07
*** hdd has quit IRC15:18
*** tosky has quit IRC15:21
vgridnevelmiko, I have another question about health check and API methods. Since we will not store history in DB, we will have the only verification for each cluster. Do we really need additional parameter to get verifications in API? The only purpose of that is to hide health checks, but I'm not sure it worth15:21
elmikohmm15:22
elmikoi guess not15:23
elmikoif there is no history, and you get the current verification state from the cluster.15:23
elmikovgridnev: will the cluster record show the most recent verification record?15:23
*** hdd has joined #openstack-sahara15:24
vgridnevyes15:24
vgridnevand it will be the only record15:24
elmikothen yea, we could probably drop the extra endpoint15:24
elmikounless we want to wrap a call to ceilometer?15:25
vgridnevI think not. If user need some history, he use ceilo for that directly15:28
vgridnevok, I going to remove endpoint15:30
elmikook15:30
*** jriveram has joined #openstack-sahara15:34
openstackgerritVitaly Gridnev proposed openstack/sahara-specs: Cluster verifications spec  https://review.openstack.org/27015615:35
*** tosky has joined #openstack-sahara15:35
*** vgridnev has quit IRC15:38
*** esikachev has quit IRC15:42
*** vgridnev has joined #openstack-sahara15:43
*** nkrinner has quit IRC15:44
tmckayelmiko, vgridnev, crobertsrh, on the subject of filtering ... nova decides exact/substring by field. I think that's a good idea.  For instance, substring on tenant doesn't make sense.15:45
*** crobertsrh has quit IRC15:45
tmckayso, I'm thinking that object by object, we have a set of columns that we add the "like" filter for, the rest are exact15:46
elmikohmm, interesting thought15:46
tmckayalso, do you like the pattern of adding "blah_blah_get_all_glob" routines (maybe "substring" instead of "glob") in a call chain from the api instead of adding boolean flags to all the existing get_all() routines? I could after all add "substring=False" -- I think that will still work with kwargs, I forget15:48
tmckaythe point of get_all_glob() was to keep all internal search in sahara unchanged15:49
tmckayif we could do it with a flag, though, and same default behavior ... prob better15:49
elmikohmm, i need to think about that one15:50
elmikogood suggestion though15:51
*** AndreyPavlov has quit IRC15:51
tmckayelmiko, think about flag vs new routine, or providing an (optional) explicit set to name substring fields?15:52
* tmckay goes to try the flag version15:52
elmikoflag v new routine15:53
*** egafford has quit IRC15:58
elmikotmckay: if we are going to do this object by object, i wonder if we should create some sort of mapping object to collect all the search types, or maybe add a specialized search function to the objects?15:58
*** vgridnev has quit IRC15:59
*** vgridnev has joined #openstack-sahara15:59
*** vgridnev has quit IRC15:59
*** egafford has joined #openstack-sahara16:00
tmckayelmiko, maybe. Looping through the search values and adding the % and the like filter is pretty general.16:00
elmikok16:00
tmckayI was thinking of just sticking a list inside the blah_blah_get_all_glob() routine in sqlalchemy/api.py, and passing to the filter generating routine16:01
tmckayit would be pretty easy to find and edit16:01
elmikook, easy is nice =)16:03
*** rcernin has quit IRC16:09
*** esikachev has joined #openstack-sahara16:13
*** david-lyle has joined #openstack-sahara16:14
*** sgotliv has quit IRC16:14
tmckayelmiko, we can see how it looks and tweak the impl if need be.16:16
elmikotmckay: sounds good, let's fight it out on review =)16:16
tmckaylol16:17
elmikoit's like, in all things, write the code first. then figure out everything else, whether that be spec/review/preso/etc...16:17
elmiko;)16:17
*** esikachev has quit IRC16:37
*** david-lyle has quit IRC16:38
*** david-lyle has joined #openstack-sahara16:40
openstackgerritMichael McCune proposed openstack/sahara-ci-config: fix saharaclient tests for new scenario location  https://review.openstack.org/27314616:50
elmikoSergeyLukjanov: would you mind taking a look at ^^ , saharaclient gate tests are broken currently16:53
openstackgerritMichael McCune proposed openstack/sahara-ci-config: fix saharaclient tests for new scenario location  https://review.openstack.org/27314616:57
*** crobertsrh has joined #openstack-sahara16:57
*** crobertsrh has quit IRC16:57
*** crobertsrh has joined #openstack-sahara16:58
*** AndreyPavlov has joined #openstack-sahara17:09
openstackgerritDenis Egorenko proposed openstack/sahara-ci-config: Add sahara-ci to sahara-scenario  https://review.openstack.org/26815017:15
*** tosky has quit IRC17:29
*** esikachev has joined #openstack-sahara17:30
openstackgerritChad Roberts proposed openstack/sahara-dashboard: Reorganizing cluster panels into tabs  https://review.openstack.org/26656617:45
*** degorenko is now known as _degorenko|afk17:50
*** tosky has joined #openstack-sahara17:57
*** rcernin has joined #openstack-sahara18:00
*** esikachev has quit IRC18:15
openstackgerritChad Roberts proposed openstack/sahara-dashboard: Reorganizing job-related panels into tabs  https://review.openstack.org/26977818:26
*** sgotliv has joined #openstack-sahara19:04
openstackgerritChad Roberts proposed openstack/sahara-dashboard: Reorganizing job and cluster guide pages  https://review.openstack.org/27047819:36
openstackgerritTrevor McKay proposed openstack/sahara: Add substring matching for cluster_templates_list()  https://review.openstack.org/23206719:40
tmckayelmiko, crobertsrh, vgridnev, egafford, ^^ what do you think of this call chain as opposed to the previous patch set?  Preference? (new routine vs extra flag)19:41
tmckaysemantics are the same, just bike shedding internals since this would be replicated for all object types in Sahara (so the new routine case makes lots of new routines)19:41
tmckayI think I like the flag19:42
elmikotmckay: ack, i'll take a look19:42
egaffordtmckay: +1 to flag over new routine. It really is an overload of the same function (we wouldn't introduce a new method for, say, pagination, either, and if we did we could end up in permutational crazytown.)19:46
*** witlessb has quit IRC19:46
*** witlessb has joined #openstack-sahara19:48
tmckayegafford, ack, don't know why I did it that way the first time19:48
tmckayelmiko, and doing it this way would let us potentially add the "exact" bool to the endpoint19:49
tmckayjust set substr_search accordingly19:49
egaffordtmckay: Mm; I mean, it's a somewhat major change to the contract; I can see it as a first impulse, but I do agree that this is a big improvement (esp. as we expand use of this pattern.)19:49
elmikotmckay: so, this is just an internal change? (we don't expose the functionality of switching to the rest api)19:52
tmckayelmiko, yes, at this point calls through the REST api just have substring search enabled on certain string fields of particular objects19:53
tmckay"name" and "description" are obvious ones, probably plugin_name too19:53
tmckayand I'm sure there are others19:53
elmikoyea, ok19:53
tmckayI haven't added the "list" yet ...19:53
elmikoi'm cool with this19:53
tmckaycool, thanks, wanted some feedback before I write more :)19:54
elmikonp, added a comment to the reivew19:54
tmckaythanks19:54
*** tmckay is now known as tmckay_bbl19:55
crobertsrhtmckay_bbl:  Seems pretty reasonable, I like it.19:57
*** crobertsrh has quit IRC19:58
*** crobertsrh has joined #openstack-sahara20:02
*** barra204 has quit IRC20:06
*** crobertsrh has quit IRC20:32
*** rcernin has quit IRC21:16
*** raildo is now known as raildo-afk21:20
openstackgerritMark Vanderwiel proposed openstack/sahara-dashboard: fix integration test screen shots  https://review.openstack.org/27325522:02
*** egafford has quit IRC22:08
*** AndreyPavlov has quit IRC22:38
*** chlong has quit IRC23:18
*** chlong has joined #openstack-sahara23:30

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!