*** tmckay has joined #openstack-sahara | 01:00 | |
*** tmckay has quit IRC | 01:47 | |
*** houming has joined #openstack-sahara | 02:20 | |
*** SergeyLukjanov has quit IRC | 03:23 | |
*** SergeyLukjanov has joined #openstack-sahara | 03:30 | |
*** nkrinner_afk is now known as nkrinner | 03:56 | |
*** links has joined #openstack-sahara | 04:15 | |
*** pgadiya has joined #openstack-sahara | 04:41 | |
*** sverma has joined #openstack-sahara | 05:14 | |
*** witlessb has joined #openstack-sahara | 05:47 | |
*** Poornima has joined #openstack-sahara | 06:03 | |
*** sgotliv__ has joined #openstack-sahara | 06:17 | |
*** rcernin has joined #openstack-sahara | 06:27 | |
*** pcaruana has joined #openstack-sahara | 06:41 | |
*** tesseract- has joined #openstack-sahara | 06:59 | |
*** jamielennox is now known as jamielennox|away | 07:01 | |
*** anshul has joined #openstack-sahara | 07:21 | |
*** anshul is now known as Guest59963 | 07:22 | |
*** dmk0202 has joined #openstack-sahara | 07:31 | |
*** permalac has joined #openstack-sahara | 07:56 | |
*** itisha has joined #openstack-sahara | 08:28 | |
*** vgridnev_ has joined #openstack-sahara | 08:31 | |
*** vgridnev_ has quit IRC | 08:52 | |
*** esikachev has joined #openstack-sahara | 08:53 | |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Tests for Sahara CLI https://review.openstack.org/334362 | 09:10 |
---|---|---|
*** jamielennox|away is now known as jamielennox | 09:26 | |
*** _degorenko|afk is now known as degorenko | 09:33 | |
*** abalutoiu has joined #openstack-sahara | 09:40 | |
*** pgadiya has quit IRC | 09:43 | |
*** tosky has joined #openstack-sahara | 09:47 | |
*** Poornima has quit IRC | 10:07 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-image-elements: build all images for ambar in gate https://review.openstack.org/334388 | 10:11 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-image-elements: build all images for ambari in gate https://review.openstack.org/334388 | 10:13 |
openstackgerrit | Michael Ionkin proposed openstack/sahara: testcommit https://review.openstack.org/334396 | 10:14 |
*** Poornima has joined #openstack-sahara | 10:16 | |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Added tests with "node group" commands for Sahara cLI https://review.openstack.org/334362 | 10:18 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: [do not review] testcommit https://review.openstack.org/323265 | 10:32 |
*** Poornima has quit IRC | 10:33 | |
openstackgerrit | Michael Ionkin proposed openstack/sahara: testcommit https://review.openstack.org/334396 | 10:34 |
*** Poornima has joined #openstack-sahara | 10:39 | |
*** Poornima has quit IRC | 10:39 | |
*** links has quit IRC | 10:43 | |
*** houming has quit IRC | 10:50 | |
*** houming has joined #openstack-sahara | 10:51 | |
*** links has joined #openstack-sahara | 10:55 | |
openstackgerrit | Merged openstack/sahara-specs: Allow creation of python topologies for Storm https://review.openstack.org/333003 | 10:59 |
*** esikachev has quit IRC | 11:16 | |
*** Poornima has joined #openstack-sahara | 11:30 | |
*** houming has quit IRC | 11:42 | |
*** agireud has quit IRC | 11:45 | |
*** esikachev has joined #openstack-sahara | 11:46 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: [do not review] freeze warlock https://review.openstack.org/334434 | 11:57 |
openstackgerrit | Tang Chen proposed openstack/python-saharaclient: Use osc_lib instead of cliff https://review.openstack.org/334438 | 12:00 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 12:02 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: [do not review] freeze warlock https://review.openstack.org/334434 | 12:04 |
*** rodrigods has quit IRC | 12:06 | |
*** rodrigods has joined #openstack-sahara | 12:06 | |
openstackgerrit | Tang Chen proposed openstack/python-saharaclient: Use osc_lib instead of cliff https://review.openstack.org/334438 | 12:07 |
vgridnev | pgadia, around? | 12:13 |
vgridnev | hm, seems no | 12:13 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 12:15 |
*** agireud has joined #openstack-sahara | 12:16 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 12:16 |
tosky | uhm, what if we move sahara_cli_tests under sahara_tempest_plugin/tests/cli ? We could then share the configuration for the tests that could require it (like the plugin used) | 12:16 |
vgridnev | tosky, what kind of configuration we want to share? | 12:25 |
tosky | vgridnev: the plugin used; see my comment in https://review.openstack.org/334362 | 12:25 |
vgridnev | uh, fake plugin | 12:26 |
tosky | the idea is to make the (future) tests working with any available plugins | 12:27 |
vgridnev | I guess it will be available for cluster creation since newton | 12:27 |
tosky | moreover, in fact those tests are tempest tests (using tempest APIs) | 12:27 |
tosky | also, related to this, we could import the tests in sahara (sahara/tests/tempest/scenario/data_processing), so that we could have only one tempest plugin | 12:28 |
tosky | now the question is the usual: cherry-pick or proper history import if SergeyLukjanov is available? | 12:29 |
vgridnev | tosky, I not sure we will find him, he is busy with internal tasks mostly | 12:30 |
tosky | I can imagine | 12:30 |
vgridnev | how many commits do we have? | 12:30 |
tosky | 19 | 12:31 |
vgridnev | it's much if we just pushing that | 12:31 |
vgridnev | tosky, can we just enable simple job (pep8 I guess) and cherry-pick changes? | 12:33 |
vgridnev | or it's bad idea? | 12:34 |
tosky | well, if there are no other infra-cores available... | 12:34 |
tosky | unless I can get some of them | 12:35 |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Added tests with "node group" commands for Sahara CLI https://review.openstack.org/334362 | 12:35 |
openstackgerrit | Mikhail Lelyakin proposed openstack/sahara-dashboard: Resolve bug with long time for loading node group template page https://review.openstack.org/333273 | 12:37 |
tosky | one thing at a time; let me see if I can find some infra-cores | 12:37 |
tosky | but for the CLI tests, so, what do you think about this possible move? | 12:37 |
vgridnev | tosky, how to run them (CLI tests) | 12:38 |
vgridnev | ? | 12:38 |
vgridnev | as separate job, or with tempest tests? | 12:38 |
openstackgerrit | Mikhail Lelyakin proposed openstack/sahara-dashboard: Resolve bug with long time for loading node group template page https://review.openstack.org/333273 | 12:38 |
tosky | vgridnev: like any other tempest tests; if you want to run only them you need to specify a custom pattern | 12:39 |
tosky | so we could keep a separate job too | 12:39 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 12:41 |
vgridnev | btw, If we have them in same place, we should be sure that we can run them together (no collision in names, for example) | 12:42 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: [do not review] testcommit https://review.openstack.org/323265 | 12:42 |
*** tmckay has joined #openstack-sahara | 12:43 | |
tosky | ack, sure; I don't think it should be a problem, as afaik the name comes also from the path | 12:44 |
*** _crobertsrh is now known as crobertsrh | 12:57 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 13:02 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 13:04 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: plugins api impl https://review.openstack.org/333374 | 13:05 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 13:12 |
*** nkrinner is now known as nkrinner_afk | 13:13 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: plugins api impl https://review.openstack.org/333374 | 13:14 |
openstackgerrit | Merged openstack/sahara-ci-config: Added publisher script and job https://review.openstack.org/328180 | 13:17 |
*** egafford has joined #openstack-sahara | 13:32 | |
*** sverma has quit IRC | 13:42 | |
vgridnev | egafford, you are welcome to review base patches of plugins api https://review.openstack.org/#/q/status:open+project:openstack/sahara+branch:master+topic:bp/plugin-management-api | 13:47 |
egafford | vgridnev: Cool; I'll look at those today (probably in about 2 hours.) Thanks! | 13:48 |
*** sverma has joined #openstack-sahara | 13:55 | |
*** tosky has quit IRC | 13:56 | |
openstackgerrit | Mikhail Lelyakin proposed openstack/sahara-dashboard: Fix bug with detailed error on node groupe deletion https://review.openstack.org/333926 | 14:07 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: sleep before waiting requests https://review.openstack.org/334178 | 14:10 |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Added tests with "node group" commands for Sahara CLI https://review.openstack.org/334362 | 14:13 |
*** vgridnev has quit IRC | 14:23 | |
*** Poornima has quit IRC | 14:27 | |
*** vgridnev has joined #openstack-sahara | 14:28 | |
openstackgerrit | Merged openstack/sahara-image-elements: build all images for ambari in gate https://review.openstack.org/334388 | 14:47 |
openstackgerrit | Mikhail Lelyakin proposed openstack/sahara: Code refactoring in oozie Workflow creators https://review.openstack.org/330398 | 14:48 |
*** sverma has quit IRC | 14:55 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Fix command for running publisher script https://review.openstack.org/334518 | 14:55 |
*** esikachev has quit IRC | 14:59 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: plugins api impl https://review.openstack.org/333374 | 15:01 |
*** esikachev has joined #openstack-sahara | 15:04 | |
*** krotscheck is now known as krotscheck_dcm | 15:05 | |
*** tellesnobrega is now known as tellesnobrega_af | 15:20 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Fix command for running publisher script https://review.openstack.org/334518 | 15:22 |
*** dmk0202 has quit IRC | 15:30 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: [do not review] testcommit https://review.openstack.org/323265 | 15:32 |
*** pcaruana has quit IRC | 15:38 | |
*** tesseract- has quit IRC | 15:40 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Fix typpo in glance command https://review.openstack.org/334540 | 15:46 |
*** links has quit IRC | 15:52 | |
*** tosky has joined #openstack-sahara | 15:52 | |
openstackgerrit | Mikhail Lelyakin proposed openstack/sahara-dashboard: Fix service configuration view for node groups https://review.openstack.org/334545 | 15:56 |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Added tests with "node group" commands for Sahara CLI https://review.openstack.org/334362 | 15:57 |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Added tests with "node group" commands for Sahara CLI https://review.openstack.org/334362 | 16:07 |
openstackgerrit | Merged openstack/sahara-ci-config: Fix command for running publisher script https://review.openstack.org/334518 | 16:20 |
openstackgerrit | Merged openstack/sahara-ci-config: Fix typpo in glance command https://review.openstack.org/334540 | 16:38 |
*** Guest59963 has quit IRC | 16:46 | |
*** degorenko is now known as _degorenko|afk | 16:54 | |
*** abalutoiu has quit IRC | 17:01 | |
openstackgerrit | Alina Nesterova proposed openstack/sahara-tests: Added cli-tests for cluster and cluster template commands https://review.openstack.org/334567 | 17:01 |
openstackgerrit | Michael Ionkin proposed openstack/sahara: Fix glanceclient.v2.images https://review.openstack.org/334569 | 17:06 |
*** _elmiko is now known as elmiko | 17:07 | |
elmiko | vgridnev: hey, heads up, i will miss the meeting this week. i am at a conference | 17:07 |
*** ukaynar has joined #openstack-sahara | 17:10 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara-ci-config: Removing of Mapr 5.5.0 for scripts https://review.openstack.org/334574 | 17:13 |
*** itisha has quit IRC | 17:20 | |
*** akuznetsov has joined #openstack-sahara | 17:28 | |
*** esikachev has quit IRC | 17:31 | |
*** abalutoiu has joined #openstack-sahara | 17:37 | |
egafford | vgridnev: Wow, sahara.plugins.labels is super dense. Haven't had a really challenging review in a while. :) | 17:52 |
*** egafford has quit IRC | 18:01 | |
*** egafford has joined #openstack-sahara | 18:07 | |
*** elmiko is now known as _elmiko | 18:26 | |
*** akuznetsov has quit IRC | 18:33 | |
*** egafford has quit IRC | 18:34 | |
*** rcernin has quit IRC | 18:34 | |
*** zemuvier has quit IRC | 18:36 | |
*** tellesnobrega_af is now known as tellesnobrega | 18:44 | |
*** esikachev has joined #openstack-sahara | 18:48 | |
*** egafford has joined #openstack-sahara | 18:53 | |
*** egafford has quit IRC | 18:54 | |
*** egafford has joined #openstack-sahara | 18:56 | |
*** egafford has quit IRC | 18:56 | |
*** egafford has joined #openstack-sahara | 18:56 | |
*** rcernin has joined #openstack-sahara | 19:03 | |
*** tmckay has quit IRC | 19:08 | |
*** ukaynar has quit IRC | 19:14 | |
*** tellesnobrega is now known as tellesnobrega_af | 19:27 | |
vgridnev | elmiko, ack | 19:40 |
vgridnev | egafford, maybe. the only though that I have, that probably labels.json is not good idea | 19:41 |
egafford | vgridnev: Yeah, I'm not a huge fan of labels.json. | 19:42 |
vgridnev | about your note at https://review.openstack.org/#/c/332043/1 , None will returned if there is no matching version | 19:42 |
egafford | It seems to me that most of that should be pushed into the plugins (and just kept as flat constants without label substitution.) | 19:42 |
egafford | Right, that's a really really minor note. | 19:42 |
egafford | I understand the flow (and that None will be returned.) The method just doesn't do anything with 'res' unless version exists in the plugin, so there's not a reason to call as_resource unless the version exists. | 19:43 |
egafford | It's incredibly trivial, and not worth worrying about unless someone has negative feedback. | 19:43 |
vgridnev | egafford, I did not got you at all | 19:48 |
vgridnev | how you will write this method? | 19:49 |
egafford | vgridnev: I looked at it again and understood what you're saying. Removed that objection; +2. | 19:49 |
egafford | Still have some concerns about some complexity that doesn't seem needed in the api patch; the others lgtm. | 19:50 |
*** esikachev has quit IRC | 19:53 | |
*** tmckay has joined #openstack-sahara | 19:56 | |
*** esikachev has joined #openstack-sahara | 19:56 | |
vgridnev | egafford, could you please take a look on https://etherpad.openstack.org/p/sahara-review-priorities list, I still think it's good instrument to highlight important reviews for us | 20:10 |
egafford | vgridnev: ack | 20:11 |
vgridnev | I also thinking about topic for changes that already got +2 from core. For example: sahara-final-core-vote | 20:11 |
vgridnev | so, when core just putted +2 for change it might be a good to change topic to highlight that there are few good changes | 20:12 |
egafford | vgridnev: Makes sense to me; I can start posting new changes to that. | 20:13 |
*** tellesnobrega_af is now known as tellesnobrega | 20:14 | |
*** esikachev has quit IRC | 20:24 | |
*** tmckay has quit IRC | 20:38 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: plugins api impl https://review.openstack.org/333374 | 20:44 |
vgridnev | egafford, I thinking that now it should be cleaner | 20:45 |
vgridnev | ^^ | 20:45 |
egafford | vgridnev: I'll take a look; thanks! | 20:46 |
egafford | vgridnev: Yup; this is way cleaner. :D | 20:47 |
egafford | vgridnev: So we need to implement plugin.get_labels() for each plugin in a future patch (or patches), right? | 20:49 |
vgridnev | yep, but it's required with default value | 20:50 |
egafford | Yeah this is much better-encapsulated and very clean and readable. Thanks! | 20:51 |
*** catintheroof has joined #openstack-sahara | 20:55 | |
openstackgerrit | Merged openstack/sahara: Fix the ca certificate handling in the client sessions https://review.openstack.org/330635 | 20:55 |
*** tmckay has joined #openstack-sahara | 20:58 | |
*** sgotliv__ has quit IRC | 21:01 | |
openstackgerrit | Merged openstack/sahara-specs: Adding ability to export and import templates via CLI https://review.openstack.org/273547 | 21:04 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara-image-elements: remove hdp from elements https://review.openstack.org/326080 | 21:13 |
*** crobertsrh is now known as _crobertsrh | 21:14 | |
vgridnev | egafford, you are welcome https://bugs.launchpad.net/sahara/+bug/1596715 | 21:33 |
openstack | Launchpad bug 1596715 in Sahara "[DOC][DIB] readme is too old and should updated properly" [Medium,Confirmed] - Assigned to Ethan Gafford (egafford) | 21:33 |
egafford | vgridnev: :D | 21:33 |
* egafford is actually laughing out loud a bit. | 21:33 | |
*** permalac_ has joined #openstack-sahara | 21:35 | |
*** permalac has quit IRC | 21:36 | |
*** witlessb has quit IRC | 21:54 | |
*** catintheroof has quit IRC | 21:55 | |
openstackgerrit | Ethan Gafford proposed openstack/sahara-image-elements: Fixing diskimage-create.sh README.rst https://review.openstack.org/334685 | 22:07 |
openstackgerrit | Merged openstack/python-saharaclient: print statment has become a function in py3 https://review.openstack.org/332070 | 22:08 |
*** egafford has quit IRC | 22:13 | |
*** jamielennox is now known as jamielennox|away | 22:21 | |
*** abalutoiu_ has joined #openstack-sahara | 22:42 | |
*** abalutoiu has quit IRC | 22:43 | |
*** abalutoiu_ has quit IRC | 22:48 | |
*** jamielennox|away is now known as jamielennox | 23:43 | |
*** tosky has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!