| *** jamielennox|away is now known as jamielennox | 00:02 | |
| *** esikachev has joined #openstack-sahara | 00:39 | |
| *** esikachev has quit IRC | 00:43 | |
| *** esikachev has joined #openstack-sahara | 00:48 | |
| *** esikachev has quit IRC | 00:52 | |
| *** links has joined #openstack-sahara | 00:54 | |
| *** esikachev has joined #openstack-sahara | 01:05 | |
| *** esikachev has quit IRC | 01:10 | |
| *** esikachev has joined #openstack-sahara | 01:21 | |
| *** esikachev has quit IRC | 01:28 | |
| *** esikachev has joined #openstack-sahara | 01:37 | |
| *** esikachev has quit IRC | 01:42 | |
| *** esikachev has joined #openstack-sahara | 01:57 | |
| *** jamielennox is now known as jamielennox|away | 02:00 | |
| *** esikachev has quit IRC | 02:01 | |
| *** shuyingya has joined #openstack-sahara | 02:05 | |
| *** esikachev has joined #openstack-sahara | 02:06 | |
| *** esikachev has quit IRC | 02:15 | |
| *** shuyingy_ has joined #openstack-sahara | 02:24 | |
| *** shuyingya has quit IRC | 02:28 | |
| *** Poornima has joined #openstack-sahara | 03:51 | |
| *** jamielennox|away is now known as jamielennox | 03:53 | |
| *** guchihiro has joined #openstack-sahara | 04:07 | |
| *** esikachev has joined #openstack-sahara | 04:32 | |
| *** esikachev has quit IRC | 04:37 | |
| *** pgadiya has joined #openstack-sahara | 05:03 | |
| *** Poornima has quit IRC | 05:05 | |
| *** pgadiya has quit IRC | 05:06 | |
| *** Poornima has joined #openstack-sahara | 05:10 | |
| *** esikachev has joined #openstack-sahara | 05:54 | |
| *** Poornima has quit IRC | 06:08 | |
| *** esikachev has quit IRC | 06:08 | |
| *** shuyingy_ has quit IRC | 06:13 | |
| *** shuyingya has joined #openstack-sahara | 06:13 | |
| *** shuyingy_ has joined #openstack-sahara | 06:19 | |
| *** rcernin has joined #openstack-sahara | 06:19 | |
| *** esikachev has joined #openstack-sahara | 06:21 | |
| *** shuyingya has quit IRC | 06:22 | |
| *** guchihiro has quit IRC | 06:25 | |
| *** zemuvier has joined #openstack-sahara | 06:58 | |
| *** anshulbehl has joined #openstack-sahara | 06:58 | |
| *** esikachev has quit IRC | 07:00 | |
| *** pcaruana has joined #openstack-sahara | 07:11 | |
| *** anshulbehl has quit IRC | 07:11 | |
| *** pcaruana has quit IRC | 07:12 | |
| *** pcaruana has joined #openstack-sahara | 07:13 | |
| *** rcernin has quit IRC | 07:14 | |
| *** rcernin has joined #openstack-sahara | 07:14 | |
| *** anshulbehl has joined #openstack-sahara | 07:24 | |
| *** hoonetorg has quit IRC | 07:39 | |
| *** esikachev has joined #openstack-sahara | 07:41 | |
| *** hoonetorg has joined #openstack-sahara | 07:53 | |
| *** anshulbehl has quit IRC | 08:07 | |
| *** anshulbehl has joined #openstack-sahara | 08:20 | |
| *** tosky has joined #openstack-sahara | 09:46 | |
| *** tuanluong has joined #openstack-sahara | 10:15 | |
| *** tenobreg has quit IRC | 10:20 | |
| *** tuanluong has quit IRC | 11:04 | |
| *** tenobreg has joined #openstack-sahara | 11:21 | |
| *** dave-mccowan has joined #openstack-sahara | 11:30 | |
| *** chlong has joined #openstack-sahara | 12:29 | |
| *** egafford has joined #openstack-sahara | 12:33 | |
| *** jeremyfreudberg has joined #openstack-sahara | 12:43 | |
| jeremyfreudberg | tenobreg, ping | 12:53 |
|---|---|---|
| tenobreg | jeremyfreudberg, pong | 12:53 |
| jeremyfreudberg | tenobreg, did you see the email I forwarded you | 12:53 |
| jeremyfreudberg | (to your redhat email) | 12:53 |
| tenobreg | jeremyfreudberg, not yet, I'm still on vacation, but I will get to it today or tomorrow | 12:54 |
| jeremyfreudberg | oh sure, no problem | 12:54 |
| jeremyfreudberg | enjoy the rest of your vacation :) | 12:55 |
| tenobreg | jeremyfreudberg, is it critical? if yes I will try to read today | 12:55 |
| tenobreg | thanks | 12:55 |
| *** chlong has quit IRC | 12:55 | |
| *** shuyingy_ has quit IRC | 13:00 | |
| jeremyfreudberg | tosky, do you know what's going on with the failures here: https://review.openstack.org/#/c/465804/ ? Are they specific to the patch or ongoing problem? | 13:04 |
| tosky | jeremyfreudberg: no; I tried to investigate a bit on Friday but I failed; vgridnev suggested the new novaclient, which is the relevant change in the dependencies | 13:05 |
| tosky | but I could not test on devstack, so I dropped it temporarily; no clue from the stack trace | 13:05 |
| tosky | if you have any idea, more than happy to review the patches :) | 13:14 |
| jeremyfreudberg | oh sure, I'll probably look into it at some point soon. I have to spin up a Devstack to work on some other things anyway | 13:15 |
| *** zemuvier has quit IRC | 13:37 | |
| *** esikachev has quit IRC | 13:39 | |
| *** esikache1 has joined #openstack-sahara | 13:39 | |
| *** shuyingya has joined #openstack-sahara | 13:40 | |
| *** esikache1 has quit IRC | 13:43 | |
| *** shuyingya has quit IRC | 13:44 | |
| *** shuyingya has joined #openstack-sahara | 13:45 | |
| *** tenobreg has quit IRC | 13:45 | |
| *** links has quit IRC | 13:57 | |
| *** tenobreg has joined #openstack-sahara | 13:58 | |
| *** esikache1 has joined #openstack-sahara | 14:36 | |
| *** shuyingy_ has joined #openstack-sahara | 14:41 | |
| *** shuyingya has quit IRC | 14:43 | |
| *** tenobreg has quit IRC | 14:47 | |
| jeremyfreudberg | tosky, it's novaclient | 14:52 |
| jeremyfreudberg | http://paste.openstack.org/show/610176/ | 14:52 |
| tosky | jeremyfreudberg: a leftover of the usage of nova for network details? I thought it was fixed earlier | 14:53 |
| jeremyfreudberg | yes, i thought we fixed that too | 14:54 |
| tosky | jeremyfreudberg: do you have some time for a quick patch? | 14:55 |
| jeremyfreudberg | tosky, sure, happy to help out | 14:56 |
| tosky | thanks! | 14:56 |
| *** shuyingy_ has quit IRC | 14:58 | |
| *** openstackgerrit has joined #openstack-sahara | 15:36 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Reflect novaclient changes in get_network https://review.openstack.org/466778 | 15:36 |
| *** chlong has joined #openstack-sahara | 15:38 | |
| *** shuyingya has joined #openstack-sahara | 15:39 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Reflect novaclient changes in get_network https://review.openstack.org/466778 | 15:39 |
| *** shuyingya has quit IRC | 15:43 | |
| jeremyfreudberg | ^uh, actually that patch might not work. needs a little more work | 15:44 |
| tosky | I see that it hides the new behavior in the existing nova client | 15:52 |
| tosky | if you can make it work good; otherwise, maybe it's better to go for direct usage of the neutron client | 15:52 |
| jeremyfreudberg | well my issue is that the functionality that remains in novaclient only does lookup by name, not by id | 15:53 |
| jeremyfreudberg | so I think by that it probably makes sense to use the true neutronclient, and that's not too much more work | 15:53 |
| *** pcaruana has quit IRC | 15:59 | |
| *** rcernin has quit IRC | 16:14 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 16:28 |
| *** anshulbehl has quit IRC | 16:30 | |
| *** rcernin has joined #openstack-sahara | 16:31 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 16:35 |
| *** jeremyfreudberg has quit IRC | 16:36 | |
| *** jeremyfreudberg has joined #openstack-sahara | 16:37 | |
| tosky | jeremyfreudberg: when you update the patch (because you will need :) please add the number of the novaclient which removed that old code | 16:41 |
| tosky | in the commit message | 16:41 |
| jeremyfreudberg | tosky, definitely | 16:42 |
| tosky | thanks | 16:42 |
| jeremyfreudberg | while I have your attention, the old get_network using novaclient claims to be unit-tested in the coverage job: http://logs.openstack.org/04/465804/1/check/sahara-coverage-ubuntu-xenial-nv/07b9558/cover/sahara_utils_openstack_nova_py.html but I can't find where that test is | 16:42 |
| *** anshulbehl has joined #openstack-sahara | 16:48 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 16:54 |
| jeremyfreudberg | ^brain is not working today, had a "self" where it shouldn't be. tosky, added release number to the commit message | 16:55 |
| tosky | thanks :) | 16:56 |
| tosky | about the coverage, wasn't there a reference to get_network in a test? Or do you mean something else? | 16:56 |
| tosky | uhm, no | 16:57 |
| jeremyfreudberg | tosky, I mean I can't find get_network in the test | 16:57 |
| jeremyfreudberg | only the mock _get_network which is something else | 16:57 |
| tosky | maybe indirectly called | 16:58 |
| jeremyfreudberg | right, but then usually in that case only the function name is green, not the body | 16:58 |
| tosky | but without mocking? Uhm | 16:58 |
| tosky | isn't it possible to run the coverage with more details? | 16:58 |
| jeremyfreudberg | probably | 16:59 |
| *** chlong has quit IRC | 16:59 | |
| tosky | I never enough much attention to it | 16:59 |
| jeremyfreudberg | tosky, uh, well there is some crazy mocking https://github.com/openstack/sahara/blob/master/sahara/tests/unit/service/validation/utils.py that uses side_effect, I guess that is it | 17:05 |
| jeremyfreudberg | so I'll have to update that too... | 17:05 |
| *** jeremyfreudberg has quit IRC | 17:06 | |
| *** crazymozart1 has joined #openstack-sahara | 17:10 | |
| *** crazymozart has quit IRC | 17:13 | |
| *** esikache1 has quit IRC | 17:13 | |
| *** chlong has joined #openstack-sahara | 17:15 | |
| *** chlong has quit IRC | 17:15 | |
| *** esikache1 has joined #openstack-sahara | 17:19 | |
| *** esikache1 has quit IRC | 17:30 | |
| *** tosky has quit IRC | 17:31 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 17:51 |
| *** jeremyfreudberg has joined #openstack-sahara | 17:52 | |
| *** chlong has joined #openstack-sahara | 17:55 | |
| *** esikache1 has joined #openstack-sahara | 18:09 | |
| *** crazymozart1 has quit IRC | 18:09 | |
| *** crazymozart1 has joined #openstack-sahara | 18:09 | |
| *** crazymozart1 has quit IRC | 18:18 | |
| *** tosky has joined #openstack-sahara | 18:29 | |
| *** masuberu has quit IRC | 18:39 | |
| *** dave-mccowan has quit IRC | 18:41 | |
| *** esikache1 has quit IRC | 19:27 | |
| *** esikache1 has joined #openstack-sahara | 19:28 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 19:29 |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 19:30 |
| *** chlong has quit IRC | 20:07 | |
| *** crazymozart1 has joined #openstack-sahara | 20:24 | |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Use neutronclient to verify network's existence https://review.openstack.org/466778 | 20:28 |
| *** chlong has joined #openstack-sahara | 20:30 | |
| *** egafford has left #openstack-sahara | 20:34 | |
| *** chlong has quit IRC | 20:41 | |
| *** jeremyfreudberg has quit IRC | 20:42 | |
| *** dave-mccowan has joined #openstack-sahara | 21:05 | |
| *** esikache1 has quit IRC | 21:17 | |
| *** esikache1 has joined #openstack-sahara | 21:19 | |
| *** esikache1 has quit IRC | 21:24 | |
| *** esikache1 has joined #openstack-sahara | 21:51 | |
| *** esikache1 has quit IRC | 21:56 | |
| *** esikache1 has joined #openstack-sahara | 22:43 | |
| *** esikache1 has quit IRC | 22:48 | |
| *** esikache1 has joined #openstack-sahara | 22:52 | |
| *** esikache1 has quit IRC | 22:56 | |
| *** tosky has quit IRC | 23:20 | |
| *** jeremyfreudberg has joined #openstack-sahara | 23:42 | |
| *** esikache1 has joined #openstack-sahara | 23:53 | |
| *** esikache1 has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!