Monday, 2017-07-24

« Sunday, 2017-07-23 Index Tuesday, 2017-07-25 »
*** ukaynar has quit IRC00:49
*** tmckay has quit IRC01:17
*** tmckay has joined #openstack-sahara01:42
*** tmckay has quit IRC02:09
*** tellesnobrega has quit IRC03:33
*** tellesnobrega has joined #openstack-sahara03:41
*** links has joined #openstack-sahara03:46
*** ukaynar has joined #openstack-sahara03:54
openstackgerritzhuli proposed openstack/sahara master: Bad request exception for unsupported content type  https://review.openstack.org/48647904:00
openstackgerritMerged openstack/puppet-sahara master: Update URLs in documents according to document migration  https://review.openstack.org/48364504:36
*** ukaynar has quit IRC04:44
*** pgadiya has joined #openstack-sahara05:14
*** anshul has joined #openstack-sahara05:22
*** Poornima_K has joined #openstack-sahara05:27
*** Poornima_K has quit IRC06:00
*** rcernin has joined #openstack-sahara06:23
*** tuanluong has joined #openstack-sahara06:32
*** esikachev has joined #openstack-sahara07:07
*** akuznetsov has joined #openstack-sahara08:18
*** iwonka has joined #openstack-sahara08:21
*** akuznetsov has quit IRC08:33
*** zemuvier has joined #openstack-sahara08:35
*** iwonka has quit IRC09:43
*** Poornima_K has joined #openstack-sahara09:51
*** tuanluong has quit IRC10:02
openstackgerritEvgeny Sikachev proposed openstack/sahara-image-elements master: Add support to create CDH 5.12 images  https://review.openstack.org/48602210:17
*** Poornima_K has quit IRC10:35
*** Poornima_K has joined #openstack-sahara10:38
*** Poornima_K has quit IRC10:55
*** Poornima_K has joined #openstack-sahara10:57
*** Poornima_K has quit IRC11:02
*** esikachev has quit IRC11:18
*** pgadiya has quit IRC12:17
*** chlong has joined #openstack-sahara12:53
*** iwonka has joined #openstack-sahara12:57
tellesnobregaiwonka, ping12:58
iwonkatellesnobrega: pong12:58
tellesnobregaiwonka, how is everything?12:58
iwonkaumm, working on test12:58
iwonkai don't know how to add a test to sahara12:58
iwonkabecause the other functions test things from level, where i just use get12:59
tellesnobregasahara has tests under sahara/tests/units/ something12:59
iwonkayeah, i saw them12:59
tellesnobregawhat exactly are you trying to test now? export or import?12:59
iwonkaexport now13:00
iwonkawant to be done with it13:00
tellesnobregaok, lets try to speed it up13:00
iwonkaok13:00
iwonkasahara/tests/unit/conductormanager/test_templates.py was the file i was looking at13:01
iwonkabut i just use get from conductor13:01
iwonkaso nothing new to test there13:01
tellesnobregaOk, so we might not even need to add a test here13:02
iwonkaok13:02
iwonkaso saharaclient next13:02
tellesnobregaok13:02
iwonkasaharaclient/tests/unit/node_group_templates.py is the file i'm working with currently13:03
iwonkais it ok?13:03
tellesnobregasounds right13:03
*** tmckay has joined #openstack-sahara13:05
iwonkatellesnobrega: i'm getting bdbquit when i'm trying to run tests with pdb inside13:07
iwonkaany ideas what's wrong?13:07
tellesnobregahmm, I've seen that before, not sure what it is13:08
tellesnobregasomething you can do for a quicker view is add prints and force the test to fail and it will print values13:08
tellesnobregahow are you running the tests?13:10
iwonkatox -e py2713:11
*** lucasxu has joined #openstack-sahara13:11
iwonkai can write to file (that's what i'm doing)…13:11
tellesnobregaok13:11
tellesnobregacool, let me check here, I believe there is a way so we can run only the test we want13:14
*** jeremyfreudberg has joined #openstack-sahara13:16
*** links has quit IRC13:20
jeremyfreudbergtellesnobrega, iwonka, did you figure out the pdb thing?13:21
tellesnobregajeremyfreudberg, didn't try13:21
tellesnobregado you happen to know what the problem is?13:21
*** Poornima has joined #openstack-sahara13:21
jeremyfreudbergyeah, tox -e pyXX uses ostestr which doesn't support it see https://bugs.launchpad.net/testrepository/+bug/902881 , but there is another way13:22
openstackLaunchpad bug 902881 in Testrepository "no way to drop into a debugger safely" [Wishlist,Triaged]13:22
jeremyfreudberguse python -m testtools.run13:22
jeremyfreudbergso if you are in saharaclient folder13:22
jeremyfreudberguse python -m testtools.run tests.unit.<module name>13:23
tellesnobregacool13:23
tellesnobregathanks jeremyfreudberg13:23
jeremyfreudbergno problem13:24
iwonkaso i should do python -m testtools.run tests.unit.py27 ?13:24
tellesnobregato run a subset of a subset of tests using tox we can run with tox -e py27 tests.unit.<module> as well?13:24
jeremyfreudbergiwonka, tests.unit.test_node_group_templates13:25
tellesnobregaiwonka, in this case it would be  python -m testtools.run tests.unit.test_node_group_templates13:25
jeremyfreudbergor whatever file you want13:25
openstackgerritMerged openstack/sahara master: Updated from global requirements  https://review.openstack.org/48640313:25
iwonkaok, got it, thanks13:26
*** Poornima has quit IRC13:27
*** Poornima has joined #openstack-sahara13:29
iwonkaping tellesnobrega13:37
tellesnobregapong13:37
iwonkai have         self.assertFields(self.body, resp.__dict__[u'node_group_template'])13:37
iwonkaand it throws an error13:38
iwonkabut in pdb p self.body==resp.__dict__[u'node_group_template'] is True13:38
iwonkathe error says that "'dict' object has no attribute 'volume_mount_prefix'"13:38
iwonka(things i'm comparing are both dicts)13:39
tellesnobregacan you paste self.body and resp.__dict__?13:39
iwonkathey both have 'volume_mount_prefix' field13:39
iwonkaself.body: {'volume_mount_prefix': '/volumes/disk', 'volumes_size': '4', 'node_processes': ['datanode'], 'name': 'name', 'use_autoconfig': True, 'volumes_per_node': '3', 'description': 'description', 'hadoop_version': '1', 'plugin_name': 'plugin', 'flavor_id': '2'}13:39
iwonkaresp.__dict__['node_group_template']: {u'flavor_id': u'2', u'name': u'name', u'volume_mount_prefix': u'/volumes/disk', u'plugin_name': u'plugin', u'volumes_size': u'4', u'node_processes': [u'datanode'], u'use_autoconfig': True, u'volumes_per_node': u'3', u'hadoop_version': u'1', u'description': u'description'}13:40
iwonkaentire resp.__dict__ is a bit longer13:41
tellesnobregaok13:41
tellesnobregathis should be enough13:41
openstackgerritMerged openstack/python-saharaclient master: Updated from global requirements  https://review.openstack.org/48634013:44
*** zemuvier has quit IRC13:45
jeremyfreudbergiwonka, can you paste the whole test? paste.openstack.org if it's long13:45
*** Poornima has quit IRC13:47
iwonkajeremyfreudberg: http://paste.openstack.org/show/616305/13:47
iwonkaalmost the same as for get13:47
jeremyfreudberghmmm, that looks like it should have worked fine13:49
jeremyfreudberg iwonka, what about without the __dict__, since none of the other tests use that?13:54
iwonkaummm13:54
iwonkathen the data is not the same13:54
iwonkai mean13:54
iwonkaresp is saharaclient.api.node_group_templates.NodeGroupTemplate13:55
iwonkaand it has the data in __dict__13:55
jeremyfreudbergyeah, i see that13:55
jeremyfreudbergbut somehow the tests for get work anyway13:55
jeremyfreudberghttps://github.com/openstack/python-saharaclient/blob/master/saharaclient/tests/unit/base.py#L3413:56
jeremyfreudberglooking at how assertFields works will help you here, it's designed to be comparing a dict with some other kind of object13:56
jeremyfreudbergbut you could write your own helper if you want13:56
jeremyfreudberg^ iwonka13:56
iwonkai think it would work if i had to compare self.body and resp.__dict__13:58
jeremyfreudberggetattr on a dict is not what you want13:59
jeremyfreudbergthat's doing dict.something and not dict['something']13:59
jeremyfreudbergso your probably want to write a new helper which can compare two dicts the way you want to13:59
iwonkaok, i'll do that13:59
jeremyfreudbergcool14:00
openstackgerritIwona Kotlarska proposed openstack/python-saharaclient master: Add export of node group templates  https://review.openstack.org/48521014:07
iwonkajeremyfreudberg: worked, thanks :)14:08
jeremyfreudbergiwonka, no problem14:08
jeremyfreudbergbtw, you pushed the code with the pdb statement still in it14:09
openstackgerritIwona Kotlarska proposed openstack/python-saharaclient master: Add export of node group templates  https://review.openstack.org/48521014:11
iwonkaindeed, sorry14:11
jeremyfreudbergiwonka, no problem :)14:11
tellesnobregathanks jeremyfreudberg14:12
jeremyfreudbergtellesnobrega: always happy to help14:12
iwonkayes, thanks a lot14:12
openstackgerritRitesh proposed openstack/sahara master: Replace six.iteritems() with .items()  https://review.openstack.org/48662814:15
tellesnobregaiwonka, just commented on a quick fix14:16
iwonkaummm14:16
iwonkabut if i had one loop and the second dict had a field that first one didn't it would say they are equal14:16
*** esikachev has joined #openstack-sahara14:17
iwonkawhile they wouldn't be14:17
jeremyfreudbergI agree with iwonka14:17
tellesnobregaoh, true14:18
tellesnobregathere could be a more efficient way to do this14:19
tellesnobregabut it sounds good for now14:19
iwonkashould i add tests to to sahara-dashboard?14:21
tellesnobregaiwonka, let me check your patch on sahara dashboard14:21
iwonkasure14:21
tellesnobregaI guess we can pass without it for now14:25
tellesnobregaso you can work more on import part14:25
jeremyfreudbergi think it's ok too to pass on it14:25
iwonkaimport? or cli?14:28
iwonkai thiught i should add export to cli?14:28
iwonka*thought14:29
tellesnobregaright, export to cli first14:38
*** akuznetsov has joined #openstack-sahara14:51
*** akuznetsov has quit IRC14:54
*** esikache1 has joined #openstack-sahara14:57
*** esikachev has quit IRC14:57
*** lucasxu has quit IRC15:03
*** chlong_ has joined #openstack-sahara15:21
*** chlong has quit IRC15:24
*** rcernin has quit IRC15:34
*** rcernin has joined #openstack-sahara15:58
*** chlong__ has joined #openstack-sahara16:12
*** chlong_ has quit IRC16:13
*** anshul has quit IRC16:27
*** esikache1 has quit IRC16:34
*** chlong_ has joined #openstack-sahara16:40
*** chlong__ has quit IRC16:41
*** chlong_ has quit IRC17:08
*** chlong_ has joined #openstack-sahara17:10
*** esikache1 has joined #openstack-sahara17:36
*** esikache1 has quit IRC17:40
iwonkaping tellesnobrega17:54
tellesnobregapong iwonka17:55
iwonkahow should i make json downloadable?17:56
iwonkai mean in cli17:56
iwonkacan i just create file and write it to file?17:56
tellesnobregaiwonka, it is the way that I imagined yes17:56
iwonkaok, thanks17:56
iwonkashould i add the code in new commit?18:08
tellesnobregado you already have a patch for the cli?18:08
iwonkayes18:09
iwonkanot exactly18:09
tellesnobregayou can write a new one then18:09
iwonkai have a patch for python-saharaclient project18:09
tellesnobregawrite a new one18:09
iwonkaok18:09
jeremyfreudberg+1 to writing a new one18:09
iwonkaso, i have a new commit18:16
tellesnobregagreat18:16
iwonkabut it depends on and old one18:16
iwonkaand git review is asking me if i want to submit both commits18:16
*** rcernin has quit IRC18:16
iwonkabut the first has already been submitted18:17
iwonkawhat should i do? submit both commits?18:17
jeremyfreudbergiwonka, what i do in that situation is clone the repo somewhere else, make the commit in that clone, git review it separately, then either use Depends-On in the commit message, or use rebase to refer to that change in the gerrit ui18:18
tellesnobregajeremyfreudberg, +118:18
jeremyfreudbergto be honest, I have never tried the "submit both commits at the same time way" that git review is thinking of18:19
tellesnobregaI've done once a long time ago18:19
iwonkaso git rebase <id_of_the_first_commit> and then git review will do the job?18:21
jeremyfreudbergiwonka, i meant the rebase button in the gerrit ui18:21
jeremyfreudbergwith the change-id, i think18:21
iwonkaok18:22
iwonkathanks18:22
jeremyfreudbergno problem18:22
openstackgerritIwona Kotlarska proposed openstack/python-saharaclient master: Add export of node group templates to CLI  https://review.openstack.org/48672118:47
openstackgerritIwona Kotlarska proposed openstack/python-saharaclient master: Add export of node group templates to CLI  https://review.openstack.org/48672118:49
iwonkagit is strange, but probably it's fine now18:50
jeremyfreudbergi think that should be fine. in terms of git stuff, anyway18:50
openstackgerritMerged openstack/sahara-extra master: Add Hadoop native libs to common-artifacts  https://review.openstack.org/48644819:54
*** jeremyfreudberg_ has joined #openstack-sahara20:04
*** jeremyfreudberg_ has quit IRC20:09
*** jeremyfreudberg has quit IRC20:09
openstackgerritJeremy Freudberg proposed openstack/sahara-image-elements master: Change default link for Hadoop native libs  https://review.openstack.org/48674620:36
openstackgerritEvgeny Sikachev proposed openstack/sahara-image-elements master: Add support to create CDH 5.12 images  https://review.openstack.org/48602220:46
*** tmckay has quit IRC21:10
*** esikache1 has joined #openstack-sahara21:31
*** esikache1 has quit IRC21:35
*** tmckay has joined #openstack-sahara22:46
*** ukaynar has joined #openstack-sahara23:05
*** chlong__ has joined #openstack-sahara23:36
*** chlong_ has quit IRC23:37
*** iwonka has quit IRC23:49
« Sunday, 2017-07-23 Index Tuesday, 2017-07-25 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!