Thursday, 2017-11-30

*** tosky has quit IRC00:11
*** links has joined #openstack-sahara01:09
*** shuyingya has joined #openstack-sahara01:15
*** shuyingya has quit IRC01:19
*** caowei has joined #openstack-sahara01:26
*** shuyingya has joined #openstack-sahara01:51
*** shuyingy_ has joined #openstack-sahara01:51
*** shuyingya has quit IRC01:55
*** dave-mccowan has quit IRC02:18
*** dave-mccowan has joined #openstack-sahara02:45
*** masber has joined #openstack-sahara03:03
*** masuberu has quit IRC03:07
*** raissa_ has joined #openstack-sahara03:15
*** raissa has quit IRC03:16
*** masber has quit IRC03:30
*** masber has joined #openstack-sahara03:34
*** dave-mccowan has quit IRC04:07
*** caowei has quit IRC04:44
*** pgadiya has joined #openstack-sahara05:14
*** caowei has joined #openstack-sahara05:23
*** pgadiya has quit IRC05:23
*** tellesnobrega has quit IRC05:34
*** tellesnobrega has joined #openstack-sahara05:55
*** tellesnobrega has quit IRC05:59
*** tellesnobrega has joined #openstack-sahara05:59
*** pcaruana has joined #openstack-sahara06:05
*** pcaruana has quit IRC06:16
*** masuberu has joined #openstack-sahara06:42
*** masber has quit IRC06:46
*** rcernin has quit IRC07:20
*** pcaruana has joined #openstack-sahara07:55
*** rcernin has joined #openstack-sahara08:07
*** hoonetorg has quit IRC08:11
*** hoonetorg has joined #openstack-sahara08:25
*** hoonetorg has quit IRC08:26
*** hoonetorg has joined #openstack-sahara08:27
*** pcaruana has quit IRC09:39
*** pcaruana has joined #openstack-sahara09:40
*** tosky has joined #openstack-sahara09:45
*** zhenguo has quit IRC10:09
*** dgonzalez has quit IRC10:09
*** ltosky[m] has quit IRC10:09
*** ltosky[m] has joined #openstack-sahara10:14
*** zhenguo has joined #openstack-sahara10:15
*** dgonzalez has joined #openstack-sahara10:15
*** masuberu has quit IRC10:49
*** caowei has quit IRC10:57
*** ltosky[m] has quit IRC11:14
openstackgerritMerged openstack/sahara-dashboard master: Imported Translations from Zanata  https://review.openstack.org/52369911:41
*** rcernin has quit IRC11:52
*** dave-mccowan has joined #openstack-sahara12:07
*** ltosky[m] has joined #openstack-sahara12:27
*** shuyingy_ has quit IRC13:35
*** ukaynar has joined #openstack-sahara13:42
*** ukaynar has quit IRC13:44
*** links has quit IRC13:54
*** shuyingya has joined #openstack-sahara13:57
*** jeremyfreudberg has joined #openstack-sahara14:01
*** shuyingya has quit IRC14:02
jeremyfreudbergum, it's the meeting now, right?14:03
*** shuyingya has joined #openstack-sahara14:03
tellesnobregayes :)14:03
tellesnobregatosky, are you joining?14:04
*** shuyingy_ has joined #openstack-sahara14:05
toskyargh, timezones14:05
toskydaylight saving14:05
tellesnobregaoh14:05
toskyI'm still thinking about 16.0014:06
*** shuyingya has quit IRC14:13
*** jeremyfreudberg has quit IRC14:27
-openstackstatus- NOTICE: if you receieved a result of "RETRY_LIMIT" after 14:15 UTC, it was likely due to an error since corrected. please "recheck"15:38
*** ukaynar has joined #openstack-sahara16:08
*** shuyingy_ has quit IRC16:22
*** ukaynar has quit IRC16:45
*** ukaynar has joined #openstack-sahara16:46
*** pcaruana has quit IRC17:08
*** jeremyfreudberg has joined #openstack-sahara17:39
jeremyfreudbergelmiko, sorry to ping you again17:39
openstackgerritAlex Schultz proposed openstack/puppet-sahara stable/pike: Prepare for post-Pike updates  https://review.openstack.org/52429317:59
tellesnobregatosky, about sahara client on the decommission of specific node. There is one option that is a json, so no need to change there. The other one is instances where we pass <node_group_template:instances_count>18:04
tellesnobregathis we would need to change, and possibly break compatibility18:04
toskythat's the CLI or the python ?18:04
tellesnobregaCLI18:05
jeremyfreudberg( tellesnobrega tosky i just sent two emails, but you can read them later )18:05
tellesnobregajeremyfreudberg, about plugins versions, sounds about right18:06
tellesnobregathe v2 I'll check later18:06
tellesnobregatosky, I'm at saharaclient/osc/v1/clusters.py18:06
jeremyfreudbergthe one v2 thing i should mention is whether or not decomission of specifc node will be a v2-exclusive18:07
jeremyfreudbergat first i was insisting it has to be because we are changing the expected request body but i'm actually not so sure anymore18:07
toskyjeremyfreudberg: and for plugins, as stop-gap, we can just document that (say) spark 2.1.2 works even if you use 2.1.0 as label18:08
tellesnobregajeremyfreudberg, doesn't seem necessary, because if the body is passed as is today, it will work18:08
toskythe point is: does a new client breaks if used against the old server, when the new features are not used?18:09
jeremyfreudbergtellesnobrega, right, the one thing is backwards compatibility, if you pass in the new fields to an old sahara, does it give bad request, or does it just throw that away18:09
jeremyfreudbergthrow away and just do the old behavior i mean18:09
tellesnobregahm, it will fail18:09
tellesnobregaon validation18:09
tellesnobregayou are right18:09
*** ukaynar has quit IRC18:10
jeremyfreudberglet me try it now18:10
tellesnobregavalidation will fail the request, because it is not expecting the instances part18:11
jeremyfreudberghttps://github.com/openstack/sahara/blob/master/sahara/service/validations/clusters_schema.py#L10118:11
jeremyfreudbergright18:11
tellesnobregamaybe we should hold it for api v218:14
jeremyfreudbergwell, hopefully it can be part of experimental v2 this release18:14
tellesnobregayeah18:15
tellesnobregawe have to get a jump on api v2 fast18:15
toskya reason more to push v218:15
tellesnobregayes18:15
tellesnobregatosky, that makes postpone testing for now18:16
tellesnobregamakes me*18:16
toskytesting of v2 or testing of decommissioning?18:16
elmikojeremyfreudberg: yo18:16
tellesnobreganevermind18:16
toskyO.o18:16
jeremyfreudbergelmiko, hi18:16
tellesnobregagot confused18:17
jeremyfreudberganother hopefully quick question18:17
jeremyfreudbergabout apiv2 OpenStack-Project-Id18:17
jeremyfreudbergseemingly a custom header of your own invention18:17
jeremyfreudbergelmiko, my question is, do we really need that?18:18
jeremyfreudbergthe only thing we seem to use it for is seeing if it matches what keystonemiddleware sets in the environment18:18
elmikothe idea was to remove the project id from the uri for an object18:18
elmikoat the time, i think there was much less of an ecosystem around detecting the project18:19
jeremyfreudbergyes, i agree it shouldn't be in the url. but i think we can just nuke it altogether18:19
elmikobut, if it isn't needed and the project id can be detected outside the uri, then by all means it can be removed18:19
jeremyfreudbergevery other service i've seen puts faith in keystonemiddleware to set the wsgi env HTTP_X_PROJECT_ID correctly18:19
elmikoiirc, at the time it was more difficult to determine the project id from the keystone middleware18:19
elmikoyeah, that works18:19
jeremyfreudbergalright, cool, thanks elmiko, i just wanted to make sure i wasn't going crazy before i undid your work18:20
elmikono no, it's all good. plus it's been several cycles since i've been "in the loop" about changes18:21
*** tellesnobrega has left #openstack-sahara18:22
*** tellesnobrega has joined #openstack-sahara18:22
toskydoes it also mean that we need to tie APIv2 to wsgi as deployment method?18:22
toskyjust to know18:23
jeremyfreudbergthanks again elmiko for your omnipresence, that's all from me for now :)18:23
jeremyfreudbergtosky, oslo service loads everything from paste18:23
jeremyfreudbergso it can be with builtin eventlet wsgi or the real way of wsgi + actual web server18:23
toskyoh, oki; I'm still a bit ignorant in that deployment part18:24
jeremyfreudberganyway, i again have to sign off18:24
jeremyfreudbergtellesnobrega, i will post 1-2 patches later (tomorrow?) that basically finish up APIv2 on the sahara-side and enable it18:25
tellesnobregajeremyfreudberg, great18:25
tellesnobregaI'm anxiously waiting for that18:26
elmikojeremyfreudberg: np18:26
tellesnobregaelmiko, seems like apiv2 is finally coming :D18:27
*** jeremyfreudberg has quit IRC18:27
tellesnobregawe should have a party for that18:27
tellesnobregatosky, about tests, do you know an easy way for us to add instances to the cluster on the tests/unit/service/api/v2/test_clusters.py18:35
tellesnobregafrom what I'm seeing, I need to create a new FakeInfra()18:36
tellesnobregathat will create the instances and add to the cluster18:36
openstackgerritMerged openstack/puppet-sahara stable/pike: Prepare for post-Pike updates  https://review.openstack.org/52429318:40
*** openstackgerrit has quit IRC18:48
*** pcaruana has joined #openstack-sahara18:50
*** ukaynar has joined #openstack-sahara19:15
toskytellesnobrega: mocking api.create_cluster19:16
toskyuh, no, that should be already working19:16
tellesnobregabasically it uses fakeOps19:17
tellesnobregaso when provision cluster is called, it goes to a fake provision cluster19:18
tellesnobregaand that is where the instances are added19:18
tellesnobregaI'm trying to add that on the fakeops provision_cluster19:18
toskyyep, that makes sense19:20
tellesnobreganot sure why it is not adding the instances :(19:21
tellesnobregahttp://paste.openstack.org/show/627917/19:23
toskyisn't the call to conductor.cluster_update?19:23
tellesnobregatosky, ^ this is what I added so fas19:23
tellesnobregahttp://paste.openstack.org/show/627918/19:23
tellesnobregathis should make more sense19:23
tellesnobregaapparently it should work with adding instances to the node_group19:36
tellesnobreganot sure why it isn't working19:36
tellesnobregatosky, it worked19:45
tellesnobregafor some reason I have to do a get_cluster after creating the cluster19:45
tellesnobregaso the updated data comes19:45
tellesnobregaso the updated cluster shows up19:47
*** ukaynar has quit IRC19:49
*** ukaynar has joined #openstack-sahara19:50
*** shuyingya has joined #openstack-sahara20:05
toskyah, good20:06
*** shuyingya has quit IRC20:09
tellesnobregatosky, it worked but not perfectly, it updates the instance count on the node_group20:09
tellesnobregabefore the count was 3 with no instances added, now I have count 6 with the 3 showing instances20:10
toskyuhm20:10
tellesnobregahttps://github.com/openstack/sahara/blob/master/sahara/db/sqlalchemy/api.py#L425-L44220:12
tellesnobregathis is why20:12
elmikotellesnobrega: \o/20:21
*** pcaruana has quit IRC20:55
*** shuyingya has joined #openstack-sahara21:00
*** shuyingya has quit IRC21:04
*** ukaynar has quit IRC21:07
*** pcaruana has joined #openstack-sahara21:24
*** raissa_ has quit IRC21:25
*** ukaynar has joined #openstack-sahara21:26
*** raissa has joined #openstack-sahara21:27
*** raissa has quit IRC21:27
*** raissa has joined #openstack-sahara21:27
*** raissa has quit IRC21:28
*** raissa has joined #openstack-sahara21:28
*** raissa has quit IRC21:29
*** raissa has joined #openstack-sahara21:29
*** raissa has quit IRC21:29
*** raissa has joined #openstack-sahara21:30
*** raissa has quit IRC21:30
*** raissa has joined #openstack-sahara21:31
*** raissa has quit IRC21:31
*** dave-mccowan has quit IRC21:35
*** pcaruana has quit IRC21:39
*** rcernin has joined #openstack-sahara22:18
*** rcernin has quit IRC22:21
*** rcernin has joined #openstack-sahara22:21
*** shuyingya has joined #openstack-sahara22:35
*** shuyingya has quit IRC22:39
*** ukaynar has quit IRC23:24
*** ukaynar has joined #openstack-sahara23:25
*** ukaynar has quit IRC23:29

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!