*** tosky has quit IRC | 00:23 | |
*** tellesnobrega has quit IRC | 01:16 | |
*** dave-mccowan has quit IRC | 03:18 | |
*** links has joined #openstack-sahara | 05:09 | |
*** openstackgerrit has quit IRC | 05:48 | |
*** caowei has quit IRC | 05:56 | |
*** caowei has joined #openstack-sahara | 05:58 | |
*** rtsisyk has joined #openstack-sahara | 05:58 | |
*** rtsisyk has joined #openstack-sahara | 05:58 | |
*** caowei has quit IRC | 06:02 | |
*** tosky has joined #openstack-sahara | 07:38 | |
*** tesseract has joined #openstack-sahara | 07:39 | |
*** pcaruana has joined #openstack-sahara | 08:12 | |
*** amoralej has joined #openstack-sahara | 10:31 | |
amoralej | hi | 10:31 |
---|---|---|
amoralej | i'm hitting issues with sahara and latest update of oslo.config | 10:31 |
amoralej | where's the proper site to report bugs to sahara? | 10:31 |
amoralej | tosky, ^ | 10:31 |
amoralej | btw it's strange you are not hitting it in upstream gate, have you seen any issue | 10:32 |
amoralej | recently? | 10:32 |
tosky | amoralej: no | 10:32 |
tosky | there was a change in puppet-sahara though recently | 10:32 |
tosky | and iirc that's not used in the gates, right? We use the devstack plugin | 10:32 |
amoralej | tosky, what i've found is that value_list format is different in https://github.com/openstack/sahara/blob/master/sahara/utils/openstack/keystone.py#L43 after latest oslo.config | 10:33 |
tosky | but when I checked that puppet-sahara change, it looked like there would not be any impact | 10:33 |
amoralej | maybe in devstack it's not entering there for some reason | 10:33 |
tosky | amoralej: oh | 10:33 |
amoralej | some configuration difference | 10:33 |
tosky | amoralej: is the oslo.config version a major bump? | 10:34 |
amoralej | yes | 10:34 |
amoralej | it is | 10:34 |
amoralej | from 5 to 6 | 10:34 |
tosky | argh | 10:34 |
tosky | so I guess we would also need to raise lower-contraints? | 10:34 |
tosky | if we fix the issue | 10:34 |
amoralej | and fix | 10:34 |
amoralej | yeap | 10:34 |
amoralej | tosky, do you use LP to report issues? | 10:34 |
tosky | amoralej: I was going to ask you to start the report - and storyboard, no more LP | 10:35 |
amoralej | ok | 10:35 |
amoralej | tosky, https://storyboard.openstack.org/#!/story/2001835 | 10:46 |
amoralej | tosky, definetively oslo config changed return from _get_file_value | 10:47 |
amoralej | but is that public api method? | 10:47 |
tosky | amoralej: we have some magic there | 10:48 |
tosky | the sahara weekly meeting is in few hours, I will ping the person who knows that code | 10:48 |
amoralej | ack | 10:49 |
amoralej | i'll check what's the differences with devstack configuration | 10:49 |
amoralej | but note this will block oslo.config promotion in RDO | 10:49 |
amoralej | which at some point may be a blocker for others | 10:49 |
tosky | it will be solved soon, but please give us some timezone buffer time :) | 10:50 |
amoralej | tosky, sure :) | 10:51 |
amoralej | tosky, btw, if i add config options in [trustee], it works | 10:52 |
amoralej | that's why it works in devstack | 10:52 |
amoralej | are those options mandatory? | 10:52 |
amoralej | yeah, _get_keystoneauth_cfg is only used if some option in trustee is empty | 10:54 |
*** tellesnobrega has joined #openstack-sahara | 11:18 | |
*** tellesnobrega has quit IRC | 11:19 | |
*** tellesnobrega has joined #openstack-sahara | 11:19 | |
*** rcernin has quit IRC | 11:35 | |
tellesnobrega | tosky, how about this? https://review.openstack.org/#/c/558518/ | 11:38 |
tellesnobrega | is this ready to merge from your tests? | 11:38 |
*** Guest94774 is now known as gokhan_ | 11:41 | |
*** amoralej is now known as amoralej|lunch | 11:53 | |
tosky | tellesnobrega: I can't have a proper run, but at least the failure in my environment is now consistent between sie and pack images | 12:10 |
tellesnobrega | cool | 12:10 |
tellesnobrega | I'm working on ntp and scala | 12:10 |
tellesnobrega | a patch is coming up soon | 12:10 |
tosky | so I'm going to ack it, unless you want to include the fix for the other two issues | 12:11 |
tosky | but yeah, probably they deserve a separate patch | 12:11 |
tellesnobrega | they are on a separated patch | 12:19 |
tosky | tellesnobrega: about scala, the logic may end up being different: an optional parameter requires a default value currently; unless sahara/plugins/image.py is changed, of course | 12:31 |
*** dave-mccowan has joined #openstack-sahara | 12:31 | |
tosky | the problem is that the code does not distinguish between a default not specified and an "empty string is the default" | 12:31 |
tellesnobrega | hmm | 12:32 |
tellesnobrega | the current implementation we have a default set to 2.11.6 | 12:33 |
tellesnobrega | even if the user doesn't pass any value | 12:33 |
tellesnobrega | https://github.com/openstack/sahara/blob/master/sahara/plugins/mapr/resources/images/image.yaml#L13-L17 | 12:33 |
tellesnobrega | this is from a run now | 12:36 |
tellesnobrega | No Presto metadata available for rhel-7-server-rpms | 12:36 |
tellesnobrega | Retrieving http://downloads.lightbend.com/scala/2.11.6/scala-2.11.6.rpm | 12:36 |
tellesnobrega | Preparing... ######################################## | 12:36 |
tellesnobrega | Updating / installing... | 12:36 |
tellesnobrega | scala-2.11.6-0 | 12:36 |
*** gokhan_ has quit IRC | 12:37 | |
*** gokhan_ has joined #openstack-sahara | 12:38 | |
tosky | tellesnobrega: and the old logic was forcing that value only for trusty, while getting the last version when openjdk 8 can be used (so centos) | 12:49 |
tosky | now, we could pin the old version, sure; that logic was originally set by mapr people iirc | 12:49 |
*** knylander has joined #openstack-sahara | 12:50 | |
tosky | in fact it was not possible to force a specific version of scala; that option was added by me (!) | 12:50 |
tosky | I already forgot that | 12:50 |
tellesnobrega | lol | 12:51 |
tosky | in the meantime: bugs.launchpad.net/bugs/1763361 | 12:54 |
tosky | today is bug filing day | 12:54 |
tosky | >.< | 12:54 |
tosky | well, at least it means that I did something, not just pretended to :D | 12:55 |
tellesnobrega | launchpad? oh puppet-sahara | 12:55 |
tosky | and openstack-ansible (because we are ecumenical) | 12:57 |
*** amoralej|lunch is now known as amoralej | 13:24 | |
*** links has quit IRC | 13:27 | |
*** shuyingya has joined #openstack-sahara | 13:32 | |
*** jeremyfreudberg has joined #openstack-sahara | 13:52 | |
*** openstackgerrit has joined #openstack-sahara | 14:11 | |
openstackgerrit | Shu Yingya proposed openstack/sahara master: Remove step upload package to oozie/sharelib https://review.openstack.org/538728 | 14:11 |
openstackgerrit | Shu Yingya proposed openstack/sahara master: Remove step upload package to oozie/sharelib https://review.openstack.org/538728 | 14:24 |
*** jeremyfreudberg has quit IRC | 14:48 | |
*** SergeyLukjanov has quit IRC | 15:00 | |
*** ruhe has quit IRC | 15:00 | |
*** dmitryme has quit IRC | 15:00 | |
*** NikitaKonovalov has quit IRC | 15:00 | |
*** aignatov has quit IRC | 15:00 | |
*** aignatov has joined #openstack-sahara | 15:15 | |
*** dmitryme has joined #openstack-sahara | 15:16 | |
*** NikitaKonovalov has joined #openstack-sahara | 15:16 | |
*** ruhe has joined #openstack-sahara | 15:16 | |
*** SergeyLukjanov has joined #openstack-sahara | 15:17 | |
*** l4yerffej has quit IRC | 15:59 | |
*** l4yerffej has joined #openstack-sahara | 16:07 | |
*** shuyingya has quit IRC | 16:14 | |
*** shuyingya has joined #openstack-sahara | 16:15 | |
*** shuyingya has quit IRC | 16:15 | |
*** shuyingya has joined #openstack-sahara | 16:16 | |
*** shuyingya has quit IRC | 16:34 | |
*** amoralej is now known as amoralej|off | 17:45 | |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: Adding NTP and Scala to mapr image https://review.openstack.org/560985 | 17:48 |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: Adding NTP and Scala to mapr image https://review.openstack.org/560985 | 17:52 |
*** tesseract has quit IRC | 17:55 | |
tellesnobrega | on scala we want the discovery version as default? | 17:56 |
tellesnobrega | is that correct? | 17:56 |
tosky | it's the current behavior | 17:56 |
tosky | right now: | 17:57 |
tosky | - on centos/rhel, the last version is discovered and used | 17:57 |
tosky | - on ubuntu trusty, 2.11.6 is hardcoded (with future fallback to the discovered version) | 17:57 |
tellesnobrega | oh ok, so I'm going to remove the default option from the main script | 17:57 |
tellesnobrega | and set locally on the file the 2.11.6 | 17:57 |
tosky | I suspect that it's not going to work - you need a default option or the validator bails out | 17:58 |
tosky | that's what I hit from a quick test | 17:58 |
tellesnobrega | let me try | 17:58 |
*** pcaruana has quit IRC | 18:09 | |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: Adding ntpdate and Scala to mapr image https://review.openstack.org/560985 | 18:11 |
tellesnobrega | tosky, take a look now, it looks better, and it actually cleaned previous version of scala and updated to newest one | 18:12 |
tosky | let me see | 18:12 |
tosky | tellesnobrega: so now there is no way to override a version | 18:14 |
tosky | and the wrong version is installed on ubuntu | 18:15 |
tellesnobrega | oh, ok, so we want the option to override to an specific version | 18:15 |
tellesnobrega | let me get back | 18:15 |
tellesnobrega | to using default_value | 18:15 |
tosky | take your time :) it's almost dinner time for me | 18:15 |
tellesnobrega | so, what we want is to have a default value, but check for new value when that default is not set correct? | 18:17 |
*** openstackgerrit has quit IRC | 18:19 | |
*** openstackgerrit has joined #openstack-sahara | 18:24 | |
openstackgerrit | Merged openstack/sahara master: Remove step upload package to oozie/sharelib https://review.openstack.org/538728 | 18:24 |
tosky | my idea would be more: if the default is not set, autodetect the version (but we need a value for the default field, hence my suggestion of using 'autodetect') | 18:27 |
tosky | in case of ubuntu (trusty), autodetect means 2.11.6 right now (mapr 6.0.1 supports xenial) | 18:28 |
tosky | in case of centos, autodetect means whatever is the last version (so real autodetect) | 18:28 |
tosky | if the default value is specified, use it | 18:28 |
tellesnobrega | that is what I'm trying now, to remove the default version to 2.11.6 | 18:30 |
tellesnobrega | so it will try to detect in case it is not explicitly set | 18:30 |
tellesnobrega | but I'm not sure that it is possible now | 18:30 |
*** links has joined #openstack-sahara | 18:31 | |
tellesnobrega | seems like every argument has to have a default value set | 18:32 |
tosky | yeah, that's what I noticed | 18:33 |
tellesnobrega | if that is not what we want | 18:33 |
tellesnobrega | we can change that for sure | 18:33 |
tosky | I think that the logic was to make sure that a default value exists, because an empty value may not be good for every case | 18:34 |
tellesnobrega | https://github.com/openstack/sahara/blob/master/sahara/plugins/images.py#L131-L134 | 18:34 |
tellesnobrega | this is the issue | 18:34 |
tosky | but now we have the usual problem to distinguish between an None value and an empty string | 18:34 |
tellesnobrega | you mena if we remove this check? | 18:37 |
tosky | if we simply remove this check, yes | 18:40 |
tosky | that's where I stopped investigating waiting for discussiong | 18:40 |
tosky | and then I thought about using a special value for the default field | 18:41 |
tellesnobrega | that is a simpler option | 18:41 |
tellesnobrega | use default to 1 | 18:42 |
tosky | the value does not matter much, as long as it's clearly not a valid version | 18:42 |
tellesnobrega | that sounds like a safer solution for now | 18:44 |
tellesnobrega | I will work on it now | 18:44 |
tosky | with that, the original code will be mostly untouched | 18:44 |
tellesnobrega | yes | 18:47 |
tellesnobrega | the fallback should be 2.11.6 in both cases? | 18:52 |
openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: Adding ntpdate and Scala to mapr image https://review.openstack.org/560985 | 19:09 |
tosky | tellesnobrega: only for trusty | 19:27 |
tosky | otherwise the autodetect would not make sense | 19:27 |
tellesnobrega | fallback I mean in case autodetect fails | 19:28 |
tosky | oh, uhm | 19:29 |
tosky | what do we do right now? | 19:29 |
tellesnobrega | fallback to default_version | 19:29 |
tosky | in sie | 19:29 |
tellesnobrega | but since default_version is "1" | 19:29 |
tellesnobrega | same | 19:29 |
tellesnobrega | falls back to 2.11.6 | 19:29 |
tellesnobrega | https://github.com/openstack/sahara-image-elements/blob/83c3011f69389e5e1459e5005134a0ff52e8bfcd/elements/hadoop-mapr/install.d/41-scala#L28-L30 | 19:30 |
*** links has quit IRC | 19:46 | |
*** tosky___ has joined #openstack-sahara | 20:44 | |
*** tosky has quit IRC | 20:45 | |
*** tosky___ is now known as tosky | 20:45 | |
*** openstackstatus has quit IRC | 21:27 | |
*** openstack has joined #openstack-sahara | 21:30 | |
*** ChanServ sets mode: +o openstack | 21:30 | |
*** rcernin has joined #openstack-sahara | 22:30 | |
-openstackstatus- NOTICE: The Etherpad service at https://etherpad.openstack.org/ is being restarted to pick up the latest release version; browsers should see only a brief ~1min blip before reconnecting automatically to active pads | 23:40 | |
*** tosky has quit IRC | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!