| *** hoonetorg has joined #openstack-sahara | 00:09 | |
| *** hoonetorg has quit IRC | 00:14 | |
| *** zchkun has joined #openstack-sahara | 01:59 | |
| openstackgerrit | Merged openstack/sahara-extra master: Add support to build hadoop-2.7.5 related package https://review.openstack.org/561592 | 02:16 |
|---|---|---|
| *** caowei has joined #openstack-sahara | 02:53 | |
| *** zchkun has joined #openstack-sahara | 03:00 | |
| *** links has joined #openstack-sahara | 04:29 | |
| *** pgadiya has joined #openstack-sahara | 04:38 | |
| *** pgadiya has quit IRC | 04:38 | |
| *** tesseract has joined #openstack-sahara | 07:01 | |
| *** pcaruana has joined #openstack-sahara | 07:06 | |
| *** amoralej|off is now known as amoralej | 07:20 | |
| *** caowei has quit IRC | 07:50 | |
| openstackgerrit | Thomas Goirand proposed openstack/python-saharaclient master: Fix build with Sphinx 1.7.x https://review.openstack.org/564136 | 08:42 |
| *** hoonetorg has joined #openstack-sahara | 09:49 | |
| *** caowei has joined #openstack-sahara | 10:10 | |
| zigo | Can someone review this 4 lines patch? | 11:44 |
| zigo | I already pushed saharaclient to Debian with it. | 11:44 |
| *** amoralej is now known as amoralej|lunch | 11:48 | |
| *** caowei has quit IRC | 11:51 | |
| tellesnobrega | zigo, I look into it | 12:03 |
| *** tosky has joined #openstack-sahara | 12:09 | |
| *** amoralej|lunch is now known as amoralej | 12:40 | |
| zigo | tellesnobrega: Cheers ! | 12:50 |
| tellesnobrega | tosky, can you take a look as well? | 12:50 |
| tosky | zigo: the sphinx thing? I know where it come from (sphinx 1.7 landed on sid few days ago), but is it going to be "the" fix for everyone? | 12:51 |
| tosky | right now we have 1.6.something in upper-constraints, so I guess that simply no one looked at that | 12:51 |
| tosky | uhm, apparently we are the only one who import that file | 12:55 |
| tosky | actually that file was introduced in order to fix a bug and I'm not sure I see the connection | 12:58 |
| tosky | https://storyboard.openstack.org/#!/story/1551292 | 12:58 |
| tosky | which lead to https://review.openstack.org/#/c/326582/ | 12:58 |
| tosky | I wonder were we use that exactly | 13:00 |
| tosky | uhm | 13:00 |
| tellesnobrega | hmm | 13:01 |
| tellesnobrega | seems odd | 13:01 |
| tellesnobrega | tosky, btw I'm building a cdh image to try and test, not sure it will work here (internet too slow) | 13:06 |
| tosky | so, that code is needed by a custom sphinx extension which automatically generates the documentation from docstrings for the CLI part, so the openstackclient plugin | 13:08 |
| zigo | tosky: Heat already imports the module from docutils, if you prefer, you can just import that one. In Sphinx 1.6, that Directive module is already deprecated, you know ... | 13:08 |
| zigo | https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896634 has the details... | 13:09 |
| openstack | Debian bug 896634 in src:python-saharaclient "FTBFS with sphinx 1.7.2: exception: cannot import name 'Directive'" [Serious,Fixed] | 13:09 |
| tosky | that is similar to what happens to API generation; that module could be useful outside there, I didn't check if it's there | 13:09 |
| zigo | According to the release notes of Sphinx 1.6 [0]: | 13:09 |
| zigo | sphinx.util.compat.Directive class is now deprecated. Please | 13:09 |
| zigo | use instead docutils.parsers.rst.Directive | 13:09 |
| zigo | [0] http://www.sphinx-doc.org/en/master/changes.html#id35 | 13:09 |
| tosky | zigo: no need for the details; I understand the bug; I was wondering if we really still need that code | 13:10 |
| zigo | So even using Sphinx 1.6, you're not supposed to use that Directive. | 13:10 |
| zigo | Ah ok ! :) | 13:10 |
| zigo | Sorry. | 13:10 |
| * zigo hides | 13:10 | |
| tosky | zigo: we depend on sphinx>=1.6.2, so I think that you can remove the try ... catch and use the new import directly | 13:10 |
| tosky | the gates should notice the issue | 13:10 |
| tosky | if any issue | 13:10 |
| zigo | Agreed. | 13:11 |
| zigo | I can fix my patch then. | 13:11 |
| tellesnobrega | thanks tosky | 13:11 |
| tellesnobrega | and zigo | 13:11 |
| openstackgerrit | Thomas Goirand proposed openstack/python-saharaclient master: Fix build with Sphinx 1.7.x https://review.openstack.org/564136 | 13:12 |
| zigo | There you go... | 13:12 |
| tosky | let's see the gates | 13:13 |
| openstackgerrit | Chuck Short proposed openstack/sahara-dashboard master: Remove mox3 from DataProcessingImageRegistryTests https://review.openstack.org/563380 | 13:15 |
| openstackgerrit | Chuck Short proposed openstack/sahara-dashboard master: Remove mox3 from DataProcessingClusterTemplateTests https://review.openstack.org/563424 | 13:17 |
| tosky | zigo: the commit message too, please | 13:31 |
| tosky | no more ImportError | 13:31 |
| openstackgerrit | Merged openstack/sahara-dashboard master: Require the (soon-to-be) Rocky version of Horizon https://review.openstack.org/563733 | 13:34 |
| *** dave-mccowan has joined #openstack-sahara | 13:34 | |
| tosky | the -2 was just to prevent a merge - I never remember if -w is enough | 13:36 |
| zigo | k | 13:36 |
| openstackgerrit | Thomas Goirand proposed openstack/python-saharaclient master: Fix build with Sphinx 1.7.x https://review.openstack.org/564136 | 13:36 |
| zigo | fixed commit message | 13:36 |
| tosky | thanks | 13:38 |
| *** dave-mcc_ has joined #openstack-sahara | 13:48 | |
| *** dave-mccowan has quit IRC | 13:51 | |
| openstackgerrit | Merged openstack/python-saharaclient master: Fix build with Sphinx 1.7.x https://review.openstack.org/564136 | 14:09 |
| *** tmckay has joined #openstack-sahara | 14:20 | |
| *** tosky has quit IRC | 15:01 | |
| *** hoonetorg has quit IRC | 15:01 | |
| *** zchkun has quit IRC | 15:01 | |
| *** zigo has quit IRC | 15:01 | |
| *** zigo has joined #openstack-sahara | 15:01 | |
| *** tosky has joined #openstack-sahara | 15:04 | |
| *** hoonetorg has joined #openstack-sahara | 15:04 | |
| *** zchkun has joined #openstack-sahara | 15:04 | |
| *** ltosky[m] has quit IRC | 15:04 | |
| *** zchkun has quit IRC | 15:51 | |
| *** pcaruana has quit IRC | 15:57 | |
| *** pcaruana has joined #openstack-sahara | 15:59 | |
| *** pcaruana has quit IRC | 16:08 | |
| *** links has quit IRC | 16:09 | |
| *** vkmc- has joined #openstack-sahara | 16:09 | |
| *** vkmc has quit IRC | 16:10 | |
| *** vkmc- is now known as vkmc | 16:10 | |
| *** vkmc has quit IRC | 16:10 | |
| *** vkmc has joined #openstack-sahara | 16:10 | |
| *** vkmc has quit IRC | 16:10 | |
| *** vkmc has joined #openstack-sahara | 16:10 | |
| *** ltosky[m] has joined #openstack-sahara | 16:16 | |
| *** amoralej is now known as amoralej|off | 16:51 | |
| *** links has joined #openstack-sahara | 17:08 | |
| *** links has quit IRC | 17:09 | |
| openstackgerrit | Chuck Short proposed openstack/sahara-dashboard master: Drop mox3 from DataProcessingJobBinaryTests https://review.openstack.org/564290 | 17:19 |
| *** pcaruana has joined #openstack-sahara | 17:20 | |
| *** tosky has quit IRC | 17:25 | |
| *** tosky has joined #openstack-sahara | 17:26 | |
| *** ukaynar has joined #openstack-sahara | 18:57 | |
| openstackgerrit | Andy Smith proposed openstack/openstack-ansible-os_sahara master: (WIP) Update to use oslo.messaging service for RPC and Notify https://review.openstack.org/564325 | 19:28 |
| *** tesseract has quit IRC | 20:40 | |
| *** pcaruana has quit IRC | 20:42 | |
| *** ukaynar has quit IRC | 21:03 | |
| *** ukaynar has joined #openstack-sahara | 21:12 | |
| *** openstackgerrit has quit IRC | 21:20 | |
| *** dave-mcc_ has quit IRC | 21:36 | |
| *** dave-mccowan has joined #openstack-sahara | 22:15 | |
| *** dave-mccowan has quit IRC | 22:36 | |
| *** ukaynar has quit IRC | 22:51 | |
| *** rcernin has joined #openstack-sahara | 22:52 | |
| *** ukaynar has joined #openstack-sahara | 22:59 | |
| *** tellesnobrega has quit IRC | 23:02 | |
| *** ukaynar has quit IRC | 23:09 | |
| *** tellesnobrega has joined #openstack-sahara | 23:21 | |
| *** tellesnobrega has quit IRC | 23:28 | |
| *** tosky has quit IRC | 23:50 | |
| *** ukaynar has joined #openstack-sahara | 23:55 | |
| *** ukaynar has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!