| openstackgerrit | Merged openstack/sahara master: Import the legacy grenade sahara job https://review.openstack.org/590583 | 01:16 |
|---|---|---|
| *** rcernin has quit IRC | 01:24 | |
| *** rcernin has joined #openstack-sahara | 01:24 | |
| *** dave-mccowan has quit IRC | 02:13 | |
| *** Bhujay has joined #openstack-sahara | 04:33 | |
| *** links has joined #openstack-sahara | 05:41 | |
| *** zigo has quit IRC | 05:49 | |
| *** links has quit IRC | 06:09 | |
| *** Bhujay has quit IRC | 06:16 | |
| *** hoonetorg has joined #openstack-sahara | 06:24 | |
| *** rcernin has quit IRC | 06:33 | |
| *** Bhujay has joined #openstack-sahara | 06:38 | |
| *** tosky has joined #openstack-sahara | 07:41 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: Make sahara-grenade job voting on the "gate" queue too https://review.openstack.org/599530 | 08:42 |
| tosky | tellesnobrega: first release of sahara-tests with rocky support (which will be followed by a 0.7.1 with more S3 support): https://review.openstack.org/#/c/599540/ | 09:21 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM grenade test: do we really need to specify the branch for the source? https://review.openstack.org/599542 | 09:35 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Naively try etcd3 instead of memcached as tooz backend https://review.openstack.org/599548 | 10:00 |
| *** dave-mccowan has joined #openstack-sahara | 10:42 | |
| tellesnobrega | tosky, looking now | 10:49 |
| tellesnobrega | tosky, I'm down to 9 failing tests | 10:58 |
| tosky | oh | 12:04 |
| tellesnobrega | can you take a look and see if you know what it is? it is on assert_has_calls | 13:24 |
| tellesnobrega | it says the call are not in the calls list | 13:24 |
| tellesnobrega | I'm not really sure what is going on | 13:24 |
| tosky | uh, where? | 13:25 |
| tosky | maybe you changed the code in a way that the functions which were called before are not the same | 13:26 |
| tosky | so now the assertion is failing because the list of functions that the mock system expected to see are not there anymore | 13:26 |
| tellesnobrega | I will show you the error | 13:28 |
| tellesnobrega | http://pastebin.test.redhat.com/640801 | 13:29 |
| tellesnobrega | this is one of the tests | 13:30 |
| tellesnobrega | but most fail the same way | 13:30 |
| tosky | ehm, the pastebin :) | 13:33 |
| tosky | well, yeah, probably something with the calls parameter of r.execute_command.assert_has_calls (I guess execute_command is a mock) | 13:34 |
| tosky | it probably contains some calls which are not executed anymore, because they changed | 13:34 |
| tosky | or the new code does not execute them anymore but it should, and then it's a real porting error | 13:35 |
| tellesnobrega | this one with extjs I don't think it changed | 13:36 |
| tellesnobrega | let me show you the code | 13:36 |
| tellesnobrega | https://github.com/tellesnobrega/sahara-plugins/blob/master/sahara_plugins/plugins/cdh/plugin_utils.py#L356-L368 | 13:36 |
| tellesnobrega | https://github.com/tellesnobrega/sahara-plugins/blob/master/sahara_plugins/plugins/cdh/plugin_utils.py#L356-L368 | 13:37 |
| tosky | and the test code? | 13:37 |
| tellesnobrega | https://github.com/tellesnobrega/sahara-plugins/blob/master/sahara_plugins/tests/unit/plugins/cdh/base_plugin_utils_test.py#L245-L262 | 13:40 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Naively try etcd3 instead of memcached as tooz backend https://review.openstack.org/599548 | 14:16 |
| *** Bhujay has quit IRC | 14:17 | |
| tosky | tellesnobrega: uhm, I would try to print out the real calls | 14:19 |
| tellesnobrega | tosky, will try that | 14:19 |
| tellesnobrega | thanks | 14:19 |
| *** openstackgerrit has quit IRC | 15:20 | |
| *** openstackgerrit has joined #openstack-sahara | 16:06 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara stable/rocky: Import the legacy grenade sahara job https://review.openstack.org/599666 | 16:06 |
| *** Bhujay has joined #openstack-sahara | 16:17 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Naively try etcd3 instead of memcached as tooz backend https://review.openstack.org/599548 | 16:24 |
| openstackgerrit | bhujay kumar proposed openstack/sahara master: Correct repo_id_map for hdp 2.5 https://review.openstack.org/599677 | 16:26 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara stable/queens: Import the legacy grenade sahara job https://review.openstack.org/599683 | 16:33 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara stable/pike: Import the legacy grenade sahara job https://review.openstack.org/599684 | 16:36 |
| *** openstackgerrit has quit IRC | 17:22 | |
| *** Bhujay has quit IRC | 17:31 | |
| tosky | tellesnobrega: https://review.openstack.org/#/c/599530/ is ready to go too | 19:28 |
| *** openstackgerrit has joined #openstack-sahara | 19:50 | |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/openstack-ansible-os_sahara stable/rocky: Update branch to point to Rocky https://review.openstack.org/599806 | 19:50 |
| tellesnobrega | tosky, will review | 19:58 |
| tellesnobrega | done | 19:59 |
| tosky | thanks | 20:00 |
| tosky | I need to recheck the two other grenade backports | 20:00 |
| tosky | it's a bit of a mess | 20:00 |
| tellesnobrega | how come? | 20:04 |
| tosky | there are few knots to solve, and as usual we are the only ones which depends on another package (heat) | 20:06 |
| tosky | so for some reason python-heatclient is installed from the wrong branch | 20:06 |
| tellesnobrega | hmm | 20:07 |
| tellesnobrega | I see | 20:07 |
| tosky | you can see it from the grenade.txt.something.gz log | 20:08 |
| tellesnobrega | will take a look | 20:11 |
| tellesnobrega | do you know how to print calls from remote? | 20:17 |
| tellesnobrega | r.execute_command.calls? | 20:17 |
| tosky | tellesnobrega: maybe mock_calls: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.mock_calls | 20:20 |
| tosky | but I didn't understand where the mock for r.execute_command is created | 20:20 |
| tellesnobrega | so, weird stuff is happening here | 20:23 |
| tellesnobrega | I see the calls when I print r.execute_command.mock_calls | 20:24 |
| tellesnobrega | (Pdb) print(r.execute_command.mock_calls) | 20:24 |
| tellesnobrega | [call('ls /var/lib/oozie/ext-2.2', raise_when_error=False), | 20:24 |
| tellesnobrega | call().__getitem__(0), | 20:24 |
| tellesnobrega | call().__getitem__().__ne__(0), | 20:24 |
| tellesnobrega | call("curl -L -o '/var/lib/oozie/extjs.zip' http://tarballs.openstack.org/sahara/dist/common-artifacts/ext-2.2.zip", run_as_root=True), | 20:24 |
| tellesnobrega | call('unzip /var/lib/oozie/extjs.zip -d /var/lib/oozie', run_as_root=True)] | 20:24 |
| tellesnobrega | AssertionError: (call("curl -L -o '/var/lib/oozie/extjs.zip' https://tarballs.openstack.org/sahara-extra/dist/common-artifacts/ext-2.2.zip", run_as_root=True),) not all found in call list | 20:24 |
| tellesnobrega | when I run the tests from current sahara code | 20:26 |
| tellesnobrega | the only difference is this at the end of call list | 20:27 |
| tellesnobrega | call.calls.__str__() | 20:27 |
| tosky | notice the difference http -> https | 20:29 |
| tosky | wonder how it works now, you probably forked the plugins earlier but rebased the base | 20:30 |
| tosky | http://tarballs... vs https://tarballs | 20:30 |
| tosky | tellesnobrega: ^^ | 20:31 |
| tellesnobrega | I can't believe I missed that | 20:31 |
| openstackgerrit | Merged openstack/sahara stable/rocky: Import the legacy grenade sahara job https://review.openstack.org/599666 | 20:34 |
| tellesnobrega | a bit more, there was also a link sahara-extra | 20:41 |
| tellesnobrega | 3 failing tests now | 20:42 |
| openstackgerrit | Merged openstack/sahara master: Make sahara-grenade job voting on the "gate" queue too https://review.openstack.org/599530 | 21:34 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Naively try etcd3 instead of memcached as tooz backend https://review.openstack.org/599548 | 22:45 |
| *** rcernin has joined #openstack-sahara | 22:55 | |
| *** tosky has quit IRC | 23:48 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Naively try etcd3 instead of memcached as tooz backend https://review.openstack.org/599548 | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!