openstackgerrit | Merged openstack/sahara master: Force the format of ssh key to PEM, at least for now https://review.openstack.org/605028 | 06:02 |
---|---|---|
*** pcaruana has joined #openstack-sahara | 06:11 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/openstack-ansible-os_sahara master: Updated from OpenStack Ansible Tests https://review.openstack.org/605956 | 06:21 |
*** rcernin has quit IRC | 07:12 | |
*** tosky has joined #openstack-sahara | 07:50 | |
openstackgerrit | Luigi Toscano proposed openstack/sahara stable/rocky: Force the format of ssh key to PEM, at least for now https://review.openstack.org/605996 | 08:25 |
*** tosky has quit IRC | 09:02 | |
*** tosky has joined #openstack-sahara | 09:03 | |
*** guimaluf has quit IRC | 09:44 | |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: doc: restructure the image building documentation https://review.openstack.org/604187 | 10:32 |
*** tellesnobrega has joined #openstack-sahara | 11:45 | |
*** Bhujay has joined #openstack-sahara | 11:58 | |
openstackgerrit | Merged openstack/openstack-ansible-os_sahara master: Updated from OpenStack Ansible Tests https://review.openstack.org/605956 | 12:48 |
Gaasmann | tosky: Should I create a second commit on the same review or squash the whole thing in a single one? | 13:08 |
tellesnobrega | Gaasmann, you can edit your previous commit | 13:10 |
tosky | Gaasmann: up to you; in this case I don't have a specific guidelines; if you squash the commits, of course, you need to change the title and the description | 13:10 |
tosky | and add an additional task (see my comment) | 13:10 |
Gaasmann | sure, I'll do that | 13:12 |
tosky | thanks! | 13:14 |
Gaasmann | I was thinking, should I change the shebang to /bin/sh too? keeping /bin/bash or whatever is a bit misleading no? | 13:34 |
tosky | that would make sense too, yes | 13:37 |
Gaasmann | I see weird stuff like sahara/plugins/resources/cron-script with syntax like %(user)s | 13:51 |
Gaasmann | Is that file a template read by something? | 13:52 |
tosky | that's unrelated | 13:53 |
tosky | only stuff under sahara/plugins/<plugin>/.../images/ and referenced by the yaml files | 13:54 |
tosky | other scripts are out of scope for sahara-image-pack | 13:54 |
tosky | they are used internally | 13:54 |
Gaasmann | ho ok, then I might have modified a script out of scope already. I'll revert that also | 13:56 |
openstackgerrit | Nicolas Haller proposed openstack/sahara master: sahara-image-pack: remove bashisms from shell scripts https://review.openstack.org/605798 | 14:24 |
tosky | at a first glance, the list of files looks correct | 14:25 |
*** Bhujay has quit IRC | 14:58 | |
Gaasmann | tosky: My image generation fails with the following | 17:19 |
Gaasmann | Connecting to tarballs.openstack.org (tarballs.openstack.org)|23.253.108.137|:443... connected. | 17:19 |
Gaasmann | OpenSSL: error:140943FC:SSL routines:ssl3_read_bytes:sslv3 alert bad record mac | 17:19 |
Gaasmann | Unable to establish SSL connection. | 17:19 |
Gaasmann | Is it related with https://review.openstack.org/602507 ? | 17:19 |
tellesnobrega | Gaasmann, not sure if it is related, that issue is related to the gate. It could be the same if your network is setup similar to the gate | 17:28 |
Gaasmann | tellesnobrega: I just tried with curl instead of wget and it works. I don't know what is the difference between the two commands | 19:13 |
tosky | Gaasmann: possibly that, try to apply that change | 19:16 |
tosky | I think we should just switch to curl if it works consistently | 19:17 |
Gaasmann | I'll try changing that for all scripts, I'm testing cdh 5.11.0 right know | 19:18 |
tosky | I'd suggest a different review for that, thought | 19:26 |
tosky | I guess I can extend my review and make it "real" (not DNM) | 19:27 |
Gaasmann | ambari/resources/images/common/oracle_java I think the link for jdk-7u51-linux-x64.tar.gz is broken | 19:38 |
tosky | again? | 19:41 |
tosky | the default choice should be openjdk iirc | 19:41 |
Gaasmann | Updates for Java SE 7 released after April 2015, and updates for Java SE 6 released after April 2013 are only available to Oracle Customers through My Oracle Support (requires support login). | 19:42 |
tosky | yes, but the download login should work through some magic | 19:44 |
tosky | or at least it was done in the past | 19:44 |
tosky | but anyway, the default openjdk should do it | 19:44 |
Gaasmann | should work but not for java 7 | 19:44 |
tosky | it should too | 19:44 |
tosky | at least in queens, umpf; it looks like ambari 2.6, used in rocky, requires jdk 8 | 19:46 |
tosky | but openjdk-8 seems to be available in xenial | 19:47 |
*** openstackgerrit has quit IRC | 20:07 | |
*** tosky has quit IRC | 22:42 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!