| *** openstackgerrit has joined #openstack-sahara | 03:52 | |
| openstackgerrit | Merged openstack/openstack-ansible-os_sahara stable/rocky: Enable overriding the service setup host python interpreter https://review.openstack.org/622517 | 03:52 |
|---|---|---|
| *** rcernin has quit IRC | 06:43 | |
| *** tosky has joined #openstack-sahara | 07:58 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: APIv2 - api-ref documentation for APIv2 https://review.openstack.org/624365 | 11:37 |
| tellesnobrega | tosky, first patch on api-ref | 11:39 |
| tosky | ooooh | 11:41 |
| tosky | uh, and we need to update the rules for ignored-files to make sure that scenario and tempest tests are not executed when only api-ref is touched | 11:43 |
| tellesnobrega | probably a lot of issues | 11:43 |
| tellesnobrega | but still something | 11:44 |
| tosky | this was a good way to review the global status of APIv2 - did you notice any inconsistency? | 11:45 |
| tellesnobrega | Not really, it looks pretty good | 12:02 |
| tosky | good to hear | 12:03 |
| tellesnobrega | and doing this I had a chance to compare with api v1 and apiv1 is really weird in so many places | 12:03 |
| tellesnobrega | mainly the jobs/jobs-execution/job-templates part | 12:03 |
| tellesnobrega | but that part is really weird | 12:03 |
| tosky | those was one of the main changes iirc | 12:03 |
| tosky | shuffling the meaning of jobs <something>, we have hidden the changes for a long time in the dashboard | 12:04 |
| tellesnobrega | yes | 12:04 |
| tellesnobrega | tosky, regarding 500 issue, at first I thought we only needed to check the pagination parameters | 12:23 |
| tellesnobrega | but there are so many parameters that we need to check, all requests have lots of params, specially when we run from client | 12:34 |
| tellesnobrega | so I had to widen the whitelist | 12:35 |
| *** Gaasmann has quit IRC | 12:46 | |
| *** dave-mccowan has joined #openstack-sahara | 12:53 | |
| *** dave-mccowan has quit IRC | 13:01 | |
| tellesnobrega | tosky, on the docs patch, the errors on the gate I had locally, but had to do a workaround to make it work, not sure how to handle that on the gate | 13:10 |
| tosky | tellesnobrega: the duplicated show-node-group-template-details-selector? | 13:15 |
| tosky | why doesn't it happen with other APIs? | 13:15 |
| tellesnobrega | it does | 13:16 |
| tellesnobrega | but it fails on the first one | 13:16 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: APIv2 - Fix 500 on malformed query string on https://review.openstack.org/623300 | 13:17 |
| tellesnobrega | the issue is that the labels are the same, the workaround is simple, change the way docs create the label target to get a random number | 13:20 |
| tosky | did you spy how other projects that provide multiple APIs solve it? | 13:23 |
| tosky | or solved it before ripping out an old API (like cinder?) | 13:23 |
| tellesnobrega | yes | 13:23 |
| tellesnobrega | the simple way, changing small things on the labels | 13:25 |
| tellesnobrega | at least for cinder | 13:25 |
| *** tmckay has quit IRC | 13:25 | |
| tellesnobrega | example: https://github.com/openstack/cinder/blob/master/api-ref/source/v3/capabilities-v3.inc#show-all-back-end-capabilities | 13:25 |
| tellesnobrega | https://github.com/openstack/cinder/blob/master/api-ref/source/v2/capabilities-v2.inc#show-back-end-capabilities | 13:25 |
| tosky | uh :) | 13:25 |
| tellesnobrega | simple fix, we can go that way as well | 13:26 |
| tosky | that's really trickery | 13:26 |
| tellesnobrega | but not sure it is the best way | 13:26 |
| tosky | we could also ask the doc team | 13:26 |
| tellesnobrega | it simply works around the issue | 13:26 |
| tellesnobrega | the workaround was from the docs team | 13:26 |
| tosky | oh | 13:26 |
| tosky | ok | 13:26 |
| tosky | well, there is no much else to say then | 13:26 |
| tellesnobrega | so, I will write the patch for api-ref | 13:28 |
| tosky | fix the engine \o/ | 13:28 |
| tellesnobrega | yes | 13:29 |
| *** tmckay has joined #openstack-sahara | 13:37 | |
| *** dave-mccowan has joined #openstack-sahara | 14:07 | |
| *** dave-mccowan has quit IRC | 14:14 | |
| *** tmckay has quit IRC | 15:20 | |
| *** tmckay has joined #openstack-sahara | 15:37 | |
| *** Gaasmann has joined #openstack-sahara | 15:46 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: APIv2 Changing return payload to project_id https://review.openstack.org/620307 | 17:51 |
| tosky | tellesnobrega: I sent the email about the splitting to openstack-discuss | 20:55 |
| tellesnobrega | nice | 20:59 |
| tellesnobrega | thanks | 20:59 |
| *** rcernin has joined #openstack-sahara | 21:59 | |
| tosky | umpf, I messed up the subject of the email (duplicated) | 23:15 |
| tosky | I always end up with such kind of stupid mistakes when dealing with important duties | 23:16 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!