| *** tosky has quit IRC | 00:22 | |
| openstackgerrit | zhangyunyong proposed openstack/puppet-sahara master: Fix tox.ini https://review.openstack.org/630550 | 02:07 |
|---|---|---|
| *** pcaruana has joined #openstack-sahara | 07:11 | |
| *** tosky has joined #openstack-sahara | 08:37 | |
| *** tellesnobrega has joined #openstack-sahara | 11:38 | |
| tellesnobrega | tosky, morning | 11:47 |
| tosky | tellesnobrega: hi | 11:48 |
| tosky | can I send a review for tagging a new set of rocky releases? | 11:49 |
| tosky | tellesnobrega: we have a significant amount of changes | 11:49 |
| tellesnobrega | tosky, yes please | 11:54 |
| tellesnobrega | I wanted to double check the load plugin dynamically fix you suggested | 11:55 |
| tellesnobrega | the issue you pointed out is that we have a list of plugins that we want to load on the config file | 11:55 |
| tosky | new rocky release: https://review.openstack.org/#/c/630656/ | 11:55 |
| tellesnobrega | but that list may not be able to be fulfilled since we may not have everything installed, correct? | 11:56 |
| tosky | yes, correct | 11:56 |
| tosky | a way to solve this issue is to we make sure that deployers always update that configuration value depending on the plugins installed | 11:56 |
| tosky | that would require no code changes | 11:56 |
| tosky | and leave the check in place | 11:57 |
| tosky | otherwise, no check, and whatever is loaded, is loaded | 11:57 |
| * tosky bbl | 11:57 | |
| tellesnobrega | sure | 11:57 |
| * tosky back (for a while) | 13:02 | |
| *** dave-mccowan has joined #openstack-sahara | 13:14 | |
| *** tellesnobrega has quit IRC | 13:16 | |
| *** wondra has joined #openstack-sahara | 13:50 | |
| wondra | Hi! I'm trying to implement a policy where the Data Processing panel is not visible unless the user has the role BigData. The Sahara API successfully does not work, but the Data Processing panel is still visible. Can you please confirm that is should work? | 14:07 |
| tosky | wondra: I have a vague memory that (and not just for Sahara) policies need to be copied under horizon to have it working, but I'm not totally sure | 16:09 |
| tosky | I worked a bit with policies with the CLI client; on the other hand, the policies should be implemented server-side, regardless of the client, so maybe something else is playing a role | 16:09 |
| tosky | did you already ask to horizon people? | 16:10 |
| wondra | I posted the question in both IRC channels :-). | 16:12 |
| wondra | And yes, I have copied the policy file to Horizon config directory and added it to local_settings.py as POLICY_FILES = { "data-processing": "sahara_policy.json",} | 16:13 |
| wondra | But I'm concerned that there is nothing about policy in the sahara-dashboard code. | 16:15 |
| tosky | well, I don't remember any discussion from the horizon team to plugin owners to add something related to this | 16:17 |
| tosky | but maybe it comes from before the time when the horizon plugins were relevant | 16:18 |
| wondra | I also have the manila-ui plugin and it contains in all tables.py files lines such as: policy_rules = (("share", "share:create"),) | 16:19 |
| tosky | ok, then no, we don't do that | 16:19 |
| tosky | so the answer to your question right now is "no, it will still show, but the operations of course will fail" | 16:19 |
| wondra | Any plans to change that? | 16:20 |
| tosky | it was probably not even known | 16:20 |
| *** pcaruana has quit IRC | 16:20 | |
| tosky | I doubt we will have the bandwidth to implement it before Stein, there are already few other significant changes pending | 16:21 |
| tosky | the starting point is a story - would you please mind creating one on storyboard? | 16:21 |
| wondra | Will do. And I'll ask my developer colleague if he wants that feature enough to implement it. We don't have much experience with Python and none with Horizon. | 16:22 |
| tosky | it does not look like it should be *too* complicated, if it's just about adding the needed policies to each call; but I don't know right now | 16:23 |
| wondra | I think it still will not hide the panel, which is the goal. | 16:24 |
| tosky | that's really a question for the horizon team, then | 16:30 |
| tosky | unless... does the manila panel hides if the policy does not allow people to access it? Or did you try only for Sahara? | 16:31 |
| wondra | Done. | 16:35 |
| wondra | I didn't try for Manila. | 16:35 |
| *** tellesnobrega has joined #openstack-sahara | 17:10 | |
| *** pcaruana has joined #openstack-sahara | 17:15 | |
| *** tellesnobrega has quit IRC | 17:16 | |
| *** tellesnobrega has joined #openstack-sahara | 17:48 | |
| tellesnobrega | tosky, are you around? | 17:50 |
| tosky | tellesnobrega: yes, I am | 17:51 |
| tellesnobrega | so, going back to the topic earlier | 17:52 |
| tellesnobrega | I had to run, my wife had a flat tire, I had to run to help her and turned I had to buy 4 new tires for my car... | 17:53 |
| tosky | o.O | 17:53 |
| tellesnobrega | I'm back for a bit and will be traveling back home soon | 17:53 |
| tellesnobrega | but wanted to discuss before I have to leave and you finish your day | 17:53 |
| tellesnobrega | the current problem is that the user can choose a list of plugins but some of them may not be installed | 17:54 |
| tellesnobrega | Solution 1. Document that the operator has to match in the conf file what is installed in the service | 17:54 |
| tosky | and fix the deployment tools to do it | 17:55 |
| tellesnobrega | Solution 2. Drop the option from the config file and load using setuptools (if what I read quickly is right) | 17:56 |
| tosky | drop the option == make it useless, and remove it later; but yes | 17:57 |
| tellesnobrega | of course | 17:57 |
| tellesnobrega | smoothly deprecate | 17:57 |
| tosky | or at least make it so that it does not fail if the plugin is not installed, but still allows you to restrict the plugins loaded | 17:57 |
| tosky | I mean, you could still may want to install all but disable some of them | 17:58 |
| tosky | so maybe keep it, but adjust the semantic | 17:58 |
| tellesnobrega | Solution 3. Continue using the config file, to subset what is installed | 17:58 |
| tosky | yes | 17:59 |
| tellesnobrega | should we fail if the plugin is not installed and is present on the config file? | 18:00 |
| tellesnobrega | or should we just notify the user that the plugin was not loaded because it is not installed | 18:00 |
| tellesnobrega | ? | 18:00 |
| tosky | right now sahara fails if the plugin is not installed and but it's listed in the config file | 18:01 |
| tosky | so I would maybe issue a warning | 18:02 |
| tellesnobrega | ok, that means keeping the behavior pretty much as is, but instead of failing, warning | 18:03 |
| tellesnobrega | we may need to update the config file with the plugins loaded for future comparisons | 18:03 |
| tellesnobrega | I will take a look on the best way to solve that | 18:03 |
| tellesnobrega | thanks tosky :) | 18:03 |
| tosky | maybe thinking more the best solution will come up | 18:05 |
| tellesnobrega | yes | 18:14 |
| *** dave-mccowan has quit IRC | 18:26 | |
| *** dave-mccowan has joined #openstack-sahara | 18:32 | |
| *** tellesnobrega has quit IRC | 18:36 | |
| *** pcaruana has quit IRC | 19:08 | |
| *** rcernin has joined #openstack-sahara | 22:31 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-plugin-ambari master: Post-import fixes: name, license, doc, translations https://review.openstack.org/630784 | 22:46 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-plugin-cdh master: Post-import fixes: name, license, doc, translations https://review.openstack.org/630785 | 22:46 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-plugin-mapr master: Post-import fixes: name, license, doc, translations https://review.openstack.org/630786 | 22:46 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-plugin-spark master: Post-import fixes: name, license, doc, translations https://review.openstack.org/630787 | 22:46 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-plugin-storm master: Post-import fixes: name, license, doc, translations https://review.openstack.org/630788 | 22:46 |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-plugin-vanilla master: Post-import fixes: name, license, doc, translations https://review.openstack.org/630789 | 22:47 |
| *** tellesnobrega has joined #openstack-sahara | 23:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!