| *** dave-mccowan has joined #openstack-sahara | 01:07 | |
| *** dave-mccowan has quit IRC | 04:31 | |
| *** pcaruana has joined #openstack-sahara | 07:59 | |
| *** rcernin has quit IRC | 08:29 | |
| *** tosky has joined #openstack-sahara | 08:43 | |
| *** tellesnobrega_ has joined #openstack-sahara | 13:59 | |
| *** tellesnobrega has quit IRC | 14:01 | |
| *** dave-mccowan has joined #openstack-sahara | 14:15 | |
| *** pcaruana has quit IRC | 17:13 | |
| *** e0ne has joined #openstack-sahara | 18:58 | |
| *** e0ne has quit IRC | 19:10 | |
| *** e0ne has joined #openstack-sahara | 19:30 | |
| *** e0ne has quit IRC | 19:41 | |
| *** e0ne has joined #openstack-sahara | 19:51 | |
| e0ne | tellesnobrega_: hi. could you please ping me when you have few minutes to chat about sahara-dashboard? | 21:01 |
|---|---|---|
| tosky | e0ne: maybe I can help a bit too | 21:05 |
| e0ne | tosky: I'm looking on legacy-sahara-dashboard-dsvm-integration job | 21:18 |
| tosky | e0ne: did you look at its replacement? | 21:18 |
| e0ne | are these tests working now? I failed to run them on my environment too | 21:19 |
| tosky | e0ne: https://review.openstack.org/#/c/542970/ | 21:19 |
| tosky | I wish I had more time to try to fix them, but I wasn't able to make them run in my environment as well | 21:19 |
| tosky | they run somehow on the gate | 21:19 |
| tosky | and then there are few errors which I can't debug if I can't run them locally | 21:20 |
| tosky | at least with the native jobs | 21:20 |
| tosky | so the last question from Jeremy was about moving the job to experimental | 21:20 |
| tosky | that reminds me that tellesnobrega_ didn't comment on that yet :) | 21:20 |
| e0ne | I would like to have some integration tests working at least in non-voting mode for now | 21:22 |
| tosky | sure, so then we just need to merge the revision above | 21:22 |
| e0ne | tosky: I didn't mention sahara in my mail http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002374.html but I'm going to propose it to other plugins too | 21:22 |
| tosky | e0ne: in our case the issue is to fix them, adapting to the changes that happened in the meantime in the integration tests API and in the sahara-ui itself | 21:23 |
| tosky | because we already had few of them | 21:23 |
| e0ne | are you going to fix them? | 21:24 |
| tosky | as I said, I tried to run them locally, but I've never been able to do it | 21:26 |
| tosky | so the answer is: I don't know | 21:26 |
| tosky | any help is appreciated | 21:26 |
| e0ne | :( | 21:26 |
| e0ne | it's important to horizon to understand which plugins are working and maintained | 21:27 |
| tosky | the plugin is working and maintained so far | 21:28 |
| tosky | the tests were not maintained because the test infrastructure didn't work | 21:28 |
| tosky | but we are short on people now | 21:28 |
| tosky | I would expect that fixing them is easier for people who know the test infrastructure than writing new tests for horizon plugins which don't have any test at all | 21:29 |
| e0ne | we restored integration tests last release | 21:31 |
| tosky | yep, I remember | 21:32 |
| e0ne | so without any tests, we can't guarantee that plugin works and we, horizon team, don't break anything with the latest changes | 21:33 |
| tosky | right, I can understand this | 21:35 |
| tosky | nevertheless, you stepped in as volunteer to add new tests - I think that fixing sahara's tests should be easier :) | 21:36 |
| e0ne | unfortunately, I don't have enough time to setup testing for all plugins :( | 21:40 |
| tosky | so let me understand | 21:42 |
| tosky | there will be time for new tests for plugins which didn't have any | 21:42 |
| tosky | but no time for few fixes on a plugin which had many of them | 21:42 |
| e0ne | tosky: I didn't say it | 21:43 |
| tosky | anyway, that would be fine | 21:44 |
| tosky | just to set expectations | 21:44 |
| e0ne | we'll have a time at least during Train release to setup integration tests | 21:44 |
| tosky | in any case, on our side we will have the native zuul v3 job and have the tests running, even if failing | 21:45 |
| tosky | later on, let's see, we can try to fix them but no guarantees, especially if it's impossible to run them locally | 21:45 |
| e0ne | I agree that's better than nothing | 21:45 |
| e0ne | I just want to understand if you're going to fix tests or not | 21:46 |
| e0ne | because from horizon side, we introduced a lot of breaking changes like new django, tests framework and we broke some plugins:( | 21:47 |
| e0ne | so we want to start test plugins against latest horizon to verify that everything work | 21:47 |
| e0ne | unfortunately, unit tests can't catch some errors | 21:47 |
| tosky | that's a good think (integrated tests) | 21:48 |
| *** dave-mccowan has quit IRC | 22:01 | |
| *** rcernin has joined #openstack-sahara | 22:27 | |
| *** e0ne has quit IRC | 22:32 | |
| *** rcernin has quit IRC | 23:06 | |
| *** rcernin has joined #openstack-sahara | 23:08 | |
| *** openstackgerrit has joined #openstack-sahara | 23:48 | |
| openstackgerrit | Luigi Toscano proposed openstack/sahara-dashboard master: Native Zuul v3 dashboard-integration test https://review.openstack.org/542970 | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!