| *** rcernin has quit IRC | 06:58 | |
| *** tesseract has joined #openstack-sahara | 07:17 | |
| *** tosky has joined #openstack-sahara | 07:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/sahara-plugin-spark master: Imported Translations from Zanata https://review.opendev.org/674232 | 08:55 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/sahara-plugin-storm master: Imported Translations from Zanata https://review.opendev.org/674252 | 10:04 |
| openstackgerrit | Merged openstack/sahara-plugin-spark master: Imported Translations from Zanata https://review.opendev.org/674232 | 10:20 |
| openstackgerrit | Merged openstack/sahara-plugin-storm master: Imported Translations from Zanata https://review.opendev.org/674252 | 10:33 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: Python 3 fixes https://review.opendev.org/672818 | 12:40 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara-plugin-cdh master: Fixes on CDH for python 3 compatibility https://review.opendev.org/673892 | 12:48 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara-plugin-mapr master: Python 3 compatibility fixes https://review.opendev.org/672811 | 12:51 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara-plugin-mapr master: Python 3 compatibility fixes https://review.opendev.org/672811 | 12:56 |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/sahara master: Python 3 fixes https://review.opendev.org/672818 | 12:57 |
| tellesnobrega | tosky, as you probably saw already I have sent some patches for review | 12:57 |
| tellesnobrega | turns out I could read all as bytes | 12:57 |
| tosky | oh | 12:58 |
| tellesnobrega | and for python2 I decoded | 12:58 |
| tellesnobrega | and this allows me to write all as bytes as well | 12:58 |
| tellesnobrega | take a look and let me know what you think | 12:58 |
| tosky | tellesnobrega: is that .encode('utf-8') going to work with files read using 'rb' on python2? I think it may not work when the files have at least one non-ascii character | 13:15 |
| tosky | (that's the CDH patch) | 13:18 |
| tellesnobrega | tosky, encode or decode? | 13:23 |
| tellesnobrega | oh | 13:24 |
| tellesnobrega | found it | 13:24 |
| tellesnobrega | it works because we don't send non-ascii characters there, at least non showed up on tests | 13:25 |
| tellesnobrega | it was mostly dicts on configuration | 13:26 |
| tellesnobrega | and so on | 13:26 |
| tosky | but configuration files may contain non-ascii characters | 13:26 |
| tosky | or better, encode is called on the db_password | 13:27 |
| tellesnobrega | I don't think we send the config files here, just what we need to execute, the config files are written on the instances using the ssh_remote.py | 13:27 |
| tosky | fine, ok; .encode is called on db_password | 13:28 |
| tosky | which is extracted using get_hive_db_password nad get_sentry_db_password | 13:28 |
| tellesnobrega | tosky, the db_password one is because we are getting the script as bytes and db_password is str so we need to make them match | 13:28 |
| tosky | ok; so is db_password always of the right type to make encode work? | 13:30 |
| tosky | what about a unit test? :) | 13:30 |
| tellesnobrega | tosky, I will double check the db_password part | 13:34 |
| tellesnobrega | and will look for places to add tests | 13:34 |
| tellesnobrega | but I just hit an issue when running on python3 | 13:34 |
| tosky | is the getmaintype/get_content_maintype also a change related to... uhm... urllib? | 13:37 |
| tellesnobrega | yes | 13:37 |
| tellesnobrega | httpmessage use to have getmaintype now it has get_content_maintype | 13:37 |
| tellesnobrega | looked for some documentation on a way to get the info without the try but looks the other option would be a lot uglier | 13:38 |
| tellesnobrega | get the property, split by '/' get the last part | 13:38 |
| tellesnobrega | it would work, but I thought the way I did looked bette | 13:38 |
| tellesnobrega | better | 13:38 |
| tellesnobrega | do you have a better idea for that? | 13:39 |
| tellesnobrega | also, do you have specific places where you would like to see unit tests? | 13:45 |
| tosky | I don't have better ideas about that; if the method changed, well, it changed; it was more a question on whether the new method works on python 2.7 | 13:45 |
| tellesnobrega | I see | 13:46 |
| tellesnobrega | but it fails :( | 13:46 |
| tellesnobrega | tried it | 13:46 |
| tosky | regarding the specific place, theoretically speaking, every time a string which may potentially have a strange encoding or unsure whether byte or string is touched | 13:46 |
| tellesnobrega | sure | 13:47 |
| tellesnobrega | I will probably work on tests next week | 13:48 |
| tellesnobrega | I will try to have the patches working today | 13:49 |
| tellesnobrega | and work on tests next week | 13:49 |
| tosky | ok, thanks | 13:53 |
| tosky | I would argue that in order to have the patches working, you need the tests, but that's my inner QE :) | 13:53 |
| tellesnobrega | I fully understand you | 13:55 |
| tellesnobrega | and also I agree with you | 13:55 |
| tellesnobrega | I will try my best | 13:55 |
| tellesnobrega | now I'm hitting different issues on python3 that I wasn't seeing | 13:56 |
| openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: DNM build spark image on ubuntu https://review.opendev.org/674032 | 13:57 |
| *** pcaruana has quit IRC | 16:14 | |
| *** altlogbot_0 has quit IRC | 16:29 | |
| *** irclogbot_0 has quit IRC | 16:33 | |
| *** altlogbot_0 has joined #openstack-sahara | 16:37 | |
| *** irclogbot_0 has joined #openstack-sahara | 16:42 | |
| *** rickflare has joined #openstack-sahara | 16:51 | |
| *** tesseract has quit IRC | 16:58 | |
| *** openstackgerrit has quit IRC | 17:22 | |
| *** guimaluf has joined #openstack-sahara | 18:41 | |
| *** tosky has quit IRC | 19:32 | |
| *** irclogbot_0 has quit IRC | 19:39 | |
| *** irclogbot_3 has joined #openstack-sahara | 19:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!