*** evrardjp has quit IRC | 04:35 | |
*** evrardjp has joined #openstack-sahara | 04:35 | |
*** rcernin has quit IRC | 05:24 | |
*** rcernin has joined #openstack-sahara | 06:09 | |
*** rcernin has quit IRC | 06:10 | |
*** rcernin has joined #openstack-sahara | 06:11 | |
*** rcernin has quit IRC | 06:25 | |
*** rcernin has joined #openstack-sahara | 06:26 | |
openstackgerrit | Andreas Jaeger proposed openstack/sahara master: Cleanup Python 2.7 support https://review.opendev.org/715466 | 06:30 |
---|---|---|
openstackgerrit | Andreas Jaeger proposed openstack/sahara master: Cleanup Python 2.7 support https://review.opendev.org/715466 | 06:31 |
*** rcernin has quit IRC | 07:13 | |
*** tosky has joined #openstack-sahara | 07:45 | |
*** evrardjp has quit IRC | 09:51 | |
*** evrardjp has joined #openstack-sahara | 09:51 | |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: Update hacking for Python3 https://review.opendev.org/716176 | 13:38 |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: zuul: remove (extra) sahara-tests-scenario-py3 https://review.opendev.org/721958 | 13:40 |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: Use unittest.mock instead of third party mock https://review.opendev.org/721011 | 13:41 |
tosky | (a few rebases) | 13:41 |
tosky | tellesnobrega: if you approve the "skip failing unit test" jobs, we can unblock a few reviews | 13:42 |
tellesnobrega | tosky, will approve | 13:42 |
tellesnobrega | saw it yesterday, I was waiting for zuul | 13:43 |
tosky | I rebased all other patches on top of that, or on top of other patches on top of it | 13:44 |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: Update hacking for Python3 https://review.opendev.org/716176 | 13:45 |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: Native zuul v3 grenade job, cleanup -py3 https://review.opendev.org/638390 | 13:48 |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: Fix duplicated words issue like "is is provided to" https://review.opendev.org/701175 | 14:23 |
tellesnobrega | tosky, merged | 15:06 |
tellesnobrega | approved actually | 15:06 |
tellesnobrega | merged in a but | 15:06 |
tellesnobrega | bit | 15:06 |
tosky | tellesnobrega: thanks! There are also a few other reviews where I added +2 and we could have before tomorrow (also because they change a few dependencies) | 15:07 |
tosky | jeremyfreudberg: ^^ | 15:07 |
tosky | so we can cut a cleaner rc1 | 15:08 |
tellesnobrega | will take a look | 15:09 |
tosky | there also two for the plugins (mock removal), but those can wait | 15:09 |
tosky | I think the relevant ones (with dependency changes) are https://review.opendev.org/#/c/715466/ and https://review.opendev.org/#/c/716176/ | 15:10 |
* tellesnobrega reviewed | 15:11 | |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Ussuri contributor docs community goal https://review.opendev.org/720211 | 16:11 |
jeremyfreudberg | oops, forgot the redirects | 16:11 |
tosky | jeremyfreudberg: do you need a diff for those? | 16:13 |
jeremyfreudberg | tosky: you already gave what i need, i just forogt to do it | 16:13 |
tosky | oki | 16:13 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Ussuri contributor docs community goal https://review.opendev.org/720211 | 16:13 |
*** tellesnobrega_ has joined #openstack-sahara | 16:23 | |
*** tellesnobrega has quit IRC | 16:24 | |
jeremyfreudberg | tosky: see https://etherpad.opendev.org/p/sahara-contrib-doc-goal | 16:26 |
openstackgerrit | Merged openstack/sahara master: (Temporarily) skip TestVerifications tests https://review.opendev.org/721613 | 16:27 |
*** evrardjp has quit IRC | 16:35 | |
*** evrardjp has joined #openstack-sahara | 16:35 | |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara master: Ussuri contributor docs community goal https://review.opendev.org/720211 | 16:44 |
tosky | uhm, so case 2. is easy, case 1., just point to https://docs.openstack.org/sahara/latest/contributor/contributing.rst maybe? Let me check what cinder did | 16:49 |
tosky | jeremyfreudberg: https://opendev.org/openstack/cinder-tempest-plugin/commit/82b3e2df84957d8b2b74059e50732cb5e50a65c0 and https://opendev.org/openstack/python-cinderclient/commit/9191d76450c0d80400a08e730a8f54f826e23022 | 16:49 |
jeremyfreudberg | so it seems the cinderclient way is what we should do for the 'case 1' repos | 16:51 |
jeremyfreudberg | it's a bit more work but i guess it makes sense to do | 16:51 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-dashboard master: Ussuri contributor docs community goal https://review.opendev.org/722083 | 17:06 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-extra master: Ussuri contributor docs community goal https://review.opendev.org/722084 | 17:06 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-image-elements master: Ussuri contributor docs community goal https://review.opendev.org/722085 | 17:07 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-specs master: Ussuri contributor docs community goal https://review.opendev.org/722086 | 17:07 |
jeremyfreudberg | tosky: there are the easy ones | 17:08 |
tosky | yep, I'm going to review | 17:09 |
openstackgerrit | Merged openstack/sahara-specs master: Ussuri contributor docs community goal https://review.opendev.org/722086 | 17:38 |
tosky | it seems there is an issue with devstack-gate on the legacy jobs (hence the failure of sahara-grenade), I asked on #openstack-qa | 17:43 |
tosky | but there are a few reviews we can merge anyway | 17:43 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-ambari master: Ussuri contributor docs community goal https://review.opendev.org/722095 | 17:44 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-cdh master: Ussuri contributor docs community goal https://review.opendev.org/722096 | 17:44 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-mapr master: Ussuri contributor docs community goal https://review.opendev.org/722097 | 17:44 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-spark master: Ussuri contributor docs community goal https://review.opendev.org/722098 | 17:44 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-storm master: Ussuri contributor docs community goal https://review.opendev.org/722099 | 17:44 |
openstackgerrit | Merged openstack/sahara-dashboard master: Ussuri contributor docs community goal https://review.opendev.org/722083 | 17:44 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-vanilla master: Ussuri contributor docs community goal https://review.opendev.org/722100 | 17:44 |
jeremyfreudberg | tosky, just pushed for the plugins | 17:44 |
jeremyfreudberg | first time using some automation, it may have gone horribly wrong | 17:44 |
tosky | let's see | 17:45 |
jeremyfreudberg | tosky: oh, i already messed up the CONTRIBUTING.rst (final line) | 17:47 |
jeremyfreudberg | should be the project specific one | 17:47 |
openstackgerrit | Merged openstack/python-saharaclient master: Use unittest.mock instead of third party mock https://review.opendev.org/720998 | 17:48 |
openstackgerrit | Merged openstack/sahara-plugin-ambari master: Use unittest.mock instead of third party mock https://review.opendev.org/721012 | 17:48 |
openstackgerrit | Merged openstack/sahara-plugin-cdh master: Use unittest.mock instead of third party mock https://review.opendev.org/721013 | 17:48 |
openstackgerrit | Merged openstack/sahara master: Use unittest.mock instead of third party mock https://review.opendev.org/721011 | 17:48 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-ambari master: Ussuri contributor docs community goal https://review.opendev.org/722095 | 17:50 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-cdh master: Ussuri contributor docs community goal https://review.opendev.org/722096 | 17:50 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-mapr master: Ussuri contributor docs community goal https://review.opendev.org/722097 | 17:50 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-spark master: Ussuri contributor docs community goal https://review.opendev.org/722098 | 17:50 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-storm master: Ussuri contributor docs community goal https://review.opendev.org/722099 | 17:50 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-plugin-vanilla master: Ussuri contributor docs community goal https://review.opendev.org/722100 | 17:50 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-tests master: Ussuri contributor docs community goal https://review.opendev.org/722105 | 17:57 |
jeremyfreudberg | and there's sahara-tests too | 17:57 |
openstackgerrit | Jeremy Freudberg proposed openstack/python-saharaclient master: Ussuri contributor docs community goal https://review.opendev.org/722107 | 18:00 |
openstackgerrit | Jeremy Freudberg proposed openstack/sahara-tests master: Ussuri contributor docs community goal https://review.opendev.org/722105 | 18:00 |
openstackgerrit | Merged openstack/sahara-extra master: Ussuri contributor docs community goal https://review.opendev.org/722084 | 18:12 |
tosky | at least one failed :) | 18:19 |
tosky | I will recheck after dinner | 18:20 |
jeremyfreudberg | yeah i messed up the sahara-tests one slightly | 18:22 |
jeremyfreudberg | enjoy your dinner; i also need to go tend to other non-sahara matters for a while | 18:22 |
tosky | jeremyfreudberg: for some reasons, the modified index in some of the guides has an extra blank between the existing line and the newly-added line | 18:25 |
tosky | it's the same, but I'm not sure why the script acted differently :) | 18:26 |
jeremyfreudberg | tosky: do you have an example? | 18:27 |
tosky | jeremyfreudberg: actually, only this one: https://review.opendev.org/#/c/722097/2/doc/source/index.rst | 18:28 |
tosky | compare with https://review.opendev.org/#/c/722095/2/doc/source/index.rst | 18:28 |
jeremyfreudberg | oh, that's odd | 18:28 |
tosky | but it's not important, the output is the same | 18:29 |
openstackgerrit | Merged openstack/sahara-image-elements master: Ussuri contributor docs community goal https://review.opendev.org/722085 | 18:34 |
tosky | tellesnobrega_: if you have some time, can you please check the remaining half-approved review to see if they are worth the other half? :) | 22:10 |
tosky | we have some failures on the legacy jobs which blocks a few reviews, but I don't know how to fix them (yet) | 22:11 |
*** rcernin has joined #openstack-sahara | 22:31 | |
openstackgerrit | Luigi Toscano proposed openstack/sahara-tests master: Bump the jsonschema version with the tempest one https://review.opendev.org/722166 | 23:32 |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Test sahara-tests requirement bump https://review.opendev.org/722167 | 23:43 |
tosky | jeremyfreudberg, tellesnobrega_ : if the second review (sahara, DNM) works, please merge the first one (sahara-tests), and recheck the other sahara failing jobs | 23:50 |
*** tosky has quit IRC | 23:51 | |
openstackgerrit | Luigi Toscano proposed openstack/sahara master: DNM Test sahara-tests requirement bump https://review.opendev.org/722167 | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!