Wednesday, 2020-04-22

*** evrardjp has quit IRC04:35
*** evrardjp has joined #openstack-sahara04:35
*** rcernin has quit IRC05:24
*** rcernin has joined #openstack-sahara06:09
*** rcernin has quit IRC06:10
*** rcernin has joined #openstack-sahara06:11
*** rcernin has quit IRC06:25
*** rcernin has joined #openstack-sahara06:26
openstackgerritAndreas Jaeger proposed openstack/sahara master: Cleanup Python 2.7 support  https://review.opendev.org/71546606:30
openstackgerritAndreas Jaeger proposed openstack/sahara master: Cleanup Python 2.7 support  https://review.opendev.org/71546606:31
*** rcernin has quit IRC07:13
*** tosky has joined #openstack-sahara07:45
*** evrardjp has quit IRC09:51
*** evrardjp has joined #openstack-sahara09:51
openstackgerritLuigi Toscano proposed openstack/sahara master: Update hacking for Python3  https://review.opendev.org/71617613:38
openstackgerritLuigi Toscano proposed openstack/sahara master: zuul: remove (extra) sahara-tests-scenario-py3  https://review.opendev.org/72195813:40
openstackgerritLuigi Toscano proposed openstack/sahara master: Use unittest.mock instead of third party mock  https://review.opendev.org/72101113:41
tosky(a few rebases)13:41
toskytellesnobrega: if you approve the "skip failing unit test" jobs, we can unblock a few reviews13:42
tellesnobregatosky, will approve13:42
tellesnobregasaw it yesterday, I was waiting for zuul13:43
toskyI rebased all other patches on top of that, or on top of other patches on top of it13:44
openstackgerritLuigi Toscano proposed openstack/sahara master: Update hacking for Python3  https://review.opendev.org/71617613:45
openstackgerritLuigi Toscano proposed openstack/sahara master: Native zuul v3 grenade job, cleanup -py3  https://review.opendev.org/63839013:48
openstackgerritLuigi Toscano proposed openstack/sahara master: Fix duplicated words issue like "is is provided to"  https://review.opendev.org/70117514:23
tellesnobregatosky, merged15:06
tellesnobregaapproved actually15:06
tellesnobregamerged in a but15:06
tellesnobregabit15:06
toskytellesnobrega: thanks! There are also a few other reviews where I added +2 and we could have before tomorrow (also because they change a few dependencies)15:07
toskyjeremyfreudberg: ^^15:07
toskyso we can cut a cleaner rc115:08
tellesnobregawill take a look15:09
toskythere also two for the plugins (mock removal), but those can wait15:09
toskyI think the relevant ones (with dependency changes) are https://review.opendev.org/#/c/715466/ and https://review.opendev.org/#/c/716176/15:10
* tellesnobrega reviewed15:11
openstackgerritJeremy Freudberg proposed openstack/sahara master: Ussuri contributor docs community goal  https://review.opendev.org/72021116:11
jeremyfreudbergoops, forgot the redirects16:11
toskyjeremyfreudberg: do you need a diff for those?16:13
jeremyfreudbergtosky: you already gave what i need, i just forogt to do it16:13
toskyoki16:13
openstackgerritJeremy Freudberg proposed openstack/sahara master: Ussuri contributor docs community goal  https://review.opendev.org/72021116:13
*** tellesnobrega_ has joined #openstack-sahara16:23
*** tellesnobrega has quit IRC16:24
jeremyfreudbergtosky: see https://etherpad.opendev.org/p/sahara-contrib-doc-goal16:26
openstackgerritMerged openstack/sahara master: (Temporarily) skip TestVerifications tests  https://review.opendev.org/72161316:27
*** evrardjp has quit IRC16:35
*** evrardjp has joined #openstack-sahara16:35
openstackgerritJeremy Freudberg proposed openstack/sahara master: Ussuri contributor docs community goal  https://review.opendev.org/72021116:44
toskyuhm, so case 2. is easy, case 1., just point to https://docs.openstack.org/sahara/latest/contributor/contributing.rst maybe? Let me check what cinder did16:49
toskyjeremyfreudberg: https://opendev.org/openstack/cinder-tempest-plugin/commit/82b3e2df84957d8b2b74059e50732cb5e50a65c0  and https://opendev.org/openstack/python-cinderclient/commit/9191d76450c0d80400a08e730a8f54f826e2302216:49
jeremyfreudbergso it seems the cinderclient way is what we should do for the 'case 1' repos16:51
jeremyfreudbergit's a bit more work but i guess it makes sense to do16:51
openstackgerritJeremy Freudberg proposed openstack/sahara-dashboard master: Ussuri contributor docs community goal  https://review.opendev.org/72208317:06
openstackgerritJeremy Freudberg proposed openstack/sahara-extra master: Ussuri contributor docs community goal  https://review.opendev.org/72208417:06
openstackgerritJeremy Freudberg proposed openstack/sahara-image-elements master: Ussuri contributor docs community goal  https://review.opendev.org/72208517:07
openstackgerritJeremy Freudberg proposed openstack/sahara-specs master: Ussuri contributor docs community goal  https://review.opendev.org/72208617:07
jeremyfreudbergtosky: there are the easy ones17:08
toskyyep, I'm going to review17:09
openstackgerritMerged openstack/sahara-specs master: Ussuri contributor docs community goal  https://review.opendev.org/72208617:38
toskyit seems there is an issue with devstack-gate on the legacy jobs (hence the failure of sahara-grenade), I asked on #openstack-qa17:43
toskybut there are a few reviews we can merge anyway17:43
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-ambari master: Ussuri contributor docs community goal  https://review.opendev.org/72209517:44
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-cdh master: Ussuri contributor docs community goal  https://review.opendev.org/72209617:44
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-mapr master: Ussuri contributor docs community goal  https://review.opendev.org/72209717:44
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-spark master: Ussuri contributor docs community goal  https://review.opendev.org/72209817:44
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-storm master: Ussuri contributor docs community goal  https://review.opendev.org/72209917:44
openstackgerritMerged openstack/sahara-dashboard master: Ussuri contributor docs community goal  https://review.opendev.org/72208317:44
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-vanilla master: Ussuri contributor docs community goal  https://review.opendev.org/72210017:44
jeremyfreudbergtosky, just pushed for the plugins17:44
jeremyfreudbergfirst time using some automation, it may have gone horribly wrong17:44
toskylet's see17:45
jeremyfreudbergtosky: oh, i already messed up the CONTRIBUTING.rst (final line)17:47
jeremyfreudbergshould be the project specific one17:47
openstackgerritMerged openstack/python-saharaclient master: Use unittest.mock instead of third party mock  https://review.opendev.org/72099817:48
openstackgerritMerged openstack/sahara-plugin-ambari master: Use unittest.mock instead of third party mock  https://review.opendev.org/72101217:48
openstackgerritMerged openstack/sahara-plugin-cdh master: Use unittest.mock instead of third party mock  https://review.opendev.org/72101317:48
openstackgerritMerged openstack/sahara master: Use unittest.mock instead of third party mock  https://review.opendev.org/72101117:48
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-ambari master: Ussuri contributor docs community goal  https://review.opendev.org/72209517:50
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-cdh master: Ussuri contributor docs community goal  https://review.opendev.org/72209617:50
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-mapr master: Ussuri contributor docs community goal  https://review.opendev.org/72209717:50
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-spark master: Ussuri contributor docs community goal  https://review.opendev.org/72209817:50
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-storm master: Ussuri contributor docs community goal  https://review.opendev.org/72209917:50
openstackgerritJeremy Freudberg proposed openstack/sahara-plugin-vanilla master: Ussuri contributor docs community goal  https://review.opendev.org/72210017:50
openstackgerritJeremy Freudberg proposed openstack/sahara-tests master: Ussuri contributor docs community goal  https://review.opendev.org/72210517:57
jeremyfreudbergand there's sahara-tests too17:57
openstackgerritJeremy Freudberg proposed openstack/python-saharaclient master: Ussuri contributor docs community goal  https://review.opendev.org/72210718:00
openstackgerritJeremy Freudberg proposed openstack/sahara-tests master: Ussuri contributor docs community goal  https://review.opendev.org/72210518:00
openstackgerritMerged openstack/sahara-extra master: Ussuri contributor docs community goal  https://review.opendev.org/72208418:12
toskyat least one failed :)18:19
toskyI will recheck after dinner18:20
jeremyfreudbergyeah i messed up the sahara-tests one slightly18:22
jeremyfreudbergenjoy your dinner; i also need to go tend to other non-sahara matters for a while18:22
toskyjeremyfreudberg: for some reasons, the modified index in some of the guides has an extra blank between the existing line and the newly-added line18:25
toskyit's the same, but I'm not sure why the script acted differently :)18:26
jeremyfreudbergtosky: do you have an example?18:27
toskyjeremyfreudberg: actually, only this one: https://review.opendev.org/#/c/722097/2/doc/source/index.rst18:28
toskycompare with https://review.opendev.org/#/c/722095/2/doc/source/index.rst18:28
jeremyfreudbergoh, that's odd18:28
toskybut it's not important, the output is the same18:29
openstackgerritMerged openstack/sahara-image-elements master: Ussuri contributor docs community goal  https://review.opendev.org/72208518:34
toskytellesnobrega_: if you have some time, can you please check the remaining half-approved review to see if they are worth the other half? :)22:10
toskywe have some failures on the legacy jobs which blocks a few reviews, but I don't know how to fix them (yet)22:11
*** rcernin has joined #openstack-sahara22:31
openstackgerritLuigi Toscano proposed openstack/sahara-tests master: Bump the jsonschema version with the tempest one  https://review.opendev.org/72216623:32
openstackgerritLuigi Toscano proposed openstack/sahara master: DNM Test sahara-tests requirement bump  https://review.opendev.org/72216723:43
toskyjeremyfreudberg, tellesnobrega_ : if the second review (sahara, DNM) works, please merge the first one (sahara-tests), and recheck the other sahara failing jobs23:50
*** tosky has quit IRC23:51
openstackgerritLuigi Toscano proposed openstack/sahara master: DNM Test sahara-tests requirement bump  https://review.opendev.org/72216723:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!