-opendevstatus- NOTICE: zuul isn't executing check jobs at the moment, investigation is ongoing, please be patient | 07:19 | |
elodilles | hi o/ if any core could review these that would be awesome: https://review.opendev.org/q/topic:setuptools-issue-3197+project:openstack/sahara-image-elements | 09:11 |
---|---|---|
elodilles | it seems they are needed for the Yoga release | 09:11 |
elodilles | thanks in advance! | 09:11 |
zigo | Building Sahara / Yoga for Debian, I get 673 failures of this kind: | 13:47 |
zigo | https://paste.opendev.org/show/bpzaiI9aPyQJnDYkyikt/ | 13:47 |
zigo | How do I fix? | 13:47 |
zigo | I got this same problem with magnum, mistral, murano, sahara, trove, zaqar ... | 13:50 |
elodilles | zigo: hmmm, then it must be releated to oslo.context change. patches should be proposed like this one: https://review.opendev.org/c/openstack/castellan/+/834669 | 13:51 |
tosky | zigo: it should be fixed now after https://review.opendev.org/c/openstack/sahara/+/834366 | 13:52 |
tosky | elodilles: ^^ | 13:52 |
tosky | elodilles: thanks for the s-i-e patches, going to merge | 13:52 |
zigo | Thanks, will try it out. | 13:52 |
elodilles | tosky: ack, thanks! | 13:54 |
zigo | tosky: Will I have to apply the same kind of patch on all other projects? :/ | 13:54 |
zigo | Probably it would have been easier to fix oslo.context then, no ? | 13:54 |
zigo | Looks like Sahara is fixed, thanks for the pointer. | 13:55 |
tosky | elodilles: is the change in tox (the explicit install_command again) really needed? | 14:03 |
elodilles | tosky: not at all | 14:10 |
elodilles | the other option is to eliminate it completely even from the general testenv | 14:10 |
elodilles | usually i don't like when install_command is added in a tox.ini as it has the possibility to create similar errors like here we have :) | 14:11 |
elodilles | i just added it there in order to not refactor the whole tox.ini in a final+1 rc candidate release patch :) | 14:12 |
elodilles | tosky: i added it because of this line: https://opendev.org/openstack/sahara-image-elements/src/branch/master/tox.ini#L9 | 14:14 |
elodilles | (the lower-constraints job was broken because it looked like this: 'pip install -c upperconstraints.txt -c lowerconstraints.txt [..]' | 14:16 |
elodilles | and pip only uses the 1st constraints, thus upper one) | 14:16 |
elodilles | anyway, i see that deps is also defined in [testenv].... hmmm... let me redo the patches then. | 14:17 |
opendevreview | Elod Illes proposed openstack/sahara-image-elements master: Disable auto-discovery for setuptools https://review.opendev.org/c/openstack/sahara-image-elements/+/835361 | 14:20 |
tosky | elodilles: maybe that was left there for historical reasons, I thought we mostly got rid of custom install_command around | 14:22 |
tosky | so maybe there was some space tu cut old stuff | 14:22 |
tosky | only if you think it's the case of course, you helped already | 14:22 |
tosky | I was just curious because somethings it's not clear (even in that code I've worked on) was left there for a purpose or there is a change that was missed | 14:23 |
opendevreview | Elod Illes proposed openstack/sahara-image-elements stable/yoga: Disable auto-discovery for setuptools https://review.opendev.org/c/openstack/sahara-image-elements/+/835373 | 14:23 |
elodilles | tosky: most of the projets removed the install_command already, but some decided to stick to that (and modify that instead of deps). I usually go for fixing the deps and removing the install command. I have missed that the deps is extracted already in [testenv] general target otherwise i would have add that there. | 14:26 |
elodilles | tosky: usually there is no real reason to keep the install_command i would say :) | 14:26 |
tosky | ah, thanks! | 14:26 |
*** amoralej|off is now known as amoralej | 14:53 | |
opendevreview | Merged openstack/sahara-image-elements master: Disable auto-discovery for setuptools https://review.opendev.org/c/openstack/sahara-image-elements/+/835361 | 16:37 |
opendevreview | Merged openstack/sahara-image-elements stable/yoga: Disable auto-discovery for setuptools https://review.opendev.org/c/openstack/sahara-image-elements/+/835373 | 17:03 |
*** amoralej is now known as amoralej|off | 17:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!