| *** etoews has joined #openstack-sdks | 00:27 | |
| *** etoews has quit IRC | 00:32 | |
| *** etoews has joined #openstack-sdks | 00:46 | |
| *** etoews has quit IRC | 00:51 | |
| *** bknudson has quit IRC | 01:33 | |
| openstackgerrit | A change was merged to openstack/python-openstackclient: Remove 'links' section from several v3 Identity objects https://review.openstack.org/125869 | 03:26 |
|---|---|---|
| *** etoews has joined #openstack-sdks | 04:46 | |
| *** etoews has quit IRC | 04:50 | |
| *** etoews has joined #openstack-sdks | 05:04 | |
| openstackgerrit | Dean Troyer proposed a change to openstack/python-openstackclient: Add some session/api examples https://review.openstack.org/127873 | 05:07 |
| *** briancurtin has quit IRC | 05:09 | |
| dtroyer | mordred: I leave you with what it took to use trunk OSC's ClientManager as a library…it turned out to be less than I expected, there is still plenty to do to make it really friendly: https://review.openstack.org/#/c/127873/1/examples/osc-lib.py,unified | 05:14 |
| *** etoews has quit IRC | 05:14 | |
| dtroyer | the addition of os-client-config will make it trivial to handle multiple clouds at once | 05:15 |
| * dtroyer zzzzzzzzzzzzzzzzzz | 05:15 | |
| *** etoews has joined #openstack-sdks | 05:27 | |
| *** etoews has quit IRC | 05:33 | |
| *** etoews has joined #openstack-sdks | 05:41 | |
| *** etoews has quit IRC | 05:46 | |
| *** etoews has joined #openstack-sdks | 05:59 | |
| *** etoews has quit IRC | 06:04 | |
| *** k4n0 has joined #openstack-sdks | 06:16 | |
| *** tellesnobrega has quit IRC | 07:28 | |
| *** etoews has joined #openstack-sdks | 08:14 | |
| *** etoews has quit IRC | 08:18 | |
| *** etoews has joined #openstack-sdks | 08:32 | |
| *** etoews has quit IRC | 08:37 | |
| *** f13o has joined #openstack-sdks | 08:50 | |
| *** k4n0 has quit IRC | 08:50 | |
| *** k4n0 has joined #openstack-sdks | 08:55 | |
| *** k4n0 has quit IRC | 09:35 | |
| openstackgerrit | Matthieu Huin proposed a change to openstack/python-openstackclient: Unscoped federated user-specific commands https://review.openstack.org/124101 | 09:45 |
| *** k4n0 has joined #openstack-sdks | 09:54 | |
| *** k4n0 has quit IRC | 09:55 | |
| *** k4n0 has joined #openstack-sdks | 09:55 | |
| openstackgerrit | Matthieu Huin proposed a change to openstack/python-openstackclient: Unscoped federated user-specific commands https://review.openstack.org/124101 | 10:54 |
| *** mlilenium_ has joined #openstack-sdks | 11:27 | |
| *** mlilenium_ has left #openstack-sdks | 11:27 | |
| *** k4n0 has quit IRC | 12:21 | |
| *** toabctl has quit IRC | 12:22 | |
| *** toabctl has joined #openstack-sdks | 12:24 | |
| *** bknudson has joined #openstack-sdks | 12:39 | |
| *** terrylhowe has joined #openstack-sdks | 13:35 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
| *** briancurtin has joined #openstack-sdks | 13:57 | |
| *** mfer has joined #openstack-sdks | 13:58 | |
| *** Guest20248 is now known as redrobot | 14:06 | |
| *** etoews has joined #openstack-sdks | 14:31 | |
| openstackgerrit | Matt Farina proposed a change to stackforge/golang-client: Initial inclusion of v3 authentication with the retrival of a token. https://review.openstack.org/127310 | 15:01 |
| mfer | dtroyer ping | 15:02 |
| *** etoews has quit IRC | 15:05 | |
| *** etoews has joined #openstack-sdks | 15:07 | |
| openstackgerrit | A change was merged to stackforge/openstack-sdk-php: Adding URL class for better encapsulation https://review.openstack.org/95751 | 15:11 |
| dtroyer | mfer: hey, you're alive! | 15:13 |
| mfer | dtroyer something like that | 15:13 |
| mfer | :D | 15:13 |
| *** ayoung has joined #openstack-sdks | 15:26 | |
| openstackgerrit | Dean Troyer proposed a change to openstack/python-openstackclient: Update use of open() in object API https://review.openstack.org/127330 | 15:34 |
| *** etoews has quit IRC | 15:37 | |
| sigmavirus24 | dtroyer: re: requests-mock testing a body that is streamed, how do you imagine it would check equality? file-object properties, e.g., fd.name, fd.tell(), etc.? | 15:37 |
| dtroyer | sigmavirus24: at this point I'd just settle for testing a simple non-streamed body, such as a POST that contains JSON, like the compute API action request | 15:39 |
| dtroyer | anything more complicated than that can be out of scope | 15:39 |
| sigmavirus24 | wait requests-mock doesn't let you test posting a simple json string? | 15:40 |
| dtroyer | if it does I couldn't find it when I added it myself | 15:40 |
| *** etoews has joined #openstack-sdks | 15:40 | |
| sigmavirus24 | dtroyer: ah yeah, I was confusing specifying a response body for a request body | 15:43 |
| sigmavirus24 | so granted it's hard to handle matching json bodies because of dictionary randomization, but you can do equality checks after deserializing the string to a dictionary and it *should* just work | 15:44 |
| dtroyer | I'm just looking for a simple string match right now; did I miss a way to extract the request body without modifying the matcher bits? | 15:49 |
| sigmavirus24 | no I was just thinking out loud | 15:51 |
| sigmavirus24 | There's https://review.openstack.org/#/c/117110/ | 15:51 |
| sigmavirus24 | but it's not merged yet | 15:52 |
| sigmavirus24 | and I'm a bit surprised there's no way to tell requests-mock to match on body | 15:52 |
| sigmavirus24 | *request body | 15:52 |
| *** stevemar has joined #openstack-sdks | 16:15 | |
| openstackgerrit | Steve Lewis proposed a change to stackforge/python-openstacksdk: Handle booleans that are strings in APIs https://review.openstack.org/124209 | 16:42 |
| *** stevemar has quit IRC | 16:57 | |
| *** ayoung has quit IRC | 17:05 | |
| briancurtin | stevelle: If you make the third parameter False in that getattr in openstack/resource.py, the return value is truthy either way and you don't need to compare against "is not None". Could just be "if getattr(value, 'parsed', False):" | 17:11 |
| stevelle | briancurtin: I made a comment on the prior changeset, that false parameter worked for me a week or two ago but I couldn't get it to work in this case I was getting False always. | 17:11 |
| briancurtin | actually, since we need the result, we should do something different. keep your None in there but store the result, so like "x = getattr(...None)" and then do if x: value = x | 17:12 |
| briancurtin | submitting a better comment on that right now | 17:14 |
| *** ayoung has joined #openstack-sdks | 17:21 | |
| terrylhowe | well if x: won’t work for booleans right? | 17:28 |
| terrylhowe | if x is None: right? | 17:28 |
| terrylhowe | I think the comment briancurtin made had the correct format | 17:29 |
| terrylhowe | the comment in the review that is | 17:29 |
| sigmavirus24 | briancurtin: if x is False, we'll never used the parsed attribute | 17:32 |
| sigmavirus24 | it should be None as a sentinel | 17:32 |
| briancurtin | sigmavirus24: check the comment on the review, teh one i wrote in here is crappy | 17:32 |
| briancurtin | basically, get rid of doing the getattr twice | 17:33 |
| sigmavirus24 | ah | 17:35 |
| sigmavirus24 | Yeah sorry, just looked at IRC again, hadn't looked at the review ye | 17:35 |
| openstackgerrit | Dean Troyer proposed a change to openstack/python-openstackclient: Move plugin stuff to clientmanager https://review.openstack.org/128023 | 17:35 |
| sigmavirus24 | *yet | 17:35 |
| openstackgerrit | Steve Lewis proposed a change to stackforge/python-openstacksdk: Handle booleans that are strings in APIs https://review.openstack.org/124209 | 17:35 |
| stevelle | briancurtin: terrylhowe sigmavirus24 thx all. | 17:37 |
| * sigmavirus24 didn't do anything | 17:37 | |
| stevelle | thx to you all, I didn't either. | 17:38 |
| openstackgerrit | Dean Troyer proposed a change to openstack/python-openstackclient: Add some session/api examples https://review.openstack.org/127873 | 17:48 |
| *** etoews has quit IRC | 18:02 | |
| *** etoews has joined #openstack-sdks | 18:15 | |
| *** etoews has quit IRC | 18:24 | |
| *** etoews has joined #openstack-sdks | 18:38 | |
| *** etoews has quit IRC | 18:44 | |
| *** etoews has joined #openstack-sdks | 18:45 | |
| *** mfer has quit IRC | 21:04 | |
| openstackgerrit | Dean Troyer proposed a change to openstack/python-openstackclient: Close files on server create, add tests https://review.openstack.org/128109 | 21:47 |
| *** briancurtin has quit IRC | 21:51 | |
| *** bknudson has quit IRC | 22:04 | |
| *** briancurtin has joined #openstack-sdks | 22:12 | |
| openstackgerrit | Terry Howe proposed a change to stackforge/python-openstacksdk: Add ability to extract a list of versions https://review.openstack.org/121335 | 22:46 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:53 | |
| *** etoews has quit IRC | 22:58 | |
| *** etoews has joined #openstack-sdks | 22:58 | |
| *** etoews has quit IRC | 23:03 | |
| *** openstackgerrit has quit IRC | 23:03 | |
| *** openstackgerrit has joined #openstack-sdks | 23:04 | |
| *** briancurtin has quit IRC | 23:14 | |
| *** etoews has joined #openstack-sdks | 23:17 | |
| *** etoews has quit IRC | 23:22 | |
| *** openstackgerrit has quit IRC | 23:33 | |
| *** openstackgerrit has joined #openstack-sdks | 23:34 | |
| *** briancurtin has joined #openstack-sdks | 23:39 | |
| *** briancurtin has joined #openstack-sdks | 23:39 | |
| *** bknudson has joined #openstack-sdks | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!