*** bknudson has joined #openstack-sdks | 00:43 | |
*** redrobot has quit IRC | 00:59 | |
*** mordred has quit IRC | 01:01 | |
*** tellesnobrega has quit IRC | 01:01 | |
*** redrobot has joined #openstack-sdks | 01:06 | |
*** mordred has joined #openstack-sdks | 01:06 | |
*** redrobot is now known as Guest48074 | 01:06 | |
*** stevemar has quit IRC | 01:07 | |
*** tellesnobrega has joined #openstack-sdks | 01:15 | |
*** etoews has joined #openstack-sdks | 01:46 | |
*** elarson has quit IRC | 02:00 | |
etoews | let me know what you think https://bugs.launchpad.net/os-client-config/+bug/1439927 | 02:32 |
---|---|---|
openstack | Launchpad bug 1439927 in os-client-config "Mixed cloud configs" [Undecided,New] | 02:32 |
*** stevemar has joined #openstack-sdks | 03:46 | |
*** chlong has joined #openstack-sdks | 03:48 | |
openstackgerrit | Everett Toews proposed stackforge/python-openstacksdk: The first functional test https://review.openstack.org/170343 | 03:49 |
*** chlong has quit IRC | 03:49 | |
*** terrylhowe has quit IRC | 04:40 | |
*** briancurtin has quit IRC | 04:46 | |
*** etoews has quit IRC | 04:46 | |
*** jdaggett has quit IRC | 04:47 | |
*** etoews has joined #openstack-sdks | 04:47 | |
*** briancurtin has joined #openstack-sdks | 04:48 | |
*** jdaggett has joined #openstack-sdks | 04:51 | |
*** maufart has joined #openstack-sdks | 05:43 | |
*** pm90_ has joined #openstack-sdks | 06:21 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Add support for showing limits of a specific project https://review.openstack.org/170360 | 06:27 |
*** pm90_ has quit IRC | 07:02 | |
*** pm90_ has joined #openstack-sdks | 07:06 | |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Add support to specify volume quotas per volume type https://review.openstack.org/170366 | 07:13 |
*** stevemar has quit IRC | 07:18 | |
*** pm90_ has quit IRC | 07:29 | |
*** bnemec has quit IRC | 09:33 | |
*** maufart has quit IRC | 10:07 | |
*** bnemec has joined #openstack-sdks | 10:19 | |
*** maufart has joined #openstack-sdks | 10:37 | |
*** bknudson has quit IRC | 13:00 | |
*** terrylhowe has joined #openstack-sdks | 13:07 | |
*** elarson has joined #openstack-sdks | 13:18 | |
*** bknudson has joined #openstack-sdks | 13:30 | |
*** openstackgerrit has quit IRC | 13:36 | |
*** openstackgerrit has joined #openstack-sdks | 13:36 | |
*** edleafe is now known as figleaf | 13:39 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:43 | |
*** maufart has quit IRC | 14:27 | |
*** openstackgerrit has quit IRC | 14:39 | |
*** openstackgerrit has joined #openstack-sdks | 14:39 | |
*** pm90_ has joined #openstack-sdks | 16:11 | |
etoews | dtroyer: mordred: i'm a bit surprised os-client-config isn't already a part of openstack/requirements http://logs.openstack.org/43/170343/1/check/gate-python-openstacksdk-requirements/7390cb7/console.html | 16:25 |
etoews | should i add it in there or am i missing something? | 16:25 |
mordred | etoews: I though it was | 16:25 |
mordred | because we added it for openstackclient a while back | 16:25 |
etoews | indeed it is | 16:26 |
etoews | https://git.openstack.org/cgit/openstack/requirements/tree/global-requirements.txt#n77 | 16:26 |
mordred | ah - it's because you're pinning to a version | 16:26 |
mordred | and global requirements does not pin | 16:26 |
etoews | ah. i see that now. | 16:26 |
etoews | i fix. | 16:26 |
etoews | thx | 16:26 |
mordred | etoews, dtroyer: I agree with etoews' bug - I've been bitten by the mix of env vars and clouds.yaml values before | 16:27 |
dtroyer | fwiw, I've been typing a reply to that bug for the last hour or so (I swear, the phone is still off!). tl;dr is env var precedence is hard. | 16:27 |
mordred | yah - because if we just do the suggestion - things get weird in the case where you're not using a clouds.yaml at all and are using it for command line and env var processing | 16:28 |
terrylhowe | I’ve had the same confusion | 16:28 |
mordred | so - I think the bug is totally valid, but we may need to poke at the solution a bit | 16:28 |
etoews | exactly. so let's not do precedence and make it entirely separate. ;) | 16:28 |
dtroyer | I'd like to collect expectations on this topic, I think in a room of 4 people we'll get 6 opinions. | 16:28 |
mordred | yah | 16:28 |
etoews | naturally | 16:28 |
dtroyer | etoews: for occ I think that's the right choice, but I'd like to still have a common way to handle this, OSC needs it and others will too | 16:29 |
etoews | better to make it clear now before use of occ spreads too far | 16:30 |
*** stevemar has joined #openstack-sdks | 16:34 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Rework update_attrs so dirty list always updated https://review.openstack.org/169451 | 16:37 |
*** stevemar has quit IRC | 16:38 | |
*** pm90_ has quit IRC | 16:38 | |
*** pm90_ has joined #openstack-sdks | 16:39 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Add _check_resource to BaseProxy https://review.openstack.org/167273 | 16:39 |
mordred | dtroyer: what if we only do env var injection if you have not requested a named cloud from occ? | 16:39 |
mordred | dtroyer: like, if get_one_cloud(cloud=None) ... then we process env vars | 16:40 |
mordred | but if get_one_cloud(cloud='monty') we assume that monty is a named config that is complete and will not overwrite parts of it with env vars | 16:40 |
mordred | (this may be the same thing etoews was saying, honestly) | 16:40 |
mordred | I'm just thinking out loud | 16:40 |
etoews | that's similar to my suggestion. except that, if present, the env vars always constitute their own cloud config. it would be a named config with a default name (e.g. 'env_var_config') or a name you explicitly set with another env var (e.g. export OS_CLIENT_CONFIG_NAME=my_cloud_config_defined_by_env_vars) | 16:44 |
etoews | either way i'm happy as long as env vars and config from clouds.yaml don't get mixed. | 16:45 |
terrylhowe | it’ll be a lot tougher for osc to determine if a command line option was specified or it picked a default from the env | 16:46 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Add _check_resource to BaseProxy https://review.openstack.org/167273 | 16:50 |
etoews | terrylhowe: thoughts on the approach for functional tests? https://review.openstack.org/#/c/170343/ | 16:50 |
terrylhowe | looks great etoews but I want to give it a test spin | 16:51 |
etoews | sgtm | 16:51 |
terrylhowe | I’m hoping it isn’t a wip for long | 16:51 |
etoews | i'm not intending it to be. i'm just looking for feedback on the approach. | 16:52 |
etoews | i just didn't want it to get merged without doc | 16:52 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Proxy delete method https://review.openstack.org/164310 | 16:57 |
openstackgerrit | Merged stackforge/python-openstacksdk: Add _check_resource to BaseProxy https://review.openstack.org/167273 | 17:02 |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:07 | |
openstackgerrit | Merged stackforge/python-openstacksdk: Proxy delete method https://review.openstack.org/164310 | 17:14 |
*** pm90_ has quit IRC | 17:16 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Proxy get method https://review.openstack.org/164351 | 17:37 |
*** bknudson has quit IRC | 17:48 | |
*** rmcall has joined #openstack-sdks | 18:08 | |
*** rmcall has quit IRC | 18:25 | |
*** pm90_ has joined #openstack-sdks | 18:49 | |
*** pm90__ has joined #openstack-sdks | 19:03 | |
*** pm90_ has quit IRC | 19:04 | |
*** mattfarina has quit IRC | 20:02 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Proxy create method https://review.openstack.org/168448 | 20:10 |
*** pm90__ has quit IRC | 20:21 | |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Improve image.v2.tag https://review.openstack.org/164055 | 20:24 |
etoews | briancurtin: | 20:25 |
*** pm90_ has joined #openstack-sdks | 20:26 | |
etoews | dang | 20:28 |
etoews | briancurtin: in your suggestion for https://review.openstack.org/#/c/170343/1/openstack/tests/functional/compute/v2/test_server.py,unified | 20:29 |
etoews | you have self.assertIsInstance(flavor.id, str) | 20:29 |
etoews | but the actual type is unicode so what would be more correct | 20:29 |
etoews | self.assertIsInstance(flavor.id, unicode) | 20:30 |
etoews | or | 20:30 |
etoews | self.assertIsInstance(flavor.id, basestring) | 20:30 |
briancurtin | it's like six.text_type i think, let me check | 20:30 |
briancurtin | etoews: six.string_types | 20:33 |
briancurtin | (that's basestring on 2 and str on 3) | 20:33 |
etoews | i knew there were python 2/3 implications but i wouldn't have found six.string_types for a long time. thx. | 20:36 |
openstackgerrit | Brian Curtin proposed stackforge/python-openstacksdk: Improve image.v2.tag https://review.openstack.org/164055 | 21:22 |
*** pm90_ has quit IRC | 21:35 | |
*** pm90_ has joined #openstack-sdks | 21:39 | |
*** figleaf is now known as edleafe | 21:52 | |
*** pm90_ has quit IRC | 22:14 | |
*** pm90_ has joined #openstack-sdks | 22:21 | |
*** pm90_ has quit IRC | 22:24 | |
*** pm90_ has joined #openstack-sdks | 22:25 | |
*** pm90_ has quit IRC | 23:24 | |
*** Viswanath has joined #openstack-sdks | 23:31 | |
*** Viswanath has quit IRC | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!