*** steveortiz is now known as zz_steveortiz | 00:06 | |
*** stevemar has joined #openstack-sdks | 00:11 | |
*** stevemar has quit IRC | 00:15 | |
*** Qiming has joined #openstack-sdks | 00:20 | |
openstackgerrit | greghaynes proposed openstack/os-client-config: Convert auth kwargs '-' to '_' https://review.openstack.org/224368 | 00:27 |
---|---|---|
*** thrash is now known as thrash|g0ne | 00:31 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 00:48 | |
openstackgerrit | greghaynes proposed openstack/os-client-config: Convert auth kwargs '-' to '_' https://review.openstack.org/224368 | 00:49 |
greghaynes | jamielennox: dtroyer Shrews if any of you folks are around ^ is breaking nodepool and mordred is asleep so would be awesome if we could get review / release | 00:51 |
jamielennox | greghaynes: i have no powers on occ, but i'm ok with that - though i'd prefer if we could figure out what occ needs so that it doesn't have to mess with options like that directly | 00:52 |
greghaynes | jamielennox: not sure I follow | 00:54 |
greghaynes | jamielennox: oscc already does that munging in some places, just not for kwargs | 00:54 |
greghaynes | also, any idea who else has oscc powers? | 00:54 |
dtroyer | greghaynes: just saw this, will look in a sec | 00:55 |
jamielennox | greghaynes: yea, i would just prefer to somehow make oscc an extension of keystoneauth rather than trying to replicate stuff | 00:55 |
openstackgerrit | greghaynes proposed openstack/os-client-config: Convert auth kwargs '-' to '_' https://review.openstack.org/224368 | 00:55 |
jamielennox | no idea how yet | 00:55 |
dtroyer | jamielennox: this munging is what lets us go between CLI args and clouds.yaml key names | 00:55 |
jamielennox | yep | 00:55 |
greghaynes | jamielennox: ah, that. I agree, I wanted to mess with that but way too many other things :( | 00:55 |
jamielennox | right, always other stuff and this works 99% | 00:56 |
dtroyer | jamielennox: FWIW, I still don't think this stuff (occ) should be part of ksa…ksa needs to be concerned with performing auth and that's it. occ handles app-layer interfaces for getting configuration. | 00:58 |
jamielennox | dtroyer: i was ok with splitting this all out, the decision came down to the fact that people will almost always want to use the loading part as well so they would always be installing two libs | 01:00 |
dtroyer | greghaynes: +2, but I didn't run it. I'm fine with the idea | 01:00 |
greghaynes | dtroyer: awesome, ty | 01:00 |
jamielennox | so at least they are no longer on the plugins itself | 01:00 |
jamielennox | if we eventually move the whole loading part out so be it | 01:00 |
greghaynes | dtroyer: I flipped the test on and off and it fixed the issue so somewhat confident it works | 01:00 |
*** gildub has quit IRC | 01:02 | |
*** gildub has joined #openstack-sdks | 01:03 | |
*** Yanyanhu has joined #openstack-sdks | 01:37 | |
*** Qiming has quit IRC | 01:42 | |
*** Yanyan has joined #openstack-sdks | 01:43 | |
*** Yanyanhu has quit IRC | 01:46 | |
*** chlong has joined #openstack-sdks | 01:46 | |
*** chlong_ has joined #openstack-sdks | 01:53 | |
openstackgerrit | Merged openstack/os-client-config: Properly handle os- prefixed args in fix_args https://review.openstack.org/224352 | 01:54 |
openstackgerrit | Merged openstack/os-client-config: Convert auth kwargs '-' to '_' https://review.openstack.org/224368 | 01:58 |
*** gildub has quit IRC | 02:00 | |
*** stevemar has joined #openstack-sdks | 02:12 | |
*** stevemar has quit IRC | 02:16 | |
*** david-lyle has joined #openstack-sdks | 02:34 | |
*** gildub has joined #openstack-sdks | 02:45 | |
*** chlong_ has quit IRC | 02:50 | |
openstackgerrit | Merged openstack/keystoneauth: Use option dest rather than name in missing error https://review.openstack.org/224348 | 03:09 |
*** Shrews has quit IRC | 03:19 | |
*** Shrews has joined #openstack-sdks | 03:19 | |
*** boris-42 has quit IRC | 03:50 | |
*** boris-42 has joined #openstack-sdks | 03:51 | |
*** pratikmallya has joined #openstack-sdks | 04:12 | |
*** stevemar has joined #openstack-sdks | 04:12 | |
*** chlong has quit IRC | 04:16 | |
*** stevemar has quit IRC | 04:16 | |
*** stevemar has joined #openstack-sdks | 04:23 | |
*** chlong has joined #openstack-sdks | 04:33 | |
*** terrylhowe has quit IRC | 04:37 | |
*** chlong has quit IRC | 04:48 | |
stevemar | mordred: new occ release? | 05:24 |
stevemar | yep | 05:25 |
stevemar | looks like it broke osc :( | 05:25 |
stevemar | sadness | 05:25 |
*** stevemar has quit IRC | 05:28 | |
*** stevemar has joined #openstack-sdks | 05:29 | |
mordred | stevemar: just cut it | 05:34 |
mordred | oh - wait | 05:34 |
mordred | there was a new occ release which had an issue. we fixed that - and I just cut a new release | 05:35 |
stevemar | mordred: oh, two in 1 day? | 05:35 |
stevemar | lol, yes 2 minutes ago | 05:36 |
stevemar | mordred: yep, i think that should fix my problem | 05:36 |
stevemar | mordred: hmm, occ 1.7.1 still makes osc unit tests fail: http://paste.openstack.org/show/465775/ | 05:44 |
mordred | stevemar: that's sad making | 05:47 |
stevemar | indeed | 05:47 |
mordred | stevemar: hrm. that's a weird error | 05:47 |
mordred | stevemar: maybe something went south with a mock? | 05:48 |
stevemar | i know we setup the cloud values here: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/shell.py#L225-L238 | 05:48 |
stevemar | mordred: confirmed its not mock, i just installed occ 1.7.1 and master osc, and tried to do `openstack user list --cloud devstack` and it blew up | 05:51 |
stevemar | http://paste.openstack.org/show/465781/ | 05:51 |
stevemar | i'll file a bug with osc for now | 05:51 |
stevemar | ahhh it might be keystoneauth related... | 05:52 |
stevemar | where the jamie-bat-man-signal? | 05:52 |
mordred | stevemar: fingers crossed it's him not me | 06:01 |
mordred | :) | 06:01 |
mordred | stevemar: oh, do get_one_cloud is maybe returning none | 06:02 |
stevemar | i shall see | 06:06 |
stevemar | just responding to the ML | 06:06 |
mordred | stevemar: k. I'm back on laptop and looking | 06:09 |
mordred | stevemar: ERROR: openstack The plugin osc_password could not be found | 06:10 |
stevemar | mordred: yep, its all about our weird little plugin | 06:11 |
mordred | stevemar: I have an idea for a patch - one sec | 06:11 |
mordred | stevemar: yup. it's the passing of osc's auth_type to get_one_coud | 06:12 |
stevemar | yep, osc_password | 06:12 |
mordred | since keystoneauth1 does notknow anything about osc_plypassword | 06:13 |
stevemar | loading.get_plugin_loader(config['auth_type']) | 06:13 |
stevemar | yep | 06:13 |
stevemar | i'm just stumped as far as a solution goe | 06:13 |
stevemar | s | 06:13 |
stevemar | aside from make ksa know the plugin, or osc register the plugin earlier? | 06:13 |
mordred | nah - that's going to take more work - (just tried that) | 06:14 |
stevemar | oh | 06:15 |
stevemar | maybe... | 06:15 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Don't pass osc_password to occ/ksa https://review.openstack.org/224444 | 06:16 |
mordred | stevemar: ^^ | 06:16 |
mordred | stevemar: that fixes it for me | 06:16 |
stevemar | could we double up on the entrypoints in setup.cfg? | 06:16 |
mordred | I tried that - the plugin interface is a little different | 06:17 |
mordred | so we'll need to do more than a 5 second patch for that | 06:17 |
mordred | but the problem is that occ uses ksa to do argument validation now | 06:17 |
stevemar | ++ | 06:17 |
stevemar | i just had the setup.cfg changes | 06:17 |
stevemar | can you add the tokenendpoint one too? | 06:17 |
mordred | just skipping that until we've got a ksa enablement patch for osc | 06:17 |
mordred | yup | 06:17 |
*** chlong has joined #openstack-sdks | 06:17 | |
mordred | stevemar: piddle - what are the parameters for token_endpoint? | 06:18 |
* mordred looks | 06:18 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Don't pass osc_password to occ/ksa https://review.openstack.org/224444 | 06:21 |
mordred | stevemar: there ya go | 06:21 |
mordred | oh. absolute piddle mess | 06:22 |
mordred | that's not going to work | 06:22 |
mordred | because osc token_endpoint takes "url" and not "endpoint" | 06:23 |
stevemar | blah | 06:26 |
mordred | (working on patch) | 06:26 |
stevemar | MissingRequiredOptions: Auth plugin requires parameters which were not given: auth-url | 06:26 |
*** Qiming has joined #openstack-sdks | 06:26 | |
stevemar | i was still getting that | 06:26 |
mordred | you updated occ? | 06:27 |
mordred | 1.7.1 should fix that error | 06:27 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Don't pass osc_password to occ/ksa https://review.openstack.org/224444 | 06:28 |
mordred | stevemar: ok. I think that should do the token_endpoint/admin_token thing | 06:28 |
stevemar | mordred: i thought it was related to the 1.7.0 -> 1.7.1 bug, but i'm looking at pip freeze and its 1.7.1 | 06:31 |
mordred | hrm | 06:31 |
stevemar | maybe my env is special | 06:31 |
mordred | that's unhapy making - | 06:32 |
mordred | I don't want your env to be special | 06:32 |
stevemar | if its working for you | 06:32 |
stevemar | true, it would be a stinky fish | 06:32 |
mordred | openstack --os-cloud=rax server list | 06:32 |
mordred | this works for me | 06:32 |
mordred | and env vars work | 06:32 |
stevemar | openstack user list --cloud devstack --debug | 06:33 |
stevemar | is still resulting in the auth-url missing thing for me | 06:33 |
stevemar | env vars work for me too | 06:33 |
mordred | stevemar: --os-cloud not --cloud | 06:33 |
stevemar | mordred: d'oh fiddlesticks | 06:34 |
mordred | stevemar: --cloud devstack is resulting in no config being passed in, which results in that error :) | 06:34 |
mordred | it's a bad error - but that's secondary | 06:34 |
stevemar | yessum | 06:34 |
mordred | or, it's an accurate error, but misleading as to what's wrong in this case | 06:34 |
stevemar | yep | 06:35 |
stevemar | now do i just push this through | 06:35 |
mordred | I'm goin to add verify=False to get_oneloud | 06:35 |
stevemar | oh? | 06:35 |
stevemar | separate patch | 06:35 |
stevemar | i assume | 06:35 |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Pass validate=False to get_one_cloud https://review.openstack.org/224451 | 06:36 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Don't pass osc_password to occ/ksa https://review.openstack.org/224444 | 06:37 |
openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Pass validate=False to get_one_cloud https://review.openstack.org/224451 | 06:37 |
mordred | stevemar: there ya go - that should avoid things dying because ksa execeptions | 06:37 |
stevemar | updated commit msg to close the bug ^ | 06:37 |
mordred | woot | 06:37 |
stevemar | i'm tempted to push things through, since we're so close to client release deadline | 06:38 |
stevemar | and dtroyer is offline | 06:38 |
stevemar | oh wait, jamielennox is around yay | 06:38 |
stevemar | he can give it a quick review | 06:38 |
jamielennox | oh, o | 06:39 |
mordred | jamielennox: yay! | 06:39 |
mordred | jamielennox: ksa/osc plugin carnage :) | 06:39 |
jamielennox | wha...? | 06:40 |
mordred | jamielennox: osc passed auth_type to occ which was set to things like token_endpoint or osc_password - neither of which are ksa plugins | 06:41 |
jamielennox | and please lets not register them as plugins this time | 06:41 |
mordred | jamielennox: nah. I worked around both I think | 06:42 |
mordred | do we still need osc_password? | 06:42 |
jamielennox | i don't mind if it exists for a while, just not registered as an entrypoint for everyone to use | 06:42 |
jamielennox | but hopefully no | 06:42 |
jamielennox | so i get the first bit | 06:43 |
jamielennox | swap token_endpoint for admin_token | 06:43 |
jamielennox | what's this | 06:43 |
jamielennox | if auth_type == 'osc_password' or auth_type == 'token_endpoint':242 | 06:43 |
jamielennox | self.cloud.config['auth_type'] = auth_type | 06:43 |
mordred | jamielennox: I'm not 100% sure it's needed - I just wanted to mess with as few of osc's assumptions about what values would be where | 06:44 |
*** e0ne has joined #openstack-sdks | 06:56 | |
*** e0ne has quit IRC | 07:03 | |
stevemar | jamielennox: mordred - i'm bailing, sorry guys | 07:09 |
stevemar | falling asleep here | 07:09 |
stevemar | i'll check this in ~7hs | 07:09 |
*** stevemar has quit IRC | 07:10 | |
GheRivero | morning! | 07:12 |
jamielennox | mordred: hmm, that's quite a problem, going AFK for a bit but will have a go at it later | 07:16 |
jamielennox | i don't know if there's a good solution | 07:16 |
jamielennox | but i should have followed through on that occ functional testing thing | 07:16 |
jamielennox | mordred, dtroyer: however i'm inclined to say that for liberty we should not ship anything that relies on keystoneauth including new occ and osc - shade doesn't really matter there | 07:21 |
*** aufi has joined #openstack-sdks | 07:31 | |
*** gildub has quit IRC | 07:55 | |
-openstackstatus- NOTICE: Gate is currently stuck, failing grenade upgrade tests due the release of oslo.utils 1.4.1 for Juno. | 08:02 | |
*** pratikmallya has quit IRC | 08:41 | |
mordred | morning GheRivero | 09:23 |
*** terrylhowe has joined #openstack-sdks | 09:24 | |
*** Yanyan has quit IRC | 09:41 | |
*** e0ne has joined #openstack-sdks | 09:51 | |
*** e0ne has quit IRC | 10:00 | |
*** e0ne has joined #openstack-sdks | 10:11 | |
*** Qiming has quit IRC | 10:12 | |
-openstackstatus- NOTICE: Gate back to normal, thanks to the backlisting of the problematic version | 10:16 | |
dtroyer | jamielennox: so OSC may be doing it wrong in a ksa world, but the idea that we can't add plugins bothers me a bit. I hope I'm misunderstanding what happened, I just woke up… | 11:09 |
*** Qiming has joined #openstack-sdks | 11:10 | |
*** e0ne has quit IRC | 11:23 | |
jamielennox | dtroyer: i think we should not touch ksa for this release - it's getting too close and is likely to cause problems | 11:28 |
jamielennox | it's just not tested enough | 11:28 |
dtroyer | jamielennox: agreed there | 11:28 |
jamielennox | so my goal here has always been standards, i want OSC to be used by everyone but until then i want all the different service CLIs to use the same options | 11:29 |
jamielennox | occ throws a wrinkle in all this that i'm still not sure how it fits | 11:30 |
openstackgerrit | Monty Taylor proposed openstack/keystoneauth: There is no token_endpoint.TokenEndpoint https://review.openstack.org/224580 | 11:30 |
jamielennox | dtroyer: case in point ^ | 11:31 |
dtroyer | I need to wake up a bit more before trying to sort this out, but my gut feel is we're still violating separation of duties here | 11:32 |
jamielennox | dtroyer: they are definetly more split than they used to be, i'm still trying to figure out how to make it so occ kind of fits in the same way as the loaders do ' | 11:35 |
jamielennox | i think the plugins telling options is correct | 11:35 |
dtroyer | FTFY: I think plugins telling their config requirements is correct | 11:35 |
dtroyer | I don't think they should know where they came from, ie option/config file names | 11:35 |
jamielennox | i would be fine with saying the keystoneauth loaders are sample/example | 11:36 |
jamielennox | i just want to get the way occ handles this into a bit better state before we send it everywhere | 11:36 |
jamielennox | dtroyer: i want this merged - what do we need to do: https://review.openstack.org/#/c/220846/2 | 11:40 |
dtroyer | kick the DevStack cores in the…. oh wait… | 11:43 |
dtroyer | +2 here | 11:43 |
jamielennox | we merged it, then some outside project complained and it got reverted | 11:43 |
jamielennox | it's going to break someone | 11:43 |
jamielennox | for sure, there's just too many people using it and we've got plugins and stuff | 11:44 |
dtroyer | outside? | 11:44 |
jamielennox | that was not supposed to be negative just not reviews i follow | 11:44 |
jamielennox | trove or one of the ceilometer spin offs | 11:44 |
jamielennox | where i was pretty sure we could just say "fix it" | 11:44 |
dtroyer | looks like it was Ironic. Yeah, their tests need to be fixed | 11:45 |
jamielennox | there was a swift problem - because swift - but i think the fix stevemar did solved that | 11:46 |
jamielennox | dtroyer: can you convince probably sdague to not revert it again and i'll write up a big warning/how to fix email we can send to -dev | 11:48 |
dtroyer | he's on vacation, but I'll make sure he knows | 11:49 |
jamielennox | last time it got merged was right on one of the freezes | 11:49 |
dtroyer | yeah, timing right now is fun ;) | 11:49 |
jamielennox | it's going to piss someone off whenever it happens | 11:49 |
jamielennox | but feature freeze has happened and it's a month before liberty release | 11:51 |
jamielennox | i'll write up an email tomorrow, always better to do this stuff at the start of the week so maybe we can +A it on monday (US) | 11:52 |
jamielennox | alright - night | 11:55 |
*** trown|outttypeww is now known as trown | 11:55 | |
*** thrash|g0ne is now known as thrash | 12:01 | |
*** e0ne has joined #openstack-sdks | 12:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cliff: Updated from global requirements https://review.openstack.org/217142 | 12:11 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystoneauth: Updated from global requirements https://review.openstack.org/224619 | 12:12 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-openstackclient: Updated from global requirements https://review.openstack.org/224681 | 12:17 |
openstackgerrit | OpenStack Proposal Bot proposed stackforge/python-openstacksdk: Updated from global requirements https://review.openstack.org/224699 | 12:18 |
*** openstackgerrit has quit IRC | 13:31 | |
*** openstackgerrit has joined #openstack-sdks | 13:32 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:46 | |
*** stevemar has joined #openstack-sdks | 13:50 | |
openstackgerrit | Merged openstack/keystoneauth: There is no token_endpoint.TokenEndpoint https://review.openstack.org/224580 | 13:53 |
*** e0ne has quit IRC | 14:01 | |
*** pratikmallya has joined #openstack-sdks | 14:03 | |
*** e0ne has joined #openstack-sdks | 14:06 | |
*** jose4183 has joined #openstack-sdks | 14:22 | |
*** pratikma_ has joined #openstack-sdks | 14:27 | |
*** pratikmallya has quit IRC | 14:29 | |
*** Qiming has quit IRC | 15:07 | |
*** aufi has quit IRC | 15:11 | |
openstackgerrit | Merged openstack/keystoneauth: Updated from global requirements https://review.openstack.org/224619 | 15:39 |
*** e0ne has quit IRC | 15:59 | |
*** e0ne has joined #openstack-sdks | 16:00 | |
*** hitalia has joined #openstack-sdks | 16:03 | |
*** woodster_ has joined #openstack-sdks | 16:04 | |
*** e0ne has quit IRC | 16:15 | |
*** karimb has joined #openstack-sdks | 16:20 | |
*** david-lyle has quit IRC | 16:36 | |
*** pratikma_ has quit IRC | 16:43 | |
*** david-lyle has joined #openstack-sdks | 16:47 | |
*** david-lyle has quit IRC | 17:03 | |
*** trown is now known as trown|lunch | 17:10 | |
*** hitalia has quit IRC | 17:12 | |
*** pratikmallya has joined #openstack-sdks | 17:17 | |
*** karimb has quit IRC | 17:17 | |
*** hitalia has joined #openstack-sdks | 17:18 | |
*** pratikma_ has joined #openstack-sdks | 17:19 | |
*** pratikmallya has quit IRC | 17:23 | |
*** rm_work has quit IRC | 17:43 | |
*** rm_work has joined #openstack-sdks | 17:45 | |
*** trown|lunch is now known as trown | 18:03 | |
*** jamielennox is now known as jamielennox|away | 18:05 | |
*** e0ne has joined #openstack-sdks | 18:07 | |
*** e0ne has quit IRC | 18:17 | |
*** e0ne has joined #openstack-sdks | 18:21 | |
*** greghaynes has quit IRC | 18:49 | |
*** david-lyle has joined #openstack-sdks | 19:11 | |
*** david-lyle has quit IRC | 19:25 | |
*** fifieldt has quit IRC | 20:19 | |
*** fifieldt has joined #openstack-sdks | 20:20 | |
*** pratikma_ has quit IRC | 20:21 | |
*** pratikmallya has joined #openstack-sdks | 20:21 | |
*** pratikma_ has joined #openstack-sdks | 20:22 | |
*** pratikmallya has quit IRC | 20:26 | |
*** karimb has joined #openstack-sdks | 20:29 | |
*** e0ne has quit IRC | 20:50 | |
*** pratikma_ has quit IRC | 21:05 | |
*** david-lyle has joined #openstack-sdks | 21:06 | |
*** david-lyle has quit IRC | 21:09 | |
*** trown is now known as trown|outttypeww | 21:11 | |
*** jamielennox|away is now known as jamielennox | 21:24 | |
*** pratikmallya has joined #openstack-sdks | 21:33 | |
*** pratikma_ has joined #openstack-sdks | 21:34 | |
*** pratikmallya has quit IRC | 21:37 | |
*** karimb has quit IRC | 21:53 | |
*** thrash is now known as thrash|g0ne | 21:55 | |
*** stevemar has quit IRC | 22:05 | |
*** jose4183 has quit IRC | 22:08 | |
*** stevemar has joined #openstack-sdks | 22:11 | |
*** stevemar has quit IRC | 22:14 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:21 | |
*** gildub has joined #openstack-sdks | 22:55 | |
*** david-lyle has joined #openstack-sdks | 22:59 | |
*** trown|outttypeww is now known as trown | 23:25 | |
*** Qiming has joined #openstack-sdks | 23:38 | |
*** pratikma_ has quit IRC | 23:51 | |
*** pratikmallya has joined #openstack-sdks | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!